Re: [virtio-dev] [RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-25 Thread Mark D Rustad
> On Feb 25, 2018, at 7:20 AM, Yan Vugenfirer wrote: > > Small mistake in the commit message. Red Hat (Qumranet) vendor ID is 1af4, > virtio-net device ID is 1041. > Should be: > PF: vendor: 1af4 device: 1041 subvendor: 8086 subdevice: 15fe > VF: vendor: 1af4 device: 1041

Re: [Intel-wired-lan] [PATCH] e1000e: prevent division by zero if TIMINCA is zero

2016-05-10 Thread Mark D Rustad
Jarod Wilson wrote: On Fri, May 06, 2016 at 11:43:17PM +, Rustad, Mark D wrote: Denys Vlasenko wrote: Users report that under VMWare, er32(TIMINCA) returns zero. This causes division by zero at init time as follows: ==>incvalue =

[PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-07-13 Thread Mark D Rustad
From: Mark Rustad mark.d.rus...@intel.com Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This is for hardware devices that provide copies of the same VPD capability registers in multiple functions. Because the kernel

[PATCH V4 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-07-13 Thread Mark D Rustad
From: Mark Rustad mark.d.rus...@intel.com This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- Changes in V3: - Added a multifunction device check --- drivers/pci/quirks.c |9

[PATCH V4 0/2] pci: Provide a flag to access VPD through function 0

2015-07-13 Thread Mark D Rustad
Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

[PATCH V3 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-03 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- Changes in V3: - Added a multifunction device check --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+)

[PATCH V3 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-03 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on function 0 or there will be an infinite

[PATCH V3 0/2] pci: Provide a flag to access VPD through function 0

2015-06-03 Thread Mark D Rustad
that the referenced function 0 is reasonable Changes in V3: - Don't leak a device reference - Check that function 0 has VPD - Make a helper for the function 0 checks - Moved a multifunction check to the quirk patch --- Mark D Rustad (2): pci: Add dev_flags bit to access VPD through function 0

[PATCH V2 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-02 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c

[PATCH V2 0/2] pci: Provide a flag to access VPD through function 0

2015-06-02 Thread Mark D Rustad
that the referenced function 0 is reasonable --- Mark D Rustad (2): pci: Add dev_flags bit to access VPD through function 0 pci: Add VPD quirk for Intel Ethernet devices drivers/pci/access.c | 48 +++- drivers/pci/quirks.c |9 + 2

[PATCH V2 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on function 0 or there will be an infinite

[PATCH 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-02 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c

[PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on funciton 0 or there will be an infinite

[PATCH 0/2] pci: Provide a flag to access VPD through function 0

2015-06-02 Thread Mark D Rustad
function or there will be an infinite recursion. The second patch uses this new flag to invoke this behavior on all multi-function Intel Ethernet devices. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- Mark D Rustad (2): pci: Add dev_flags bit to access VPD through function 0