PS3: gelic: Add support for dual network interface
Add support for dual network (net_device) interface so that ethernet
and wireless can own separate ethX interfaces.
V2
- Fix the bug that bringing down and up the interface keeps rx
disabled.
- Make 'gelic_net_poll_controller()' extern ,
PS3: gelic: remove duplicated ethtool handlers
Remove some ethtool handlers, which duplicate functionality that was already
provided by the common ethtool handlers.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 43
PS3: gelic: Fix the wrong dev_id passed
The device id for lv1_net_set_interrupt_status_indicator() is wrong.
This path would be invoked only in the case of an initialization failure.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1
[6] PS3: gelic: Add support for dual network interface
[7] PS3: gelic: Add wireless support for PS3
--
Masakazu MOKUNO
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
PS3: gelic: Add endianness macros
Mark the members of the structure for DMA descriptors with proper endian
annotations and use the appropriate accessor macros.
As the gelic driver works only on PS3, all these macros will be
expanded to null.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED
.
- Group constants with enum.
- Use bitwise constants for interrupt status, instead of bit numbers to
eliminate shift operations.
- Style fixes.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 464 +---
drivers/net
PS3: gelic: add support for port link status
Add support for interrupt driven port link status detection.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 77
drivers/net/ps3_gelic_net.h |2 +
2 files changed
with my wireless patch because the dependent patch
set will go into the tree.
best regards
--
Masakazu MOKUNO
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 24 Jan 2008 21:47:25 -0500
John W. Linville [EMAIL PROTECTED] wrote:
On Thu, Jan 24, 2008 at 08:49:45PM -0500, Dan Williams wrote:
On Thu, 2008-01-24 at 14:51 +0900, Masakazu Mokuno wrote:
Hi
PS3: gelic: Add wireless support for PS3
This is the version 2 of the re
This is a prerequisite for the new PS3 wireless support.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 765 +++-
drivers/net/ps3_gelic_net.h | 108 +-
2 files changed, 564 insertions(+), 309 deletions(-)
--- a/drivers/net
in the case
of 'ret == 0'?
Same issue exists in compat_wext_handle_ioctl() of the #9 patch.
+ IW_IS_GET(cmd)
+ copy_to_user(arg, ifr, sizeof(struct iwreq)))
return -EFAULT;
+
return ret;
}
--
Masakazu MOKUNO
--
To unsubscribe from this list: send
Hi
Sorry for my intermittent posts.
On Thu, 10 Jan 2008 01:16:02 -0800 (PST)
David Miller [EMAIL PROTECTED] wrote:
From: Masakazu Mokuno [EMAIL PROTECTED]
Date: Thu, 27 Dec 2007 18:24:40 +0900
On ppc64 (PS3), IW_EV_LCP_LEN is 8, not 4.
include/linux/wireless.h:
#define
,
Thank you for your reviewing. I'll fix it.
--
Masakazu MOKUNO
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
the hypervisor guy. Unfortunately all EAPOL frames would be
dropped by the wireless chip firmware.
--
Masakazu MOKUNO
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
later.
Thanks for reviewing!
--
Masakazu MOKUNO
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PS3: gelic: Fix the wrong dev_id passed
The device id for lv1_net_set_interrupt_status_indicator() would be wrong.
This path would be invoked only in the case of the initialization failure.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |2 +-
1 file
PS3: gelic: remove duplicated ethtool handers
Remove some ethtool handers, which the common ethtool handlers already has
in functionality
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 43 +++
1 file changed, 3
PS3: gelic: add support for port link status
Add support for interrupt driven port link status detection.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 77
drivers/net/ps3_gelic_net.h |2 +
2 files changed
dual
{source,destination} interfaces.
- Use new NAPI functions
This is a prerequisite for the new PS3 wireless support.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 721 ++--
drivers/net/ps3_gelic_net.h | 107
.
- Group constatns with enum.
- Use bitwise constatns for interrupt status, instead of bit number to
eliminate shift operations.
- Style fixes.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 464 +---
drivers/net
PS3: gelic: Add endianness macros
Mark the members of the structure for DMA descriptor proper endian
and use appropriate accessor macros.
As gelic driver works only on PS3, all these macros will be
expanded null.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c
the association and 4way handshake in its
firmware/hypervisor. No interventions between them are allowed to the guest
OSes.
All frames which are sent/received from/to before the connection process
completed seems to be dropped by the hardware. Only the static WEP is
supported.
--
Masakazu MOKUNO
.
--
Masakazu MOKUNO
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 31 Aug 2007 06:57:03 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Masakazu Mokuno wrote:
Improve tx throughputs.
netperf score gained approximately 20%
This is a useless patch description. It does not adequately summarize
the changes contained within the patch
Hi Jeff,
The comments for the patch #1 was rewritten. I believe
it's more descriptive than the older one.
#1 Change the way to handle tx skbs (comments rewritten)
#2 Remove work-around code no longer needed
regards.
--
Masakazu MOKUNO
-
To unsubscribe from this list: send the line
make the headroom for moving mac address
fields in the skb buffer. Then we can send one tx skb with
one tx descriptor. This also gives us a tx throughut gain of approx.
20% according to netperf results.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
CC: Geoff Levand [EMAIL PROTECTED]
---
drivers
Removed the workaround that was needed for PS3 firmware versions
prior to the first release.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
CC: Geoff Levand [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 16
1 file changed, 4 insertions(+), 12 deletions
Hi,
Two updates for the gelic network driver;
- Improve tx throughput
- Remove work-around code no longer needed
--
Masakazu MOKUNO
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
Removed the workaround that was needed for PS3 firmware versions
prior to the first release.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
CC: Geoff Levand [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 16
1 file changed, 4 insertions(+), 12 deletions
Improve tx throughputs.
netperf score gained approximately 20%
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
CC: Geoff Levand [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 140 +++-
1 file changed, 63 insertions(+), 77 deletions
Fix the bug that 'ifconfig eth0 down' would hang up, reported by Stefan
Assmann [EMAIL PROTECTED].
As we removed netif_poll_enable() from dev-open(), we should not use
netif_poll_disable() in dev-stop().
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
CC: Geoff Levand [EMAIL PROTECTED
and Mike.
--
Masakazu MOKUNO
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
] ps3: reduce allocation size of rx skb buffers
--
Masakazu MOKUNO
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Fixed the bug that calculation of the address of rx descriptor was
wrong.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1107,7
- Removed the embarrassing definition which was used in only one
place.
- Fixed wrong initialization of dmac_cmd_status.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |5 +++--
drivers/net/ps3_gelic_net.h |1 -
2 files changed, 3 insertions(+), 3
descriptors are more than 2
- Fixed descriptor leak if dma map for second descriptor failed
- Stopped calling xmit handler from interrupt handler in order
to recheck tx queue. Instead, call appropriate helper functions.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED
Removed defines no longer used.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.h |7 ---
1 file changed, 7 deletions(-)
--- a/drivers/net/ps3_gelic_net.h
+++ b/drivers/net/ps3_gelic_net.h
@@ -28,15 +28,8 @@
#ifndef _GELIC_NET_H
#define _GELIC_NET_H
Removed conditional ethtool support. Always enabled.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |4
drivers/net/ps3_gelic_net.h |2 --
2 files changed, 6 deletions(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
Removed the statistics information from private structre.
Instead, use net_device_stats in net_device structure.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 31 ---
drivers/net/ps3_gelic_net.h |1 -
2 files changed, 8
Use net_device name for registration of irq as many network drivers do.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1073,7
Removed use of netif_poll_enable() in open function.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1134,7 +1134,6 @@ static int gelic_net_open
Reduced allocation size for rx skb buffers, from 2308 bytes to
1356 per buffer.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c | 45
drivers/net/ps3_gelic_net.h | 12 ++-
2 files changed, 44 insertions
of the hypervisor would be updated
by processing interrupt in the hypervisor.
Thus we should wait for the interrupt delivery before restarting
DMA.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |9 +++--
drivers/net/ps3_gelic_net.h |1 +
2 files
Hi Sthephen,
Thank you for your review. I'll submit the patches which would
fix these issues.
--
Masakazu MOKUNO
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
Hi
This patch fixes the improper return value of the hard_start_xmit()
handler of PS3 gelic network driver.
Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED]
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net
If there are no more comments, please apply for 2.6.23.
Thank you
--
Subject: PS3: Ethernet driver
From: Masakazu Mokuno [EMAIL PROTECTED]
Add Gigabit Ethernet support for the PS3 game console. The module will
be called ps3_gelic.
CC: Geoff Levand [EMAIL PROTECTED]
Signed-off-by: Masakazu Mokuno
-$(CONFIG_GELIC_NET) += gelic_net.o
obj-$(CONFIG_GELIC_WIRELESS) += gelic_wireless.o
then we would get two modules gelic_net.ko and gelic_wireless.ko, which
we don't want.
--
Masakazu MOKUNO
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
On Sat, 23 Jun 2007 11:09:04 -0700
Geoff Levand [EMAIL PROTECTED] wrote:
MOKUNO Masakazu wrote:
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2920,6 +2920,12 @@ M: [EMAIL PROTECTED]
L: [EMAIL PROTECTED]
S: Maintained
+PS3 NETWORK SUPPORT
+P: Masakazu Mokuno
+M: [EMAIL
48 matches
Mail list logo
