[PATCH v2 1/4] staging: rtl8712: Remove casts between void * and type *

This removes unnecessary explicit pointer casts in rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 45 ++--- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git a/drivers/staging/r

[PATCH v2 0/4] Cleanups for rtl871x_ioctl_rtl

This applies some janitorial work to rtl8712 driver. Mauro Dreissig (4): staging: rtl8712: Remove casts between void * and type * staging: rtl8712: Rename local variable staging: rtl8712: Make error handling check for failure staging: rtl8712: Rename local variable drivers/staging

[PATCH v2 2/4] staging: rtl8712: Rename local variable

Renames all instances of struct _adapter to adapter in rtl871x_ioctl_rtl.c, avoiding camel case. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 86 ++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff

[PATCH v2 4/4] staging: rtl8712: Rename local variable

Renames all instances of struct oid_par_priv to oid in rtl871x_ioctl_rtl.c and rtl871x_ioctl_rtl.h, making the code cleaner. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 292 +--- drivers/staging/r

[PATCH v2 3/4] staging: rtl8712: Make error handling check for failure

Make all error handling paths check for failure instead of success in rtl871x_ioctl_rtl.c, reducing indentation and avoiding else statements. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 +++- 1 file change

Re: [PATCH 3/4] staging: rtl8712: Make error handling check for failure

On 25-11-2015 09:44, Sudip Mukherjee wrote: > On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote: >> Some error handling paths are checking for success >> instead of error on rtl871x_ioctl_rtl.c. >> >> Signed-off-by: Mauro Dreissig <muk...@gmail.com> &

Re: [PATCH 3/4] staging: rtl8712: Make error handling check for failure

On 25-11-2015 12:56, Mauro Dreissig wrote: > On 25-11-2015 09:44, Sudip Mukherjee wrote: >> On Tue, Nov 24, 2015 at 10:19:41AM -0200, Mauro Dreissig wrote: >>> Some error handling paths are checking for success >>> instead of error on rtl871x_ioctl_rtl.c. >>> &g

Re: [PATCH 1/4] staging: rtl8712: Remove casts between void * and type *

On 24-11-2015 11:07, Dan Carpenter wrote: > On Tue, Nov 24, 2015 at 10:19:39AM -0200, Mauro Dreissig wrote: >> Cleaning rtl871x_ioctl_rtl.c. >> > > It's better if you think about the header and the body as two different > things. Just repeat the title but with more i

[PATCH 3/4] staging: rtl8712: Make error handling check for failure

Some error handling paths are checking for success instead of error on rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 239 ++-- 1 file changed, 121 insertions(+), 118 deletions(-) diff

[PATCH 0/4] staging: rtl8712: Cleanups for rtl871x_ioctl_rtl

This applies some janitorial work. Mauro Dreissig (4): staging: rtl8712: Remove casts between void * and type * staging: rtl8712: Rename local variable staging: rtl8712: Make error handling check for failure staging: rtl8712: Rename local variable drivers/staging/rtl8712

[PATCH 4/4] staging: rtl8712: Rename local variable

Make all instances of struct oid_par_priv be called oid in rtl871x_ioctl_rtl.c and rtl871x_ioctl_rtl.h. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 287 +--- drivers/staging/rtl8712/rtl871x_ioctl_rtl.h

[PATCH 2/4] staging: rtl8712: Rename local variable

Make all instances of struct _adapter be called adapter in rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 86 ++--- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/drivers/s

[PATCH 1/4] staging: rtl8712: Remove casts between void * and type *

Cleaning rtl871x_ioctl_rtl.c. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl871x_ioctl_rtl.c | 45 ++--- 1 file changed, 15 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_rtl.c b/drivers/s

[PATCH] staging: rtl8712: Cleanup _io_ops wrappers

This removes ugly and unnecessary declarations. Signed-off-by: Mauro Dreissig <muk...@gmail.com> --- drivers/staging/rtl8712/rtl8712_io.c | 77 +++- 1 file changed, 22 insertions(+), 55 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_io.c b/d