Re: TJA1100 100Base-T1 PHY features via ethtool?

On Mon, Aug 13, 2018 at 12:53:35PM -0700, Florian Fainelli wrote: > On 08/13/2018 12:35 PM, Michael Grzeschik wrote: > > Hi David, > > > > I use a special 100Base-T1 phy (NXP TJA1100 [1]) that has some features > > like: > > > > - enabling/dis

TJA1100 100Base-T1 PHY features via ethtool?

Hi David, I use a special 100Base-T1 phy (NXP TJA1100 [1]) that has some features like: - enabling/disabling test modes - fault detection - switching managed/autonomous mode - signal quality indication - ... I already implemented the support of the features with the ethtool

[PATCH v2 0/2] net: macb: add error handling on probe and

This series adds more error handling to the macb driver. Michael Grzeschik (2): net: macb: add of_phy_deregister_fixed_link to error paths net: macb: add of_node_put to error paths drivers/net/ethernet/cadence/macb_main.c | 9 + 1 file changed, 9 insertions(+) -- 2.11.0

[PATCH v2 1/2] net: macb: add of_phy_deregister_fixed_link to error paths

We add the call of_phy_deregister_fixed_link to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v2: removed extra parenthesis drivers/net/ethernet/cadence/macb_main.c | 7 +++ 1 file changed, 7 insertions(+) diff

[PATCH v2 2/2] net: macb: add of_node_put to error paths

We add the call of_node_put(bp->phy_node) to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v2: removed extra of_node_put from macb_remove drivers/net/ethernet/cadence/macb_main.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to error paths

On Wed, Nov 08, 2017 at 01:22:57PM +0900, David Miller wrote: > From: Michael Grzeschik <m.grzesc...@pengutronix.de> > Date: Mon, 6 Nov 2017 12:10:04 +0100 > > > We add the call of_phy_deregister_fixed_link to all associated > > error paths for memory clean up. >

[PATCH v2] net: macb: add of_node_put to error paths

We add the call of_node_put(bp->phy_node) to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v1 -> v2: removed extra of_node_put from macb_remove drivers/net/ethernet/cadence/macb_main.c | 2 ++ 1 file changed,

Re: [PATCH 2/2] net: macb: add of_node_put to error paths

On Tue, Nov 07, 2017 at 10:27:20AM +0100, Nicolas Ferre wrote: > On 06/11/2017 at 12:10, Michael Grzeschik wrote: > > We add the call of_node_put(bp->phy_node) to all associated error > > paths for memory clean up. > > > > Signed-off-by: Michael Grzesch

[PATCH 2/2] net: macb: add of_node_put to error paths

We add the call of_node_put(bp->phy_node) to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/ethernet/cadence/macb_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/cadence/ma

[PATCH 1/2] net: macb: add of_phy_deregister_fixed_link to error paths

We add the call of_phy_deregister_fixed_link to all associated error paths for memory clean up. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/ethernet/cadence/macb_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/c

[PATCH 1/4] arcnet: add err_skb package for package status feedback

We need to track the status of our queued packages. This way the driving process knows if failed packages need to be retransmitted. For this purpose we queue the transferred/failed packages back into the err_skb message queue added with some status information. Signed-off-by: Michael Grzeschik

[PATCH 2/4] arcnet: com20020-pci: add attribute to readback backplane status

We add the sysfs interface the read back the backplane status of the interface. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/arcnet/com20020-pc

[PATCH 0/4] arcnet: Collection of latest features

an extra sysfs attribute. In the last patch we add another card type PCIFB2. Michael Grzeschik (4): arcnet: add err_skb package for package status feedback arcnet: com20020-pci: add attribute to readback backplane status arcnet: com20020-pci: handle backplane mode depending on card type arcnet

[PATCH 3/4] arcnet: com20020-pci: handle backplane mode depending on card type

We read the backplane mode of each subcard from bits 2 and 3 of the misc register. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/

[PATCH 4/4] arcnet: com20020-pci: add support for PCIFB2 card

We add support for the PCIFB2 card from EAE. Beside other cards, this card has the backplane mode enabled by default. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 34 ++ 1 file changed, 34 inse

[PATCH 1/5] arcnet: change irq handler to lock irqsave

42.213978] [] (SyS_sendto) from [] (SyS_send+0x18/0x20) [ 42.221388] [] (SyS_send) from [] (ret_fast_syscall+0x0/0x1c) Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v1 -> v2: removed unneeded zero assignment of flags --- drivers/net/arcnet/arcnet.c | 7 +

[PATCH 0/5] arcnet: Collection of latest fixes

and missing assignments that improves the code footprint. Colin Ian King (1): Trivial fix to spelling mistake in arc_printk message Michael Grzeschik (4): arcnet: change irq handler to lock irqsave arcnet: com20020: remove needless base_addr assignment arcnet: com20020-pci: fix dev_id

[PATCH 3/5] arcnet: com20020: remove needless base_addr assignment

The assignment is superfluous. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index 13d9ad4b3f5c9..78043a9c5981e

[PATCH 4/5] arcnet: com20020-pci: fix dev_id calculation

The dev_id was miscalculated. Only the two bits 4-5 are relevant for the MA1 card. PCIARC1 and PCIFB2 use the four bits 4-7 for id selection. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 5/5] arcnet: com20020-pci: add missing pdev setup in netdev structure

We add the pdev data to the pci devices netdev structure. This way the interface get consistent device names in the userspace (udev). Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH 2/5] Trivial fix to spelling mistake in arc_printk message

From: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Colin Ian King <colin.k...@canonical.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/capmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

Re: [GIT PULL] arcnet: fixes and features

Hi, On Fri, Jun 23, 2017 at 01:54:03PM -0400, David Miller wrote: > From: Michael Grzeschik <m.grzesc...@pengutronix.de> > Date: Thu, 22 Jun 2017 17:31:02 +0200 > > > are available in the git repository at: > > > > pub...@git.pengutronix.de:/mgr/linux.git

Re: [PATCH] arcnet: fix spelling mistake "Ackknowledge" -> "Acknowledge"

On Sun, Jun 25, 2017 at 10:15:06PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in arc_printk message > > Signed-off-by: Colin Ian King > --- > drivers/net/arcnet/capmode.c | 2 +- > 1 file changed, 1

[PATCH v2] net: macb: add fixed-link node support

In case the MACB is directly connected to a non-mdio PHY/device, it should be possible to provide a fixed link configuration in the DT. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v1 -> v2: - moved of_phy_connect case and phy_connect_direct into if el

[PATCH 8/8] arcnet: com20020-pci: add support for PCIFB2 card

We add support for the PCIFB2 card from EAE. Beside other cards, this card has the backplane mode enabled by default. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 34 ++ 1 file changed, 34 inse

[PATCH 7/8] arcnet: com20020-pci: handle backplane mode depending on card type

We read the backplane mode of each subcard from bits 2 and 3 of the misc register. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/

[PATCH 4/8] arcnet: com20020-pci: add missing pdev setup in netdev structure

We add the pdev data to the pci devices netdev structure. This way the interface get consistent device names in the userspace (udev). Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH 3/8] arcnet: com20020: remove needless base_addr assignment

The assignment is superfluous. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index 13d9ad4b3f5c9..78043a9c5981e

[PATCH 5/8] arcnet: com20020-pci: fix dev_id calculation

The dev_id was miscalculated. Only the two bits 4-5 are relevant for the MA1 card. PCIARC1 and PCIFB2 use the four bits 4-7 for id selection. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 5 +++-- 1 file changed, 3 insertions

[PATCH 1/8] arcnet: change irq handler to lock irqsave

42.213978] [] (SyS_sendto) from [] (SyS_send+0x18/0x20) [ 42.221388] [] (SyS_send) from [] (ret_fast_syscall+0x0/0x1c) Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcnet.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a

[GIT PULL] arcnet: fixes and features

Michael Grzeschik (8): arcnet: change irq handler to lock irqsave arcnet: add err_skb package for package status feedback arcnet: com20020: remove needless base_addr assignment arcnet: com20020-pci: add missing pdev setup in netdev structure arcnet: com20020-pci: fix

[PATCH 2/8] arcnet: add err_skb package for package status feedback

We need to track the status of our queued packages. This way the driving process knows if failed packages need to be retransmitted. For this purpose we queue the transferred/failed packages back into the err_skb message queue added with some status information. Signed-off-by: Michael Grzeschik

[PATCH 6/8] arcnet: com20020-pci: add attribute to readback backplane status

We add the sysfs interface the read back the backplane status of the interface. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/arcnet/com20020-pc

Re: [PATCH] net: macb: add fixed-link node support

Hi Nicolas, On Mon, Jun 19, 2017 at 12:54:10PM +0200, Nicolas Ferre wrote: > Le 16/06/2017 à 10:55, Michael Grzeschik a écrit : > > In case the MACB is directly connected to a > > non-mdio PHY/device, it should be possible to provide > > a fixed link configuration in the DT

[PATCH] net: macb: add fixed-link node support

In case the MACB is directly connected to a non-mdio PHY/device, it should be possible to provide a fixed link configuration in the DT. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/ethernet/cadence/macb.c | 21 + drivers/net/ethernet/c

Re: [PATCH 2/5] arcnet: com90xx: add __init attribute

not called from any other function. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > Acked-by: Michael Grzeschik <m...@pengutronix.de> > --- > drivers/net/arcnet/com90xx.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/driv

[PATCH v3] can: c_can: add xceiver enable/disable support

This patch adds support to enable and disable the xceiver in case it's switchable by the regulator framework. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v1 -> v2: - always returning PTR_ERR in case devm_regulator_get fails - removed inline wrapper functions wi

Re: [PATCH v2] can: c_can: add xceiver enable/disable support

Hi, On Wed, Jan 20, 2016 at 05:19:18PM +0100, Bjørn Mork wrote: > Michael Grzeschik <m.grzesc...@pengutronix.de> writes: > > > @@ -1263,6 +1271,10 @@ int register_c_can_dev(struct net_device *dev) > > */ > > pinctrl_pm_select_sleep_state(dev->dev.parent)

[PATCHv2 net-next 2/6] arcnet: com20020: add enable and disable device on open/close

This patch changes the driver to properly work with the linux netif interface. The controller gets enabled on open and disabled on close. Therefor it removes every bogus start of the xceiver. It only gets enabled on com20020_open and disabled on com20020_close. Signed-off-by: Michael Grzeschik

[PATCHv2 net-next 1/6] arcnet: move dev_free_skb to its only user

The call for dev_free_skb is done only once. This patch moves its call to its only user and removes the obsolete condition variable. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcnet.c | 10 ++ 1 file changed, 2 insertions(+), 8 del

[PATCHv2 net-next 4/6] arcnet: com20020-pci: add rotary index support

The EAE PLX-PCI card has a special rotary encoder to configure the address of every card individually. We take this information for the initial setup of the cards dev_id. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v1 -> v2: kbuild test robot: fixed type of misc

[GIT PULL v2] ARCNET: code simplification and features

. Michael Grzeschik (6): arcnet: move dev_free_skb to its only user arcnet: com20020: add enable and disable device on open/close arcnet: com20020-pci: set dev_port to the subdevice index arcnet: com20020-pci: add rotary index support arcnet: com20020-pci: add led trigger

[PATCHv2 net-next 5/6] arcnet: com20020-pci: add led trigger support

The EAE PLX-PCI card has special leds on the the main io pci resource bar. This patch adds support to trigger the conflict and data leds with the packages. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- v1 -> v2: kbuild test robot: added dummy inline

[PATCHv2 net-next 3/6] arcnet: com20020-pci: set dev_port to the subdevice index

This patch sets the dev_port according to the index of the card. This can be used by udev to name the ports in userspace. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/

[PATCHv2 net-next 6/6] arcnet: add netif_carrier_on/off for reconnect

ine the connection stable again. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h | 2 ++ drivers/net/arcnet/arcnet.c| 25 + 2 files changed, 27 insertions(+) diff --git a/drivers/net/arcnet/arcdevice.h b/drivers/net/arcnet/ar

[PATCH net-next 4/6] arcnet: com20020-pci: add rotary index support

The EAE PLX-PCI card has a special rotary encoder to configure the address of every card individually. We take this information for the initial setup of the cards dev_id. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.

[PATCH net-next 5/6] arcnet: com20020-pci: add led trigger support

The EAE PLX-PCI card has special leds on the the main io pci resource bar. This patch adds support to trigger the conflict and data leds with the packages. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h| 19 ++ drivers/net/

[PATCH net-next 3/6] arcnet: com20020-pci: set dev_port to the subdevice index

This patch sets the dev_port according to the index of the card. This can be used by udev to name the ports in userspace. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/

[PATCH net-next 6/6] arcnet: add netif_carrier_on/off for reconnect

ine the connection stable again. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h | 2 ++ drivers/net/arcnet/arcnet.c| 25 + 2 files changed, 27 insertions(+) diff --git a/drivers/net/arcnet/arcdevice.h b/drivers/net/arcnet/ar

[PATCH net-next 2/6] arcnet: com20020: add enable and disable device on open/close

This patch changes the driver to properly work with the linux netif interface. The controller gets enabled on open and disabled on close. Therefor it removes every bogus start of the xceiver. It only gets enabled on com20020_open and disabled on com20020_close. Signed-off-by: Michael Grzeschik

[GIT PULL] ARCNET: code simplification and features

. Michael Grzeschik (6): arcnet: move dev_free_skb to its only user arcnet: com20020: add enable and disable device on open/close arcnet: com20020-pci: set dev_port to the subdevice index arcnet: com20020-pci: add rotary index support arcnet: com20020-pci: add led

[PATCH net-next 1/6] arcnet: move dev_free_skb to its only user

The call for dev_free_skb is done only once. This patch moves its call to its only user and removes the obsolete condition variable. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcnet.c | 10 ++ 1 file changed, 2 insertions(+), 8 del

Re: [GIT PULL] ARCNET: features and fixes

Hi David, On Sun, Oct 18, 2015 at 08:19:42PM -0700, David Miller wrote: > From: Michael Grzeschik <m.grzesc...@pengutronix.de> > Date: Fri, 16 Oct 2015 13:00:54 +0200 > > > This series includes some small fixes. The main changes are the correct > > xceiv

[PATCH 6/6] arcnet: add netif_carrier_on/off for reconnect

ine the connection stable again. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h | 2 ++ drivers/net/arcnet/arcnet.c| 25 + 2 files changed, 27 insertions(+) diff --git a/drivers/net/arcnet/arcdevice.h b/drivers/net/arcnet/ar

[PATCH 2/6] arcnet: com20020: add enable and disable device on open/close

This patch changes the driver to properly work with the linux netif interface. The controller gets enabled on open and disabled on close. Therefor it removes every bogus start of the xceiver. It only gets enabled on com20020_open and disabled on com20020_close. Signed-off-by: Michael Grzeschik

[PATCH 5/6] arcnet: com20020-pci: add led trigger support

The EAE PLX-PCI card has special leds on the the main io pci resource bar. This patch adds support to trigger the conflict and data leds with the packages. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h| 19 ++ drivers/net/

[PATCH 1/6] arcnet: move dev_free_skb to its only user

The call for dev_free_skb is done only once. This patch moves its call to its only user and removes the obsolete condition variable. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcnet.c | 10 ++ 1 file changed, 2 insertions(+), 8 del

[PATCH 4/6] arcnet: com20020-pci: add rotary index support

The EAE PLX-PCI card has a special rotary encoder to configure the address of every card individually. We take this information for the initial setup of the cards dev_id. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-pci.

[GIT PULL] ARCNET: features and fixes

) of the com20020 cards. The driver now handles link status change detection. The EAE PCI-ARCNET cards now make use of the rotary encoded subdevice indexing and got support for led triggers on transmit and reconnection events. Michael Grzeschik (6

Re: [GIT PULL] ARCNET: refactoring and cleanup

On Tue, Sep 22, 2015 at 05:25:03PM -0700, David Miller wrote: > From: Michael Grzeschik <m.grzesc...@pengutronix.de> > Date: Tue, 22 Sep 2015 11:01:41 +0200 > > > git://git.pengutronix.de/git/mgr/linux.git tags/arcnet-cleanup-v4.3-rc2 > > Please build this tree agai

[PATCH 01/33] arcnet: fix indentation of if_arcnet.h

From: Joe Perches <j...@perches.com> Standardized spacing is easier to read. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- include/uapi/linux/if_arcnet.h | 55 --

[PATCH 05/33] arcnet: Coalesce string fragments

From: Joe Perches <j...@perches.com> Using coalesced strings helps grep for specific messages. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rimi.c | 9 +++-- drivers/net/arcnet/a

[GIT PULL] ARCNET: refactoring and cleanup

and arcnet_writeb arcnet: arc-rimi: Use arcnet_ routines arcnet: com90xx: Use arcnet_readb/writeb routines arcnet: Remove function pointer macro indirections arcnet: Add com9026.h to standardize COM9026_REG_ arcnet: Remove unused arcnet_w macros Michael Grzeschik (4): arcnet: reformat structs to C99

[PATCH 08/33] arcnet: Neaten BUGMSG macro defines

From: Joe Perches <j...@perches.com> These macros are actually printk and pr_cont uses with a flag. Add a new BUGLVL_TEST macro which is just the "should use" test and not an odd "if ()" macro to simplify uses in a new patch. Signed-off-by: Joe Perches <j...@perche

[PATCH 02/33] arcnet: Use normal kernel spacing style

From: Joe Perches <j...@perches.com> Standardized spacing is easier to read. git diff -w shows no differences. objdiff shows no differences. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/ar

[PATCH 09/33] arcnet: Expand odd BUGLVL macro with if and uses

From: Joe Perches <j...@perches.com> Don't hide what should be obvious. Make the macro a simple test instead of using if and test. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c

[PATCH 26/33] arcnet: com90xx: Use arcnet_readb/writeb routines

From: Joe Perches <j...@perches.com> Simplify and make consistent the current uses of readb/writeb by using the newly introduced arcnet_ equivalents. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arc

[PATCH 18/33] arcnet: Move files out of include/linux

arcnet is currently unmaintained. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- MAINTAINERS | 1 - drivers/net/arcnet/arc-rawmode.c | 3 ++- drivers/net

[PATCH 19/33] arcnet: Make a char * array const char * const

From: Joe Perches <j...@perches.com> Might as well be specific about the use of this array. Add a commment questioning the indexing too. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcn

[PATCH 25/33] arcnet: arc-rimi: Use arcnet_ routines

-place where appropriate Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rimi.c | 55 --- 1 file changed, 25 insertions(+), 30 deletions(-) diff --git a/driv

[PATCH 13/33] arcnet: Remove unnecessary OOM messages

From: Joe Perches <j...@perches.com> Alloc failures have generic stack dumps so these are redundant. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 1 - drivers/net/arcnet/

[PATCH 12/33] arcnet: Move EXPORT_SYMBOL after declarations

From: Joe Perches <j...@perches.com> Use the normal kernel style for EXPORT_SYMBOL. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcnet.c | 33 ++--- 1 file chan

[PATCH 14/33] arcnet: Remove assignments from ifs

From: Joe Perches <j...@perches.com> Move the assignment above the if like general kernel style. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com20020-isa.c | 4 +++- drivers/net/arcnet/

[PATCH 20/33] arcnet: Add arcnet_ macros

From: Joe Perches <j...@perches.com> arcnet uses an I/O scheme which can align I/O addresses to word boundaries on different architectures. Add arcnet specific macros which can hide this alignment calculation. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Micha

[PATCH 27/33] arcnet: Remove function pointer macro indirections

From: Joe Perches <j...@perches.com> It's clearer to use function pointer calls directly instead of the macro indirections of ARCRESET, ACOMMAND, ASTATUS, and AINTMASK. Remove the now unused macros too. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzesch

[PATCH 11/33] arcnet: Convert printk to pr_

From: Joe Perches <j...@perches.com> Use the more current logging style. Remove #define VERSION, use pr_info normally. Add pr_fmt with "arcnet:" prefixes and KBUILD_MODNAME. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pen

[PATCH 06/33] arcnet: Use include/linux path for asm

From: Joe Perches <j...@perches.com> Use the preferred kernel include path for asm paths. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rimi.c | 2 +- drivers/net/arcnet/com20020-isa

[PATCH 15/33] arcnet: Remove pointer comparisons to NULL

From: Joe Perches <j...@perches.com> Use direct tests of pointer instead. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 2 +- drivers/net/arcnet/capmode.c | 4 ++--

[PATCH 16/33] arcnet: Convert arcnet_dump_skb macro to static inline

From: Joe Perches <j...@perches.com> Make sure the arguments are tested appropriately when not using this function. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- include/linux/arcdevice.h | 5 - 1 file cha

[PATCH 17/33] arcnet: Wrap some long lines

From: Joe Perches <j...@perches.com> Just neatening. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 3 ++- drivers/net/arcnet/arc-rimi.c | 11 ++- drivers/n

[PATCH 23/33] arcnet: com90xx: Use arcnet_ routines

where appropriate Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com90xx.c | 67 ++-- 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/drivers/net/

[PATCH 31/33] arcnet: com20020: replace magic numbers with readable macros

This patch replaces all magic numbers in the driver with proper named macros. For the case of XTOcfg and STARTIOcmd it introduces the new macros. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h | 1 + drivers/net/arcnet/com20020.c

[PATCH 22/33] arcnet: com90io: Use arcnet_ routines

where appropriate Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/com90io.c | 101 --- 1 file changed, 48 insertions(+), 53 deletions(-) diff --git a/drivers/net/

[PATCH 07/33] arcnet: Use network block comment style

From: Joe Perches <j...@perches.com> Conformity can be useful. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 15 drivers/net/arcnet/arc-rimi.c | 17 -

[PATCH 03/33] arcnet: Add and remove blank lines

From: Joe Perches <j...@perches.com> Use a more current kernel line style. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 5 - drivers/net/arcnet/arc-rimi.c | 8 +++

[PATCH 33/33] arcnet: capmode: remove extra function

This patch cleans the capmode protocol module. It removes the obsolete function arcnet_cap_init and replaces printk with pr_info. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/capmode.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-)

[PATCH 10/33] arcnet: Convert BUGMSG and BUGMSG2 to arc_prink and arc_cont

; Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 16 +-- drivers/net/arcnet/arc-rimi.c | 24 +++-- drivers/net/arcnet/arcnet.c | 212 -- drivers/net/arcnet/capmode.c | 35 --- drivers/n

[PATCH 04/33] arcnet: Use normal kernel brace style

From: Joe Perches <j...@perches.com> Move braces normal kernel locations. Add missing braces. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 6 +++--- drivers/net/arcnet/

[PATCH 30/33] arcnet: reformat structs to C99 format

This patch changes the macro definitions to match the C99 formating. This improves the readability. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/capmode.c | 14 ++ drivers/net/arcnet/com20020-pci.

[PATCH 24/33] arcnet: arcdevice.h: Add arcnet_readb and arcnet_writeb

From: Joe Perches <j...@perches.com> Use the same indirection as the other arcnet_ macros. Neither of these new macros add the BUS_ALIGN use for 8 bit devices on 16 bit busses. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...

[PATCH 28/33] arcnet: Add com9026.h to standardize COM9026_REG_

From: Joe Perches <j...@perches.com> Deduplicate the COM9026 registers. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rimi.c | 13 + drivers/net/arcnet/arcnet.c | 1 +

[PATCH 32/33] arcnet: arc-rawmode: reorder module functions

This patch moves the module_init and module_exit patches to the end of the file. It also replaces the printk with pr_info. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arc-rawmode.c | 84 ++-- 1 file chang

[PATCH 29/33] arcnet: Remove unused arcnet_w macros

From: Joe Perches <j...@perches.com> The word length macros are unused. Remove them. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h | 10 -- 1 file changed, 10 deleti

[PATCH 21/33] arcnet: com20020: Use arcnet_ routines

h to arcdevice.h. Signed-off-by: Joe Perches <j...@perches.com> Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcdevice.h| 22 +--- drivers/net/arcnet/com20020-isa.c | 14 +++--- drivers/net/arcnet/com20020-pci.c | 6 +-- drivers/net

[GIT PULL] ARCNET: refactoring and cleanup

to standardize COM9026_REG_ arcnet: Remove unused arcnet_w macros Michael Grzeschik (4): arcnet: reformat structs to C99 format arcnet: com20020: replace magic numbers with readable macros arcnet: arc-rawmode: reorder module functions arcnet: capmode: remove extra function

[PATCH][RESEND] ARCNET: fix hard_header_len limit

well include short (or even no?) soft headers. For this reason only use arc_hardware instead of archdr to determine the hard_header_len for an arcnet device. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion

[PATCH][RESEND] MAINTAINERS: add arcnet and take maintainership

Add entry for arcnet to MAINTAINERS file and add myself as the maintainer of the subsystem. Signed-off-by: Michael Grzeschik <m.grzesc...@pengutronix.de> Cc: da...@davemloft.net Cc: j...@perches.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAI

Re: [PATCH] ARCNET: fix hard_header_len limit

On Wed, Aug 05, 2015 at 05:34:51PM +0200, Michael Grzeschik wrote: > On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: > > From: Michael Grzeschik <m.grzesc...@pengutronix.de> > > Date: Thu, 30 Jul 2015 15:34:36 +0200 > > > > > The commit <9c707

Re: [PATCH] ARCNET: fix hard_header_len limit

On Thu, Jul 30, 2015 at 11:16:36AM -0700, David Miller wrote: From: Michael Grzeschik m.grzesc...@pengutronix.de Date: Thu, 30 Jul 2015 15:34:36 +0200 The commit 9c7077622dd9 (packet: make packet_snd fail on len smaller than l2 header) adds the check for minimum packet length of the used

[PATCH] MAINTAINERS: add arcnet and take maintainership

Add entry for arcnet to MAINTAINERS file and add myself as the maintainer of the subsystem. Signed-off-by: Michael Grzeschik m.grzesc...@pengutronix.de Cc: da...@davemloft.net Cc: j...@perches.com --- As I have a test coverage of com20020 based arcnet systems I would like to take

  1   2   >