Re: [PATCH resend net-next 2/2] net: bridge: switchdev: include local flag in FDB notifications

2021-04-19 Thread Nikolay Aleksandrov
| 2 +- > 9 files changed, 15 insertions(+), 14 deletions(-) > For the bridge change: Acked-by: Nikolay Aleksandrov

Re: [PATCH resend net-next 1/2] net: bridge: switchdev: refactor br_switchdev_fdb_notify

2021-04-19 Thread Nikolay Aleksandrov
ekranz > Reviewed-by: Vladimir Oltean > Signed-off-by: Vladimir Oltean > --- > net/bridge/br_switchdev.c | 41 +++ > 1 file changed, 11 insertions(+), 30 deletions(-) > Acked-by: Nikolay Aleksandrov

[PATCH iproute2-next 5/6] bridge: vlan: add support for the new rtm dump call

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Use the new bridge vlan rtm dump helper to dump all of the available vlan information when -details (-d) is used with vlan show. It is also capable of dumping vlan stats if -statistics (-s) is added. Currently this is the only interface capable of dumping per-vlan

[PATCH iproute2-next 4/6] libnetlink: add bridge vlan dump request helper

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add rtnl bridge vlan dump request helper which will be used to retrieve bridge vlan information and options. Signed-off-by: Nikolay Aleksandrov --- include/libnetlink.h | 2 ++ lib/libnetlink.c | 19 +++ 2 files changed, 21 insertions(+) diff

[PATCH iproute2-next 3/6] bridge: vlan: add option set command and state option

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add a new per-vlan option set command. It allows to manipulate vlan options, those can be bridge-wide or per-port depending on what device is specified. The first option that can be set is the vlan STP state, it is identical to the bridge port STP state. The man page is

[PATCH iproute2-next 6/6] bridge: monitor: add support for vlan monitoring

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support for vlan activity monitoring, we display vlan notifications on vlan add/del/options change. The man page and help are also updated accordingly. Signed-off-by: Nikolay Aleksandrov --- bridge/br_common.h | 2 +- bridge/mdb.c | 2 +- bridge/monitor.c

[PATCH iproute2-next 2/6] bridge: add parse_stp_state helper

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add a helper which parses an STP state string to its numeric value. Signed-off-by: Nikolay Aleksandrov --- bridge/br_common.h | 1 + bridge/link.c | 22 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/bridge/br_common.h b

[PATCH iproute2-next 0/6] bridge: vlan: add per-vlan options support

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This set extends the bridge vlan code to use the new vlan RTM calls which allow to dump detailed per-port, per-vlan information and also to manipulate the per-vlan options. It also allows to monitor any vlan changes (add/del/option change). The rtm vlan dumps have

[PATCH iproute2-next 1/6] bridge: rename and export print_portstate

2021-04-18 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Rename print_portstate to print_stp_state in preparation for use by vlan code as well (per-vlan state), and export it. To be in line with the new naming rename also port_states to stp_states as they'll be used for vlans, too. Signed-off-by: Nikolay Aleksa

Re: [PATCH net-next 1/2] net: bridge: switchdev: refactor br_switchdev_fdb_notify

2021-04-14 Thread Nikolay Aleksandrov
On 14/04/2021 18:15, Vladimir Oltean wrote: > From: Tobias Waldekranz > > Instead of having to add more and more arguments to > br_switchdev_fdb_call_notifiers, get rid of it and build the info > struct directly in br_switchdev_fdb_notify. > > Signed-off-by: Tobias Waldekranz > Reviewed-by: Vla

Re: [PATCH net-next] net: bridge: propagate error code and extack from br_mc_disabled_update

2021-04-14 Thread Nikolay Aleksandrov
On 14/04/2021 18:13, Vladimir Oltean wrote: > On Wed, Apr 14, 2021 at 05:58:04PM +0300, Nikolay Aleksandrov wrote: >>> @@ -3607,7 +3619,7 @@ int br_multicast_toggle(struct net_bridge *br, >>> unsigned long val) >>>

Re: [PATCH net-next] net: bridge: propagate error code and extack from br_mc_disabled_update

2021-04-14 Thread Nikolay Aleksandrov
On 14/04/2021 17:34, Vladimir Oltean wrote: > From: Florian Fainelli > > Some Ethernet switches might only be able to support disabling multicast > flooding globally, which is an issue for example when several bridges > span the same physical device and request contradictory settings. > > Propag

Re: [PATCH][next] net: bridge: Fix missing return assignment from br_vlan_replay_one call

2021-03-24 Thread Nikolay Aleksandrov
t net_device *br_dev, struct > net_device *dev, > if (!br_vlan_should_use(v)) > continue; > > - br_vlan_replay_one(nb, dev, &vlan, extack); > + err = br_vlan_replay_one(nb, dev, &vlan, extack); > if (err) > return err; > } > Thanks, Acked-by: Nikolay Aleksandrov

Re: [PATCH v4 net-next 05/11] net: bridge: add helper to replay VLANs installed on port

2021-03-23 Thread Nikolay Aleksandrov
hanged, 83 insertions(+) > Same comments about the const qualifiers as the other patches. The code looks good to me otherwise. Acked-by: Nikolay Aleksandrov > diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h > index b564c4486a45..2cc35038a8ca 100644 > --- a/inclu

Re: [PATCH v4 net-next 03/11] net: bridge: add helper to replay port and host-joined mdb entries

2021-03-23 Thread Nikolay Aleksandrov
ween br_mdb_switchdev_host_port, > br_mdb_notify and the newly added br_mdb_queue_one in how the switchdev > mdb object is created, so a helper was created. > > Suggested-by: Ido Schimmel > Signed-off-by: Vladimir Oltean > --- > include/linux/if_bridge.h | 9 +++ > include/n

Re: [PATCH v4 net-next 04/11] net: bridge: add helper to replay port and local fdb entries

2021-03-23 Thread Nikolay Aleksandrov
ll of the bridge fdbs every time (dst == NULL). The code itself is correct and the alternative to take only 1 net_device and act based on its type would add another step to the process per-port which also doesn't sound good... There are a few minor const nits below too, again if there is anot

Re: [PATCH v4 net-next 02/11] net: bridge: add helper to retrieve the current ageing time

2021-03-23 Thread Nikolay Aleksandrov
nux/if_bridge.h | 6 ++ > net/bridge/br_stp.c | 13 + > 2 files changed, 19 insertions(+) > The patch is mostly fine, there are a few minor nits (const qualifiers). If there is another version of the patch-set please add them, either way: Acked-by: Nikolay A

Re: [PATCH v4 net-next 01/11] net: bridge: add helper for retrieving the current bridge port STP state

2021-03-23 Thread Nikolay Aleksandrov
state, such that drivers can synchronize to it when they may have missed > switchdev events. > > Signed-off-by: Vladimir Oltean > Reviewed-by: Florian Fainelli > Reviewed-by: Tobias Waldekranz > --- > include/linux/if_bridge.h | 6 ++ > net/bridge/br_stp.c | 14 ++ > 2 files changed, 20 insertions(+) > Acked-by: Nikolay Aleksandrov

Re: [PATCH v3 net-next 08/12] net: dsa: replay port and host-joined mdb entries when joining the bridge

2021-03-22 Thread Nikolay Aleksandrov
On 22/03/2021 18:56, Vladimir Oltean wrote: > On Mon, Mar 22, 2021 at 06:35:10PM +0200, Nikolay Aleksandrov wrote: >>> + hlist_for_each_entry(mp, &br->mdb_list, mdb_node) { >> >> You cannot walk over these lists without the multicast lock or RCU. RTNL is >

Re: [PATCH v3 net-next 10/12] net: dsa: replay VLANs installed on port when joining the bridge

2021-03-22 Thread Nikolay Aleksandrov
On 21/03/2021 00:34, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently this simple setup: > > ip link add br0 type bridge vlan_filtering 1 > ip link add bond0 type bond > ip link set bond0 master br0 > ip link set swp0 master bond0 > > will not work because the bridge has created the

Re: [PATCH v3 net-next 09/12] net: dsa: replay port and local fdb entries when joining the bridge

2021-03-22 Thread Nikolay Aleksandrov
On 21/03/2021 00:34, Vladimir Oltean wrote: > From: Vladimir Oltean > > When a DSA port joins a LAG that already had an FDB entry pointing to it: > > ip link set bond0 master br0 > bridge fdb add dev bond0 00:01:02:03:04:05 master static > ip link set swp0 master bond0 > > the DSA port will hav

Re: [PATCH v3 net-next 08/12] net: dsa: replay port and host-joined mdb entries when joining the bridge

2021-03-22 Thread Nikolay Aleksandrov
On 21/03/2021 00:34, Vladimir Oltean wrote: > From: Vladimir Oltean > > I have udhcpcd in my system and this is configured to bring interfaces > up as soon as they are created. > > I create a bridge as follows: > > ip link add br0 type bridge > > As soon as I create the bridge and udhcpcd brin

Re: [PATCH v3 net-next 00/12] Better support for sandwiched LAGs with bridge and DSA

2021-03-22 Thread Nikolay Aleksandrov
On 21/03/2021 00:34, Vladimir Oltean wrote: > From: Vladimir Oltean > > The objective of this series is to make LAG uppers on top of switchdev > ports work regardless of which order we link interfaces to their masters > (first make the port join the LAG, then the LAG join the bridge, or the > oth

[PATCH net-next] net: bridge: when suppression is enabled exclude RARP packets

2021-03-22 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Recently we had an interop issue where RARP packets got suppressed with bridge neigh suppression enabled, but the check in the code was meant to suppress GARP. Exclude RARP packets from it which would allow some VMWare setups to work, to quote the report: "Those

Re: [PATCH net-next] net: bridge: declare br_vlan_tunnel_lookup argument tunnel_id as __be64

2021-03-22 Thread Nikolay Aleksandrov
{ > }; > > static struct net_bridge_vlan *br_vlan_tunnel_lookup(struct rhashtable *tbl, > - u64 tunnel_id) > + __be64 tunnel_id) > { > return rhashtable_lookup_fast(tbl, &tunnel_id, > br_vlan_tunnel_rht_params); > Acked-by: Nikolay Aleksandrov

[PATCH net-next v2 1/2] net: bridge: mcast: remove unreachable EHT code

2021-03-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov In the initial EHT versions there were common functions which handled allow/block messages for both INCLUDE and EXCLUDE modes, but later they were separated. It seems I've left some common code which cannot be reached because the filter mode is checked before ca

[PATCH net-next v2 2/2] net: bridge: mcast: factor out common allow/block EHT handling

2021-03-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We hande EHT state change for ALLOW messages in INCLUDE mode and for BLOCK messages in EXCLUDE mode similarly - create the new set entries with the proper filter mode. We also handle EHT state change for ALLOW messages in EXCLUDE mode and for BLOCK messages in INCLUDE

[PATCH net-next v2 0/2] net: bridge: mcast: simplify allow/block EHT code

2021-03-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, The set does two minor cleanups of the EHT allow/block handling code: patch 01 removes code which is unreachable (it was used in initial EHT versions, but isn't anymore) and prepares the allow/block functions to be factored out. Patch 02 factors out common

Re: [PATCH net-next] net: bridge: mcast: remove unreachable EHT code

2021-03-15 Thread Nikolay Aleksandrov
On 15/03/2021 17:38, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > In the initial EHT versions there were common functions which handled > allow/block messages for both INCLUDE and EXCLUDE modes, but later they > were separated. It seems I've left some common

[PATCH net-next] net: bridge: mcast: remove unreachable EHT code

2021-03-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov In the initial EHT versions there were common functions which handled allow/block messages for both INCLUDE and EXCLUDE modes, but later they were separated. It seems I've left some common code which cannot be reached because the filter mode is checked before ca

Re: [PATCH net-next 0/2] Fixing build breakage after "Merge branch 'Propagate-extack-for-switchdev-LANs-from-DSA'"

2021-02-15 Thread Nikolay Aleksandrov
.h | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > This was unexpected. :) Thanks for fixing these so quickly. FWIW: Acked-by: Nikolay Aleksandrov

Re: [PATCH net-next 3/5] net: bridge: propagate extack through switchdev_port_attr_set

2021-02-14 Thread Nikolay Aleksandrov
On 13/02/2021 22:43, Vladimir Oltean wrote: > From: Vladimir Oltean > > The benefit is the ability to propagate errors from switchdev drivers > for the SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING and > SWITCHDEV_ATTR_ID_BRIDGE_VLAN_PROTOCOL attributes. > > Signed-off-by: Vladimir Oltean > --- > in

Re: [PATCH net-next 2/5] net: bridge: propagate extack through store_bridge_parm

2021-02-14 Thread Nikolay Aleksandrov
On 13/02/2021 22:43, Vladimir Oltean wrote: > From: Vladimir Oltean > > The bridge sysfs interface stores parameters for the STP, VLAN, > multicast etc subsystems using a predefined function prototype. > Sometimes the underlying function being called supports a netlink > extended ack message, and

Re: [PATCH net-next 1/5] net: bridge: remove __br_vlan_filter_toggle

2021-02-14 Thread Nikolay Aleksandrov
c| 7 +-- > 3 files changed, 4 insertions(+), 10 deletions(-) > Acked-by: Nikolay Aleksandrov

Re: [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes

2021-02-12 Thread Nikolay Aleksandrov
lude/net/switchdev.h | 6 -- > net/dsa/slave.c | 3 ++- > net/switchdev/switchdev.c | 11 ++++--- > 8 files changed, 24 insertions(+), 11 deletions(-) > Reviewed-by: Nikolay Aleksandrov

Re: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag

2021-02-12 Thread Nikolay Aleksandrov
itchdev_set_port_flag if already > populated. > > net/bridge/br_netlink.c | 9 + > net/bridge/br_private.h | 6 -- > net/bridge/br_switchdev.c | 13 +++-- > net/bridge/br_sysfs_if.c | 7 +-- > 4 files changed, 21 insertions(+), 14 deletions(-) > Acked-by: Nikolay Aleksandrov

Re: [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport

2021-02-12 Thread Nikolay Aleksandrov
; Patch is new. > > Changes in v2: > Patch is new. > > net/bridge/br_netlink.c | 109 -- > net/bridge/br_switchdev.c | 6 ++- > 2 files changed, 39 insertions(+), 76 deletions(-) > LGTM, thanks! Acked-by: Nikolay Aleksandrov

Re: [PATCH v4 net-next 21/21] Documentation: add TCP DDP offload documentation

2021-02-12 Thread Nikolay Aleksandrov
On 12/02/2021 07:20, Boris Pismenny wrote: > Signed-off-by: Boris Pismenny > Signed-off-by: Ben Ben-Ishay > Signed-off-by: Or Gerlitz > Signed-off-by: Yoray Zack > --- > Documentation/networking/index.rst | 1 + > Documentation/networking/tcp-ddp-offload.rst | 296 +

[PATCH net-next v2 2/3] bonding: 3ad: add support for 400G speed

2021-02-10 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov In order to be able to use 3ad mode with 400G devices we need to extend the supported speeds. Signed-off-by: Nikolay Aleksandrov --- v2: no changes drivers/net/bonding/bond_3ad.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/bonding

[PATCH net-next v2 0/3] bonding: 3ad: support for 200G/400G ports and more verbose warning

2021-02-10 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, We'd like to have proper 200G and 400G support with 3ad bond mode, so we need to add new definitions for them in order to have separate oper keys, aggregated bandwidth and proper operation (patches 01 and 02). In patch 03 Ido changes the code to use pr_err

[PATCH net-next v2 1/3] bonding: 3ad: add support for 200G speed

2021-02-10 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov In order to be able to use 3ad mode with 200G devices we need to extend the supported speeds. Signed-off-by: Nikolay Aleksandrov --- v2: no changes drivers/net/bonding/bond_3ad.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/bonding

[PATCH net-next v2 3/3] bonding: 3ad: Print an error for unknown speeds

2021-02-10 Thread Nikolay Aleksandrov
): unknown ethtool speed (20) for port 1 (set it to 0) v2: * Use pr_err_once() instead of WARN_ONCE() Signed-off-by: Ido Schimmel Signed-off-by: Nikolay Aleksandrov --- drivers/net/bonding/bond_3ad.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding

Re: [PATCH v3 net-next 00/11] Cleanup in brport flags switchdev offload for DSA

2021-02-10 Thread Nikolay Aleksandrov
On 10/02/2021 14:01, Vladimir Oltean wrote: > On Wed, Feb 10, 2021 at 01:05:57PM +0200, Nikolay Aleksandrov wrote: >> On 10/02/2021 13:01, Vladimir Oltean wrote: >>> On Wed, Feb 10, 2021 at 12:52:33PM +0200, Nikolay Aleksandrov wrote: >>>> On 10/02/2021 12:45, V

Re: [PATCH v3 net-next 00/11] Cleanup in brport flags switchdev offload for DSA

2021-02-10 Thread Nikolay Aleksandrov
On 10/02/2021 13:01, Vladimir Oltean wrote: > On Wed, Feb 10, 2021 at 12:52:33PM +0200, Nikolay Aleksandrov wrote: >> On 10/02/2021 12:45, Vladimir Oltean wrote: >>> Hi Nikolay, >>> >>> On Wed, Feb 10, 2021 at 12:31:43PM +0200, Nikolay Aleksandrov wrote: >

Re: [PATCH v3 net-next 00/11] Cleanup in brport flags switchdev offload for DSA

2021-02-10 Thread Nikolay Aleksandrov
On 10/02/2021 12:45, Vladimir Oltean wrote: > Hi Nikolay, > > On Wed, Feb 10, 2021 at 12:31:43PM +0200, Nikolay Aleksandrov wrote: >> Hi Vladimir, >> Let's take a step back for a moment and discuss the bridge unlock/lock >> sequences >> that come with this

Re: [PATCH v3 net-next 00/11] Cleanup in brport flags switchdev offload for DSA

2021-02-10 Thread Nikolay Aleksandrov
On 10/02/2021 11:14, Vladimir Oltean wrote: > From: Vladimir Oltean > > The initial goal of this series was to have better support for > standalone ports mode and multiple bridges on the DSA drivers like > ocelot/felix and sja1105. Proper support for standalone mode requires > disabling address l

Re: [PATCH v3 net-next 08/11] net: bridge: put SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS on the blocking call chain

2021-02-10 Thread Nikolay Aleksandrov
On 10/02/2021 11:14, Vladimir Oltean wrote: > From: Vladimir Oltean > > Since we would like br_switchdev_set_port_flag to not use an atomic > notifier, it should be called from outside spinlock context. > > We can temporarily drop br->lock, but that creates some concurrency > complications (exam

Re: [PATCH net-next 3/3] bonding: 3ad: Use a more verbose warning for unknown speeds

2021-02-09 Thread Nikolay Aleksandrov
On 09/02/2021 12:32, Nikolay Aleksandrov wrote: > From: Ido Schimmel > > The bond driver needs to be patched to support new ethtool speeds. > Currently it emits a single warning [1] when it encounters an unknown > speed. As evident by the two previous patches, this is not ex

[PATCH net-next 3/3] bonding: 3ad: Use a more verbose warning for unknown speeds

2021-02-09 Thread Nikolay Aleksandrov
From: Ido Schimmel The bond driver needs to be patched to support new ethtool speeds. Currently it emits a single warning [1] when it encounters an unknown speed. As evident by the two previous patches, this is not explicit enough. Instead, use WARN_ONCE() to get a more verbose warning [2]. [1]

[PATCH net-next 2/3] bonding: 3ad: add support for 400G speed

2021-02-09 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov In order to be able to use 3ad mode with 400G devices we need to extend the supported speeds. Signed-off-by: Nikolay Aleksandrov Signed-off-by: Ido Schimmel --- drivers/net/bonding/bond_3ad.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net

[PATCH net-next 1/3] bonding: 3ad: add support for 200G speed

2021-02-09 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov In order to be able to use 3ad mode with 200G devices we need to extend the supported speeds. Signed-off-by: Nikolay Aleksandrov Signed-off-by: Ido Schimmel --- drivers/net/bonding/bond_3ad.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net

[PATCH net-next 0/3] bonding: 3ad: support for 200G/400G ports and more verbose warning

2021-02-09 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, We'd like to have proper 200G and 400G support with 3ad bond mode, so we need to add new definitions for them in order to have separate oper keys, aggregated bandwidth and proper operation (patches 01 and 02). In patch 03 Ido changes the code to use WARN

Re: [PATCH net-next 2/9] net: bridge: offload initial and final port flags through switchdev

2021-02-08 Thread Nikolay Aleksandrov
On 08/02/2021 13:45, Vladimir Oltean wrote: > On Mon, Feb 08, 2021 at 01:37:03PM +0200, Nikolay Aleksandrov wrote: >> Hi Vladimir, >> I think this patch potentially breaks some use cases. There are a few >> problems, I'll >> start with the more serious one: befo

Re: [PATCH net-next 2/9] net: bridge: offload initial and final port flags through switchdev

2021-02-08 Thread Nikolay Aleksandrov
On 08/02/2021 01:21, Vladimir Oltean wrote: > From: Vladimir Oltean > > It must first be admitted that switchdev device drivers have a life > beyond the bridge, and when they aren't offloading the bridge driver > they are operating with forwarding disabled between ports, emulating as > closely as

Re: [PATCH net] net: bridge: use switchdev for port flags set through sysfs too

2021-02-08 Thread Nikolay Aleksandrov
c int store_flag(struct net_bridge_port *p, unsigned > long v, > flags &= ~mask; > > if (flags != p->flags) { > + err = br_switchdev_set_port_flag(p, flags, mask); > + if (err) > + return err; > + > p->flags = flags; > br_port_flags_change(p, mask); > } > Acked-by: Nikolay Aleksandrov

Re: [PATCH 106/141] net: bridge: Fix fall-through warnings for Clang

2021-02-02 Thread Nikolay Aleksandrov
break; > } > Somehow this hasn't hit my inbox, good thing I just got the reply and saw the patch. Anyway, thanks! Acked-by: Nikolay Aleksandrov

[PATCH net-next 1/2] net: bridge: mcast: drop hosts limit sysfs support

2021-01-29 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We decided to stop adding new sysfs bridge options and continue with netlink only, so remove hosts limit sysfs support. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_sysfs_if.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/net

[PATCH net-next 2/2] net: bridge: add warning comments to avoid extending sysfs

2021-01-29 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We're moving to netlink-only options, so add comments in the bridge's sysfs files to warn against adding any new sysfs entries. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_sysfs_br.c | 4 net/bridge/br_sysfs_if.c | 4 2 files changed, 8

Re: [PATCH net-next v2 0/2] net: bridge: multicast: per-port EHT hosts limit

2021-01-28 Thread Nikolay Aleksandrov
On 28/01/2021 03:42, Jakub Kicinski wrote: > On Tue, 26 Jan 2021 11:35:31 +0200 Nikolay Aleksandrov wrote: >> From: Nikolay Aleksandrov >> >> Hi, >> This set adds a simple configurable per-port EHT tracked hosts limit. >> Patch 01 adds a default limit of 512 trac

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-27 Thread Nikolay Aleksandrov
On 27/01/2021 06:15, Hangbin Liu wrote: > On Tue, Jan 26, 2021 at 04:55:22PM +0200, Nikolay Aleksandrov wrote: >>>> Thanks for the reply. There are a few reasons I think the bridge should >>>> handle NETDEV_NOTIFY_PEERS: >>>> >>>> 1. Only a few d

[PATCH net-next] net: bridge: multicast: fix br_multicast_eht_set_entry_lookup indentation

2021-01-26 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Fix the messed up indentation in br_multicast_eht_set_entry_lookup(). Fixes: baa74d39ca39 ("net: bridge: multicast: add EHT source set handling functions") Reported-by: kernel test robot Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast_

[PATCH net-next 1/2] net: bridge: multicast: add per-port EHT hosts limit

2021-01-26 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add a default limit of 512 for number of tracked EHT hosts per-port. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 1 + net/bridge/br_multicast_eht.c | 7 +++ net/bridge/br_private.h | 2 ++ net/bridge

Re: [PATCH net-next 0/2] net: bridge: multicast: per-port EHT hosts limit

2021-01-26 Thread Nikolay Aleksandrov
On 26/01/2021 11:21, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Hi, > This set adds a simple configurable per-port EHT tracked hosts limit. > Patch 01 adds a default limit of 512 tracked hosts per-port, since the EHT > changes are still only in net-next t

[PATCH net-next 2/2] net: bridge: multicast: make tracked EHT hosts limit configurable

2021-01-26 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add two new port attributes which make EHT hosts limit configurable and export the current number of tracked EHT hosts: - IFLA_BRPORT_MCAST_EHT_HOSTS_LIMIT: configure/retrieve current limit - IFLA_BRPORT_MCAST_EHT_HOSTS_CNT: current number of tracked hosts Setting

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Nikolay Aleksandrov
On 26/01/2021 15:56, Nikolay Aleksandrov wrote: > On 26/01/2021 15:25, Hangbin Liu wrote: >> On Tue, Jan 26, 2021 at 09:40:13AM +0200, Nikolay Aleksandrov wrote: >>> On 26/01/2021 06:09, Hangbin Liu wrote: >>>> After adding bridge as upper layer of bond/team, w

[PATCH net-next v2 0/2] net: bridge: multicast: per-port EHT hosts limit

2021-01-26 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This set adds a simple configurable per-port EHT tracked hosts limit. Patch 01 adds a default limit of 512 tracked hosts per-port, since the EHT changes are still only in net-next that shouldn't be a problem. Then patch 02 adds the ability to configure and ret

[PATCH net-next v2 1/2] net: bridge: multicast: add per-port EHT hosts limit

2021-01-26 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add a default limit of 512 for number of tracked EHT hosts per-port. Signed-off-by: Nikolay Aleksandrov --- v2: no change net/bridge/br_multicast.c | 1 + net/bridge/br_multicast_eht.c | 7 +++ net/bridge/br_private.h | 2 ++ net/bridge

[PATCH net-next v2 2/2] net: bridge: multicast: make tracked EHT hosts limit configurable

2021-01-26 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add two new port attributes which make EHT hosts limit configurable and export the current number of tracked EHT hosts: - IFLA_BRPORT_MCAST_EHT_HOSTS_LIMIT: configure/retrieve current limit - IFLA_BRPORT_MCAST_EHT_HOSTS_CNT: current number of tracked hosts Setting

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-26 Thread Nikolay Aleksandrov
On 26/01/2021 15:25, Hangbin Liu wrote: > On Tue, Jan 26, 2021 at 09:40:13AM +0200, Nikolay Aleksandrov wrote: >> On 26/01/2021 06:09, Hangbin Liu wrote: >>> After adding bridge as upper layer of bond/team, we usually clean up the >>> IP address on bond/team and set it

[PATCH net-next 0/2] net: bridge: multicast: per-port EHT hosts limit

2021-01-26 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This set adds a simple configurable per-port EHT tracked hosts limit. Patch 01 adds a default limit of 512 tracked hosts per-port, since the EHT changes are still only in net-next that shouldn't be a problem. Then patch 02 adds the ability to configure and ret

Re: [PATCH net-next] bridge: Propagate NETDEV_NOTIFY_PEERS notifier

2021-01-25 Thread Nikolay Aleksandrov
On 26/01/2021 06:09, Hangbin Liu wrote: > After adding bridge as upper layer of bond/team, we usually clean up the > IP address on bond/team and set it on bridge. When there is a failover, > bond/team will not send gratuitous ARP since it has no IP address. > Then the down layer(e.g. VM tap dev) of

Re: [PATCH] bridge: Use PTR_ERR_OR_ZERO instead if(IS_ERR(...)) + PTR_ERR

2021-01-25 Thread Nikolay Aleksandrov
oups */ > - err = IS_ERR(pg) ? PTR_ERR(pg) : 0; > + err = PTR_ERR_OR_ZERO(pg); > spin_unlock(&br->multicast_lock); > > return err; > This should be targeted at net-next. Acked-by: Nikolay Aleksandrov

[PATCH net-next 11/14] net: bridge: multicast: optimize TO_INCLUDE EHT timeouts

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov This is an optimization specifically for TO_INCLUDE which sends queries for the older entries and thus lowers the S,G timers to LMQT. If we have the following situation for a group in either include or exclude mode: - host A was interested in srcs X and Y, but is

[PATCH net-next 10/14] net: bridge: multicast: add EHT include and exclude handling

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support for IGMPv3/MLDv2 include and exclude EHT handling. Similar to how the reports are processed we have 2 cases when the group is in include or exclude mode, these are processed as follows: - group include - is_include: create missing entries - to_include

[PATCH net-next 05/14] net: bridge: multicast: add EHT structures and definitions

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add EHT structures for tracking hosts and sources per group. We keep one set for each host which has all of the host's S,G entries, and one set for each multicast source which has all hosts that have joined that S,G. For each host, source entry we record the filter

[PATCH net-next 14/14] net: bridge: multicast: mark IGMPv3/MLDv2 fast-leave deletes

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Mark groups which were deleted due to fast leave/EHT. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 21 ++--- net/bridge/br_multicast_eht.c | 8 net/bridge/br_private.h | 3 ++- 3 files changed, 20 insertions

[PATCH net-next 08/14] net: bridge: multicast: add EHT host delete function

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Now that we can delete set entries, we can use that to remove EHT hosts. Since the group's host set entries exist only when there are related source set entries we just have to flush all source set entries joined by the host set entry and it will be automati

[PATCH net-next 12/14] net: bridge: multicast: add EHT host filter_mode handling

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We should be able to handle host filter mode changing. For exclude mode we must create a zero-src entry so the group will be kept even without any S,G entries (non-zero source sets). That entry doesn't count to the entry limit and can always be created, its tim

[PATCH net-next 13/14] net: bridge: multicast: handle block pg delete for all cases

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov A block report can result in empty source and host sets for both include and exclude groups so if there are no hosts left we can safely remove the group. Pull the block group handling so it can cover both cases and add a check if EHT requires the delete. Signed-off-by

[PATCH net-next 07/14] net: bridge: multicast: add EHT source set handling functions

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add EHT source set and set-entry create, delete and lookup functions. These allow to manipulate source sets which contain their own host sets with entries which joined that S,G. We're limiting the maximum number of tracked S,G entries per host to PG_SRC_ENT_

[PATCH net-next 09/14] net: bridge: multicast: add EHT allow/block handling

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add support for IGMPv3/MLDv2 allow/block EHT handling. Similar to how the reports are processed we have 2 cases when the group is in include or exclude mode, these are processed as follows: - group include - allow: create missing entries - block: remove existing

[PATCH net-next 06/14] net: bridge: multicast: add EHT host handling functions

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Add functions to create, destroy and lookup an EHT host. These are per-host entries contained in the eht_host_tree in net_bridge_port_group which are used to store a list of all sources (S,G) entries joined for that group by each host, the host's current filter mod

[PATCH net-next 04/14] net: bridge: multicast: calculate idx position without changing ptr

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We need to preserve the srcs pointer since we'll be passing it for EHT handling later. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/net/b

[PATCH net-next 03/14] net: bridge: multicast: __grp_src_block_incl can modify pg

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Prepare __grp_src_block_incl() for being able to cause a notification due to changes. Currently it cannot happen, but EHT would change that since we'll be deleting sources immediately. Make sure that if the pg is deleted we don't return true as that would

[PATCH net-next 01/14] net: bridge: multicast: rename src_size to addr_size

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Rename src_size argument to addr_size in preparation for passing host address as an argument to IGMPv3/MLDv2 functions. No functional change. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 78 +++ 1 file changed

[PATCH net-next 02/14] net: bridge: multicast: pass host src address to IGMPv3/MLDv2 functions

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov We need to pass the host address so later it can be used for explicit host tracking. No functional change. Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_multicast.c | 90 +-- 1 file changed, 49 insertions(+), 41 deletions

[PATCH net-next 00/14] net: bridge: multicast: add initial EHT support

2021-01-20 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov Hi, This set adds explicit host tracking support for IGMPv3/MLDv2. The already present per-port fast leave flag is used to enable it since that is the primary goal of EHT, to track a group and its S,Gs usage per-host and when left without any interested hosts delete

Re: [PATCH v1] ipv4: add iPv4_is_multicast() check in ip_mc_leave_group().

2021-01-19 Thread Nikolay Aleksandrov
On 19/01/2021 06:39, Jakub Kicinski wrote: > On Sun, 17 Jan 2021 05:34:16 -0800 wangyingji...@126.com wrote: >> From: Yingjie Wang >> >> There is no iPv4_is_multicast() check added to ip_mc_leave_group() >> to check if imr->imr_multiaddr.s_addr is a multicast address. >> If not a multicast address

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-19 Thread Nikolay Aleksandrov
On 19/01/2021 02:42, Vladimir Oltean wrote: > On Tue, Jan 19, 2021 at 12:42:04AM +0200, Nikolay Aleksandrov wrote: >> No, it shouldn't be a problem to change that. We should be careful about the >> way it's changed though because reporting it for all ports might become a

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 19/01/2021 00:06, Vladimir Oltean wrote: > On Mon, Jan 18, 2021 at 11:53:18PM +0200, Nikolay Aleksandrov wrote: >> On 18/01/2021 23:50, Vladimir Oltean wrote: >>> On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: >>>> Apologies for the multiple

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:50, Vladimir Oltean wrote: > On Mon, Jan 18, 2021 at 11:39:27PM +0200, Nikolay Aleksandrov wrote: >> Apologies for the multiple emails, but wanted to leave an example: >> >> 00:11:22:33:44:55 dev ens16 master bridge permanent >> >> This must al

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:22, Nikolay Aleksandrov wrote: > On 18/01/2021 23:17, Nikolay Aleksandrov wrote: >> On 18/01/2021 22:19, Tobias Waldekranz wrote: >>> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: >>>> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekra

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 23:17, Nikolay Aleksandrov wrote: > On 18/01/2021 22:19, Tobias Waldekranz wrote: >> On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: >>> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: >>>> Ah I see, no I was not aware of t

Re: [RFC net-next 2/7] net: bridge: switchdev: Include local flag in FDB notifications

2021-01-18 Thread Nikolay Aleksandrov
On 18/01/2021 22:19, Tobias Waldekranz wrote: > On Mon, Jan 18, 2021 at 21:27, Vladimir Oltean wrote: >> On Mon, Jan 18, 2021 at 07:58:59PM +0100, Tobias Waldekranz wrote: >>> Ah I see, no I was not aware of that. I just saw that the entry towards >>> the CPU was added to the ATU, which it would i

Re: [PATCH v4 net-next] net: bridge: check vlan with eth_type_vlan() method

2021-01-18 Thread Nikolay Aleksandrov
| 2 +- > 3 files changed, 5 insertions(+), 12 deletions(-) > Acked-by: Nikolay Aleksandrov

Re: [RFC PATCH v2] net: bridge: igmp: Extend IGMP query to be per vlan

2021-01-18 Thread Nikolay Aleksandrov
On 16/01/2021 17:39, Joachim Wiberg wrote: > On Wed, Jan 13, 2021 at 14:15, Nikolay Aleksandrov wrote: >> On 12/01/2021 15:59, Horatiu Vultur wrote: >>> Based on the comments of the previous version, we started to work on a >>> new version, so it would be possible to

Re: [PATCH net-next] net: bridge: use eth_type_vlan in br_dev_queue_push_xmit

2021-01-14 Thread Nikolay Aleksandrov
On 14/01/2021 09:51, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > Replace the check for ETH_P_8021Q and ETH_P_8021AD in > br_dev_queue_push_xmit with eth_type_vlan. > > Signed-off-by: Menglong Dong > --- > net/bridge/br_forward.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deleti

Re: [PATCH] net/bridge: Fix inconsistent format argument types

2021-01-13 Thread Nikolay Aleksandrov
On 13/01/2021 11:44, Jiapeng Zhong wrote: > Fix the following warnings: > > net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1) > requires 'long' but the argument type is 'unsigned long'. > net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1) > requires 'long' but

Re: [PATCH] net/bridge: Fix inconsistent format argument types

2021-01-13 Thread Nikolay Aleksandrov
On 13/01/2021 11:36, Jiapeng Zhong wrote: > Fix the following warnings: > > net/bridge/br_sysfs_br.c(833): warning: %u in format string (no. 1) > requires 'unsigned int' but the argument type is 'signed int'. > net/bridge/br_sysfs_br.c(817): warning: %u in format string (no. 1) > requires 'unsigne

Re: [RFC PATCH v2] net: bridge: igmp: Extend IGMP query to be per vlan

2021-01-13 Thread Nikolay Aleksandrov
On 12/01/2021 15:59, Horatiu Vultur wrote: > Based on the comments of the previous version, we started to work on a > new version, so it would be possible to enable/disable queries per vlan. > This is still work in progress and there are plenty of things that are > not implemented and tested: > - i

  1   2   3   4   5   6   7   8   9   10   >