RE: [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()

2018-03-28 Thread Paul Durrant
> -Original Message- > From: Dongli Zhang [mailto:dongli.zh...@oracle.com] > Sent: 28 March 2018 00:42 > To: xen-de...@lists.xenproject.org; linux-ker...@vger.kernel.org > Cc: netdev@vger.kernel.org; Wei Liu <wei.l...@citrix.com>; Paul Durrant > <paul.durr...@ci

RE: [PATCH net-next v2] xen-netback: make copy batch size configurable

2017-12-21 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 21 December 2017 17:24 > To: netdev@vger.kernel.org > Cc: Joao Martins <joao.m.mart...@oracle.com>; Wei Liu > <wei.l...@citrix.com>; Paul Durrant <pa

RE: [PATCH] xen-netback: Fix logging message with spurious period after newline

2017-12-06 Thread Paul Durrant
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: 06 December 2017 06:40 > To: Wei Liu <wei.l...@citrix.com>; Paul Durrant <paul.durr...@citrix.com> > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; linux- > ker...@vger.ker

RE: [PATCH] xen-netfront: remove warning when unloading module

2017-11-20 Thread Paul Durrant
> -Original Message- > From: Eduardo Otubo [mailto:ot...@redhat.com] > Sent: 20 November 2017 10:41 > To: xen-de...@lists.xenproject.org > Cc: netdev@vger.kernel.org; Paul Durrant <paul.durr...@citrix.com>; Wei > Liu <wei.l...@citrix.com>; linux-k

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 13 November 2017 16:34 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; Wei Liu <wei.l...@citrix.com>; xen- > de...@lists.xenproject.org > Sub

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 13 November 2017 11:54 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; Wei Liu <wei.l...@citrix.com>; xen- > de...@lists.xenproject.org > Sub

RE: [Xen-devel] [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 13 November 2017 10:50 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com>; xen-de...@lists.xenproject.org; 'Joao > Martins' <joao.m.mart...@or

RE: [PATCH net-next v1] xen-netback: make copy batch size configurable

2017-11-13 Thread Paul Durrant
> -Original Message- > From: Joao Martins [mailto:joao.m.mart...@oracle.com] > Sent: 10 November 2017 19:35 > To: netdev@vger.kernel.org > Cc: Joao Martins <joao.m.mart...@oracle.com>; Wei Liu > <wei.l...@citrix.com>; Paul Durrant <pa

RE: [PATCH net] xen-netback: correctly schedule rate-limited queues

2017-06-21 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 21 June 2017 10:21 > To: netdev@vger.kernel.org > Cc: Xen-devel <xen-de...@lists.xenproject.org>; Paul Durrant > <paul.durr...@citrix.com>; David Miller <da...@davemloft.net>; jea

RE: [PATCH net v3] xen-netback: fix race condition on XenBus disconnect

2017-03-09 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 09 March 2017 19:42 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant <paul.durr...@citrix.com>; jgr...@suse.com; Wei Liu > <wei.l...@

RE: [PATCH net v2] xen-netback: fix race condition on XenBus disconnect

2017-03-06 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 03 March 2017 20:23 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant <paul.durr...@citrix.com>; jgr...@suse.com; Wei Liu > <wei.l...@

RE: [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 03 March 2017 13:54 > To: Paul Durrant <paul.durr...@citrix.com>; netdev@vger.kernel.org; xen- > de...@lists.xenproject.org > Cc: jgr...@suse.com; Wei Liu <wei.l...@citrix.com> > Subject: Re: [PATCH

RE: [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 03 March 2017 13:56 > To: Paul Durrant <paul.durr...@citrix.com>; netdev@vger.kernel.org; xen- > de...@lists.xenproject.org > Cc: jgr...@suse.com; Wei Liu <wei.l...@citrix.com> > Subject: Re: [PATCH

RE: [PATCH] xen-netback: fix race condition on XenBus disconnect

2017-03-03 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 02 March 2017 22:57 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant <paul.durr...@citrix.com>; jgr...@suse.com; Wei Liu > <wei.l...@

[PATCH net 1/2] xen-netback: keep a local pointer for vif in backend_disconnect()

2017-03-02 Thread Paul Durrant
This patch replaces use of 'be->vif' with 'vif' and hence generally makes the function look tidier. No semantic change. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> --- Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/xenbus.c | 32 ++---

[PATCH net 2/2] xen-netback: don't vfree() queues under spinlock

2017-03-02 Thread Paul Durrant
] ? xenbus_printf+0x50/0x50 [ 174.541278] ? __kthread_init_worker+0x40/0x40 [ 174.541898] ret_from_fork+0x21/0x2c [ 174.548635] switch: port 2(vif3.0) entered disabled state This patch defers the vfree() until after the spinlock is released. Reported-by: Juergen Gross <jgr...@suse.com> Signed-off-by

[PATCH net 0/2] xen-netback: update memory leak fix to avoid BUG

2017-03-02 Thread Paul Durrant
d this call to vfree() in a spin lock, leading to a BUG due to incorrect context. Patch #1 makes the existing code more readable Patch #2 fixes the problem Paul Durrant (2): xen-netback: keep a local pointer for vif in backend_disconnect() xen-netback: don't vfree() queues under spinlock dri

RE: BUG due to "xen-netback: protect resource cleaning on XenBus disconnect"

2017-03-02 Thread Paul Durrant
er...@vger.kernel.org>; netdev@vger.kernel.org; Boris Ostrovsky > <boris.ostrov...@oracle.com>; David Miller <da...@davemloft.net>; Paul > Durrant <paul.durr...@citrix.com> > Subject: Re: BUG due to "xen-netback: protect resource cleaning on XenBus > disconnect" >

RE: [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash

2017-03-02 Thread Paul Durrant
> -Original Message- > From: Anoob Soman [mailto:anoob.so...@citrix.com] > Sent: 02 March 2017 10:50 > To: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Cc: Paul Durrant <paul.durr...@citrix.com>; Wei Liu <wei.l...@citrix.com>; > Anoob Soman <

RE: [Xen-devel] [PATCH] xen-netback: vif counters from int/long to u64

2017-02-10 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Mart van Santen > Sent: 10 February 2017 12:02 > To: Wei Liu <wei.l...@citrix.com>; Paul Durrant <paul.durr...@citrix.com>; > xen-de...@lists.xenproject.org; netdev@

[PATCH net-next] xen-netfront: reject short packets and handle non-linear packets

2017-01-25 Thread Paul Durrant
lls sufficient bytes into the linear area. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reported-by: Sowmini Varadhan <sowmini.varad...@oracle.com> Tested-by: Sowmini Varadhan <sowmini.varad...@oracle.com> --- Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> Cc: Jue

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-25 Thread Paul Durrant
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: 19 January 2017 11:14 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Wei Liu > <wei.l...@citrix.com>

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Paul Durrant
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: 19 January 2017 11:14 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com>; Wei Liu > <wei.l...@citrix.com>

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 18 January 2017 19:25 > To: Sowmini Varadhan <sowmini.varad...@oracle.com>; Wei Liu > <wei.l...@citrix.com>; Paul Durrant <paul.durr...@citrix.com> >

RE: [PATCH v2 2/2] xen-netback: protect resource cleaning on XenBus disconnect

2017-01-18 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 17 January 2017 20:50 > To: Wei Liu <wei.l...@citrix.com> > Cc: Paul Durrant <paul.durr...@citrix.com>; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linu

RE: [PATCH v2 1/2] xen-netback: fix memory leaks on XenBus disconnect

2017-01-18 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 17 January 2017 20:50 > To: Wei Liu <wei.l...@citrix.com> > Cc: Paul Durrant <paul.durr...@citrix.com>; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linu

RE: [PATCH] xen-netback: fix memory leaks on XenBus disconnect

2017-01-13 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 13 January 2017 10:38 > To: Igor Druzhinin <igor.druzhi...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com>; xen-de...@lists.xenproject.org; Paul > Durrant <paul.durr...@citrix.co

RE: [PATCH] xen-netback: fix memory leaks on XenBus disconnect

2017-01-13 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin [mailto:igor.druzhi...@citrix.com] > Sent: 12 January 2017 17:52 > To: Wei Liu <wei.l...@citrix.com>; xen-de...@lists.xenproject.org; Paul > Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; linu

RE: [PATCH 2/3] xen: modify xenstore watch event interface

2017-01-06 Thread Paul Durrant
; Roger Pau Monne <roger@citrix.com>; Wei Liu > <wei.l...@citrix.com>; Paul Durrant <paul.durr...@citrix.com>; > netdev@vger.kernel.org > Subject: [PATCH 2/3] xen: modify xenstore watch event interface > > Today a Xenstore watch event is delivered via a callback function

RE: [Xen PATCH] xen-netback: fix error handling output

2016-11-08 Thread Paul Durrant
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 08 November 2016 13:35 > To: David Vrabel <david.vra...@citrix.com> > Cc: Arnd Bergmann <a...@arndb.de>; Wei Liu <wei.l...@citrix.com>; Paul > Durrant <paul.durr...@citrix.com&g

RE: [PATCH v3] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-11-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 November 2016 07:46 > To: Paul Durrant <paul.durr...@citrix.com>; Wei Liu <wei.l...@citrix.com> > Cc: xen-devel <xen-de...@lists.xenproject.org>; netdev@vger.kernel.org > Sub

RE: [PATCH 06/12] xen: make use of xenbus_read_unsigned() in xen-netback

2016-11-01 Thread Paul Durrant
.@suse.com>; Wei Liu <wei.l...@citrix.com>; Paul > Durrant <paul.durr...@citrix.com>; netdev@vger.kernel.org > Subject: [PATCH 06/12] xen: make use of xenbus_read_unsigned() in xen- > netback > > Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. > This re

RE: [PATCH v2 RESEND] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-10-25 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 25 October 2016 09:23 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: David Vrabel <david.vra...@citrix.com>; Wei Liu <wei.l...@citrix.com>; > xen-de...@lists.xenproject.org;

RE: [PATCH v2 RESEND] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-10-25 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 24 October 2016 16:08 > To: Paul Durrant <paul.durr...@citrix.com>; Wei Liu <wei.l...@citrix.com> > Cc: David Vrabel <david.vra...@citrix.com>; xen-de...@lists.xenproject.org; >

RE: [PATCH] xen-netback: fix type mismatch warning

2016-10-12 Thread Paul Durrant
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 12 October 2016 10:54 > To: Wei Liu <wei.l...@citrix.com>; Paul Durrant <paul.durr...@citrix.com> > Cc: Arnd Bergmann <a...@arndb.de>; David S. Miller > <da...@davemloft.net&

RE: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

2016-10-11 Thread Paul Durrant
> -Original Message- > From: David Vrabel [mailto:david.vra...@citrix.com] > Sent: 11 October 2016 16:48 > To: netdev@vger.kernel.org > Cc: David Vrabel <david.vra...@citrix.com>; xen-de...@lists.xenproject.org; > Paul Durrant <paul.durr...@citrix.com>

[PATCH net] xen-netback: (re-)create a debugfs node for hash information

2016-10-10 Thread Paul Durrant
From: Paul Durrant <paul.durr...@citrix.com> It is useful to be able to see the hash configuration when running tests. This patch adds a debugfs node for that purpose. The original version of this patch (commit c0c64c152389) was reverted due to build failures caused by a conflict with

[PATCH net-next] MAINTAINERS: add myself as a maintainer of xen-netback

2016-10-07 Thread Paul Durrant
Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 464437d..4491841 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13061,6 +13061,7 @@ F:

Reversion of "xen-netback: create a debugfs node for hash information"

2016-10-07 Thread Paul Durrant
Dave, I notice that you have made the above reversion of commit c0c64c15 (debugfs node) due to a build failure, despite the failure being caused by commit 0364a882 (switch to threaded irq) which was made subsequently. I assume you want me to re-spin a new patch for the debugfs node to fix

[PATCH v2 net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-07 Thread Paul Durrant
() instead, which is clearly guaranteed to be called irrespective of the number of queues. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- v2: - Simplified and re-based onto re-factored net branch --- drivers/net/xen-netback/inte

RE: [PATCH net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-07 Thread Paul Durrant
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 07 October 2016 06:38 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > <wei.l...@citrix.com> > Subject: Re: [

[PATCH net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-06 Thread Paul Durrant
not only on the presence of a s/w hash, but also on whether the hash algorithm has been configured. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/interface.c | 13 ++--- drivers/net/xen-netback/netb

RE: [Xen-devel] [PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:49 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > <wei.l...@citrix.com>; David V

RE: [Xen-devel] [PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:48 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org; Wei Liu > <wei.l...@citrix.com>; David V

RE: [Xen-devel] [PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 04 October 2016 13:52 > To: Paul Durrant <paul.durr...@citrix.com>; annie...@oracle.com; > joao.m.mart...@oracle.com > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproje

[PATCH v2 net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-04 Thread Paul Durrant
From: David Vrabel <david.vra...@citrix.com> Instead of only placing one skb on the guest rx ring at a time, process a batch of up-to 64. This improves performance by ~10% in some tests. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durran

[PATCH v2 net-next 0/7] xen-netback: guest rx side refactor

2016-10-04 Thread Paul Durrant
. v2: - Rebased onto refreshed net-next David Vrabel (4): xen-netback: refactor guest rx xen-netback: immediately wake tx queue when guest rx queue has space xen-netback: process guest rx packets in batches xen-netback: batch copies for multiple to-guest rx packets Paul Durrant (2): xen

[PATCH v2 net-next 7/7] xen/netback: add fraglist support for to-guest rx

2016-10-04 Thread Paul Durrant
From: Ross Lagerwall <ross.lagerw...@citrix.com> This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 fragments) to be handled by netback for to-guest rx. Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.dur

[PATCH v2 net-next 6/7] xen-netback: batch copies for multiple to-guest rx packets

2016-10-04 Thread Paul Durrant
e copy batch. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.durr...@citrix.com> --- Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/common.h | 1 + drivers/net/xen-netback/rx.c | 27 +---

[PATCH v2 net-next 3/7] xen-netback: refactor guest rx

2016-10-04 Thread Paul Durrant
Each struct xenvif_queue is now only 44 kB instead of 220 kB. 3. Make the code more maintainable. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.durr...@citrix.com> --- Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xe

[PATCH v2 net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-04 Thread Paul Durrant
From: David Vrabel <david.vra...@citrix.com> When an skb is removed from the guest rx queue, immediately wake the tx queue, instead of after processing them. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.durr...@citrix.com&g

[PATCH v2 net-next 1/7] xen-netback: separate guest side rx code into separate module

2016-10-04 Thread Paul Durrant
patch style-check issues. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> --- Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/Makefile | 2 +- drivers/net/xen-netback/netback.c | 754 drivers/net/xen-netback/rx.

[PATCH v2 net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-04 Thread Paul Durrant
, which is also used by all Linux frontends. NOTE: Removal of this feature will not cause breakage in old Windows frontends. They simply will no longer receive GSO packets - the packets instead being fragmented in the backend. Signed-off-by: Paul Durrant <paul.durr...@citrix.com>

RE: [PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-04 Thread Paul Durrant
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 04 October 2016 05:52 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: netdev@vger.kernel.org; xen-de...@lists.xenproject.org > Subject: Re: [PATCH net-next 0/7] xen-netback: guest rx

[PATCH net-next 7/7] xen/netback: add fraglist support for to-guest rx

2016-10-03 Thread Paul Durrant
From: Ross Lagerwall <ross.lagerw...@citrix.com> This allows full 64K skbuffs (with 1500 mtu ethernet, composed of 45 fragments) to be handled by netback for to-guest rx. Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.dur

[PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-03 Thread Paul Durrant
. David Vrabel (4): xen-netback: refactor guest rx xen-netback: immediately wake tx queue when guest rx queue has space xen-netback: process guest rx packets in batches xen-netback: batch copies for multiple to-guest rx packets Paul Durrant (2): xen-netback: separate guest side rx code

[PATCH net-next 1/7] xen-netback: separate guest side rx code into separate module

2016-10-03 Thread Paul Durrant
patch style-check issues. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> --- Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/Makefile | 2 +- drivers/net/xen-netback/netback.c | 754 drivers/net/xen-netback/rx.

[PATCH net-next 3/7] xen-netback: refactor guest rx

2016-10-03 Thread Paul Durrant
Each struct xenvif_queue is now only 44 kB instead of 220 kB. 3. Make the code more maintainable. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.durr...@citrix.com> --- Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xe

[PATCH net-next 6/7] xen-netback: batch copies for multiple to-guest rx packets

2016-10-03 Thread Paul Durrant
e copy batch. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.durr...@citrix.com> --- Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/common.h | 1 + drivers/net/xen-netback/rx.c | 27 +---

[PATCH net-next 5/7] xen-netback: process guest rx packets in batches

2016-10-03 Thread Paul Durrant
From: David Vrabel <david.vra...@citrix.com> Instead of only placing one skb on the guest rx ring at a time, process a batch of up-to 64. This improves performance by ~10% in some tests. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durran

[PATCH net-next 4/7] xen-netback: immediately wake tx queue when guest rx queue has space

2016-10-03 Thread Paul Durrant
From: David Vrabel <david.vra...@citrix.com> When an skb is removed from the guest rx queue, immediately wake the tx queue, instead of after processing them. Signed-off-by: David Vrabel <david.vra...@citrix.com> [re-based] Signed-off-by: Paul Durrant <paul.durr...@citrix.com&g

[PATCH net-next 2/7] xen-netback: retire guest rx side prefix GSO feature

2016-10-03 Thread Paul Durrant
, which is also used by all Linux frontends. NOTE: Removal of this feature will not cause breakage in old Windows frontends. They simply will no longer receive GSO packets - the packets instead being fragmented in the backend. Signed-off-by: Paul Durrant <paul.durr...@citrix.com>

RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 22 September 2016 11:39 > To: Paul Durrant <paul.durr...@citrix.com>; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Wei Liu <wei.l...@citr

RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 22 September 2016 11:17 > To: Paul Durrant <paul.durr...@citrix.com>; xen-de...@lists.xenproject.org; > net...@vger.kernel.orga <netdev@vger.kernel.org>; linux- > ker...@vger.k

[PATCH net-next] xen-netback: create a debugfs node for hash information

2016-08-17 Thread Paul Durrant
It is useful to be able to see the hash configuration when running tests. This patch adds a debugfs node for that purpose. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/common.h | 4 +++ drivers/net/xen-netback/h

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of David Vrabel > Sent: 07 July 2016 11:45 > To: Wei Liu; David Vrabel > Cc: xen-de...@lists.xenproject.org; Jan Beulich; netdev@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH]

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 07 July 2016 11:41 > To: Wei Liu; David Vrabel > Cc: Jan Beulich; Wei Liu; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org > Subject: RE: [Xen-devel] [PATCH] xen-netback: correct return value che

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Wei Liu > Sent: 07 July 2016 11:35 > To: David Vrabel > Cc: Jan Beulich; Wei Liu; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH]

RE: [Xen-devel] [PATCH] xen-netback: prefer xenbus_write() over xenbus_printf() where possible

2016-07-07 Thread Paul Durrant
r xenbus_write() over > xenbus_printf() where possible > > ... as being the simpler variant. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > --- > drivers/net/xen-netback/xenbus.c | 24 +--

RE: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Paul Durrant
t return value checks on > xenbus_scanf() > > Only a positive return value indicates success. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > --- > drivers/net/xen-netback/xenbus.c | 26 +-

[PATCH net-next] xen-netback: only deinitialized hash if it was initialized

2016-05-18 Thread Paul Durrant
() was called. This patch brings the call to xenvif_deinit_hash() in xenvif_disconnect_ctrl() inside the if clause that checks whether the control ring event channel was connected. This is sufficient to ensure it is only called if xenvif_init_hash() was called previously. Signed-off-by: Paul Durrant

[PATCH net-next] xen-netback: correct length checks on hash copy_ops

2016-05-18 Thread Paul Durrant
to correct the incorrect check, keep the two checks consistent, and to make it clear what the checks are for. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reported-by: Dan Carpenter <dan.carpen...@oracle.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/

[PATCH net-next v4 0/4] xen-netback: support for control ring

2016-05-13 Thread Paul Durrant
support for accepting hash values calculated by capable frontends and using them the set the socket buffer hash. Paul Durrant (4): xen-netback: add control ring boilerplate xen-netback: add control protocol implementation xen-netback: pass hash value to the frontend xen-netback: use hash value

[PATCH net-next v4 3/4] xen-netback: pass hash value to the frontend

2016-05-13 Thread Paul Durrant
. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/interface.c | 13 ++- drivers/net/xen-netback/netback.c | 78 +++-- 2 files changed, 77 insertions(+), 14 deletions(-)

[PATCH net-next v4 2/4] xen-netback: add control protocol implementation

2016-05-13 Thread Paul Durrant
it be created. This patch adds implementations for each of the defined protocol messages. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- v4: - Remove calls to init_rcu_head() and destroy_rcu_head() v3: - Remove unintentional label rename

[PATCH net-next v4 1/4] xen-netback: add control ring boilerplate

2016-05-13 Thread Paul Durrant
by a frontend, but does not add implementations for any of the defined protocol messages. These are added in a subsequent patch for clarity. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- v2: - Changed error handling style in conne

[PATCH net-next v4 4/4] xen-netback: use hash value from the frontend

2016-05-13 Thread Paul Durrant
. netback receive side) packet to set the skb hash accordingly. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/netback.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net

RE: [Xen-devel] [PATCH net-next v2 0/4] xen-netback: support for control ring

2016-05-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > David Miller > Sent: 12 May 2016 16:52 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org > Subject: Re: [Xen-devel] [PATCH net-next v2 0/4]

[PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()

2016-05-12 Thread Paul Durrant
he problem. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Reported-by: Jan Beulich <jbeul...@suse.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/netback.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netback/netback.c b/drive

[PATCH net-next v3 4/4] xen-netback: use hash value from the frontend

2016-05-11 Thread Paul Durrant
. netback receive side) packet to set the skb hash accordingly. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/netback.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net

[PATCH net-next v3 0/4] xen-netback: support for control ring

2016-05-11 Thread Paul Durrant
My recent patch to import an up-to-date include/xen/interface/io/netif.h from the Xen Project brought in the necessary definitions to support the new control shared ring and protocol. This patch series updates xen-netback to support the new ring. Patch #1 adds the necessary boilerplate to map the

[PATCH net-next v3 3/4] xen-netback: pass hash value to the frontend

2016-05-11 Thread Paul Durrant
. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/interface.c | 13 ++- drivers/net/xen-netback/netback.c | 78 +++-- 2 files changed, 77 insertions(+), 14 deletions(-)

[PATCH net-next v3 1/4] xen-netback: add control ring boilerplate

2016-05-11 Thread Paul Durrant
by a frontend, but does not add implementations for any of the defined protocol messages. These are added in a subsequent patch for clarity. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- v2: - Changed error handling style in connect_ctrl_ring()

[PATCH net-next v3 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Paul Durrant
it be created. This patch adds implementations for each of the defined protocol messages. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- v3: - Remove unintentional label rename v2: - Use RCU list for hash cache --- drivers/net/xen-netb

RE: [PATCH net-next v2 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Paul Durrant
> -Original Message- > From: Paul Durrant [mailto:paul.durr...@citrix.com] > Sent: 11 May 2016 16:16 > To: xen-de...@lists.xenproject.org; netdev@vger.kernel.org > Cc: Paul Durrant; Wei Liu > Subject: [PATCH net-next v2 2/4] xen-netback: add control protocol > implemen

[PATCH net-next v2 1/4] xen-netback: add control ring boilerplate

2016-05-11 Thread Paul Durrant
by a frontend, but does not add implementations for any of the defined protocol messages. These are added in a subsequent patch for clarity. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- v2: - Changed error handling style in connect_ctrl_ring()

[PATCH net-next v2 0/4] xen-netback: support for control ring

2016-05-11 Thread Paul Durrant
My recent patch to import an up-to-date include/xen/interface/io/netif.h from the Xen Project brought in the necessary definitions to support the new control shared ring and protocol. This patch series updates xen-netback to support the new ring. Patch #1 adds the necessary boilerplate to map the

[PATCH net-next v2 4/4] xen-netback: use hash value from the frontend

2016-05-11 Thread Paul Durrant
. netback receive side) packet to set the skb hash accordingly. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/netback.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net

[PATCH net-next v2 2/4] xen-netback: add control protocol implementation

2016-05-11 Thread Paul Durrant
it be created. This patch adds implementations for each of the defined protocol messages. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- v2: - Use RCU list for hash cache --- drivers/net/xen-netback/Makefile| 2 +- drivers/net/xen-netb

[PATCH net-next v2 3/4] xen-netback: pass hash value to the frontend

2016-05-11 Thread Paul Durrant
. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/interface.c | 13 ++- drivers/net/xen-netback/netback.c | 78 +++-- 2 files changed, 77 insertions(+), 14 deletions(-)

RE: [PATCH net-next 1/4] xen-netback: add control ring boilerplate

2016-05-10 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 10 May 2016 14:29 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; Wei Liu > Subject: Re: [PATCH net-next 1/4] xen-netback: add control ring boilerplate > > On

RE: [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-10 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 10 May 2016 14:29 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; Wei Liu > Subject: Re: [PATCH net-next 2/4] xen-netback: add control protocol > implementatio

RE: [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-09 Thread Paul Durrant
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: 07 May 2016 20:09 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; Wei Liu > Subject: Re: [PATCH net-next 2/4] xen-netback: add control protocol > implement

[PATCH net-next 1/4] xen-netback: add control ring boilerplate

2016-05-05 Thread Paul Durrant
by a frontend, but does not add implementations for any of the defined protocol messages. These are added in a subsequent patch for clarity. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/common.h| 28 +++--- dri

[PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-05 Thread Paul Durrant
it be created. This patch adds implementations for each of the defined protocol messages. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/Makefile| 2 +- drivers/net/xen-netback/common.h| 43 + drivers/net

[PATCH net-next 3/4] xen-netback: pass hash value to the frontend

2016-05-05 Thread Paul Durrant
. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/interface.c | 13 ++- drivers/net/xen-netback/netback.c | 78 +++-- 2 files changed, 77 insertions(+), 14 deletions(-) diff --g

[PATCH net-next 4/4] xen-netback: use hash value from the frontend

2016-05-05 Thread Paul Durrant
. netback receive side) packet to set the skb hash accordingly. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/netback.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net

[PATCH net-next 0/4] xen-netback: support for control ring

2016-05-05 Thread Paul Durrant
My recent patch to import an up-to-date include/xen/interface/io/netif.h from the Xen Project brought in the necessary definitions to support the new control shared ring and protocol. This patch series updates xen-netback to support the new ring. Patch #1 adds the necessary boilerplate to map the

[PATCH net-next 3/3] xen-netback: reduce log spam

2016-03-10 Thread Paul Durrant
Remove the "prepare for reconnect" pr_info in xenbus.c. It's largely uninteresting and the states of the frontend and backend can easily be observed by watching the (o)xenstored log. Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Cc: Wei Liu <wei.l...@citrix.com>

[PATCH net-next 1/3] xen-netback: re-import canonical netif header

2016-03-10 Thread Paul Durrant
_/g ,s/NETRXF_/XEN_NETRXF_/g ,s/NETIF_/XEN_NETIF_/g ,s/XEN_XEN_/XEN_/g ,s/netif/xen_netif/g ,s/xen_xen_/xen_/g ,s/^typedef.*$//g ,s/^/${TAB}/g w $ w EOF indent --line-length 80 --linux-style netif.h \ -o include/xen/interface/io/netif.h Signed-off-by: Paul Durrant <paul.durr...@citrix.com>

  1   2   >