Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

> sound/oss/soundcard.c | 2 +- > sound/oss/sys_timer.c | 2 +- > sound/oss/uart6850.c | 2 +- > 47 files changed, 54 insertions(+), 54 deletions(-) Acked-by: Ralf Baechle <r...@linux-mips.org> Thanks, Ralf

Re: [PATCH 09/13] timer: Remove users of expire and data arguments to DEFINE_TIMER

uses mod_timer(), > never add_timer(), so the preset expires value is ignored). Set both > sets of arguments to zero. > > Cc: Ralf Baechle <r...@linux-mips.org> > Cc: Wim Van Sebroeck <w...@iguana.be> > Cc: Guenter Roeck <li...@roeck-us.net> > Cc: Geert Uytt

[PATCH] sni_82596: Add Thomas' email address to driver.

--- Reviewing Christoph's DMA patch I noticed Thomas' email address was missing from the entire driver file. drivers/net/ethernet/i825xx/sni_82596.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i825xx/sni_82596.c

Re: [PATCH 3/4] i825xx: switch to switch to dma_alloc_attrs

On Sat, Aug 26, 2017 at 09:21:24AM +0200, Christoph Hellwig wrote: Adding Thomas Bogendoerfer , the author of sni_82596.c to cc. > This way we can always pass DMA_ATTR_NON_CONSISTENT, the SNI mips version > will simply ignore the flag. > > Signed-off-by: Christoph

Re: [PATCH 1/4] sgiseeq: switch to dma_alloc_attrs

On Sat, Aug 26, 2017 at 09:21:22AM +0200, Christoph Hellwig wrote: Looks good, Acked-by: Ralf Baechle <r...@linux-mips.org> Ralf

Re: [PATCH v2 0/5] MIPS: Implement eBPF JIT.

On Tue, Jun 13, 2017 at 03:28:42PM -0700, David Daney wrote: > Changes in v2: > > - Squash a couple of the uasm cleanups. > > - Make insn_table_MM const (suggested by Matt Redfearn) > > - Put the eBPF in its own source file (should fix build > warnings/errors on 32-bit kernel

Re: [PATCH v2 0/5] MIPS: BPF: JIT fixes and improvements.

On Tue, Mar 14, 2017 at 05:34:02PM -0700, David Daney wrote: > > What tree are you targetting with these changes? Do you expect > > them to go via the MIPS or the net-next tree? > > > > Please be explicit about this in the future. > > > > Sorry I didn't mention it. > > My expectation is that

[PATCH] NET: Fix /proc/net/arp for AX.25

"*" in buf for a NULL address argument. Finally the HW address field is left aligned in a 17 character field (the length of an ethernet HW address in the usual hex notation) for readability. Signed-off-by: Ralf Baechle <r...@linux-mips.org> --- net/ipv4/arp.c | 12 ++-- 1

[PATCH] NET: mkiss/6pack: Fix SIOCSIFENCAP ioctl

y was passing 4 for the mode, so the mode check added for 6pack is a bit more lenient allow the values 0 and 4 to be set. That way we retain the option to set different encapsulation modes for future extensions. Signed-off-by: Ralf Baechle <r...@linux-mips.org> drivers/net/hamradio/6pack.c

[PATCH] NET: mkiss: Fix panic

or dev->hard_header_len and dev->addr_len are set to the same values as in my mkiss patch. [r...@linux-mips.org: Massages original submission to conform to the usual standards for patch submissions.] Signed-off-by: Thomas Osterried <tho...@osterried.de> Signed-off-by: Ralf Baechle &l

[PATCH iproute2] ip: HSR: Fix cut and paste error

Fixes: 5c0aec93a516 ("ip: Add HSR support") Signed-off-by: Ralf Baechle <r...@linux-mips.org> --- I found this by coincidence when reading the HSR code. ip/iplink_hsr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink_hsr.c b/ip/iplink_hsr.c index

Re: [PATCH net-next 20/27] net/bpf_jit: MIPS: split VLAN_PRESENT bit handling from VLAN_TCI

I assume you want to merge this together with the rest of you series, so Acked-by: Ralf Baechle <r...@linux-mips.org> Cheers, Ralf On Tue, Dec 13, 2016 at 01:12:39AM +0100, Michał Mirosław wrote: > Date: Tue, 13 Dec 2016 01:12:39 +0100 (CET) > From: Michał Mirosław <mirq-li.

Re: [PATCH] rose: correct integer overflow check

On Thu, Feb 18, 2016 at 04:03:16PM -0500, Insu Yun wrote: > > Because of the types on the right hand side of the comparison > the expressions are all promoted to unsigned. > > Did you look at the compiler's assembler output?  I did when > reviewing your patch. > > > I checked

Re: use-after-free in sixpack_close

On Thu, Dec 17, 2015 at 04:05:32PM -0500, David Miller wrote: > This should fix it, the only thing I'm unsure of is if we should perhaps > also use del_timer_sync() here. Anyone? I think so. Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH 2/2] mkiss: Fix use after free in sixpack_close().

On Thu, Dec 17, 2015 at 04:05:49PM -0500, David Miller wrote: > Subject: [PATCH 2/2] mkiss: Fix use after free in sixpack_close(). Make that subject "... mkiss_close()." Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net-next v3 04/17] tx4939: use __ethtool_get_ksettings

On Mon, Nov 30, 2015 at 02:05:42PM -0800, David Decotigny wrote: Acked-by: Ralf Baechle <r...@linux-mips.org> Ralf -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: [PATCH] MIPS: Remove all the uses of custom gpio.h

On Mon, Aug 03, 2015 at 09:13:27AM +0200, Linus Walleij wrote: Very good job being done here. Reviewed-by: Linus Walleij linus.wall...@linaro.org I guess this better go in through the MIPS tree. Given all the OpenWRT ports using MIPS this is excellent progress for a large hobbyist

[PATCH net-tools] Fix stale references to axattach

Rename all references to axattach to kissattach. Axattach has been renamed early to kissattach early in the history of the ax25-utils package which itself has been superseeded by libax25, ax25-tools and ax25-apps but stale references have remained. Signed-off-by: Ralf Baechle r...@linux-mips.org

[PATCH] NET: AX.25: Stop heartbeat timer on disconnect.

This may result in a kernel panic. The bug has always existed but somehow we've run out of luck now and it bites. Signed-off-by: Richard Stearn rich...@rns-stearn.demon.co.uk Cc: sta...@vger.kernel.org # all branches Signed-off-by: Ralf Baechle r...@linux-mips.org --- net/ax25/ax25_subr.c

[PATCH v2] NET: AX.25: Stop heartbeat timer on disconnect.

From: Richard Stearn rich...@rns-stearn.demon.co.uk This may result in a kernel panic. The bug has always existed but somehow we've run out of luck now and it bites. Signed-off-by: Richard Stearn rich...@rns-stearn.demon.co.uk Cc: sta...@vger.kernel.org # all branches Signed-off-by: Ralf

[PATCH] NET: hamradio: Fix IP over bpq encapsulation.

. Signed-off-by: Ralf Baechle r...@linux-mips.org Cc: sta...@vger.kernel.org # 4.1 --- drivers/net/hamradio/bpqether.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/hamradio/bpqether.c b/drivers/net/hamradio/bpqether.c index 63ff08a..5b54b18 100644 --- a/drivers/net/hamradio

Bpqether broken in 4.1

Eric's Commit 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic neighbour cache operations.) breaks IP traffic over the AX.25 bpqether driver. Here's how to reproduce the issue if you don't have an AX.25 setup. The arp command is there to fudge things if you don't have a peer that

Re: Bpqether broken in 4.1

On Thu, Jul 02, 2015 at 04:03:07PM -0500, Eric W. Biederman wrote: Eric's Commit 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic neighbour cache operations.) breaks IP traffic over the AX.25 bpqether driver. Sigh. NETIF_F_LLTX is not set so recursion does not work :(

Re: [PATCH 1/2] ax25: Stop using sock-sk_protinfo.

On Thu, Jun 25, 2015 at 06:19:07AM -0700, David Miller wrote: Just make a ax25_sock structure that provides the ax25_cb pointer. Nice minimal solution, thanks! I have the big solution my queue which combines struct sock with ax25_cb into struct ax25_sock but that's more complex because

[PATCH] NET: ROSE: Don't dereference NULL neighbour pointer.

A ROSE socket doesn't necessarily always have a neighbour pointer so check if the neighbour pointer is valid before dereferencing it. Signed-off-by: Ralf Baechle r...@linux-mips.org Tested-by: Bernard Pidoux f6...@free.fr Cc: sta...@vger.kernel.org #2.6.11+ diff --git a/net/rose/af_rose.c b/net

Re: [PATCH] ssb: fix handling of ssb_pmu_get_alp_clock()

On Sun, Jun 07, 2015 at 09:02:23AM +0200, Michael Büsch wrote: Signed-off-by: Michael Buesch m...@bues.ch Can some MIPS people take this, please? Will do, as usual. Unfortunately this missed my last pull request so it's going to Linus by the end of the week. Ralf -- To unsubscribe from

Re: [PATCH] net: rose: Use mod_timer

Hi Vaishali, On Sat, Jun 06, 2015 at 09:52:34AM +0530, Vaishali Thakkar wrote: Use mod_timer instead of del_timer followed by add_timer to update the expire field of the active timer. The semantic patch that performs this transformation is as follows: @change@ expression e1, e2, e3, e4;

Re: [UPDATED PATCH] SGISEEQ: use cached memory access to make driver work on IP28

On Wed, Dec 19, 2007 at 01:42:36PM +0100, Thomas Bogendoerfer wrote: - Use inline functions for dma_sync_* instead of macros - added Kconfig change to make selection for similair SGI boxes easier Signed-off-by: Thomas Bogendoerfer [EMAIL PROTECTED] Acked-by: Ralf Baechle [EMAIL PROTECTED

Re: [UPDATED PATCH] SGISEEQ: use cached memory access to make driver work on IP28

On Tue, Dec 04, 2007 at 03:14:46PM -0500, Jeff Garzik wrote: Changes to last version: - Use inline functions for dma_sync_* instead of macros (suggested by Ralf) - added Kconfig change to make selection for similair SGI boxes easier Has Ralf ACK'd this updated version? Acked-by: Ralf

Re: Inconsistent lock state and possible irq lock inversion dependency detected in ax25.ko

rose_node_list_lock twice: Signed-off-by: Ralf Baechle [EMAIL PROTECTED] Part of Bernard's patch is undoing d85838c55d836c33077344fab424f200f2827d84, this one should probably reverted separately. Ralf -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] SGISEEQ: use cached memory access to make driver work on IP28

and DMA_SYNC_DESC_DEV being macros so why not using inlines. Acked-by: Ralf Baechle [EMAIL PROTECTED] Ralf - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] dependencies for platform drivers (was Re: ax88796: add superh to kconfig dependencies)

On Thu, Nov 08, 2007 at 08:18:54AM +, Al Viro wrote: On Thu, Nov 08, 2007 at 04:31:05PM +0900, Magnus Damm wrote: config AX88796 tristate ASIX AX88796 NE2000 clone support - depends on ARM || MIPS + depends on ARM || MIPS || SUPERH You know, that really sucks more and

Re: [PATCH] Fix/Rewrite of the mipsnet driver

On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote: Hello All, currently the mipsnet driver fails after transmitting a number of packages because SKBs are allocated but never freed. I fixed that and coudn't refrain from removing the most egregious warts. - mipsnet.h folded

Re: [PATCH] Fix/Rewrite of the mipsnet driver

On Sun, Oct 28, 2007 at 01:22:04PM -0700, Stephen Hemminger wrote: -#define MIPSNET_INTCTL_TXDONE ((uint32_t)(1 0)) -#define MIPSNET_INTCTL_RXDONE ((uint32_t)(1 1)) -#define MIPSNET_INTCTL_TESTBIT((uint32_t)(1 31)) -#define MIPSNET_INTCTL_ALLSOURCES

Re: [PATCH] Remove always-true tests in irq handlers

On Fri, Oct 26, 2007 at 05:40:24AM -0400, Jeff Garzik wrote: In these drivers, dev_id is always non-NULL. Signed-off-by: Jeff Garzik [EMAIL PROTECTED] --- arch/ia64/hp/sim/simeth.c |5 - arch/mips/pmc-sierra/msp71xx/msp_hwbutton.c |5 + Acked-by: Ralf

[MIPS] MIPSnet: Delete all the useless debugging printks.

Plus minor formatting fixes. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- drivers/net/mipsnet.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) diff --git a/drivers/net/mipsnet.c b/drivers/net/mipsnet.c index 37707a0..aafc3ce 100644

[NET] Jazzsonic: Fix warning about unused variable.

Caused by [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF() aka 0795af5729b18218767fab27c44b1384f72dc9ad. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/jazzsonic.c b/drivers/net/jazzsonic.c index d3825c8..5c154fe 100644 --- a/drivers/net/jazzsonic.c +++ b

[NET] TC35815: Fix build

of 'lp' was here Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index a679f43..8038f28 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c @@ -1461,7 +1461,6 @@ static irqreturn_t tc35815_interrupt(int irq, void *dev_id

[NET] SAA9730: Fix build

Fix build breakage by the recent statistics cleanup in cset 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/saa9730.c b/drivers/net/saa9730.c index 14361e8..c65199d 100644 --- a/drivers/net/saa9730.c +++ b/drivers/net/saa9730.c

[NET] MIPSsim: General cleanup

General cleanups mostly as suggested by checkpatch plus getting rid of homebrew version of offsetof(). Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- drivers/net/mipsnet.c | 63 ++--- drivers/net/mipsnet.h | 83

Re: [PATCH] sb1250-mac: Driver model phylib update

On Fri, Sep 21, 2007 at 12:44:09PM -0700, Andrew Morton wrote: A driver model and phylib update. akpm:/usr/src/25 diffstat patches/git-net.patch | tail -n 1 1013 files changed, 187667 insertions(+), 23587 deletions(-) Sorry, but raising networking patches against Linus's crufty old

Re: [PATCH][MIPS][7/7] AR7: ethernet

On Thu, Sep 13, 2007 at 02:42:46AM +0100, Thiemo Seufer wrote: All struct members here are sized such that there is no padding needed, so the packed attribute doesn't buy you anything - unless of course the entire structure is missaligned but I don't see how that would be possible in this

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

On Thu, Sep 13, 2007 at 03:13:06PM +0100, Maciej W. Rozycki wrote: Hmm, works fine with linux-2.6.git#master. I do not recall any recent activity with this driver -- I wonder what the difference is. Let me see... Hmm... HEAD du jour has no differences for the sb1250-mac between lmo and

Re: [NET] Nuke SET_NETDEV_DEVICE macro

On Wed, Sep 12, 2007 at 05:27:13PM +0100, Ralf Baechle wrote: It's been a useless no-op for long enough in 2.6 so I figured it's time to remove it. The number of people that could object because they're maintaining unified 2.4 and 2.6 drivers is probably rather small. Whops, wrong patch

Re: [PATCH][MIPS][7/7] AR7: ethernet

On Sat, Sep 08, 2007 at 02:23:00AM +0200, Matteo Croce wrote: Driver for the cpmac 100M ethernet driver. It works fine disabling napi support, enabling it gives a kernel panic when the first IPv6 packet has to be forwarded. Other than that works fine. Signed-off-by: Matteo Croce [EMAIL

Re: [PATCH 1/2] remove asm/bitops.h includes

] Signed-off-by: Jiri Slaby [EMAIL PROTECTED] For the MIPS and hamradio bits: Acked-by: Ralf Baechle [EMAIL PROTECTED] Ralf - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] sb1250-mac.c: De-typedef, de-volatile, de-etc...

On Mon, Sep 10, 2007 at 01:20:38PM +0100, Maciej W. Rozycki wrote: Remove typedefs, volatiles and convert kmalloc()/memset() pairs to kcalloc(). Also reformat the surrounding clutter. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- Per your request, Andrew, a while ago. It

[NET] sgiseeq: replace use of dma_cache_wback_inv

The sgiseeq driver is one of the few remaining users of the ancient cache banging DMA API. Replaced with the modern days DMA API. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index 0fb74cb..eb67b02 100644 --- a/drivers/net/sgiseeq.c

Re: [PATCH 8/9] define global BIT macro

On Sat, Aug 18, 2007 at 11:44:12AM +0200, Jiri Slaby wrote: define global BIT macro move all local BIT defines to the new globally define macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Acked-by: Ralf Baechle [EMAIL PROTECTED] for the MACE ethernet and MIPS bits. Ralf

[NET] sgiseeq: Fix return type of sgiseeq_remove

The driver remove method needs to return an int not void. This was just never noticed because usually this driver is not being built as a module. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index 384b468..0fb74cb 100644 --- a/drivers

[METH] Don't use GFP_DMA for zone allocation.

IP32 doesn't even have a ZONE_DMA so no point in using GFP_DMA in any IP32-specific device driver. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/meth.c b/drivers/net/meth.c index 92b403b..32bed6b 100644 --- a/drivers/net/meth.c +++ b/drivers/net/meth.c @@ -405,7 +405,7

Re: [PATCH 13/24] make atomic_read() behave consistently on mips

On Thu, Aug 09, 2007 at 10:00:04AM -0400, Chris Snook wrote: Purify volatile use for atomic[64]_t on mips. Signed-off-by: Chris Snook [EMAIL PROTECTED] Acked-by: Ralf Baechle [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[NET] IOC3: Switch hw checksumming to ethtool configurable.

Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- I've previously sent out this patch a long time ago. At that time I was told NETIF_F_IP_CSUM wouldn't make any sense without NETIF_F_SG. IOC3's S/G abilities are very limited; it can do upto three segments of which the first one is upto 104

[IOC3] Switch to pci refcounting safe APIs

: Signed-off-by: Ralf Baechle [EMAIL PROTECTED] Index: upstream-linus/drivers/net/ioc3-eth.c === --- upstream-linus.orig/drivers/net/ioc3-eth.c +++ upstream-linus/drivers/net/ioc3-eth.c @@ -352,13 +352,12 @@ static u64 nic_find(struct ioc3

[NET] au1000_eth: Fix warnings.

'dma_free_noncoherent' Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index c39ab80..c27cfce 100644 --- a/drivers/net/au1000_eth.c +++ b/drivers/net/au1000_eth.c @@ -34,7 +34,7 @@ * * */ - +#include linux/dma-mapping.h

Re: [NET] meth driver renovation

On Wed, May 23, 2007 at 01:02:18PM -0700, Shane McDonald wrote: static void __exit meth_exit_module(void) { - unregister_netdev(meth_dev); - free_netdev(meth_dev); + platform_driver_register(meth_driver); }

[NET] meth driver renovation

The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting the meth driver to a platform device. Signed-off-by: Ralf Baechle

[NET] meth driver renovation

The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting the meth driver to a platform device. Signed-off-by: Ralf Baechle

Re: [NET] meth driver renovation

On Wed, May 23, 2007 at 09:43:30AM +0100, Ralf Baechle wrote: The meth ethernet driver for the SGI IP32 aka O2 is so far still an old style driver which does not use the device driver model. This is now causing issues with some udev based gadgetry in debian-stable. Fixed by converting

Re: [PATCH 4/5] ne: MIPS: Use platform_driver for ne on RBTX49XX

driver selectable on these boards regardless of CONFIG_ISA Signed-off-by: Atsushi Nemoto [EMAIL PROTECTED] Acked-by: Ralf Baechle [EMAIL PROTECTED] Ralf - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

[NET] SAA9730: Fix large pile of warnings

: passing argument 2 of 'outl' makes integer from pointer without a cast Fixed by using writel instead of outl. 42 warnings less. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/saa9730.c b/drivers/net/saa9730.c index b269513..143958f 100644 --- a/drivers/net/saa9730.c +++ b

Re: [PATCH] Netpoll support for Sibyte MAC

On Mon, Mar 19, 2007 at 03:43:11PM -0700, Deepak Saxena wrote: +#ifdef CONFIG_SBMAC_COALESCE Not your patch's fault but ... CONFIG_SBMAC_COALESCE is being defined in sb1250-mac.c but the CONFIG_* namespace is reserved for kconfig. Ralf - To unsubscribe from this list: send the line

[NET] AX.25 Kconfig and docs updates and fixes

Rewrite the commented out piece of old Linux 2.4 configuration language to Kconfig for consistency. o Fixup dependencies. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/Documentation/networking/ax25.txt b/Documentation/networking/ax25.txt index 37c25b0..8257dbf 100644

[NET] ibmtr: Drain rich supply of modpost warnings.

. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] drivers/net/tokenring/ibmtr.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) Index: linux-mips/drivers/net/tokenring/ibmtr.c === --- linux-mips.orig

[NET] 3c59x: Fix several modpost warnings

function. o Wrap vortex_eisa_driver reference to vortex_eisa_remove with __devexit_p(). Signed-off-by: Ralf Baechle [EMAIL PROTECTED] drivers/net/3c59x.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) Index: linux-mips/drivers/net/3c59x.c

Re: [patch 2/2] div64_64: common code

On Tue, Mar 06, 2007 at 02:42:28AM -0800, [EMAIL PROTECTED] wrote: Implement div64_64(): 64-bit by 64-bit division. Needed by networking (at least). Your patch only implements div64_64() for 32-bit MIPS. Below patch adds the trivial 64-bit bits. Ralf Signed-off-by: Ralf Baechle [EMAIL

[NET] netxen: fix warnings

: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'dma_addr_t' u64 is unsigned long so the cast to u64 will result in a warning on the printf arguments for 64-bit builds. So cast to unsigned long long instead. Signed-off-by: Ralf Baechle [EMAIL PROTECTED

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

On Tue, Mar 06, 2007 at 10:45:23AM -0800, Don Fry wrote: The patch below moves the init_block out of the private struct and only allocates init block with pci_alloc_consistent. This has two effects: 1. Performance increase for non cache coherent machines, because the CPU only data in

Re: [PATCH 1/2] pcnet32: only allocate init_block dma consistent

On Tue, Mar 06, 2007 at 07:39:21PM -0800, Michael K. Edwards wrote: On 3/6/07, Ralf Baechle [EMAIL PROTECTED] wrote: This small change btw. delivers about ~ 3% extra performance on a very slow test system. Has this change been tested / benchmarked under VMWare? pcnet32 is the (default

[NET] Fix PCnet32 performance bug on non-coherent architecutres

this patch increases network bandwidth by about 12%. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c index 36f9d98..4d94ba7 100644 --- a/drivers/net/pcnet32.c +++ b/drivers/net/pcnet32.c @@ -1234,14 +1234,14 @@ static void pcnet32_rx_entry(struct

Re: [PATCH] Fix broken RBTX4927 support in ne.c

On Thu, Mar 01, 2007 at 01:22:23AM +0900, Atsushi Nemoto wrote: There are some ifdefs for RBTX4927, but need some more bits. Acked-by: Ralf Baechle [EMAIL PROTECTED] Longer term I think NE2000 will need to support platform_devices. It's been used too widely in too creative ways and we don't

[PATCH] jmr3927: do not call tc35815_killall().

No need to stop tc35815 before resetting the board. This fixes the build of tc35815 as a module. This also means there is no caller of tc35815_killall left, so remove that function also. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/arch/mips/jmr3927/rbhma3100/setup.c b/arch/mips

[NET] Add support for Seeq 8003 on Challenge S Mezz board.

From: Ladislav Michl [EMAIL PROTECTED] Thanks to Jö Fahlke for donating hardware. Signed-off-by: Ladislav Michl [EMAIL PROTECTED] Forward porting of Ladis' 2.4 patch. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index 52ed522

Re: possible bug in net/tc35815.c in linux-2.6.19

On Sat, Feb 24, 2007 at 05:04:01PM -0500, Jeff Garzik wrote: I am a graduate student working on finding bugs in Linux drivers using an automated research tool. I think I've found a possible bug in net/tc35815.c, and I'd appreciate it if you could confirm/disconfirm it. Thanks, Philip

[RFC][NET] Alignment in mv643xx_eth

Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c index d98e53e..3e045a6 100644 --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c @@ -147,13 +147,13 @@ static void mv643xx_eth_rx_refill_descs(struct net_device *dev

[NET] sgiseeq: Don't include unnecessary headerfiles.

Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/sgiseeq.c b/drivers/net/sgiseeq.c index a833e7f..52ed522 100644 --- a/drivers/net/sgiseeq.c +++ b/drivers/net/sgiseeq.c @@ -12,26 +12,15 @@ #include linux/init.h #include linux/types.h #include linux/interrupt.h -#include

Re: [PATCH] Eliminate user-selectable CONFIG_MV643XX_ETH_[012]

variables are only used in arch/ppc, so also move them from drivers/net/Kconfig to arch/ppc/Kconfig. Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] Acked-by: Ralf Baechle [EMAIL PROTECTED] Ralf - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH] Eliminate user-selectable CONFIG_MV643XX_ETH_[012]

On Tue, Feb 20, 2007 at 11:27:30AM -0500, Jeff Garzik wrote: It was a mis-feature that the supported ports were ever user-selectable. Which ports the hardware supports should be specified by platform-specific code, not by the user. arch/mips/momentum/jaguar_atx/platform.c | 21

[HAMRADIO] Replace local random function with random32()

Signed-off-by: Joe Perches [EMAIL PROTECTED] Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c index 153b6dc..84aa211 100644 --- a/drivers/net/hamradio/baycom_epp.c +++ b/drivers/net/hamradio/baycom_epp.c @@ -52,6

[NET] Convert meth to netdev_priv

And while at it loose plenty of useless casts. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/meth.c b/drivers/net/meth.c index d38b7c7..7e69ca6 100644 --- a/drivers/net/meth.c +++ b/drivers/net/meth.c @@ -170,7 +170,7 @@ static int mdio_probe(struct meth_private *priv

Re: [PATCH 5/59] sysctl: rose remove unnecessary insert_at_head flag

] sysctl: Remove sys_sysctl support from drivers/char/rtc.c Subject: [PATCH 55/59] sysctl: Remove insert_at_head from register_sysctl Acked-by: Ralf Baechle [EMAIL PROTECTED] Ralf - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: Using 802.11x wireless usb device on MIPS platform

On Tue, Jan 09, 2007 at 10:52:14AM +0800, colin wrote: I have used two 802.11x wireless usb devices successfully on MIPS platform. One is realtek 8187 and the other one is ralink 2571. I would like to put them into kernel tree and then I found that there are not many 802.11x devices supported

[AX.25 4/7] Fix unchecked nr_add_node uses

Signed-off-by: Ralf Baechle [EMAIL PROTECTED] net/netrom/nr_route.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-net/net/netrom/nr_route.c === --- linux-net.orig/net/netrom/nr_route.c +++ linux

[AX.25 7/7] Fix unchecked rose_add_loopback_neigh uses

rose_add_loopback_neigh uses kmalloc and the callers were ignoring the error value. Rewrite to let the caller deal with the allocation. This allows the use of static allocation of kmalloc use entirely. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] include/net/rose.h |4 ++-- net

[AX.25 1/7] Mark all kmalloc users __must_check

The recent fix 0506d4068bad834aab1141b5dc5e748eb175c6b3 made obvious that error values were not being propagated through the AX.25 stack. To help with that this patch marks all kmalloc users in the AX.25, NETROM and ROSE stacks as __must_check. Signed-off-by: Ralf Baechle [EMAIL PROTECTED

[AX.25 2/7] Fix unchecked ax25_protocol_register uses.

Replace ax25_protocol_register by ax25_register_pid which assumes the caller has done the memory allocation. This allows replacing the kmalloc allocations entirely by static allocations. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] include/net/ax25.h |9 - net/ax25

[AX.25] Constify ax25 utility functions

Signed-off-by: Ralf Baechle [EMAIL PROTECTED] include/net/ax25.h | 18 ++ net/ax25/ax25_addr.c | 19 +++ 2 files changed, 21 insertions(+), 16 deletions(-) Index: linux-net/include/net/ax25.h

[AX.25] Fix default address and broadcast address initialization

for null_ax25_address also. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] drivers/net/hamradio/6pack.c |9 ++--- drivers/net/hamradio/baycom_epp.c | 10 ++ drivers/net/hamradio/bpqether.c |9 ++--- drivers/net/hamradio/dmascc.c | 10 ++ drivers/net/hamradio/hdlcdrv.c

[RFC] memory barrier cleanups

semantics of schedule_work() should imply a memory barrier, as needed so the caller shouldn't have to worry. It's not quite obvious why the barrier in net/packet/af_packet.c is needed; maybe it should be implied through flush_dcache_page? Ralf Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff

Re: [PATCH] rose_add_loopback_node: propagate -E

On Sun, Dec 03, 2006 at 12:33:39AM +0300, Alexey Dobriyan wrote: David Binderman's icc logs: net/rose/rose_route.c(399): remark #593: variable err was set but never used Which is more of a non-fix because all the callers ignore the return value ... Ralf - To unsubscribe from this list: send

[SAA9730] Fix build error

is known to work. Also limit the driver to the Atlas board - the only known system to ever use the SAA9730 before Phillips ended the short live of the SAA9730. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 4f22c8e..c80eb79 100644

[SAA9730] Fix build error

is known to work and limit the driver to the Atlas board - the only known system to ever use the SAA9730 before Phillips ended the short live of the SAA9730. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 4f22c8e..6b5b745 100644

[DECnet] Don't clear memory twice.

When dn_neigh.c was converted from kmalloc to kzalloc in commit 0da974f4f303a6842516b764507e3c0a03f41e5a it was missed that dn_neigh_seq_open was actually clearing the allocation twice was missed. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] diff --git a/net/decnet/dn_neigh.c b/net/decnet

Re: [patch 4/6] 2.6.18: sb1250-mac: The actual driver update

On Tue, Oct 03, 2006 at 04:42:53PM -0700, Andrew Morton wrote: On Tue, 3 Oct 2006 16:18:44 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: + sbmac_state_t sbm_state; /* current state */ argh. The reader looks at this and doesn't know if it's an integer, a

Re: [PATCH 1/2] remove Momentum Jaguar ATX network driver support

On Mon, Oct 02, 2006 at 11:33:44PM +0900, Yoichi Yuasa wrote: This patch has removed Momentum / PMC-Sierra Jaguar ATX network driver support. It is listed in feature-removal-schedule.txt . NAK. I won't remove the Momentum / Ocelot support for now. Ralf - To unsubscribe from this list:

[NET] GT96100: Delete bitrotting ethernet driver

Code for the EV96100 evaluation board hasn't compiled since at least November 15, 2003, so it is being deleted as of 2.6.18 due to lack of a user base. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] drivers/net/Kconfig |6 drivers/net/Makefile |1 drivers/net/gt96100eth.c | 1566

[AX.25 2/2] Fix reference counting by socket timers

With struct sock and ax25_cb in a unified data structure it now is possible to fix the reference counting by using the sk_reset_timer and sk_stop_timer helper function - the previous implementation was based simply on principle hope. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] include/net

ipw2200: Driver lockup

I got the driver to die several times under the extreme condition at the KS / OLS with dozens to hundreds of other machines in the same room. The last kernel message I got from about the time when wireless died was eth1: NETDEV_TX_BUSY returned; driver should report queue full via

[SLHC 1/4] Cleanup SLHC configuration

On Thu, Jul 13, 2006 at 10:07:18PM -0700, David Miller wrote: Subject: Re: [SLHC 1/4] Cleanup SLHC configuration From: David Miller [EMAIL PROTECTED] Content-Type: Text/Plain; charset=us-ascii From: Ralf Baechle [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 12:06:15 +0100 Convert selection

Re: [SLHC 1/4] Cleanup SLHC configuration

Convert selection of serial line header compression to use CONFIG_SLHC rather than makefile ifeq uglyness. This makes it easier to select the SLHC module from other code. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- drivers/isdn/i4l/Kconfig |1 + drivers/net/Kconfig |8

  1   2   >