[PATCH] nfc: nci: non-static functions can not be inline

2015-10-26 Thread Robert Dolca
Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci_core.h | 8 net/nfc/nci/core.c | 16 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/net/nfc/nci_core.h b/include/net/nfc/nci_core.h index 530df66..1

[PATCH v4 10/10] nfc: Add Intel Fields Peak NFC solution driver

2015-10-22 Thread Robert Dolca
be enumerated using ACPI using the id INT339A. The 1st GPIO is the IRQ and the 2nd is the RESET pin. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- drivers/nfc/Kconfig | 1 + drivers/nfc/Makefile | 1 + drivers/nfc/fdp/Kconfig | 23 ++ drivers/nfc/fdp/Makefile

[PATCH v4 09/10] nfc: nci: add nci_get_conn_info_by_id function

2015-10-22 Thread Robert Dolca
This functin takes as a parameter a pointer to the nci_dev struct and the first byte from the values of the first domain specific parameter that was used for the connection creation. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci_core.h | 1 + net/nfc/nci/

[PATCH v4 04/10] nfc: nci: Do not call post_setup when setup fails

2015-10-22 Thread Robert Dolca
The driver should know that it can continue with post setup where setup left off. Being able to execute post_setup when setup fails may force the developer to keep this state in the driver. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- net/nfc/nci/core.c | 3 +-- 1 file chan

[PATCH v4 08/10] nfc: nci: fix possible crash in nci_core_conn_create

2015-10-22 Thread Robert Dolca
If the number of destination speific parameters supplied is 0 the call will fail. If the first destination specific parameter does not have a value, curr_id will be set to 0. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- net/nfc/nci/core.c | 9 - 1 file changed, 8 inse

[PATCH v4 06/10] nfc: nci: Allow the driver to set handler for core nci ops

2015-10-22 Thread Robert Dolca
driver needs to take certain actions when a reset notification arrives (packet also not handled by the nfc core). The driver handlers do not interfere with the core and they are called after the core processes the packet. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/n

[PATCH v4 05/10] nfc: nci: Introduce nci_core_cmd

2015-10-22 Thread Robert Dolca
This allows sending core commands from the driver. The driver should be able to send NCI core commands like CORE_GET_CONFIG_CMD. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci_core.h | 1 + net/nfc/nci/core.c | 24 +++- 2 files c

[PATCH v4 03/10] nfc: nci: Introduce new core opcodes

2015-10-22 Thread Robert Dolca
Add NCI_OP_CORE_GET_CONFIG_CMD, NCI_OP_CORE_GET_CONFIG_RSP and NCI_OP_CORE_RESET_NTF. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/net/nfc/nci.h b/include/net/nfc/nci.h index 75d2e18..b

[PATCH v4 07/10] nfc: nci: rename nci_prop_ops to nci_driver_ops

2015-10-22 Thread Robert Dolca
Initially it was used to create hooks in the driver for proprietary operations. Currently it is being used for hooks for both proprietary and generic operations. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- drivers/nfc/s3fwrn5/nci.c | 4 ++-- drivers/nfc/st-nci/core.c

[PATCH v4 00/10] Add Intel FieldsPeak NFC solution driver

2015-10-22 Thread Robert Dolca
t the new connection ID - nci: Allow the driver to set handler for core nci ops Robert Dolca (10): nfc: nci: Export nci data send API nfc: nci: Add function to get max packet size for conn nfc: nci: Introduce new core opcodes nfc: nci: Do not call post_setup when setup fails nfc: nci:

[PATCH v4 01/10] nfc: nci: Export nci data send API

2015-10-22 Thread Robert Dolca
For the firmware update the driver may use nci_send_data. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- net/nfc/nci/data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/nfc/nci/data.c b/net/nfc/nci/data.c index 566466d..83acd18 100644 --- a/net/nfc/nci/data.c +++ b/n

[PATCH v4 02/10] nfc: nci: Add function to get max packet size for conn

2015-10-22 Thread Robert Dolca
FDP driver needs to send the firmware as regular packets (not fragmented). The driver should have a way to get the max packet size for a given connection. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci_core.h | 1 + net/nfc/nci/data.c | 12 +

[PATCH v2 0/9] Adds Intel FieldsPeak NFC solution driver

2015-09-01 Thread Robert Dolca
nci: check the setup return code before callig post_setup - nci: add function to allow sending core commands from driver - nci: Use a separate mutex for nci open and close - nci: mutex for: Adds a way to get the new connection ID - nci: Allow the driver to set handler for core nci ops Rober

[PATCH v2 6/9] nfc: nci: Introduce nci_core_cmd

2015-09-01 Thread Robert Dolca
This allows sending core commands from the driver. The driver should be able to send NCI core commands like CORE_GET_CONFIG_CMD. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci_core.h | 1 + net/nfc/nci/core.c | 24 +++- 2 files c

[PATCH v2 4/9] nfc: nci: Allow the driver to set handler for core nci ops

2015-09-01 Thread Robert Dolca
driver needs to take certain actions when a reset notification arrives (packet also not handled by the nfc core). The driver handlers do not interfere with the core and they are called after the core processes the packet. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/n

[PATCH v2 8/9] nfc: nci: Add a parameter to get the new connection id

2015-09-01 Thread Robert Dolca
nci_core_conn_create has a new parameter so it can return the id of the new connection. Also now you can't call nci_core_conn_create without waiting for the answer from the previous call. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- drivers/nfc/st-nci/st-nci_se.c | 2 +- inclu

[PATCH v2 3/9] nfc: nci: Introduce new core opcodes

2015-09-01 Thread Robert Dolca
Add NCI_OP_CORE_GET_CONFIG_CMD, NCI_OP_CORE_GET_CONFIG_RSP and NCI_OP_CORE_RESET_NTF. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/net/nfc/nci.h b/include/net/nfc/nci.h index 75d2e18..b

[PATCH v2 2/9] nfc: nci: Add function to get max packet size for conn

2015-09-01 Thread Robert Dolca
FDP driver needs to send the firmware as regular packets (not fragmented). The driver should have a way to get the max packet size for a given connection. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci_core.h | 1 + net/nfc/nci/data.c | 12 +

[PATCH v2 5/9] nfc: nci: Do not call post_setup when setup fails

2015-09-01 Thread Robert Dolca
The driver should know that it can continue with post setup where setup left off. Being able to execute post_setup when setup fails may force the developer to keep this state in the driver. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- net/nfc/nci/core.c | 3 +-- 1 file chan

[PATCH v2 1/9] nfc: nci: Export nci data send API

2015-09-01 Thread Robert Dolca
For the firmware update the driver may use nci_send_data. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- net/nfc/nci/data.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/nfc/nci/data.c b/net/nfc/nci/data.c index 566466d..83acd18 100644 --- a/net/nfc/nci/data.c +++ b/n

[PATCH v2 7/9] nfc: nci: Use a separate mutex for nci open and close

2015-09-01 Thread Robert Dolca
in nci_request to allow calling the function during setup. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- include/net/nfc/nci_core.h | 3 +++ net/nfc/nci/core.c | 30 -- 2 files changed, 19 insertions(+), 14 deletions(-) diff --git a/include/n

[PATCH v2 9/9] nfc: Add Intel Fields Peak NFC solution driver

2015-09-01 Thread Robert Dolca
be enumerated using ACPI using the id INT339A. The 1st GPIO is the IRQ and the 2nd is the RESET pin. Signed-off-by: Robert Dolca <robert.do...@intel.com> --- drivers/nfc/Kconfig | 1 + drivers/nfc/Makefile | 1 + drivers/nfc/fdp/Kconfig | 23 ++ drivers/nfc/fdp/Makefile

Re: [linux-nfc] [PATCH 1/8] NFC: NCI: Allow connection close with dev down

2015-08-28 Thread Robert Dolca
On Sun, May 24, 2015 at 8:07 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca