[PATCH net-next v2] net: thunderx: Make hfunc variable const type in nicvf_set_rxfh()

>From struct ethtool_ops: int (*set_rxfh)(struct net_device *, const u32 *indir, const u8 *key, const u8 hfunc); Change function arg of hfunc to const type. V2: Fixed indentation. Signed-off-by: Robert Richter <rrich...@cavium.com> --- dr

[PATCH net-next] net: thunderx: Make hfunc variable const type in nicvf_set_rxfh()

>From struct ethtool_ops: int (*set_rxfh)(struct net_device *, const u32 *indir, const u8 *key, const u8 hfunc); Change function arg of hfunc to const type. Signed-off-by: Robert Richter <rrich...@cavium.com> --- drivers/net/ethernet/caviu

Re: [PATCH 2/2] net, thunderx: Use bool in structs where possible

On 18.02.16 11:05:14, David Miller wrote: > From: Robert Richter <rrich...@caviumnetworks.com> > Date: Thu, 18 Feb 2016 13:39:09 +0100 > > > From: Robert Richter <rrich...@cavium.com> > > > > Looks like the :1 notation was accidentally introduced (this stil

[PATCH 2/2] net, thunderx: Use bool in structs where possible

From: Robert Richter <rrich...@cavium.com> Looks like the :1 notation was accidentally introduced (this still uses 1 byte per flag). Using bool instead, which is the common use. Signed-off-by: Robert Richter <rrich...@cavium.com> --- drivers/net/ethernet/cavium/thunde

[PATCH 0/2] net: thunderx: Small cleanups

From: Robert Richter <rrich...@cavium.com> Sending two small cleanups of the driver fixing issues found during code review. Robert Richter (2): net: thunderx: Fix const type in nicvf_set_rxfh() net, thunderx: Use bool in structs where possible drivers/net/ethernet/cavium/thunder

[PATCH 1/2] net: thunderx: Fix const type in nicvf_set_rxfh()

From: Robert Richter <rrich...@cavium.com> >From struct ethtool_ops: int (*set_rxfh)(struct net_device *, const u32 *indir, const u8 *key, const u8 hfunc); Change function arg of hfunc to const type. Signed-off-by: Robert Richter <rrich..

Re: [PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations

On 11.02.16 09:33:41, David Miller wrote: > From: Sunil Kovvuri > Date: Thu, 11 Feb 2016 18:56:48 +0530 > > > If time permits, can you please look at this patchset. > > You were given feedback and I expect you to address that feedback > and resubmit this series. > >

Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address

On 08.02.16 16:30:37, Sergei Shtylyov wrote: > >@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device > >*adev, u8 *dst) > > goto out; > > > > if (!is_valid_ether_addr(mac)) { > >+dev_warn(dev, "MAC address invalid: %pM\n", mac); > >dev_er(),

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

On 11.08.15 13:04:55, David Daney wrote: In the future it might be better structured to try and get the OF node, and if that fails then try and use the ACPI method to obtain these values. Our current approach, as you can see in the patch, is the opposite. If ACPI is being used, prefer that

Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

On 07.08.15 10:09:04, Tomasz Nowicki wrote: On 07.08.2015 02:33, David Daney wrote: ... +#else + +static int bgx_init_acpi_phy(struct bgx *bgx) +{ +return -ENODEV; +} + +#endif /* CONFIG_ACPI */ + #if IS_ENABLED(CONFIG_OF_MDIO) static int bgx_init_of_phy(struct bgx *bgx)

Re: [PATCH 2/2] net, thunder, bgx: Add support for ACPI binding.

On 07.08.15 12:52:41, Tomasz Nowicki wrote: On 07.08.2015 12:43, Robert Richter wrote: On 07.08.15 10:09:04, Tomasz Nowicki wrote: On 07.08.2015 02:33, David Daney wrote: ... +#else + +static int bgx_init_acpi_phy(struct bgx *bgx) +{ + return -ENODEV; +} + +#endif /* CONFIG_ACPI