[PATCH iproute2] tc: Fix output of ip attributes

Example output is of tos and ttl. Befoe this fix the format used %x caused output of the pointer instead of the intended string created in the out variable. Fixes: e28b88a464c4 ("tc: jsonify flower filter") Signed-off-by: Roi Dayan --- tc/f_flower.c | 2 +- 1 file changed, 1 inser

Re: [PATCH net-next 0/2] cls_flower: Various fixes

On 03/06/2018 22:39, Jiri Pirko wrote: Sun, Jun 03, 2018 at 08:33:25PM CEST, xiyou.wangc...@gmail.com wrote: On Wed, May 30, 2018 at 1:17 AM, Paul Blakey wrote: Two of the fixes are for my multiple mask patch Paul Blakey (2): cls_flower: Fix missing free of rhashtable cls_flower:

[PATCH iproute2-next] tc: Fix compilation error with old iptables

The compat_rev field does not exists in old versions of iptables. e.g. iptables 1.4. Fixes: dd29621578d2 ("tc: add em_ipt ematch for calling xtables matches from tc matching context") Signed-off-by: Roi Dayan <r...@mellanox.com> --- tc/em_ipt.c | 2 ++ 1 file changed, 2 ins

[PATCH net] net/sched: Fix update of lastuse in act modules implementing stats_update

assed lastuse argument") Fixes: 9fea47d93bcc ("net/sched: act_gact: Update statistics when offloaded to hardware") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Paul Blakey <pa...@mellanox.com> Acked-by: Jiri Pirko <j...@mellanox.com> --- net/sched/act_gact.

Re: [net] vxlan: fix use-after-free on deletion

iginal kasan issue reported. Tested-by: Roi Dayan <r...@mellanox.com>

[PATCH iproute2] devlink: Add option to set and show eswitch encapsulation support

tunnel key action. Possible values are enable/disable. Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- devlink/devlink.c | 48 +++- man/man8/devlink-dev.8 | 13 + 2 files changed, 6

[PATCH iproute2 net-next] devlink: Add json and pretty options to help and man

While at it also fixed missing double dash for long opts. Signed-off-by: Roi Dayan <r...@mellanox.com> --- devlink/devlink.c | 2 +- man/man8/devlink.8 | 14 -- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/devlink/devlink.c b/devlink/devlink.c index c

[PATCH iproute2] tc: flower: Fix parsing ip address

Fix order of arguments when passed to __flower_parse_ip_addr. Fixes: ("f888f4e20534 tc: flower: Support matching ARP") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Paul Blakey <pa...@mellanox.com> --- tc/f_flower.c | 4 ++-- 1 file changed, 2 insertions(+)

Re: [PATCH v2 iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE for "protocol all"

} tail->rta_len = (((void *)n)+n->nlmsg_len) - (void *)tail; Reviewed-by: Roi Dayan <r...@mellanox.com>

[PATCH iproute2 0/2] two small fixes in flower option parser error flow

Hi, the first adds a missing return check and the second removes an incorrect error msg. Thanks, Roi Roi Dayan (2): tc: flower: Add missing err check when parsing flower options tc: flower: Fix incorrect error msg about eth type tc/f_flower.c | 11 +-- 1 files changed, 5

[PATCH iproute2 2/2] tc: flower: Fix incorrect error msg about eth type

addattr16 may return an error about the nl msg size but not about incorrect eth type. Fixes: 488b41d020fb ("tc: flower no need to specify the ethertype") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Paul Blakey <pa...@mellanox.com> --- tc/f_flower.c |7 ++

[PATCH iproute2 1/2] tc: flower: Add missing err check when parsing flower options

addattr32 may return an error. Fixes: cfcabf18d84a ("tc: flower: Add skip_{hw|sw} support") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Paul Blakey <pa...@mellanox.com> --- tc/f_flower.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --gi

[PATCH iproute2] tc: flower: Fix flower output for src and dst ports

This fix a missing use case after the introduction of enum flower_endpoint. Fixes: 6910d65661a3 ("tc: flower: introduce enum flower_endpoint") Signed-off-by: Roi Dayan <r...@mellanox.com> Signed-off-by: Paul Blakey <pa...@mellanox.com> --- tc/f_flower.c |4 ++-- 1 files

[PATCH iproute2 V2 1/2] tc: flower: Fix typo and style in flower man page

Replace vlan_eth_type with vlan_ethtype. Fixes: 745d91726006 ("tc: flower: Introduce vlan support") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> --- man/man8/tc-flower.8 | 10 +- 1 file changed, 5 insertions(+), 5 de

[PATCH iproute2 V2 2/2] tc: tunnel_key: Add tc-tunnel_key man page to Makefile

To be installed with the other man pages. Fixes: d57639a475a9 ("tc/act_tunnel: Introduce ip tunnel action") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Amir Vadai <a...@vadai.me> --- man/man8/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/man/ma

[PATCH iproute2 V2 0/2] Man pages fixes

Hi, The 2 patches are man page related only. First fixes a typo and second adding missing man page to the Makefile. Thanks, Roi v2: - style fix in flower man page Roi Dayan (2): tc: flower: Fix typo and style in flower man page tc: tunnel_key: Add tc-tunnel_key man page to Makefile man

[PATCH iproute2 1/2] tc: flower: Fix typo in the flower man page

Replace vlan_eth_type with vlan_ethtype. Fixes: 745d91726006 ("tc: flower: Introduce vlan support") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Hadar Hen Zion <had...@mellanox.com> --- man/man8/tc-flower.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[PATCH iproute2 2/2] tc: tunnel_key: Add tc-tunnel_key man page to Makefile

To be installed with the other man pages. Fixes: d57639a475a9 ("tc/act_tunnel: Introduce ip tunnel action") Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Amir Vadai <a...@vadai.me> --- man/man8/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/man/ma

[PATCH iproute2 0/2] Man page fixes

Hi, The 2 patches are man page related only. First fixes a typo and second adding missing man page to the Makefile. Thanks Roi Dayan (2): tc: flower: Fix typo in the flower man page tc: tunnel_key: Add tc-tunnel_key man page to Makefile man/man8/Makefile| 1 + man/man8/tc-flower.8 | 4

Re: [PATCH net] net, sched: respect rcu grace period on cls destruction

e we just kfree() tp->root from there. Fixes: 1f947bf151e9 ("net: sched: rcu'ify cls_bpf") Fixes: 9888faefe132 ("net: sched: cls_basic use RCU") Fixes: 70da9f0bf999 ("net: sched: cls_flow use RCU") Fixes: 77b9900ef53a ("tc: introduce Flower classifier") Fi

Re: [PATCH iproute2 0/2] Adding help and inline mode control to eswitch

Hi Stephen, I forgot to mention that the patches are for net-next branch of iproute2. Thanks, Roi On 27/11/2016 13:21, Roi Dayan wrote: Hi, The first patch is adding missing help message for eswitch. The second patch is adding functionality to show/modify eswitch inline mode. Thanks, Roi

Re: [PATCH net-next] net/sched: Export tc_tunnel_key so its UAPI accessible

Hi, My mistake. this should be targeted for net. I'm sending a patch over net branch. Thanks, Roi On 27/11/2016 12:07, Roi Dayan wrote: Export tc_tunnel_key so it can be used from user space. Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Amir Vadai <a...

[PATCH iproute2 2/2] devlink: Add option to set and show eswitch inline mode

This is needed for some HWs to do proper macthing and steering. Possible values are none, link, network, transport. Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> --- devlink/devlink.c

[PATCH iproute2 1/2] devlink: Add usage help for eswitch subcommand

Add missing usage help for devlink dev eswitch subcommand. Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Or Gerlitz <ogerl...@mellanox.com> --- devlink/devlink.c |7 ++- man/man8/devlink-dev.8 |2 +- 2 files changed, 7 insertions(+), 2 deletions(-)

[PATCH iproute2 0/2] Adding help and inline mode control to eswitch

Hi, The first patch is adding missing help message for eswitch. The second patch is adding functionality to show/modify eswitch inline mode. Thanks, Roi Roi Dayan (2): devlink: Add usage help for eswitch subcommand devlink: Add option to set and show eswitch inline mode devlink/devlink.c

[PATCH net] net/sched: Export tc_tunnel_key so its UAPI accessible

Export tc_tunnel_key so it can be used from user space. Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Amir Vadai <a...@vadai.me> --- Hi, I previously sent the patch targeted for net-next but should be for net. Thanks, Roi include/uapi/linux/tc_act/Kbuild | 1 + 1 fil

[PATCH net-next] net/sched: Export tc_tunnel_key so its UAPI accessible

Export tc_tunnel_key so it can be used from user space. Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Amir Vadai <a...@vadai.me> --- include/uapi/linux/tc_act/Kbuild | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/tc_act/Kbuild b/include/uapi/

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

On 27/11/2016 06:47, Roi Dayan wrote: On 27/11/2016 02:33, Daniel Borkmann wrote: On 11/26/2016 12:09 PM, Daniel Borkmann wrote: On 11/26/2016 07:46 AM, Cong Wang wrote: On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann <dan...@iogearbox.net> wrote: [...] Ok, strange, qdisc_d

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

On 27/11/2016 02:33, Daniel Borkmann wrote: On 11/26/2016 12:09 PM, Daniel Borkmann wrote: On 11/26/2016 07:46 AM, Cong Wang wrote: On Thu, Nov 24, 2016 at 7:20 AM, Daniel Borkmann wrote: [...] Ok, strange, qdisc_destroy() calls into ops->destroy(), where ingress

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

On 24/11/2016 12:14, Daniel Borkmann wrote: On 11/24/2016 09:29 AM, Roi Dayan wrote: Hi, I'm testing this patch with KASAN enabled and got into a new kernel crash I didn't hit before. [ 1860.725065] == [ 1860.733893] BUG

Re: [Patch net-next] net_sched: move the empty tp check from ->destroy() to ->delete()

a grace period here, we should not modify tp->root in ->destroy() either. Fixes: 1e052be69d04 ("net_sched: destroy proto tp when all filters are gone") Reported-by: Roi Dayan <r...@mellanox.com> Cc: Daniel Borkmann <dan...@iogearbox.net> Cc: John Fastabend <joh

[PATCH net-next] net/sched: cls_flower: verify root pointer before dereferncing it

ing freed with kfree_rcu() and classify() path is under rcu_read_lock(). Fixes: 1e052be69d04 ("net_sched: destroy proto tp when all filters are gone") Signed-off-by: Roi Dayan <r...@mellanox.com> Cc: Cong Wang <cw...@twopensource.com> --- Hi Cong, all As stated above, the i

[PATCH net-next 0/2] misc TC/flower changes

This series includes two small changes to the TC flower classifier. Thanks, Roi Roi Dayan (2): net/sched: cls_flower: add missing unbind call when destroying flows net/sched: cls_flower: merge filter delete/destroy common code net/sched/cls_flower.c | 20 +++- 1 file

[PATCH net-next 2/2] net/sched: cls_flower: merge filter delete/destroy common code

Move common code from fl_delete and fl_detroy to __fl_delete. Signed-off-by: Roi Dayan <r...@mellanox.com> --- net/sched/cls_flower.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index a5f6370..a

[PATCH net-next 1/2] net/sched: cls_flower: add missing unbind call when destroying flows

tcf_unbind was called in fl_delete but was missing in fl_destroy when force deleting flows. Fixes: 77b9900ef53a ('tc: introduce Flower classifier') Signed-off-by: Roi Dayan <r...@mellanox.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> --- net/sched/cls_flower.c | 1 + 1 fil