[GIT] [4.15] NFC update

Hi David, This is the NFC pull request for 4.15. We have: - A new netlink command for explicitly deactivating NFC targets - i2c constification for all NFC drivers - One NFC device allocation error path fix The following changes since commit 2798b80b385384d51a81832556ee9ad25d175f9b: Merge

Re: [PATCH] NFC: fix device-allocation error return

Hi Johan, On Sun, Jul 09, 2017 at 01:08:58PM +0200, Johan Hovold wrote: > A recent change fixing NFC device allocation itself introduced an > error-handling bug by returning an error pointer in case device-id > allocation failed. This is clearly broken as the callers still expected > NULL to be

[GIT] [4.13] NFC update

Hi David, This is the NFC pull request for 4.13. We have: - A conversion to unified device and GPIO APIs for the fdp, pn544, and st{21,-nci} drivers. - A fix for NFC device IDs allocation. - A fix for the nfcmrvl driver firmware download mechanism. - A trf7970a DT and GPIO cleanup and clock

Re: [PATCH] nfc: Add sockaddr length checks before accessing sa_family in bind handlers

On Tue, Jun 13, 2017 at 06:44:28PM +0200, Mateusz Jurczyk wrote: > Verify that the caller-provided sockaddr structure is large enough to > contain the sa_family field, before accessing it in bind() handlers of the > AF_NFC socket. Since the syscall doesn't enforce a minimum size of the >

Re: [PATCH] nfc: nci: remove unnecessary null check

Hi Gustavo, On Tue, Jun 13, 2017 at 11:37:18AM -0500, Gustavo A. R. Silva wrote: > Remove unnecessary NULL check for pointer conn_info. > conn_info is set in list_for_each_entry() using container_of(), > which is never NULL. > > Addresses-Coverity-ID: 1362349 > Cc: Guenter Roeck

Re: [PATCH] nfc: Ensure presence of required attributes in the activate_target netlink handler

Hi Mateusz, On Wed, May 24, 2017 at 12:42:26PM +0200, Mateusz Jurczyk wrote: > Check that the NFC_ATTR_TARGET_INDEX and NFC_ATTR_PROTOCOLS attributes (in > addition to NFC_ATTR_DEVICE_INDEX) are provided by the netlink client > prior to accessing them. This prevents potential unhandled NULL

Re: [PATCH] nfc: Fix the sockaddr length sanitization in llcp_sock_connect

Hi Mateusz, On Wed, May 24, 2017 at 12:26:20PM +0200, Mateusz Jurczyk wrote: > Fix the sockaddr length verification in the connect() handler of NFC/LLCP > sockets, to compare against the size of the actual structure expected on > input (sockaddr_nfc_llcp) instead of its shorter version

Re: [PATCH 0/2] NFC-digital: Adjustments for four function implementations

Hi Markus, On Mon, May 22, 2017 at 02:57:42PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 14:50:05 +0200 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Improve

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

Hi Johan, On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > This started out with the observation that the nfcmrvl_uart driver > unconditionally dereferenced the tty class device despite the fact that > not every tty has an associated struct device (Unix98 ptys). Some > further

[GIT] [4.12] NFC update

wilink driver Samuel Ortiz (1): MAINTAINERS: Remove Lauro and Aloisio from the NFC maintainers list Sudip Mukherjee (1): nfc: fdp: fix NULL pointer dereference Tobias Klauser (1): NFC: nfcmrvl: Include unaligned.h instead of access_ok.h .../devicetree/bindings/net/nfc/trf7970a.tx

Re: [PATCH v2 0/8] NFC: fix device allocation and nfcmrvl crashes

Hi Johan, On Tue, Apr 18, 2017 at 12:09:16PM +0200, Johan Hovold wrote: > On Thu, Mar 30, 2017 at 12:15:34PM +0200, Johan Hovold wrote: > > This started out with the observation that the nfcmrvl_uart driver > > unconditionally dereferenced the tty class device despite the fact that > > not every

Re: [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

Hi Geoff, On Wed, Dec 21, 2016 at 11:18:32PM -0500, Geoff Lansberry wrote: > The TRF7970A has configuration options to support hardware designs > which use a 27.12MHz clock. This commit adds a device tree option > 'clock-frequency' to support configuring the this chip for default > 13.56MHz clock

Re: [PATCH v1] NFC: netlink: Use error code from nfc_activate_target()

Hi Andy, On Wed, Mar 22, 2017 at 09:20:58PM +0200, Andy Shevchenko wrote: > It looks like a typo to assign a return code to a variable which is not > used. Found due to a compiler warning: > > net/nfc/netlink.c: In function ‘nfc_genl_activate_target’: > net/nfc/netlink.c:903:6: warning: variable

Re: [PATCH v1] NFC: Add nfc_dbg() macro

On Wed, Mar 22, 2017 at 09:22:51PM +0200, Andy Shevchenko wrote: > In some cases nfc_dbg() is useful. Add such macro to a header. > > Signed-off-by: Andy Shevchenko > --- > include/net/nfc/nfc.h | 1 + > 1 file changed, 1 insertion(+) Applied as well. Cheers,

Re: [PATCH] Make EN2 pin optional in the TRF7970A driver

Hi Heiko, On Tue, Feb 07, 2017 at 06:22:04AM +0100, Heiko Schocher wrote: > From: Guan Ben > > Make the EN2 pin optional. This is useful for boards, > which have this pin fix wired, for example to ground. > > Signed-off-by: Guan Ben >

[GIT] [4.8] NFC update

Hi David, This is the first NFC pull request for 4.8. We have: - A fairly large NFC digital stack patchset: * RTOX fixes. * Proper DEP RWT support. * ACK and NACK PDUs handling fixes, in both initiator and target modes. * A few memory leak fixes. - A conversion of the nfcsim driver

Re: [PATCH] nfp: check idx is -ENOSPC before using it is an index

Hi Colin, On Mon, Jul 11, 2016 at 04:46:57PM +0100, Colin King wrote: > diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c > index e44a7a2..d93d314 100644 > --- a/drivers/nfc/fdp/fdp.c > +++ b/drivers/nfc/fdp/fdp.c > @@ -345,7 +345,7 @@ static void fdp_nci_release_firmware(struct nci_dev

[GIT] [4.6] NFC update

Hi David, This is the first NFC pull request for 4.7. With this one we mainly have: - Support for NXP's pn532 NFC chipset. The pn532 is based on the same microcontroller as the pn533, but it talks to the host through i2c instead of USB. By separating the pn533 driver into core and PHY

[GIT] [4.6] NFC update

Hi David, This is a very small one this time, with only 5 patches. There are a couple of big items that could not be merged/finished on time. We have: - 2 LLCP fixes for a race and a potential OOM. - 2 cleanups for the pn544 and microread drivers. - 1 Maintainer addition for the s3fwrn5 driver.

Re: [PATCH v2 net] nfc: close a race condition in llcp_sock_getname()

lt;lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> > --- > net/nfc/llcp_sock.c | 6 ++ > 1 file changed, 6 insertions(+) Applied as well, thanks. Cheers, Samuel.

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

e.com> > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com> > --- > net/nfc/llcp_commands.c | 4

Re: [PATCH v2 net] nfc: use GFP_USER for user-controlled kmalloc

licious users to OOM kernel on purpose. > > > > Reported-by: Dmitry Vyukov <dvyu...@google.com> > > Cc: Lauro Ramos Venancio <lauro.venan...@openbossa.org> > > Cc: Aloisio Almeida Jr <aloisio.alme...@openbossa.org> > > Cc: Samuel Ortiz <sa...@linu

[GIT] [4.5] NFC update

Hi David, This is the first NFC pull request for 4.5 and it brings: - A new driver for the STMicroelectronics ST95HF NFC chipset. The ST95HF is an NFC digital transceiver with an embedded analog front-end and as such relies on the Linux NFC digital implementation. This is the 3rd user of

[GIT] [4.4] NFC fixes

Hi David, This is the 1st NFC fixes pull request for 4.4. It includes bug fixes and one fix for a build failure, all of them introduced with the first NFC pull request for 4.4. We have: - Fix nfcmrvl SPI driver potential build error due to a broken Kconfig dependency. - A few fixes for the

[GIT] [4.4] NFC update

crash in nci_core_conn_create NFC: nci: add nci_get_conn_info_by_id function NFC: Add Intel Fields Peak NFC solution driver NFC: nci: non-static functions can not be inline Samuel Ortiz (2): NFC: nci: Use __nci_request for exported routines NFC: st-nci: Rename st-nci_se.c

Re: [PATCH 1/2] NFC: delete null dereference

Hi Julia, On Sat, Oct 17, 2015 at 11:32:19AM +0200, Julia Lawall wrote: > The exit label performs device_unlock(>dev);, which will fail when dev > is NULL, and nfc_put_device(dev);, which is not useful when dev is NULL, so > just exit the function immediately. > > Problem found using

Re: [PATCH] nfc: netlink: avoid NULL pointer dereference on error

gt; > ./net/nfc/netlink.c:1175:21-24: ERROR: dev is NULL but dereferenced. > > Signed-off-by: Vincent Stehlé <vincent.ste...@laposte.net> > Cc: Thierry Escande <thierry.esca...@linux.intel.com> > Cc: Samuel Ortiz <sa...@linux.intel.com> > --- > net/nf

[GIT] [4.3] NFC update

Hi David, This is the NFC pull request for 4.3. With this one we have: - A new driver for Samsung's S3FWRN5 NFC chipset. In order to properly support this driver, a few NCI core routines needed to be exported. Future drivers like Intel's Fields Peak will benefit from this. - SPI support

[GIT] [4.2] 2nd NFC update

Hi David, This is a follow up fix for a typo that I introduced while cleaning the 1st 4.2 NFC pull request patches. The following changes since commit d0dcad8bd32a34aa85bcbd5d2033658cb3964377: NFC: nfcmrvl: set PB_BAIL_OUT at setup (2015-06-13 00:08:55 +0200) are available in the git

[GIT] [4.2] NFC update

support for enumerating through ACPI Samuel Ortiz (5): NFC: nxp-nci: Fix build warning NFC: nci: Handle proprietary response and notifications NFC: Introduce vendor commands structures NFC: netlink: Implement vendor command support NFC: nci: Export nci_req_complete Tomas

Re: [PATCH] NFC: nci: hci: Fix releasing uninitialized skbs

Hi Joe, On Sun, May 31, 2015 at 05:44:45PM -0700, Joe Perches wrote: Several of these goto exit; uses should be direct returns as skb is not yet initialized by nci_hci_get_param(). Miscellanea: o Use !memcmp instead of memcmp() == 0 o Remove unnecessary goto from if () {... goto exit;}

Re: [linux-nfc] [PATCH 8/8] NFC: Add Intel FieldsPeak NFC solution driver

Hi Robert, On Wed, Apr 01, 2015 at 06:35:31PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz sa...@linux.intel.com wrote: + /* If a patch was applied the new version is checked */ + if (patched) { + r = nci_init(ndev); + if (r

Re: [linux-nfc] [PATCH 3/8] NFC: NCI: Adds NCI init and reset API for drivers

Hi Robert, On Tue, Mar 31, 2015 at 05:05:53PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote: In order to communicate with the device during the setup phase

Re: [linux-nfc] [PATCH 1/8] NFC: NCI: Allow connection close with dev down

Hi Robert, On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote: On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Robert, On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote: By calling __nci_request instead of nci_request allows the driver

[PATCH] [IrDA] LMP discovery timer not started by default

Hi Dave, By default, LMP sets up a 3 seconds timer for discovery. We don't need it until discovery is set to 1. This patch is against your latest net-2.6.25 tree. From: Ross Burton [EMAIL PROTECTED] Signed-off-by: Ross Burton [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED

[PATCH] [IrDA] af_irda memory leak fixes

Hi Dave, Here goes an IrDA patch against your latest net-2.6 tree. This patch fixes some af_irda memory leaks. It also checks for irias_new_obect() return value. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/af_irda.c | 30

[PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb

It seems to me that irda_usb_net_open() must set self-netopen under spinlock or disconnect() may fail to kill all URBs, if it is called while an interface is opened. From: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED

[PATCH 0/5] [IrDA] IrDA net-2.6 fixes

Hi Dave, Here goes a batch of 5 IrDA patches against your latest net-2.6 tree. Cheers, Samuel. -- -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 5/5] [IrDA] irda parameters warning fixes.

: warning: Using plain integer as NULL pointer From: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Cc: Andrew Morton [EMAIL PROTECTED] --- net/irda/parameters.c |6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps

While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in irlmp_register_link and should probably be freed in irlmp_unregister_link(). Signed-off-by: Hinko Kocevar [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL

[PATCH 4/5] [IrDA] stir4200 fixes

The attached patch observes the stir4200 fifo size and will clear the fifo, if the size is increasing, while it should be transmitting bytes From: Olaf Hartmann [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/stir4200.c | 10 ++ 1 file changed, 6

[PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer

While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in mcs_net_close(). Patch below fixes it. From: Hinko Kocevar [EMAIL PROTECTED] Signed-off-by: Hinko Kocevar [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/mcs7780.c |2 ++ 1

[PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps

While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in irlmp_register_link and should probably be freed in irlmp_unregister_link(). Signed-off-by: Hinko Kocevar [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL

[PATCH 4/5] [IrDA] stir4200 fixes

The attached patch observes the stir4200 fifo size and will clear the fifo, if the size is increasing, while it should be transmitting bytes From: Olaf Hartmann [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/stir4200.c | 10 ++ 1 file changed, 6

[PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer

While testing the mcs7780 based IrDA USB dongle I've stumbled upon memory leak in mcs_net_close(). Patch below fixes it. Signed-off-by: Hinko Kocevar [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/mcs7780.c |2 ++ 1 file changed, 2 insertions(+) Index

[PATCH 0/5] [IrDA] IrDA updates for net-2.6

Hi Herbert, Here goes a series of 5 IrDA patches against your latest net-2.6 tree. Cheers, Samuel. -- -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 5/5] [IrDA] irda parameters warning fixes.

: warning: Using plain integer as NULL pointer Signed-off-by: Richard Knutsson [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Cc: Andrew Morton [EMAIL PROTECTED] --- net/irda/parameters.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: net-2.6/net/irda

[PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb

It seems to me that irda_usb_net_open() must set self-netopen under spinlock or disconnect() may fail to kill all URBs, if it is called while an interface is opened. Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/irda-usb.c

Re: [irda-users] [PATCH]race between open and disconnect in irda-usb

Hi Oliver, On Fri, Oct 12, 2007 at 10:53:55AM +0200, Oliver Neukum wrote: Hi, it seems to me that irda_usb_net_open() must set self-netopen under spinlock or disconnect() may fail to kill all URBs, if it is called while an interface is opened. Makes sense, yes. I will push it upstream with

[PATCH] IrDA: Oops fix for ksdazzle

Hi Dave, This is the last remaining patch for IrDA, against net-2.6.24. It fixes a kernel oops triggered by the ksdazzle SIR driver. We need more space for input frames, and 2048 should be plenty of it. Signed-off-by: Alex Villacís Lasso [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL

[PATCH 1/3] [IrDA] MSG_NOSIGNAL support for IrDA sockets

Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/af_irda.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) Index: net-2.6.24-quilt/net/irda/af_irda.c === --- net-2.6.24-quilt.orig/net/irda

[PATCH 3/3] [IrDA] Kingsun KS-959 IrDA USB driver

. On plugin, this dongle reports vendor and device IDs: 0x07d0:0x4959 . The Windows driver that is used normally to control this dongle has a filename of KS-959.SYS . Signed-off-by: Alex Villacís Lasso [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/Kconfig

[PATCH 2/3] [IrDA] Kingsun Dazzle IrDA USB driver

Villacís Lasso [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/Kconfig| 12 drivers/net/irda/Makefile |1 drivers/net/irda/ksdazzle-sir.c | 823 3 files changed, 836 insertions(+) Index: net-2.6.24

[PATCH 0/3] [IrDA] IrDA updates for net-2.6.24

Hi Dave, Here go 3 IrDA patches for net-2.6.24 inclusion. Cheers, Samuel. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [net-2.6.24] forcedeth does not compile without CONFIG_FORCEDETH_NAPI set

: for each function it appears in.) make[2]: *** [drivers/net/forcedeth.o] Error 1 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 This only occurs the CONFIG_FORCEDETH_NAPI is _disabled_. This fixes the build: -- Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] drivers/net

Re: [PATCH] [IrDA] KS959 USB IrDA dongle support

On 7/23/2007, David Miller [EMAIL PROTECTED] wrote: From: Samuel Ortiz [EMAIL PROTECTED] Date: Mon, 23 Jul 2007 00:32:17 +0300 Last IrDA patch for 2.6.23-rc1, if it's not too late... Too late, Linus just closed the merge window, you had two weeks to submit this :-) Too bad... I submitted

[PATCH] [IrDA] KS959 USB IrDA dongle support

] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/Kconfig | 14 + drivers/net/irda/Makefile|1 + drivers/net/irda/ks959-sir.c | 919 ++ 3 files changed, 934 insertions(+), 0 deletions(-) create mode 100644 drivers/net/irda/ks959

[PATCH] [IrDA] Fix IrDA build failure

it can make it to the merge window, and [EMAIL PROTECTED] is CCed on this mail. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] diff --git a/net/irda/af_irda.c b/net/irda/af_irda.c index dcd7e32..4c670cf 100644 --- a/net/irda/af_irda.c +++ b/net/irda/af_irda.c @@ -2567,7 +2567,7 @@ int __init

Re: [irda-users] [PATCH] [IrDA] Fix IrDA build failure

On Mon, Jul 16, 2007 at 02:17:15PM +0300, Samuel Ortiz wrote: Hi Dave, When having built-in IrDA, we hit the following error: `irda_sysctl_unregister' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o `irda_proc_unregister

Re: RFC: removing DONGLE_OLD drivers?

Hi Adrian, On Mon, Jul 09, 2007 at 07:25:39PM +0200, Adrian Bunk wrote: With one exception, all DONGLE_OLD drivers have newer counterparts. The DONGLE_OLD drivers depend on BROKEN_ON_SMP which e.g. implies that the many distributions shipping only SMP-kernels will never offer them. The

Re: Generic netlink interface help

On Sun, May 27, 2007 at 07:47:59PM +0200, Rodolfo Giometti wrote: On Sun, May 27, 2007 at 03:54:30PM +0200, Johannes Berg wrote: It's written in python without using libnl: http://git.sipsolutions.net/pynl80211.git If I well understand I should do something like this: s =

Re: Generic netlink interface help

Hi Rodolfo, On Sun, May 27, 2007 at 07:39:59PM +0200, Rodolfo Giometti wrote: On Thu, May 24, 2007 at 09:43:30AM -, Samuel Ortiz wrote: You could look at Johannes Berg 802.11 generic netlink implementation for a good example (net/wireless/nl80211.c in John Linville's tree): http

Re: Generic netlink interface help

Hi Rodolfo, On 5/24/2007, Rodolfo Giometti [EMAIL PROTECTED] wrote: Hello, I'm trying to use this new API for my LinuxPPS support but I have some difficulties in understanding the code! Looking at http://linux-net.osdl.org/index.php/Generic_Netlink_HOWTO is not clear... for example in line:

Re: Generic netlink interface help

On 5/24/2007, Rodolfo Giometti [EMAIL PROTECTED] wrote: You probably want to use the libnl library. The latest SVN code has support for generic netlink: http://people.suug.ch/~tgr/libnl/ Regarding this issue I'd like to know if could be possible to avoid using this library... my LinuxPPS

Re: [PATCH] [-mm] ACPI: export ACPI events via netlink

On 5/22/2007, Zhang Rui [EMAIL PROTECTED] wrote: Index: linux-2.6.22-rc1/include/linux/netlink.h === --- linux-2.6.22-rc1.orig/include/linux/netlink.h 2007-05-21 10:19:00.0 +0800 +++

[PATCH] [IrDA] KingSun/DonShine USB IrDA dongle support

driver that is used normally to control this dongle has a filename of DSIR620.SYS . Signed-off-by: Alex Villac�s Lasso [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/Kconfig | 14 + drivers/net/irda/Makefile |1 + drivers/net/irda/kingsun-sir.c

Re: [irda-users] [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

On Mon, Apr 30, 2007 at 03:24:05PM +0200, Guennadi Liakhovetski wrote: On Tue, 10 Apr 2007, Samuel Ortiz wrote: Hi Guennadi, The patch below schedules irnet_flow_indication() asynchronously. Could you please give it a try (it builds, but I couldn't test it...) ? : Ok, your patch

Re: [patch 13/15] irda_device_dongle_init: fix kzalloc(GFP_KERNEL) in spinlock

On 4/26/2007, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Fix http://bugzilla.kernel.org/show_bug.cgi?id=8343 Cc: Samuel Ortiz [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] This one was on my pipeline, looks good

Re: [irda-users] [PATCH 5/7] [IrDA] IrDA monitor mode

On Sat, Apr 21, 2007 at 10:46:00AM -0700, David Miller wrote: From: Samuel Ortiz [EMAIL PROTECTED] Date: Sat, 21 Apr 2007 14:42:40 +0300 I actually asked for your advice about it some time ago: http://marc.info/?l=linux-netdevm=117590341703544w=2 But by looking at the flow of emails

Re: [irda-users] [PATCH 5/7] [IrDA] IrDA monitor mode

Hi Dave, On Fri, Apr 20, 2007 at 10:11:43PM -0700, David Miller wrote: From: [EMAIL PROTECTED] Date: Thu, 19 Apr 2007 00:32:07 +0300 Through a protocol specific ioctl, one can disable IrDA TX in order to monitor an IrDA link. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] I'd

Re: [irda-users] [PATCH 2/7] [IrDA] af_irda: Silence kernel message in irda_recvmsg_stream

On Fri, Apr 20, 2007 at 10:09:00PM -0700, David Miller wrote: There were some conflicts in this one wrt. the sock_orphan() bug fix we put into mainline recently, but I did my best to resolve it when I applied this to net-2.6.22 You can have a look and verify things when I put up my net-2.6.2

[PATCH] [net-2.6] IrDA: Correctly handling socket error

) to oops. This is against the latest net-2.6 and should be considered for -stable inclusion. Signed-off-by: Olaf Kirch [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/af_irda.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/irda

Re: [irda-users] [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

Hi Guennadi, On Sat, Apr 07, 2007 at 03:59:26AM +0300, Samuel Ortiz wrote: IMHO, irnet_flow_indication() should be called asynchronously by irttp_run_tx_queue(), through some bottom-half mechanism. That would fix your locking issues, and that would reduce the time we spend in the IrDA code

Re: [PATCH 1/4] [net-2.6.22] IrDA: IrLAP raw mode

On Fri, Mar 16, 2007 at 08:34:51PM -0700, David Miller wrote: From: Samuel Ortiz [EMAIL PROTECTED] Date: Sat, 17 Mar 2007 03:57:29 +0200 This patch allows us to bypass the IrDA stack down to the IrLAP level. Sending and receiving frames is done through a character device. This is useful

Re: [irda-users] [BUG] 2.6.20.1-rt8 irnet + pppd recursive spinlock...

Hi Guennadi, On Thu, Apr 05, 2007 at 12:59:40PM +0200, Guennadi Liakhovetski wrote: Ok, a simple analysis reveals the recursive spinlock: On Thu, 5 Apr 2007, Guennadi Liakhovetski wrote: [bf12b220] (ppp_channel_push+0x0/0xc8 [ppp_generic]) from [bf12bf98] (ppp_output_wakeup+0x18/0x1c

Re: [git patches] net driver fixes

On 3/30/2007, Guennadi Liakhovetski [EMAIL PROTECTED] wrote: On Thu, 29 Mar 2007, Jeff Garzik wrote: Guennadi Liakhovetski wrote: Jeff, might be worth getting the sk_buff leak fix in ppp from http://www.spinics.net/lists/netdev/msg27706.html in 2.6.21 too? Don't know how important it is

Re: [irda-users] [2.6.20-rt8] Neighbour table overflow.

On Sat, Mar 24, 2007 at 10:10:34PM -0700, David Miller wrote: From: Guennadi Liakhovetski [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 13:14:43 +0100 (CET) On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2007, Samuel Ortiz wrote: I'm quite sure the leak

Re: [irda-users] [2.6.20-rt8] Neighbour table overflow.

On Fri, Mar 23, 2007 at 01:14:43PM +0100, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2007, Samuel Ortiz wrote: I'm quite sure the leak is in the IrDA code rather than in the ppp or ipv4 one, hence the need for full irda debug... Well

Re: [irda-users] [2.6.20-rt8] Neighbour table overflow.

On 3/21/2007, Guennadi Liakhovetski [EMAIL PROTECTED] wrote: (Short recap for newly added to cc: netdev: I'm seeing an skb leak in 2.6.20 during an IrDA IrNET+ppp UDP test with periodic connection disruptions) On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote: On Tue, 20 Mar 2007, Guennadi

Re: [PATCH 3/6] IrDA: IrLAP raw mode

Hi Ingo, On Fri, Mar 16, 2007 at 11:02:04AM +0100, Ingo Oeser wrote: --- /dev/null +++ b/include/net/irda/irlap_raw.h @@ -0,0 +1,27 @@ +/* + * Copyright (C) 2007 Samuel Ortiz ([EMAIL PROTECTED]) + * + * This program is free software; you can redistribute it and/or + * modify

[PATCH 1/3] [net-2.6] IrDA: Delay needed when uploading firmware chunks

With 42101001.sb firmwares, we need a 10 ms delay between firmware chunks upload on irda-usb. Patch from Nigel Williams [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/irda-usb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH 1/4] [net-2.6.22] IrDA: IrLAP raw mode

/net/irda/irlap_raw.h new file mode 100644 index 000..ce90563 --- /dev/null +++ b/include/net/irda/irlap_raw.h @@ -0,0 +1,57 @@ +/* + * Copyright (C) 2007 Samuel Ortiz ([EMAIL PROTECTED]) + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU

[PATCH 2/4] [net-2.6.22] IrDA: removing stir4200 useless include

stir4200 doesn't need to include irlap.h Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/stir4200.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c index a22175f..aec86a2 100644 --- a/drivers

[PATCH 3/4] [net-2.6.22] IrDA: irda lockdep annotation

Rmmoding irda triggers a lockdep false positive. Reported-by: Dave Jones [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/irqueue.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/net/irda/irqueue.c b/net/irda/irqueue.c index 9266233

[PATCH 3/3] [net-2.6] IrDA: Calling ppp_unregister_channel() from process context

We need to call ppp_unregister_channel() when IrNET disconnects, and this must be done from a process context. Bug reported and patch tested by Guennadi Liakhovetski. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/irnet/irnet.h |2 +- net/irda/irnet/irnet_irda.c | 34

[PATCH 4/4] [net-2.6.22] IrDA: SMC SuperIO Chip LPC47N227 not identified properly

SMC SuperIO Chip LPC47N227 used for IrDA is not detected because its device identification byte can be 0x7A instead of 0x5A. Patch from Peter Kovar [EMAIL PROTECTED] Cc: Jean Delvare [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED

Re: [PATCH 0/6] IrDA: Updates

On Thu, Mar 15, 2007 at 03:00:54AM -0700, David Miller wrote: From: Samuel Ortiz [EMAIL PROTECTED] Date: Wed, 14 Mar 2007 21:22:36 +0200 Some IrDA updates: - IrNET identation and bug fix. (patches 1 and 2) - IrLAP raw mode initial implementation. (patch 3) - stir4200 and irda-usb

[PATCH 0/6] IrDA: Updates

Hi Dave, Some IrDA updates: - IrNET identation and bug fix. (patches 1 and 2) - IrLAP raw mode initial implementation. (patch 3) - stir4200 and irda-usb fixes. (patches 4 and 5) - hashbin lockdep fixes. (patch 6) Cheers, Samuel. - To unsubscribe from this list: send the line unsubscribe netdev

[PATCH 2/6] IrDA: Process context ppp_unregister_channel() call

tested by Guennadi Liakhovetski. Reported-by: Guennadi Liakhovetski [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/irnet/irnet.h |1 + net/irda/irnet/irnet_irda.c | 37 + 2 files changed, 26 insertions(+), 12 deletions

[PATCH 5/6] IrDA: stir4200 useless include

stir4200 doesn't need to include irlap.h Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/stir4200.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c index 20d306f..45351f2 100644 --- a/drivers

[PATCH 4/6] IrDA: Delay needed when uploading firmware chunks

With 42101001.sb firmwares, we need a 10 ms delay between firmware chunks upload. Patch from Nigel Williams [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/irda-usb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/irda

Re: [irda-users] [PATCH 1/6] IrDA: IrNET code indentation

The IrNET identation patch was too big for netdev limit, so I split it in 2 patches: [PATCH 1a/6] IrDA: IrNET code identation [PATCH 1b/6] IrDA: irnet_irda.c identation My apologies for the mess... Cheers, Samuel. - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [2.6 patch] drivers/net/irda/vlsi_ir.{h,c}: remove kernel 2.4 code

On Thu, Jan 18, 2007 at 10:56:13PM +0100, Adrian Bunk wrote: This patch removes kernel 2.4 compatibility code. Looks correct to me, thanks. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Acked-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/vlsi_ir.c | 16

[PATCH 1/2] [IrDA] irda-usb TX path optimization (was Re: IrDA spams logfiles - since 2.6.19)

-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/irda-usb.c | 43 --- drivers/net/irda/irda-usb.h |1 + 2 files changed, 21 insertions(+), 23 deletions(-) diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda-usb.c index 3ca1082

[PATCH 2/2] [IrDA] Removed incorrect IRDA_ASSERT()

With USB2.0 bulk out MTU can be 512 bytes, so checking it only for 64 bytes is incorrect. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/irda-usb.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/irda-usb.c b/drivers/net/irda/irda

Re: IrDA spams logfiles - since 2.6.19

Hi Dave, On Wed, Jan 10, 2007 at 03:26:07PM -0800, David Miller wrote: The warning is a bit extreme because the skb_cow() call does fix things up and makes space available. But it's not the most efficient thing in the world, so it's good that we know about this so we can have a closer work.

Re: [PATCH] irda: handle out of memory errors

On Tue, Dec 19, 2006 at 05:55:09PM +0900, Akinobu Mita wrote: This patch checks return value of memory allocation functions for irda subsystem and fixes memory leaks in error cases. Cc: Samuel Ortiz [EMAIL PROTECTED] Signed-off-by: Akinobu Mita [EMAIL PROTECTED] That looks correct, thanks

Re: [PATCH] irlan: handle out of memory errors

On Tue, Dec 19, 2006 at 05:56:01PM +0900, Akinobu Mita wrote: This patch checks return values: - irlmp_register_client() - irlmp_register_service() - irlan_open() Cc: Samuel Ortiz [EMAIL PROTECTED] Signed-off-by: Akinobu Mita [EMAIL PROTECTED] This one seems correct as well, thanks again

Re: [2.6 patch] net/irda/: proper prototypes

Hi Adrian, On Mon, Dec 18, 2006 at 04:46:26AM +0100, Adrian Bunk wrote: This patch adds proper prototypes for some functions in include/net/irda/irda.h Signed-off-by: Adrian Bunk [EMAIL PROTECTED] looks good to me, thanks. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Cheers, Samuel

Re: [PATCH] irlan: fix header build warning

include/net/irda/irlan_filter.h:31: warning: its scope is only this definition or declaration, which is probably not what you want Signed-off-by: Randy Dunlap [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] Cheers, Samuel. - To unsubscribe from this list: send the line

  1   2   >