t: add TC flower filter offload support")
> Signed-off-by: Davide Caratti
Acked-by: Sathya Perla
Thanks!
On Sun, Dec 10, 2017 at 10:11 PM, Al Viro wrote:
>
> In be_cmd_txq_create() we have
> if (req->hdr.version > 0)
> req->if_id = cpu_to_le16(adapter->if_handle);
> req->num_pages = PAGES_4K_SPANNED(q_mem->va, q_mem->size);
> req->ulp_num = BE_ULP1_NUM;
>
>This flag (via tc_in_hw()) must be checked before issuing the call
>>to delete a filter in HW (fl_hw_destroy_filter()) and before issuing the
>>call to query stats (fl_hw_update_stats()).
>>
>>Signed-off-by: Sathya Perla
>
> 1) You have to indicate what tree you
On Thu, Jan 25, 2018 at 3:53 AM, Jakub Kicinski wrote:
>
> On Wed, 24 Jan 2018 17:12:55 +0530, Sathya Perla wrote:
> > When a filter cannot be added in HW (i.e, fl_hw_replace_filter() returns
> > error), the TCA_CLS_FLAGS_IN_HW flag is not set in the filter flags.
> >
>
stats (fl_hw_update_stats()).
Signed-off-by: Sathya Perla
---
net/sched/cls_flower.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c
index 6132a73..dbcfb52 100644
--- a/net/sched/cls_flower.c
+++ b/net/sched/cls_flower.c
Check for ingress-only qdisc for flower offload, as other qdiscs
are not supported for flower offload.
Suggested-by: Jiri Pirko
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom
When bnxt VF-reps are not compiled in (CONFIG_BNXT_SRIOV is off)
bnxt_tc.c needs a dummy definition of the routine bnxt_vf_rep_get_fid().
Reported-by: kbuild test robot
Fixes: 2ae7408fedfe ("bnxt_en: bnxt: add TC flower filter offload support")
Signed-off-by: Sathya Perla
---
d
d7 ("bnxt_en: add support to enable VF-representors")
Suggested-by: Arnd Bergmann
Signed-off-by: Sathya Perla
---
drivers/infiniband/hw/bnxt_re/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig
b/drivers/infiniband/hw/bnxt_re/Kconfi
On Thu, Jul 27, 2017 at 1:18 PM, Arnd Bergmann wrote:
[...]
>
> On today's linux-next:
>
> drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.o: In function `bnxt_dl_register':
> bnxt_vfr.c:(.text+0x1440): undefined reference to `devlink_alloc'
> bnxt_vfr.c:(.text+0x14c0): undefined reference to `devlink
On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote:
[...]
>> Sathya already sent 3 patches to fix some of these issues. But I need
>> to rework one of his patch and resend.
>
> Ok, thanks. I just ran into one more issue, and don't know if that's included
> as well. If not, please also add the p
This fixes the build error:
‘struct net_device’ has no member named ‘switchdev_ops’
Reported-by: kbuild test robot
Fixes: c124a62ff2dd ("bnxt_en: add support for port_attr_get and and
get_phys_port_name")
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
Fix the phys_port_name for the external physical port to be in
"pA" format and that of VF-rep to be in "pCvfD" format as
suggested by Jakub Kicinski.
Fixes: c124a62ff2dd ("bnxt_en: add support for port_attr_get and
get_phys_port_name")
Signed-off-by: Sathya Pe
nable VF-representors")
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
index 83478e9..86850ae 100644
--- a/dri
On Tue, Jul 25, 2017 at 10:15 AM, Jakub Kicinski wrote:
...
>> +static int bnxt_get_phys_port_name(struct net_device *dev, char *buf,
>> +size_t len)
>> +{
>> + struct bnxt *bp = netdev_priv(dev);
>> + int rc;
>> +
>> + /* The PF and it's VF-reps only su
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
On Behalf Of Roman Mashak
>
> Signed-off-by: Roman Mashak
> Signed-off-by: Jamal Hadi Salim
> ---
> man/man8/tc.8 | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --g
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org]
On Behalf Of Sathya Perla
> Sent: Wednesday, July 27, 2016 2:56 PM
> To: netdev@vger.kernel.org
> Subject: [net-next PATCH 0/4] be2net: patch set
>
> Hi David, pls conside
.
Signed-off-by: Sriharsha Basavapatna
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +
drivers/net/ethernet/emulex/benet/be_main.c | 169 +---
2 files changed, 130 insertions(+), 41 deletions(-)
diff --git a/drivers/net/ethernet/emulex
)
calls are now replaced with mutex calls.
Also a new rx_filter_lock is now needed to protect the RX filtering fields
like vids[] between be_vlan_add/rem_vid() and __be_set_rx_mode() contexts.
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 19 +-
drivers/net
ket reception to be
delayed on that CPU. This patch defers processing of the above cmds to a
separate workqueue. With this change, FW cmds are now issued only in process
context. Now that the FW cmds are issued only in process context, they can
sleep waiting for a completion instead of polling.
Sat
The driver currently removes a new vid from the adapter->vids[] array if
be_vid_config() returns an error, which occurs when there is an error in
HW/FW. This is wrong. After the HW/FW error is recovered from, we need the
complete vids[] array to re-program the vlan list.
Signed-off-by: Sat
issue,
this patch first explicitly clears the vlan-promisc mode via RX_FILTER
cmd and then tries to program the vlan list.
Signed-off-by: Somnath Kotur
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
> -Original Message-
> From: Sathya Perla [mailto:sathya.pe...@broadcom.com]
> > >
> > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter
> > *adapter)
> > > > u32 cap_flags = be_if_cap_flags(adapter);
> > >
lm-sensors) in case we have adapters'
> functions which interface is down.
>
> This patch moves the fw query code to be invoked even if interface is
down.
> No functional changes were introduced.
>
> Signed-off-by: Guilherme G. Piccoli
Acked-by: Sathya Perla
> -Original Message-
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
>
> On 07/25/2016 07:48 AM, Sathya Perla wrote:
> >> -Original Message-
> >> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
> >>
> >&
> -Original Message-
> From: Sathya Perla [mailto:sathya.pe...@broadcom.com]
>
> > -Original Message-
> > From: David Miller [mailto:da...@davemloft.net]
> >
> > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter
> *adapter)
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
>
> > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter
*adapter)
> > u32 cap_flags = be_if_cap_flags(adapter);
> > int status;
> >
> > + /* alloc required memory for other filtering fields */
>
> -Original Message-
> From: Guilherme G. Piccoli [mailto:gpicc...@linux.vnet.ibm.com]
>
> Temperature values on be2net driver are made available to userspace via
hwmon abstraction, so tools like lm-
> sensors can present them to the user.
> The driver provides hwmon structures for each ada
The driver currently removes a new vid from the adapter->vids[] array if
be_vid_config() returns an error, which occurs when there is an error in
HW/FW. This is wrong. After the HW/FW error is recovered from, we need the
complete vids[] array to re-program the vlan list.
Signed-off-by: Sat
issue,
this patch first explicitly clears the vlan-promisc mode via RX_FILTER
cmd and then tries to program the vlan list.
Signed-off-by: Somnath Kotur
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff
ket reception to be
delayed on that CPU. This patch defers processing of the above cmds to a
separate workqueue. With this change, FW cmds are now issued only in process
context. Now that the FW cmds are issued only in process context, they can
sleep waiting for a completion instead of polling.
Sat
)
calls are now replaced with mutex calls.
Also a new rx_filter_lock is now needed to protect the RX filtering fields
like vids[] between be_vlan_add/rem_vid() and __be_set_rx_mode() contexts.
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 19 +-
drivers/net
.
Signed-off-by: Sriharsha Basavapatna
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +
drivers/net/ethernet/emulex/benet/be_main.c | 169 +---
2 files changed, 130 insertions(+), 41 deletions(-)
diff --git a/drivers/net/ethernet/emulex
be_msix_disable(struct be_adapter
*adapter)
>
> static int be_msix_enable(struct be_adapter *adapter) {
> - unsigned int i, num_vec, max_roce_eqs;
> + unsigned int i, max_roce_eqs;
> struct device *dev = &adapter->pdev->dev;
> + int num_vec;
>
Oops...thanks for catching this! This must go into net-next.
Acked-by: Sathya Perla
queues via
ethtool set-channels option.
Patch 3 disables EVB when VFs are not enabled on a BE3 SR-IOV config to
avoid the broadcast echo problem.
Patch 4 updates copyright markings in be2net src files
Patch 5 updates the be2net maintainers' list
Sathya Perla (3):
be2net: fix definiti
From: Somnath Kotur
This patch updates year and company name in the copyright markings in the
be2net source files.
Signed-off-by: Somnath Kotur
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
drivers/net/ethernet/emulex/benet/be_cmds.c| 2
the max number of EQs avialable for NIC only and renames
be_max_eqs() to be_max_func_eqs().
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 8 ++--
drivers/net/ethernet/emulex/benet/be_main.c | 29 +
2 files changed, 19 insertions
-queues can be created with the
following cmds:
ethtool -L ethX combined N rx M-N (when N < M)
ethtool -L ethX combined M tx N-M (when M < N)
Setting both RX-only and TX-only channels is still not supported.
It is mandatory to create atleast one combined channel.
Signed-off-by: Sathya
This patch removes Padmanabh's name from the maintainers list as he's no
longer with the company. It also adds the driver name on the headline to
make it easy to lookup the maintainers list by the driver name.
Signed-off-by: Sathya Perla
---
MAINTAINERS | 3 +--
1 file changed, 1
rksaround this problem by disabling the EVB initially
and re-enabling it *only* when SR-IOV is enabled by the user. For the
driver fix to work, the BE3 FW version must be >= 11.1.84.0.
Signed-off-by: Somnath Kotur
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 11 +
Hi David, the following patch set contains three non-critical fixes that
can go into the net-next tree.
Patch 1 fixes the logic for provisioning queue pairs on VFs to take into
account the limit on number of TXQs too as in some profiles the number
of TXQs is less than that of RXQs.
Patch 2 enable
This proportional share calculation is done based on division of the
PF's MAX VFs with the Total MAX VFs on that port. It also needs to
learn about the no: of NIC PFs on the port and subtract that from
the 15 RSS Policy Tables on the port.
Signed-off-by: Somnath Kotur
Signed-off-by: Sa
s.
4) Remove code in be_set_wol() that writes to PCICFG_PM_CONTROL_OFFSET
to set pme_en bit; pci_enable_wake() sets that.
Fixes: 028991e49 ("Enabling Wake-on-LAN is not supported in S5 state")
Signed-off-by: Sriharsha Basavapatna
Signed-off-by: Sathya Perla
---
drivers/net/ethern
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 1 +
drivers/net/ethernet/emulex/benet/be_cmds.c | 90 +++--
drivers/net/ethernet/emulex/benet/be_cmds.h | 2 +-
drivers/net/ethernet/emulex/benet/be_main.c | 82 +-
4
er->pcicfg was mapped or not, then
> use that flag in be_unmap_pci_bars() to unmap if required.
>
> Signed-off-by: Douglas Miller
Acked-by: Sathya Perla
Could you pls add the "fixes" tag line to this patch:
Fixes: 25848c901 ("use PCI MMIO read instead of config read for errors")
thanks for the fix,
-Sathya
n
versions >= 11.0.283.0 and 10.6.334.0
Reported-by: Ivan Vecera
Signed-off-by: Venkat Duvvuru
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.h | 9 ++---
drivers/net/ethernet/emulex/benet/be_main.c | 16 +---
2 files changed, 15 insertions(+), 10 delet
On Fri, Feb 26, 2016 at 6:43 PM, Ivan Vecera wrote:
> Should the MULTICAST bit be masked in any be_cmd_rx_filter() call on BE3's
> VFs if the trans. tagging is enabled?
Not on any be_cmd_rx_filter() call, but on the first call in
be_open()->be_if_enable_filters() where the basic filtering flags a
On Fri, Feb 26, 2016 at 5:54 PM, Ivan Vecera wrote:
> On 26.2.2016 12:36, Sathya Perla wrote:
>>
>> On Fri, Feb 26, 2016 at 2:16 PM, Ivan Vecera wrote:
>>>
>>> The FILTMGMT privilege is necessary on BE3 chip to manipulare filters
>>> like MC, UC list man
ents to make interface up for such VF because be_enable_if_filters()
> called from be_open() fails thus be_open() also fails.
>
> Cc: Sathya Perla
> Cc: Sriharsha Basavapatna
> Signed-off-by: Ivan Vecera
> ---
> drivers/net/ethernet/emulex/benet/be_main.c | 11 +++
>
SW_CONFIG command cannot be used as it is not supported by
> these older chipset's FW.
>
> v2: added the comment
Acked-by: Sathya Perla
On Wed, Feb 10, 2016 at 1:13 PM, Ivan Vecera wrote:
>
> The EVB (virtual bridge) functionality should be disabled on older BE3
> and Lancer chips if SR-IOV is disabled in the NIC's BIOS. This setting
> is identified by the zero value of total VFs reported by the card.
> The GET_HSW_CONFIG command
be2net maintainers' email addresses changed from avagotech.com to
broadcom.com starting today. While updating the list, I'm also adding
Somnath's name to the list.
Signed-off-by: Sathya Perla
---
MAINTAINERS | 9 +
1 file changed, 5 insertions(+), 4 deletions(-
On Fri, Jan 1, 2016 at 4:52 AM, SF Markus Elfring
wrote:
> From: Markus Elfring
> Date: Fri, 1 Jan 2016 00:11:57 +0100
>
> Remove two checks for null pointers which would be handled by usual
> error detection before.
>
> Signed-off-by: Markus Elfring
Acked-by: Sathya
From: Suresh Reddy
All code relating to FW cmds is in be_cmds.[ch] excepting FW flash cmd
related code. This patch moves these routines from be_main.c to be_cmds.c
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 583
sh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 35 +
drivers/net/ethernet/emulex/benet/be_cmds.h | 3 ++-
2 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c
b/drivers
to recommended_prio_bits.
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
drivers/net/ethernet/emulex/benet/be_cmds.c | 3 +--
drivers/net/ethernet/emulex/benet/be_main.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ether
to BE3 are
labeled "g3". This patch cleans up all of this to make this code more
readable.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.h | 141
drivers/net/ethernet/emulex/benet/be_main.c | 78
-dump option as it is
now available via --get-dump option. Even though the
"ethtool --register-dump" cmd which used to work earlier, will now fail
with ENOTSUPP error, we feel it is not an issue as this is used only
for diagnostics purpose.
Signed-off-by: Venkat Duvvuru
Signed-off-b
From: Suresh Reddy
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h
b/drivers/net/ethernet/emulex/benet/be.h
index 8b8212f..22bf7af
m while issuing
GET_PROFILE_CONFIG cmd")
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 4 +-
drivers/net/ethernet/emulex/benet/be_cmds.c | 85 -
drivers/net/ethernet/emulex/benet/be_cmds.h | 11 +---
drivers
From: Suresh Reddy
BE3 chip doesn't support VEPA mode.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/e
us to ethtool when errors
relating to FW image authentication occur.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 14 +-
drivers/net/ethernet/emulex/benet/be_cmds.h | 4 +++-
2 files changed, 16 insertions(+), 2 deletions(-
gister-dump" cmd which used to work
earlier, will now fail with ENOTSUPP error, we feel it is not an issue as
this is used only for diagnostics purpose.
Patch 10 bumps up the driver version.
Sathya Perla (1):
be2net: remove a line of code that has no effect
Suresh Reddy (7):
be2net: fix V
From: Venkat Duvvuru
eeh_error, fw_timeout, hw_error variables in the be_adapter structure are
not used anymore. An earlier patch that introduced adapter->err_flags to
store this information missed removing these variables.
Signed-off-by: Venkat Duvvuru
Signed-off-by: Sathya Pe
On Wed, Dec 30, 2015 at 2:20 AM, David Miller wrote:
>
> Please fix the problems reported by the kbuild test robot, they happened
> when I tried to build this too.
David, the test robot is complaining that all values of the enum are
not being handled by the switch statement.
There is a "return -E
m while issuing
GET_PROFILE_CONFIG cmd")
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 4 +-
drivers/net/ethernet/emulex/benet/be_cmds.c | 85 -
drivers/net/ethernet/emulex/benet/be_cmds.h | 11 +---
drivers
us to ethtool when errors
relating to FW image authentication occur.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 11 +++
drivers/net/ethernet/emulex/benet/be_cmds.h | 4 +++-
2 files changed, 14 insertions(+), 1 deletion(-)
to recommended_prio_bits.
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
drivers/net/ethernet/emulex/benet/be_cmds.c | 3 +--
drivers/net/ethernet/emulex/benet/be_main.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ether
From: Suresh Reddy
All code relating to FW cmds is in be_cmds.[ch] excepting FW flash cmd
related code. This patch moves these routines from be_main.c to be_cmds.c
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 583
From: Suresh Reddy
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h
b/drivers/net/ethernet/emulex/benet/be.h
index 8b8212f..22bf7af
From: Venkat Duvvuru
eeh_error, fw_timeout, hw_error variables in the be_adapter structure are
not used anymore. An earlier patch that introduced adapter->err_flags to
store this information missed removing these variables.
Signed-off-by: Venkat Duvvuru
Signed-off-by: Sathya Pe
-dump option as it is
now available via --get-dump option. Even though the
"ethtool --register-dump" cmd which used to work earlier, will now fail
with ENOTSUPP error, we feel it is not an issue as this is used only
for diagnostics purpose.
Signed-off-by: Venkat Duvvuru
Signed-off-b
From: Suresh Reddy
BE3 chip doesn't support VEPA mode.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/e
to BE3 are
labeled "g3". This patch cleans up all of this to make this code more
readable.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.h | 141
drivers/net/ethernet/emulex/benet/be_main.c | 78
is not an issue as
this is used only for diagnostics purpose.
Patch 10 bumps up the driver version.
Sathya Perla (1):
be2net: remove a line of code that has no effect
Suresh Reddy (7):
be2net: fix VF link state transition from disabled to auto
be2net: avoid configuring VEPA mode on BE3
be2n
sh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 35 +
drivers/net/ethernet/emulex/benet/be_cmds.h | 3 ++-
2 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c
b/drivers
option as it is now available via --get-dump
option. Even though the "ethtool --register-dump" cmd which used to work
earlier, will now fail with ENOTSUPP error, we feel it is not an issue as
this is used only for diagnostics purpose.
Patch 10 bumps up the driver version.
Sathya Perla (
-dump option as it is
now available via --get-dump option. Even though the
"ethtool --register-dump" cmd which used to work earlier, will now fail
with ENOTSUPP error, we feel it is not an issue as this is used only
for diagnostics purpose.
Signed-off-by: Venkat Duvvuru
Signed-off-b
From: Suresh Reddy
BE3 chip doesn't support VEPA mode.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/e
From: Venkat Duvvuru
eeh_error, fw_timeout, hw_error variables in the be_adapter structure are
not used anymore. An earlier patch that introduced adapter->err_flags to
store this information missed removing these variables.
Signed-off-by: Venkat Duvvuru
Signed-off-by: Sathya Pe
to recommended_prio_bits.
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
drivers/net/ethernet/emulex/benet/be_cmds.c | 3 +--
drivers/net/ethernet/emulex/benet/be_main.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ether
From: Suresh Reddy
All code relating to FW cmds is in be_cmds.[ch] excepting FW flash cmd
related code. This patch moves these routines from be_main.c to be_cmds.c
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 583
From: Suresh Reddy
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/emulex/benet/be.h
b/drivers/net/ethernet/emulex/benet/be.h
index 8b8212f..22bf7af
sh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 35 +
drivers/net/ethernet/emulex/benet/be_cmds.h | 3 ++-
2 files changed, 28 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_cmds.c
b/drivers
us to ethtool when errors
relating to FW image authentication occur.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 11 +++
drivers/net/ethernet/emulex/benet/be_cmds.h | 4 +++-
2 files changed, 14 insertions(+), 1 deletion(-)
m while issuing
GET_PROFILE_CONFIG cmd")
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be.h | 4 +-
drivers/net/ethernet/emulex/benet/be_cmds.c | 85 -
drivers/net/ethernet/emulex/benet/be_cmds.h | 11 +---
drivers
to BE3 are
labeled "g3". This patch cleans up all of this to make this code more
readable.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.h | 141
drivers/net/ethernet/emulex/benet/be_main.c | 78
On Fri, Nov 13, 2015 at 3:22 PM, Ivan Vecera wrote:
> The lancer_cmd_get_file_len() calls lancer_cmd_read_object() to get
> the current size of registers for ethtool registers dump. The size
> is stored in data_read but only when the returned status is 0 otherwise
> it is uninitialized thus random
ater
> usage during Rx queue creation.
>
> Signed-off-by: Ivan Vecera
Acked-by: Sathya Perla
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
tly but
will be fixed in a future version. This patch fixes this issue by updating
the VF's profile descriptor so that they match the interface capability
flags provisioned by the PF.
Fixes: 435452aa8847 ("Prevent VFs from enabling VLAN promiscuous mode")
Signed-off-by: Kalesh A
: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c
b/drivers/net/ethernet/emulex/benet/be_main.c
index 86eed47..821e014 100644
--- a/drivers/net/ethernet/emulex/benet
ke care of this.
We hit this issue when we try to flash old BE3 images (used prior to the
release of BE3-R) on pre-BE3-R adapters.
Fixes: a6e6ff6eee12f3e ("be2net: simplify UFI compatibility checking")
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
---
drivers/net/eth
eried for, the driver will
read wrong data. This patch fixes this issue by using the GET_CNTL_ATTRIB
cmd to query the real pci_func_num of a function and then uses it in the
GET_PROFILE_CONFIG cmd.
Signed-off-by: Somnath Kotur
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet
Patch 1 fixes a FW image compatibility check in the driver that
prevents certain FW images from being flashed on BE3 (not BE3-R)
adapters.
Patch 2 fixes a spin_lock not being released in a failure case in
be_cmd_notify_wait().
Patch 3 includes a workaround to pad packets that are only 32b long or
From: Suresh Reddy
The mcc/mbox lock is not being released when be_cmd_copy() returns
an error.
Signed-off-by: Suresh Reddy
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_cmds.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net
1 +
> drivers/net/ethernet/emulex/benet/be_main.c | 10 ++
> 2 files changed, 11 insertions(+)
Acked-by: Sathya Perla
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
o now when
there are two quick invocations of this cmd, the 2nd request may end up
overwriting the first request, causing FW cmd corruption.
This patch reverts the offending commit and hence fixes the regression.
Fixes: 8af65c2f4("be2net: make the RX_FILTER command asynchronous")
Signed-
eed only
if EQs haven't yet been destroyed. This fixes a possible crash when
affinity_mask is freed twice.
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff
functions, be_enable_if_filters() and
be_disable_if_filters() are introduced to enable/disable IFACE filters in
be_open()/be_close() respectively. In be_setup() the IFACE is now created
only with the RSS flag.
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex
Hi David,
This patch set contains 2 driver fixes to a Lancer HW issue and a fix
to a double free bug. Pls apply to the "net" tree. Thanks!
Patch 1 now enables filters only after creating RXQs. This is done as
HW issues were observed on Lancer adapters if filters
(flags, mac addrs etc) are enable
ackets are selected for
transfer to the RXQs by disabling interface filters.
Signed-off-by: Kalesh AP
Signed-off-by: Sathya Perla
---
drivers/net/ethernet/emulex/benet/be_main.c | 42 -
1 file changed, 30 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/em
1 - 100 of 116 matches
Mail list logo
