Re: [PATCH bpf-next] xdp: sample code for redirecting vlan packets to specific cpus

On Wed, Nov 7, 2018 at 1:44 PM Daniel Borkmann wrote: > > On 10/29/2018 11:11 PM, John Fastabend wrote: > > On 10/29/2018 02:19 PM, Shannon Nelson wrote: > >> This is an example of using XDP to redirect the processing of > >> particular vlan packets to speci

[RFC PATCH] net: vlan ipsec-xfrm offload

to the real_dev. Signed-off-by: Shannon Nelson --- net/8021q/vlan_dev.c | 98 1 file changed, 98 insertions(+) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index ff720f1..a46e056 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q

Re: [PATCH bpf-next] xdp: sample code for redirecting vlan packets to specific cpus

On 10/29/2018 3:11 PM, John Fastabend wrote: On 10/29/2018 02:19 PM, Shannon Nelson wrote: This is an example of using XDP to redirect the processing of particular vlan packets to specific CPUs. This is in response to comments received on a kernel patch put forth previously to do something

[PATCH bpf-next] xdp: sample code for redirecting vlan packets to specific cpus

CPUs. This example currently uses a vlan key and cpu value in the BPF map, so only can do one CPU per vlan. This could easily be modified to use a bitpattern of CPUs rather than a CPU id to allow multiple CPUs per vlan. Signed-off-by: Shannon Nelson --- samples/bpf/Makefile

[PATCH bpf-next] bpf_load: add map name to load_maps error message

To help when debugging bpf/xdp load issues, have the load_map() error message include the number and name of the map that failed. Signed-off-by: Shannon Nelson --- samples/bpf/bpf_load.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/bpf/bpf_load.c b/samples/bpf

Re: [PATCH net-next] net: enable RPS on vlan devices

On 10/10/2018 10:37 AM, John Fastabend wrote: Latest tree has a sk_lookup() helper supported in 'tc' layer now to lookup the socket. And XDP has support for a "cpumap" object that allows redirect to remote CPUs. Neither was specifically designed for this but I suspect with some extra work these

Re: [PATCH net-next] net: enable RPS on vlan devices

On 10/10/2018 10:14 AM, Eric Dumazet wrote: On 10/10/2018 09:18 AM, Shannon Nelson wrote: On 10/9/2018 7:17 PM, Eric Dumazet wrote: On 10/09/2018 07:11 PM, Shannon Nelson wrote: Hence the reason we sent this as an RFC a couple of weeks ago.  We got no response, so followed up

Re: [PATCH net-next] net: enable RPS on vlan devices

On 10/9/2018 7:17 PM, Eric Dumazet wrote: On 10/09/2018 07:11 PM, Shannon Nelson wrote: Hence the reason we sent this as an RFC a couple of weeks ago.  We got no response, so followed up with this patch in order to get some input. Do you have any suggestions for how we might accomplish

Re: [PATCH net-next] net: enable RPS on vlan devices

On 10/9/2018 6:04 PM, Eric Dumazet wrote: On 10/09/2018 05:41 PM, Shannon Nelson wrote: From: Silviu Smarandache This patch modifies the RPS processing code so that it searches for a matching vlan interface on the packet and then uses the RPS settings of the vlan interface.  If no vlan

[PATCH net-next] net: enable RPS on vlan devices

of cpus separate from the VM's cpus. Yes, choosing to use this may cause a bit of throughput pain when the packets are actually passed into the VM and have to move from one cache to another. Orabug: 28645929 Signed-off-by: Silviu Smarandache Signed-off-by: Shannon Nelson --- net/core/dev.c | 59

[PATCH] ixgbe: allow IPsec Tx offload in VEPA mode

n VEPA mode. To get there with the ixgbe device, use the handy 'bridge' command: bridge link set dev eth1 hwmode vepa Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ix

[PATCH RFC net-next] net: enable RPS on vlan devices

the VM's cpus. Yes, choosing to use this may cause a bit of throughput pain when the packets are actually passed into the VM and have to move from one cache to another. Orabug: 28645929 Signed-off-by: Silviu Smarandache Signed-off-by: Shannon Nelson --- net/core/dev.c | 59

Re: [PATCH] ixgbevf: off by one in ixgbevf_ipsec_tx()

On 9/19/2018 3:35 AM, Dan Carpenter wrote: The ipsec->tx_tbl[] array has IXGBE_IPSEC_MAX_SA_COUNT elements so the > should be a >=. Fixes: 0062e7cc955e ("ixgbevf: add VF IPsec offload code") Signed-off-by: Dan Carpenter Signed-off-by: Shannon Nelson diff --git a/d

[PATCH next-queue 1/2] ixgbe: disallow ipsec tx offload when in sr-iov mode

was enabled, but we'll get to that later. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c index 68395ab..24076b4

[PATCH next-queue 2/2] ixgbe: fix the return value for unsupported VF offload

When failing the request because we can't support that offload, reporting EOPNOTSUPP makes much more sense than ENXIO. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel

[PATCH ipsec-next] xfrm: allow driver to quietly refuse offload

ws the user a little more flexibility in requesting offloads and not needing to know every detail at all times about each specific NIC when trying to create SAs. Signed-off-by: Shannon Nelson --- More specifically, this will help one user experience issue with the coming ixgbevf IPsec offload. Docu

Re: [Intel-wired-lan] [PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

On 8/16/2018 2:36 PM, Shannon Nelson wrote: On 8/16/2018 2:15 PM, Alexander Duyck wrote: On Tue, Aug 14, 2018 at 10:10 AM Shannon Nelson wrote: On 8/14/2018 8:30 AM, Alexander Duyck wrote: On Mon, Aug 13, 2018 at 11:43 AM Shannon Nelson wrote: This set of patches implements IPsec

Re: [Intel-wired-lan] [PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

On 8/16/2018 2:15 PM, Alexander Duyck wrote: On Tue, Aug 14, 2018 at 10:10 AM Shannon Nelson wrote: On 8/14/2018 8:30 AM, Alexander Duyck wrote: On Mon, Aug 13, 2018 at 11:43 AM Shannon Nelson wrote: This set of patches implements IPsec hardware offload for VF devices in Intel's 10Gbe

Re: [PATCH next-queue 3/8] ixgbe: add VF ipsec management

improve the system] url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ixgbe-ixgbevf-IPsec-offload-support-for-VFs/20180814-074800 base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue config: x86_64-randconfig-v0-08131550 (attached as .config

Re: [Intel-wired-lan] [PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

On 8/14/2018 8:30 AM, Alexander Duyck wrote: On Mon, Aug 13, 2018 at 11:43 AM Shannon Nelson wrote: This set of patches implements IPsec hardware offload for VF devices in Intel's 10Gbe x540 family of Ethernet devices. [...] So the one question I would have about this patch set is what

[PATCH next-queue 0/8] ixgbe/ixgbevf: IPsec offload support for VFs

ching output from sar also shows a nice decrease in CPU utilization. Shannon Nelson (8): ixgbe: reload ipsec ip table after sa tables ixgbe: prep ipsec constants for later use ixgbe: add VF ipsec management ixgbe: add VF IPsec offload enable flag ixgbe: add VF IPsec offload request message

[PATCH next-queue 3/8] ixgbe: add VF ipsec management

Add functions to translate VF IPsec offload add and delete requests into something the existing code can work with. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 256 - drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h | 13 ++ 2 files

[PATCH next-queue 1/8] ixgbe: reload ipsec ip table after sa tables

Restore the ipsec hardware IP table after reloading the SA tables. This doesn't make much difference now, but will matter when we add support for VF ipsec offloads. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 1 file changed, 8

[PATCH next-queue 2/8] ixgbe: prep ipsec constants for later use

Pull out a couple of values from a function so they can be used later elsewhere. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers

[PATCH next-queue 6/8] ixgbevf: add defines for IPsec offload request

Fix up the register definitions for using IPsec offloads and add the new mailbox message IDs. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbevf/defines.h | 8 drivers/net/ethernet/intel/ixgbevf/mbx.h | 5 + 2 files changed, 13 insertions(+) diff --git

[PATCH next-queue 5/8] ixgbe: add VF IPsec offload request message handling

Add an add and a delete message for IPsec offload requests from the VF. These call into the ipsec functions that can translate the message buffer into a useful IPsec offload. These new messages bump the mbox API version to 1.4. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel

[PATCH next-queue 4/8] ixgbe: add VF IPsec offload enable flag

candidate for becoming a netdev feature flag. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 1 + drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 9 + drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++- 3 files changed, 12 insertions(+), 1 deletio

[PATCH next-queue 7/8] ixgbevf: add VF ipsec offload code

Add the ipsec offload support code. This is based off of the similar code in ixgbe, but instead of writing the SA registers, the VF asks the PF to setup the offload by sending the offload information to the PF via the standard mailbox. Signed-off-by: Shannon Nelson --- drivers/net/ethernet

[PATCH next-queue 8/8] ixgbevf: enable VF ipsec offload operations

Add the ipsec initialization into the driver startup and add the Rx and Tx processing hooks. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbevf/defines.h | 2 +- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 2 + drivers/net/ethernet/intel/ixgbevf/ixgbevf.h

[PATCH next-queue] ixgbe: don't clear ipsec sa counters on hw clearing

The software SA record counters should not be cleared when clearing the hardware tables. This causes the counters to be out of sync after a driver reset. Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/i

Re: [PATCH net] ixgbe: Off by one in ixgbe_ipsec_tx()

Carpenter Acked-by: Shannon Nelson diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c index c116f459945d..da4322e4daed 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c @@ -

[PATCH ethtool] ethtool: ixgbe dump strings for security registers

Add the ixgbe's security configuration registers into the register dump. Signed-off-by: Shannon Nelson --- ixgbe.c | 26 ++ 1 file changed, 26 insertions(+) NOTE: Obviously this should wait until Intel accepts and pushes the related ixgbe patch and Dave accepts

[PATCH next-queue] ixgbe: add ipsec security registers into ethtool register dump

Add the ixgbe's security configuration registers into the register dump. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers

[PATCH ipsec-next 1/1] xfrm: don't check offload_handle for nonzero

but meaningful value. We can remove the checks for non-zero because there are plenty other attributes also being checked to see if there is an offload in place for the SA in question. Signed-off-by: Shannon Nelson --- net/ipv4/esp4_offload.c | 6 ++ net/ipv6/esp6_offload.c | 6 ++ net/xfrm

[PATCH v3 net-next 1/4] selftests: rtnetlink: clear the return code at start of ipsec test

Following the custom from the other functions, clear the global ret code before starting the test so as to not have previously failed tests cause us to thing this test has failed. Reported-by: Anders Roxell Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 2 ++ 1

[PATCH v3 net-next 0/4] Updates for ipsec selftests

Fix up the existing ipsec selftest and add tests for the ipsec offload driver API. v2: addressed formatting nits in netdevsim from Jakub Kicinski v3: a couple more nits from Jakub Shannon Nelson (4): selftests: rtnetlink: clear the return code at start of ipsec test selftests: rtnetlink: use

[PATCH v3 net-next 3/4] netdevsim: add ipsec offload testing

Implement the IPsec/XFRM offload API for testing. Signed-off-by: Shannon Nelson --- V2 - addressed formatting comments from Jakub Kicinski V3 - a couple more little xmas tree nits drivers/net/netdevsim/Makefile| 4 + drivers/net/netdevsim/ipsec.c | 297

[PATCH v3 net-next 4/4] selftests: rtnetlink: add ipsec offload API test

Using the netdevsim as a device for testing, try out the XFRM commands for setting up IPsec hardware offloads. Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 114 +++ 1 file changed, 114 insertions(+) diff --git a/tools/testing

[PATCH v3 net-next 2/4] selftests: rtnetlink: use dummydev as a test device

We really shouldn't mess with local system settings, so let's use the already created dummy device instead for ipsec testing. Oh, and let's put the temp file into a proper directory. Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 15 +++ 1 file changed

Re: [PATCH net-next] liquidio: fix kernel panic when NIC firmware is older than 1.7.2

On 6/26/2018 4:58 AM, Felix Manlunas wrote: From: Rick Farrington Pre-1.7.2 NIC firmware does not support (and does not respond to) the "get speed" command which is sent by the 1.7.2 driver during modprobe. Due to a bug in older firmware (with respect to unknown commands), this unsupported

[PATCH v2 net-next 2/4] selftests: rtnetlink: use dummydev as a test device

We really shouldn't mess with local system settings, so let's use the already created dummy device instead for ipsec testing. Oh, and let's put the temp file into a proper directory. Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 15 +++ 1 file changed

[PATCH v2 net-next 4/4] selftests: rtnetlink: add ipsec offload API test

Using the netdevsim as a device for testing, try out the XFRM commands for setting up IPsec hardware offloads. Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 114 +++ 1 file changed, 114 insertions(+) diff --git a/tools/testing

[PATCH v2 net-next 3/4] netdevsim: add ipsec offload testing

Implement the IPsec/XFRM offload API for testing. Signed-off-by: Shannon Nelson --- V2 - addressed formatting comments from Jakub Kicinski drivers/net/netdevsim/Makefile| 4 + drivers/net/netdevsim/ipsec.c | 298 ++ drivers/net/netdevsim/netdev.c

[PATCH v2 net-next 0/4] Updates for ipsec selftests

Fix up the existing ipsec selftest and add tests for the ipsec offload driver API. v2: addressed formatting nits in netdevsim from Jakub Kicinski Shannon Nelson (4): selftests: rtnetlink: clear the return code at start of ipsec test selftests: rtnetlink: use dummydev as a test device

[PATCH v2 net-next 1/4] selftests: rtnetlink: clear the return code at start of ipsec test

Following the custom from the other functions, clear the global ret code before starting the test so as to not have previously failed tests cause us to thing this test has failed. Reported-by: Anders Roxell Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 2 ++ 1

Re: [PATCH net-next 3/4] netdevsim: add ipsec offload testing

On 6/22/2018 9:07 PM, Jakub Kicinski wrote: On Fri, 22 Jun 2018 17:31:37 -0700, Shannon Nelson wrote: Implement the IPsec/XFRM offload API for testing. Signed-off-by: Shannon Nelson Thanks for the patch! Just a number of stylistic nit picks. diff --git a/drivers/net/netdevsim/ipsec.c b

Re: [PATCH net-next 3/4] netdevsim: add ipsec offload testing

On 6/22/2018 9:07 PM, Jakub Kicinski wrote: On Fri, 22 Jun 2018 17:31:37 -0700, Shannon Nelson wrote: Implement the IPsec/XFRM offload API for testing. Signed-off-by: Shannon Nelson Thanks for the patch! Just a number of stylistic nit picks. Thanks for the comments, I'll do a v2

[PATCH net-next 3/4] netdevsim: add ipsec offload testing

Implement the IPsec/XFRM offload API for testing. Signed-off-by: Shannon Nelson --- drivers/net/netdevsim/Makefile| 4 + drivers/net/netdevsim/ipsec.c | 345 ++ drivers/net/netdevsim/netdev.c| 7 + drivers/net/netdevsim/netdevsim.h | 37

[PATCH net-next 0/4] Updates for ipsec selftests

Fix up the existing ipsec selftest and add tests for the ipsec offload driver API. Shannon Nelson (4): selftests: rtnetlink: clear the return code at start of ipsec test selftests: rtnetlink: use dummydev as a test device netdevsim: add ipsec offload testing selftests: rtnetlink: add

[PATCH net-next 4/4] selftests: rtnetlink: add ipsec offload API test

Using the netdevsim as a device for testing, try out the XFRM commands for setting up IPsec hardware offloads. Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 114 +++ 1 file changed, 114 insertions(+) diff --git a/tools/testing

[PATCH net-next 2/4] selftests: rtnetlink: use dummydev as a test device

We really shouldn't mess with local system settings, so let's use the already created dummy device instead for ipsec testing. Oh, and let's put the temp file into a proper directory. Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 15 +++ 1 file changed

[PATCH net-next 1/4] selftests: rtnetlink: clear the return code at start of ipsec test

Following the custom from the other functions, clear the global ret code before starting the test so as to not have previously failed tests cause us to think this test has failed. Reported-by: Anders Roxell Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 2 ++ 1

offload_handle issue in ipsec offload

all that... shall we remove the offload_handle references in the stack code? sln -- == Shannon Nelson shannon.nel...@oracle.com Parents can't afford to be squeamish

Re: [PATCH net-next 0/2] fixes for ipsec selftests

On 6/21/2018 9:49 PM, David Miller wrote: From: Shannon Nelson Date: Tue, 19 Jun 2018 22:42:41 -0700 A couple of bad behaviors in the ipsec selftest were pointed out by Anders Roxell and are addressed here. Shannon Nelson (2): selftests: rtnetlink: hide complaint from terminated monitor

Re: [PATCH net-next 0/2] fixes for ipsec selftests

On 6/21/2018 9:56 AM, Anders Roxell wrote: On Thu, 21 Jun 2018 at 02:32, Shannon Nelson wrote: On 6/20/2018 4:18 PM, Anders Roxell wrote: On Thu, 21 Jun 2018 at 00:26, Shannon Nelson wrote: On 6/20/2018 12:09 PM, Anders Roxell wrote: On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote

Re: [PATCH net-next 0/2] fixes for ipsec selftests

On 6/20/2018 4:18 PM, Anders Roxell wrote: On Thu, 21 Jun 2018 at 00:26, Shannon Nelson wrote: On 6/20/2018 12:09 PM, Anders Roxell wrote: On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote: A couple of bad behaviors in the ipsec selftest were pointed out by Anders Roxell

Re: [PATCH net-next 0/2] fixes for ipsec selftests

On 6/20/2018 12:09 PM, Anders Roxell wrote: On Wed, 20 Jun 2018 at 07:42, Shannon Nelson wrote: A couple of bad behaviors in the ipsec selftest were pointed out by Anders Roxell and are addressed here. Shannon Nelson (2): selftests: rtnetlink: hide complaint from terminated monitor

[PATCH net-next 2/2] selftests: rtnetlink: use a local IP address for IPsec tests

) Reported-by: Anders Roxell Signed-off-by: Shannon Nelson --- tools/testing/selftests/net/rtnetlink.sh | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/rtnetlink.sh b/tools/testing/selftests/net/rtnetlink.sh index 0a2bc6e..b33a371 100755 -

[PATCH net-next 0/2] fixes for ipsec selftests

A couple of bad behaviors in the ipsec selftest were pointed out by Anders Roxell and are addressed here. Shannon Nelson (2): selftests: rtnetlink: hide complaint from terminated monitor selftests: rtnetlink: use a local IP address for IPsec tests tools/testing/selftests/net/rtnetlink.sh

[PATCH net-next 1/2] selftests: rtnetlink: hide complaint from terminated monitor

Set up the "ip xfrm monitor" subprogram so as to not see a "Terminated" message when the subprogram is killed. Fixes: 5e596ee171ba ("selftests: add xfrm state-policy-monitor to rtnetlink.sh") Reported-by: Anders Roxell Signed-off-by: Shannon Nelson --- tools/test

[PATCH] ixgbe: fix broken ipsec Rx with proper cast on spi

Fix up a cast problem introduced by a sparse cleanup patch. This fixes a problem where the encrypted packets were not recognized on Rx and subsequently dropped. Fixes: 9cfbfa701b55 ("ixgbe: cleanup sparse warnings") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/i

[PATCH v2] ixgbe: check ipsec ip addr against mgmt filters

Make sure we don't try to offload the decryption of an incoming packet that should get delivered to the management engine. This is a corner case that will likely be very seldom seen, but could really confuse someone if they were to hit it. Suggested-by: Jesse Brandeburg Signed-off-by: Shannon

[PATCH] ixgbe: check ipsec ip addr against mgmt filter

Make sure we don't try to offload the decryption of an incoming packet that should get delivered to the management engine. This is a corner case that will likely be very seldom seen, but could really confuse someone if they were to hit it. Suggested-by: Jesse Brandeburg Signed-off-by: Shannon

Re: [PATCH] ixgbe: fix memory leak on ipsec allocation

he failed allocation of ipsec. Detected by CoverityScan, CID#146424 ("Resource Leak") Fixes: 63a67fe229ea ("ixgbe: add ipsec offload add and remove SA") Signed-off-by: Colin Ian King <colin.k...@canonical.com> Yep, thanks, good catch. Acked-by: Shannon Nelson <shannon.n

Re: [PATCH] ethtool: fix a potential missing-check bug

On 4/29/2018 6:31 PM, Wenwen Wang wrote: In ethtool_get_rxnfc(), the object "info" is firstly copied from user-space. If the FLOW_RSS flag is set in the member field flow_type of "info" (and cmd is ETHTOOL_GRXFH), info needs to be copied again from user-space because FLOW_RSS is newer and has

[PATCH ipsec-next] selftests: add xfrm state-policy-monitor to rtnetlink.sh

Add a simple set of tests for the IPsec xfrm commands. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- tools/testing/selftests/net/rtnetlink.sh | 103 +++ 1 file changed, 103 insertions(+) diff --git a/tools/testing/selftests/net/rtnetlink.sh b

Re: [Intel-wired-lan] [iwl next-queue PATCH 02/10] macvlan: Rename fwd_priv to accel_priv and add accessor function

On 4/3/2018 2:16 PM, Alexander Duyck wrote: [...] +static inline void *macvlan_accel_priv(struct net_device *dev) +{ + struct macvlan_dev *macvlan = netdev_priv(dev); + + return macvlan->accel_priv; Perhaps a check for (macvlan == NULL) before using it? sln +} #endif /*

Re: [Intel-wired-lan] [iwl next-queue PATCH 03/10] macvlan: Use software path for offloaded local, broadcast, and multicast traffic

On 4/3/2018 2:16 PM, Alexander Duyck wrote: This change makes it so that we use a software path for packets that are going to be locally switched between two macvlan interfaces on the same device. In addition we resort to software replication of broadcast and multicast packets instead of

Re: [PATCH V5 net-next 06/14] net/tls: Add generic NIC offload infrastructure

Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Acked-by: Shannon Nelson <shannon.nel...@oracle.com> --- include/net/tls.h | 120 +-- net/tls/Kconfig | 10 + net/tls/Makefile | 2 + net/tls/tls_device.c | 759 ++

Re: [PATCH V3 net-next 06/14] net/tls: Add generic NIC offload infrastructure

On 3/26/2018 12:10 AM, Boris Pismenny wrote: Hi Shannon, On 3/23/2018 11:21 PM, Shannon Nelson wrote: On 3/22/2018 3:33 PM, Saeed Mahameed wrote: From: Ilya Lesokhin <il...@mellanox.com> Thanks, Boris, these sound fine. sln

Re: [PATCH V3 net-next 06/14] net/tls: Add generic NIC offload infrastructure

On 3/22/2018 3:33 PM, Saeed Mahameed wrote: From: Ilya Lesokhin This patch adds a generic infrastructure to offload TLS crypto to a network devices. It enables the kernel TLS socket to skip encryption s/devices/device/ and authentication operations on the transmit side

[next-queue v2 3/4] ixgbe: no need for esp trailer if gso

There is no need to calculate the trailer length if we're doing a GSO/TSO, as there is no trailer added to the packet data. Also, don't bother clearing the flags field as it was already cleared earlier. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet

[next-queue v2 4/4] ixgbe: enable tso with ipsec offload

Fix things up to support TSO offload in conjunction with IPsec hw offload. This raises throughput with IPsec offload on to nearly line rate. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- v2 updates from Alex's comments: - changed feature add from variable to #define -

[next-queue v2 1/4] ixgbe: no need for ipsec csum feature check

With the patch commit f8aa2696b4af ("esp: check the NETIF_F_HW_ESP_TX_CSUM bit before segmenting") we no longer need to protect ourself from checksum offload requests on IPsec packets, so we can remove the check in our .ndo_features_check callback. Signed-off-by: Shannon Nelson &l

[next-queue v2 0/4] ixgbe: Enable tso and checksum offload with ipsec

This patchset fixes up the bits for supporting TSO and checksum offload in conjunction with IPsec offload. This brings the throughput of a simple iperf test back up to nearly line rate. v2: fixes in patch 4 from Alex's comments Shannon Nelson (4): ixgbe: no need for ipsec csum feature check

[next-queue v2 2/4] ixgbe: remove unneeded ipsec test in TX path

Since the ipsec data fields will be zero anyway in the non-ipsec case, we can remove the conditional jump. Suggested-by: Alexander Duyck <alexander.du...@gmail.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++

Re: [PATCH v2 06/15] ice: Initialize PF and setup miscellaneous interrupt

as the "other interrupt causes" (OIC) handler and is used to handle non hotpath interrupts (like control queue events, link events, exceptions, etc. 3) Implement a background task to process admin queue receive (ARQ) events received by the driver. CC: Shannon Nelson &l

Re: [PATCH v2 04/15] ice: Get switch config, scheduler config and device capabilities

Nelson <shannon.nel...@oracle.com> Signed-off-by: Anirudh Venkataramanan <anirudh.venkatarama...@intel.com> --- v2: Addressed Shannon Nelson's review comment by changing retry count value to 2. The fix looks fine. sln Acked-by: Shannon Nelson <shannon.nel...@oracle.com>

Re: [PATCH v2 07/15] ice: Add support for VSI allocation and deallocation

p. If the VSI can't get a contiguous queue allocation, it will fallback to scatter. This is implemented in ice_vsi_get_qs which is called as part of the VSI setup flow. In the release flow, the VSI's queues are released and the bitmap is updated to reflect this by ice_vsi_put_qs. CC: Shan

Re: [PATCH v2 03/15] ice: Start hardware initialization

config and transition the device to non-PXE mode. 3) Get the NVM configuration stored in the device's non-volatile memory (NVM) using ice_init_nvm. CC: Shannon Nelson <shannon.nel...@oracle.com> Signed-off-by: Anirudh Venkataramanan <anirudh.venkatarama...@intel.com> --- v

Re: [Intel-wired-lan] [next-queue 4/4] ixgbe: enable tso with ipsec offload

On 3/15/2018 3:03 PM, Alexander Duyck wrote: On Thu, Mar 15, 2018 at 2:23 PM, Shannon Nelson <shannon.nel...@oracle.com> wrote: Fix things up to support TSO offload in conjunction with IPsec hw offload. This raises throughput with IPsec offload on to nearly line rate. Signed-off-by: S

[next-queue 4/4] ixgbe: enable tso with ipsec offload

Fix things up to support TSO offload in conjunction with IPsec hw offload. This raises throughput with IPsec offload on to nearly line rate. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 7 +-- drivers/net/ethernet

[next-queue 0/4] ixgbe: Enable tso and checksum offload with ipsec

This patchset fixes up the bits for supporting TSO and checksum offload in conjunction with IPsec offload. This brings the throughput of a simple iperf test back up to nearly line rate. Shannon Nelson (4): ixgbe: no need for ipsec csum feature check ixgbe: remove unneeded ipsec test in Tx

[next-queue 3/4] ixgbe: no need for esp trailer if gso

There is no need to calculate the trailer length if we're doing a GSO/TSO, as there is no trailer added to the packet data. Also, don't bother clearing the flags field as it was already cleared earlier. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet

[next-queue 2/4] ixgbe: remove unneeded ipsec test in TX path

Since the ipsec data fields will be zero anyway in the non-ipsec case, we can remove the conditional jump. Suggested-by: Alexander Duyck <alexander.du...@gmail.com> Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 ++

[next-queue 1/4] ixgbe: no need for ipsec csum feature check

With the patch commit f8aa2696b4af ("esp: check the NETIF_F_HW_ESP_TX_CSUM bit before segmenting") we no longer need to protect ourself from checksum offload requests on IPsec packets, so we can remove the check in our .ndo_features_check callback. Signed-off-by: Shannon Nelson &l

Re: [Intel-wired-lan] [PATCH 03/15] ice: Start hardware initialization

On 3/14/2018 3:05 PM, Venkataramanan, Anirudh wrote: On Mon, 2018-03-12 at 19:05 -0700, Shannon Nelson wrote: On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: + +/** + * ice_read_sr_aq - Read Shadow RAM. + * @hw: pointer to the HW structure + * @offset: offset in words from module start

Re: [Intel-wired-lan] [PATCH 07/15] ice: Add support for VSI allocation and deallocation

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch introduces data structures and functions to alloc/free VSIs. The driver represents a VSI using the ice_vsi structure. Some noteworthy points about VSI allocation: 1) A VSI is allocated in the firmware using the "add VSI" admin queue

Re: [Intel-wired-lan] [PATCH 04/15] ice: Get switch config, scheduler config and device capabilities

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch adds to the initialization flow by getting switch configuration, scheduler configuration and device capabilities. Switch configuration: On boot, an L2 switch element is created in the firmware per physical function. Each physical

Re: [Intel-wired-lan] [PATCH 06/15] ice: Initialize PF and setup miscellaneous interrupt

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch continues the initialization flow as follows: 1) Allocate and initialize necessary fields (like vsi, num_alloc_vsi, irq_tracker, etc) in the ice_pf instance. 2) Setup the miscellaneous interrupt handler. This also known as the

Re: [Intel-wired-lan] [PATCH 02/15] ice: Add support for control queues

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: A control queue is a hardware interface which is used by the driver to interact with other subsystems (like firmware, PHY, etc.). It is implemented as a producer-consumer ring. More specifically, an "admin queue" is a type of control queue used

Re: [Intel-wired-lan] [PATCH 03/15] ice: Start hardware initialization

On 3/9/2018 9:21 AM, Anirudh Venkataramanan wrote: This patch implements multiple pieces of the initialization flow as follows: 1) A reset is issued to ensure a clean device state, followed by initialization of admin queue interface. 2) Once the admin queue interface is up, clear the PF

[PATCH net] macvlan: filter out unsupported feature flags

d crop up in the future with any other new feature flags, so let's filter out any flags that aren't defined as supported in macvlan. Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") Reported-by: Alexey Kodanev <alexey.koda...@oracle.com> Signed-off-by: Shann

Re: [PATCH net] macvlan: filter out xfrm feature flags

On 3/8/2018 9:33 AM, David Miller wrote: From: Shannon Nelson <shannon.nel...@oracle.com> Date: Tue, 6 Mar 2018 14:57:08 -0800 This isn't broken for vlans because they use a separate features connection (vlan_features) for inheriting features. This is fine, but I don't think trying

[PATCH net] macvlan: filter out xfrm feature flags

every driver for every new upperdev is a good idea - I think the upperdev should try to protect itself. Fixes: d77e38e612a0 ("xfrm: Add an IPsec hardware offloading API") Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/macvlan.c | 6 +- 1 file chang

Re: [PATCH v2 0/4] GSO_BY_FRAGS correctness improvements

From: Daniel Axtens Date: Wed, Feb 28, 2018 at 10:13 PM As requested [1], I went through and had a look at users of gso_size to see if there were things that need to be fixed to consider GSO_BY_FRAGS, and I have tried to improve our helper functions to deal with this case. I

[PATCH ipsec-next] esp: check the NETIF_F_HW_ESP_TX_CSUM bit before segmenting

If I understand correctly, we should not be asking for a checksum offload on an ipsec packet if the netdev isn't advertising NETIF_F_HW_ESP_TX_CSUM. In that case, we should clear the NETIF_F_CSUM_MASK bits. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- net/ipv4/esp4_off

[PATCH next-queue 3/3] ixgbe: remove unneeded ipsec state free callback

With commit 7f05b467a735 ("xfrm: check for xdo_dev_state_free") we no longer need to add an empty callback function to the driver, so now let's remove the useless code. Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ix

[PATCH next-queue 2/3] ixgbe: fix ipsec trailer length

later we can put it into the Tx descriptor to tell the device where to stop the checksum calculation. Fixes: 592594704761 ("ixgbe: process the Tx ipsec offload") Signed-off-by: Shannon Nelson <shannon.nel...@oracle.com> --- drivers/net/ethernet/intel/ixgbe/ix

[PATCH next-queue 0/3] ixgbe: ipsec fixups

These are a couple of updates for the ixgbe IPsec offload support. Shannon Nelson (3): ixgbe: check for 128-bit authentication ixgbe: fix ipsec trailer length ixgbe: remove unneeded ipsec state free callback drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 53

  1   2   3   4   >