Re: selftests/bpf: test_kmod.sh hangs on all devices

Hi Naresh, Please use sh...@kernel.org for faster responses. I updated MAINTAINERS entry a while back removing shua...@osg.samsung.com address due to IT infrastructure changes at Samsung. On 10/08/2018 08:55 AM, Naresh Kamboju wrote: > Daniel, > > On Mon, 8 Oct 2018 at 18:58, Daniel Borkmann

Re: [PATCH v4] selftests: add headers_install to lib.mk

On 07/23/2018 02:49 PM, Anders Roxell wrote: > On Thu, 7 Jun 2018 at 13:09, Anders Roxell wrote: >> >> If the kernel headers aren't installed we can't build all the tests. >> Add a new make target rule 'khdr' in the file lib.mk to generate the >> kernel headers and that gets include for every

Re: [PATCH bpf-next 0/5] fix test_sockmap

On 05/18/2018 01:17 AM, Prashant Bhole wrote: > This series fixes bugs in test_sockmap code. They weren't caught > previously because failure in RX/TX thread was not notified to the > main thread. > > Also fixed data verification logic and slightly improved test output > such that parameters

[PATCH 24/24] selftests: net: return Kselftest Skip code for skipped tests

message, instead of failing the test when /sys/power/state file open fails. Signed-off-by: Shuah Khan (Samsung OSG) <sh...@kernel.org> --- tools/testing/selftests/net/fib_tests.sh| 8 +--- tools/testing/selftests/net/netdevice.sh| 16 +-- tools/testing/selftests/net/p

Re: [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support

On 03/07/2018 11:25 AM, David Miller wrote: > From: Anders Roxell > Date: Tue, 6 Mar 2018 16:10:04 +0100 > >> The reuseport_bpf_numa test case fails there's no numa support. The >> test shouldn't fail if there's no support it should be skipped with a >> pass. >> >>

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

On 02/21/2018 05:33 PM, Daniel Borkmann wrote: > Hi Shuah, > > On 02/22/2018 12:03 AM, Shuah Khan wrote: >> On 02/21/2018 03:48 PM, David Miller wrote: >>> From: Anders Roxell <anders.rox...@linaro.org> >>> Date: Wed, 21 Feb 2018 22:30:01 +0100 >>>

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

On 02/21/2018 03:48 PM, David Miller wrote: > From: Anders Roxell > Date: Wed, 21 Feb 2018 22:30:01 +0100 > >> bpf builds a test program for loading BPF ELF files. Add the executable >> to the .gitignore list. >> >> Signed-off-by: Anders Roxell

[PATCH] selftests: bpf: update .gitignore with missing generated files

Update .gitignore with missing generated files. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- tools/testing/selftests/bpf/.gitignore | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore

Re: [PATCH v3 2/2] selftests: bpf: test_kmod.sh: use modprobe on target device

On 11/07/2017 09:35 AM, naresh.kamb...@linaro.org wrote: > From: Naresh Kamboju Odd to see this From: line in the patch. Could you take a look and see where this is coming from? Your gitconfig perhaps. I have to fix this up when I apply the patch which I would like to

Re: [PATCH v3 1/2] selftests: bpf: test_kmod.sh: check the module path before insmod

On 11/07/2017 09:35 AM, naresh.kamb...@linaro.org wrote: > From: Naresh Kamboju Odd to see this From: line in the patch. Could you take a look and see where this is coming from? Your gitconfig perhaps. I have to fix this up when I apply the patch which I would like to

Re: [PATCH v2 1/2] selftests: bpf: test_kmod.sh: check if module is present in the path before insert

On 11/06/2017 08:23 AM, Naresh Kamboju wrote: > On 7 September 2017 at 14:46, Daniel Borkmann wrote: >> On 09/07/2017 10:19 AM, naresh.kamb...@linaro.org wrote: >>> >>> From: Naresh Kamboju >>> >>> The test script works when kernel source and

Re: [PATCH 3/3][v2] selftests: silence test output by default

On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > Some of the networking tests are very noisy and make it impossible to > see if we actually passed the tests as they run. Default to suppressing > the output from any tests run in order to make it easier

Re: [PATCH 2/3][v2] selftests: actually run the various net selftests

On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > These self tests are just self contained binaries, they are not run by > any of the scripts in the directory. This means they need to be marked > with TEST_GEN_PROGS to actually be run, not

Re: [PATCH 1/3][v2] selftest: add a reuseaddr test

On 09/19/2017 07:51 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > This is to test for a regression introduced by > > b9470c27607b ("inet: kill smallest_size and smallest_port") > > which introduced a problem with reuseaddr and bind conflicts. > > Signed-off-by: Josef

Re: [PATCH 2/3] selftests: actually run the various net selftests

On 09/19/2017 12:14 PM, Willem de Bruijn wrote: > On Tue, Sep 19, 2017 at 9:34 AM, Josef Bacik <jo...@toxicpanda.com> wrote: >> On Mon, Sep 18, 2017 at 04:14:41PM -0600, Shuah Khan wrote: >>> On 09/18/2017 11:32 AM, jo...@toxicpanda.com wrote: >>>&

Re: [PATCH 2/3] selftests: actually run the various net selftests

On 09/18/2017 11:32 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > These self tests are just self contained binaries, they are not run by > any of the scripts in the directory. This means they need to be marked > with TEST_GEN_PROGS to actually be run, not

Re: [PATCH 3/3] selftests: silence test output by default

On 09/18/2017 02:19 PM, Josef Bacik wrote: > On Mon, Sep 18, 2017 at 01:48:31PM -0600, Shuah Khan wrote: >> On 09/18/2017 12:24 PM, Josef Bacik wrote: >>> On Mon, Sep 18, 2017 at 12:13:40PM -0600, Shuah Khan wrote: >>>> On 09/18/2017 11:52 AM, Josef Bacik wrote: >&

Re: [PATCH 3/3] selftests: silence test output by default

On 09/18/2017 12:24 PM, Josef Bacik wrote: > On Mon, Sep 18, 2017 at 12:13:40PM -0600, Shuah Khan wrote: >> On 09/18/2017 11:52 AM, Josef Bacik wrote: >>> On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shuah Khan wrote: >>>> On 09/18/2017 11:37 AM, jo...@toxicpanda.com

Re: [PATCH 3/3] selftests: silence test output by default

On 09/18/2017 11:52 AM, Josef Bacik wrote: > On Mon, Sep 18, 2017 at 11:46:18AM -0600, Shuah Khan wrote: >> On 09/18/2017 11:37 AM, jo...@toxicpanda.com wrote: >>> From: Josef Bacik <jba...@fb.com> >>> >>> Some of the networking tests are very noisy and ma

Re: [PATCH 3/3] selftests: silence test output by default

On 09/18/2017 11:37 AM, jo...@toxicpanda.com wrote: > From: Josef Bacik > > Some of the networking tests are very noisy and make it impossible to > see if we actually passed the tests as they run. Default to suppressing > the output from any tests run in order to make it easier

Re: selftests/bpf doesn't compile

t;>>>> On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: >>>>>> Is bpf test intended to be run in kselftest run? The clang dependency >>>>>> might >>>>>> not be met on majority of the systems. Is this a hard dependency??

Re: selftests/bpf doesn't compile

On 09/15/2017 12:14 PM, Alexei Starovoitov wrote: > On Fri, Sep 15, 2017 at 11:00:31AM -0600, Shuah Khan wrote: >>>> I could add a special target for bpf TARGET_BPF perhaps and exclude it from >>>> the run_test> >>> I'm not sure what was the motivation to ex

Re: selftests/bpf doesn't compile

On 09/15/2017 11:00 AM, Shuah Khan wrote: > On 09/15/2017 10:02 AM, Alexei Starovoitov wrote: >> On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: >>> Hi Alexei and Daniel, >>> >>> bpf test depend

Re: selftests/bpf doesn't compile

On 09/15/2017 10:02 AM, Alexei Starovoitov wrote: > On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: >> Hi Alexei and Daniel, >> >> bpf test depends on clang and fails to compile when >> >> -- >&

selftests/bpf doesn't compile

Hi Alexei and Daniel, bpf test depends on clang and fails to compile when -- make -C tools/testing/selftests/bpf run_tests make: clang: Command not found Makefile:39: recipe for target

Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

steen" -> "listen" >> >> thanks to Daniel Borkmann for spotting one of these mistakes >> >> Signed-off-by: Colin Ian King <colin.k...@canonical.com> > > Acked-by: Daniel Borkmann <dan...@iogearbox.net> > > I can get this into 4

Re: [PATCH net-next v7 01/10] selftest: Enhance kselftest_harness.h with a step mechanism

gikod.net> >>>> Cc: Andy Lutomirski <l...@amacapital.net> >>>> Cc: Arnaldo Carvalho de Melo <a...@kernel.org> >>>> Cc: Kees Cook <keesc...@chromium.org> >>>> Cc: Shuah Khan <sh...@kernel.org> >>>> Cc: Will Drewr

Re: [PATCH v2 net] selftests/bpf: fix broken build, take 2

uild"), thanks for fixing Zi! >> >> Acked-by: Daniel Borkmann <dan...@iogearbox.net> >> Tested-by: Daniel Borkmann <dan...@iogearbox.net> > > worked for me as well: > Acked-by: Alexei Starovoitov <a...@kernel.org> > Tested-by: Alexei Starovoitov <a...@kernel.org> > > > David, Could you please apply it to your tree. I think you already applied the first fix. Acked-by: Shuah Khan <shua...@osg.samsung.com> thanks, -- Shuah

Re: linux-next: manual merge of the kselftest tree with the net-next tree

On 02/15/2017 08:24 PM, Stephen Rothwell wrote: > Hi Shuah, > > Today's linux-next merge of the kselftest tree got a conflict in: > > tools/testing/selftests/bpf/Makefile > > between commit: > > d498f8719a09 ("bpf: Rebuild bpf.o for any dependency update") > > from the net-next tree and

Re: linux-next: manual merge of the kselftest tree with the net-next tree

On 01/23/2017 09:45 PM, Stephen Rothwell wrote: > Hi Shuah, > > Today's linux-next merge of the kselftest tree got a conflict in: > > tools/testing/selftests/bpf/Makefile > > between commit: > > 4d3381f5a322 ("bpf: Add tests for the lpm trie map") > > from the net-next tree and commit: >

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

On 01/05/2017 08:54 AM, Sowmini Varadhan wrote: > On (01/04/17 16:26), Shuah Khan wrote: >> >> Could you please split this patch into two. Hardening part in one and >> the cleanup in a separate patch. This way I can get the hardening fix >> into 4.10 in my next Kselftes

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

On 01/04/2017 03:55 PM, Sowmini Varadhan wrote: > On (01/04/17 15:37), Shuah Khan wrote: >>> + /* the filter below checks for all of the following conditions that >>> +* are based on the contents of create_payload() >>> +* ether type 0x80

Re: [PATCH v3 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

acros to make it more readable. > > Signed-off-by: Sowmini Varadhan <sowmini.varad...@oracle.com> > Acked-by: Willem de Bruijn <will...@google.com> > --- > v2: commit comment edited based on Willem de Bruijn review > v3: Shuah Khan nit. > > tools/testing/selftests/net/p

Re: [PATCH v2 net-next 1/2] tools: psock_lib: tighten conditions checked in sock_setfilter

Hi Sowmini, Thanks for the patch. On 01/04/2017 10:33 AM, Sowmini Varadhan wrote: > The bpf_prog used in sock_setfilter() only attempts to check for > ip pktlen, and verifies that the contents of the 80'th packet in > the ethernet frame is 'a' or 'b'. Thus many non-udp packets > could

Re: [PATCH 2/3] selftests: do not require bash to run bpf tests

On 12/14/2016 04:03 AM, Daniel Borkmann wrote: > On 12/14/2016 11:58 AM, Rolf Eike Beer wrote: >> From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001 >> From: Rolf Eike Beer >> Date: Wed, 14 Dec 2016 09:58:12 +0100 >> Subject: [PATCH 2/3] selftests: do

[PATCH] net/netfilter: Fix use uninitialized warn in nft_range_eval()

-by: Shuah Khan <shua...@osg.samsung.com> --- net/netfilter/nft_range.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nft_range.c b/net/netfilter/nft_range.c index c6d5358..fe5f69b 100644 --- a/net/netfilter/nft_range.c +++ b/net/netfilter/nft_range.c @@ -28,7

Re: [PATCH v2 6/6] selftests: move watchdog tests from Documentation/watchdog

On 09/13/2016 02:33 PM, Timur Tabi wrote: > Shuah Khan wrote: >> Remove watchdog-test from Makefile to move the test to selftests. >> >> Add Makefile and .gitignore to for watchdog-test. watchdog-test will > > to for? Thanks - will fix that. > >> n

[PATCH v2 4/6] selftests: move vDSO tests from Documentation/vDSO

Remove vDSO from Makefile to move the to selftests. Update vDSO Makefile to work under selftests. vDSO will not be run as part of selftests suite and will not be included in install targets. They can be built separately for now. Signed-off-by: Shuah Khan <shua...@osg.samsung.

[PATCH v2 1/6] selftests: move dnotify_test from Documentation/filesystems

and will not be included in install targets. It can be built separately for now. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/Makefile | 2 +- Documentation/filesystems/.gitignore | 1 - Documentation/filesystems/Ma

[PATCH v2 5/6] selftests: move ia64 tests from Documentation/ia64

and this update doesn't change that. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/Makefile | 2 +- Documentation/ia64/.gitignore| 1 - Documentation/ia64/Makefile | 5 - Documentation/ia64/aliasing-

[PATCH v2 6/6] selftests: move watchdog tests from Documentation/watchdog

Remove watchdog-test from Makefile to move the test to selftests. Add Makefile and .gitignore to for watchdog-test. watchdog-test will not be run as part of selftests suite and will not be included in install targets. It can be built separately for now. Signed-off-by: Shuah Khan <s

[PATCH v2 0/6] Move runnable code (tests) from Documentation to selftests

and people that responded with comments and ideas. - Included ia64 and watchdog which I missed in the v1 series. Shuah Khan (6): selftests: move dnotify_test from Documentation/filesystems selftests: move prctl tests from Documentation/prctl selftests: move ptp tests from Documentation/ptp

[PATCH v2 2/6] selftests: move prctl tests from Documentation/prctl

-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/Makefile | 2 +- Documentation/prctl/.gitignore | 3 - Documentation/prctl/Makefile | 10 --- .../prctl/disable-tsc-ctxt-sw-stress-test.c

[PATCH v2 3/6] selftests: move ptp tests from Documentation/ptp

Remove ptp from Makefile to move the test to selftests. Update ptp Makefile to work under selftests. ptp will not be run as part of selftests suite and will not be included in install targets. They can be built separately for now. Signed-off-by: Shuah Khan <shua...@osg.samsung.

Re: [PATCH 0/9] Move runnable code (tests) from Documentation to selftests

On 09/13/2016 03:20 AM, Jani Nikula wrote: > On Sat, 10 Sep 2016, Jonathan Corbet <cor...@lwn.net> wrote: >> On Fri, 9 Sep 2016 16:22:41 -0600 >> Shuah Khan <shua...@osg.samsung.com> wrote: >> >>> Move runnable code (tests) from Documentation to selfte

Re: [PATCH 2/9] selftests: update filesystems Makefile to work under selftests

On 09/13/2016 05:56 AM, Michael Ellerman wrote: > Shuah Khan <shua...@osg.samsung.com> writes: > >> Update to work under selftests. dnotify_test will not be run as part of >> selftests suite and will not included in install targets. It can be built >> separa

[PATCH 5/9] selftests: Update prctl Makefile to work under selftests

Update prctl Makefile to work under selftests. prctl will not be run as part of selftests suite and will not included in install targets. They can be built separately for now. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- tools/testing/selftests/prctl/Makefil

[PATCH 0/9] Move runnable code (tests) from Documentation to selftests

patch series that will address those. Shuah Khan (9): selftests: move dnotify_test from Documentation/filesystems selftests: update filesystems Makefile to work under selftests selftests: move .gitignore from Documentation/filesystems selftests: move prctl tests from Documentation/prctl

[PATCH 3/9] selftests: move .gitignore from Documentation/filesystems

Move .gitignore for dnotify_test from Documentation/filesystems to selftests/filesystems. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/filesystems/.gitignore | 1 - tools/testing/selftests/filesystems/.gitignore | 1 + 2 files changed, 1 insertion

[PATCH 4/9] selftests: move prctl tests from Documentation/prctl

Move prctl tests from Documentation/prctl to selftests/prctl. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/prctl/.gitignore | 3 - Documentation/prctl/Makefile | 10 --- .../prctl/disable-tsc-ctxt-sw-stress-test.c

[PATCH 7/9] selftests: Update ptp Makefile to work under selftests

Update ptp Makefile to work under selftests. ptp will not be run as part of selftests suite and will not included in install targets. They can be built separately for now. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- tools/testing/selftests/ptp/Makefile | 12 ++--

[PATCH 2/9] selftests: update filesystems Makefile to work under selftests

Update to work under selftests. dnotify_test will not be run as part of selftests suite and will not included in install targets. It can be built separately for now. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- tools/testing/selftests/filesystems/Makefile | 10 ++

[PATCH 1/9] selftests: move dnotify_test from Documentation/filesystems

Move dnotify_test from Documentation/filesystems to selftests/filesystems Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/filesystems/Makefile | 5 Documentation/filesystems/dnotify_test.c | 34 -- tools/testing/sel

[PATCH 9/9] selftests: Update vDSO Makefile to work under selftests

Update vDSO Makefile to work under selftests. vDSO will not be run as part of selftests suite and will not included in install targets. They can be built separately for now. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- tools/testing/selftests/vDSO/Makefil

[PATCH 6/9] selftests: move ptp tests from Documentation/ptp

Move ptp tests from Documentation/ptp to selftests/ptp. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/ptp/.gitignore | 1 - Documentation/ptp/Makefile | 8 - Documentation/ptp/testptp.c

[PATCH 8/9] selftests: move vDSO tests from Documentation/vDSO

Move vDSO tests from Documentation/vDSO to selftests/vDSO. Signed-off-by: Shuah Khan <shua...@osg.samsung.com> --- Documentation/vDSO/.gitignore | 2 - Documentation/vDSO/Makefile| 17 -- Documentation/vDSO/parse_vdso.c

Re: [PATCH net-next] sxgbe: remove unused code

ne SR_PCS_MMD_CONTROL1 0x03 > -#define SR_PCS_CONTROL2 0x030007 > -#define VR_PCS_MMD_XAUI_MODE_CONTROL 0x038004 > -#define VR_PCS_MMD_DIGITAL_STATUS0x038010 > -#define SR_MII_MMD_CONTROL 0x1F > -#define SR_MII_MMD_AN_ADV

Re: question about samsung/sxgbe/sxgbe_xpcs.c

till > net-next opens up again? > My second attempt to locate the author for a comment on this before it gets removed. Maybe this code could be fixed just in case it is important for some product out there. I am cc'ing the original author in case he has any comments. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com | (970) 217-8978