Subject: Re: [PATCH 1/1] qlcnic: add wmb() call in transmit data path.
>
>> +/* Ensure writes are complete before HW fetches Tx descriptors */
>> +wmb();
>> qlcnic_update_cmd_producer(tx_ring);
>>
>> return NETDEV_TX_OK;
>>
>
> Would not an mmiowb be more appropriate in this
0001-qlcnic-add-wmb-call-in-transmit-data-path.patch
This patch adds a wmb() call in the Tx data path to ensure
writes are completed before hardware fetches updated Tx descriptors.
Please apply to net.
Thanks,
Sony
Call wmb() to ensure writes are complete before
hardware fetches updated Tx descriptors.
Signed-off-by: Sony Chacko <sony.cha...@qlogic.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/
qlogic/qlcnic/qlcnic.h
> @@ -1092,7 +1092,7 @@ struct qlcnic_filter_hash { struct qlcnic_mailbox {
> struct workqueue_struct *work_q;
> struct qlcnic_adapter *adapter;
> - struct qlcnic_mbx_ops *ops;
> + const struct qlcnic_mbx_ops *ops;
> struct work_struct
Sony,
I also sent this patch and was wondering if I can get a reply on it.
From 4a607447562bec161fd947caae5eb02c2365c58a Mon Sep
17 00:00:00 2001
From: Nicholas Krause xerofo...@gmail.com
Date: Wed, 8 Jul 2015 08:29:07 -0400
Subject: [PATCH] bnx2i:Fix backwards locking scenario in the
-Original Message-
From: Nicholas Krause [mailto:xerofo...@gmail.com]
Sent: Wednesday, July 08, 2015 11:31 AM
To: Sony Chacko
Cc: Dept-GE Linux NIC Dev; netdev; linux-kernel
Subject: [PATCH] bnx2:Make various functions to have a return
type of void in the file bnx2.c
This makes
)
+ bnx2x_stop_ptp(bp);
/* Disable HW interrupts, NAPI */
bnx2x_netif_stop(bp, 1);
Acked-by: Sony Chacko sony.cha...@qlogic.com
Thanks.
