24.03.2017 17:39, Maxime Morin пишет:
I did a "git bisect" to find when the regression was introduced, because it
previously worked with kernel 4.4, but not with the recent ones. The commit that made
appear the issue is this one:
23.03.2017 14:30, Maxime Morin пишет:
Hi,
Thank you very much for your help and your reactivity! See my answer bellow:
22.03.2017 16:23, Maxime Morin пишет:
Hi all,
I work on an embedded platform based on the Marvell Armada 88F6707, that is
connected to a Marvell Alaska 88E1512 ethernet
22.03.2017 16:23, Maxime Morin пишет:
Hi all,
I work on an embedded platform based on the Marvell Armada 88F6707, that is
connected to a Marvell Alaska 88E1512 ethernet transceiver. A defect has
appeared recently, and it turns out to be a regression on the network part.
There is a complete
22.03.2017 16:23, Maxime Morin пишет:
Hi all,
I work on an embedded platform based on the Marvell Armada 88F6707, that is
connected to a Marvell Alaska 88E1512 ethernet transceiver. A defect has
appeared recently, and it turns out to be a regression on the network part.
There is a complete
04.01.2016 04:05, Sowmini Varadhan пишет:
On (12/30/15 15:42), Stas Sergeev wrote:
29.12.2015 18:22, Sowmini Varadhan пишет:
Do you have admin control over the ubuntu router?
If yes, you might want to check the shared_media [#] setting
on that router for the interfaces with overlapping subnets
04.01.2016 04:05, Sowmini Varadhan пишет:
On (12/30/15 15:42), Stas Sergeev wrote:
29.12.2015 18:22, Sowmini Varadhan пишет:
Do you have admin control over the ubuntu router?
If yes, you might want to check the shared_media [#] setting
on that router for the interfaces with overlapping subnets
29.12.2015 18:22, Sowmini Varadhan пишет:
> Do you have admin control over the ubuntu router?
> If yes, you might want to check the shared_media [#] setting
> on that router for the interfaces with overlapping subnets.
> (it is on by default, I would try turning it off).
That didn't help, problem
29.12.2015 18:38, Stas Sergeev пишет:
> Likely the router's side is doing the right thing, but of
Or maybe not?
Here's the ifconfig of router:
eth0 Link encap:Ethernet HWaddr 00:1e:8c:a7:b5:36
inet addr:192.168.0.220 Bcast:192.168.3.255 Mask:255.255.252.0
eth0:1L
29.12.2015 18:22, Sowmini Varadhan пишет:
> Do you have admin control over the ubuntu router?
> If yes, you might want to check the shared_media [#] setting
> on that router for the interfaces with overlapping subnets.
> (it is on by default, I would try turning it off).
Ahha, good catch, thanks!
29.12.2015 15:32, Sowmini Varadhan пишет:
> On (12/29/15 15:06), Stas Sergeev wrote:
>> Router on 192.168.8.1 is just a PC with ubuntu, w/o any special
>> software. I'd be very surprised if it does so. As I understand,
>> linux would accept such ICMP redirect only from th
29.12.2015 13:54, Stas Sergeev пишет:
> Hello.
>
> I was hitting a strange problem when some internet hosts
> suddenly stops responding until I reboot. ping to these
> host gives "Destination Host Unreachable". After the
> initial confusion, I've finally got to
> i
Hello.
I was hitting a strange problem when some internet hosts
suddenly stops responding until I reboot. ping to these
host gives "Destination Host Unreachable". After the
initial confusion, I've finally got to
ip route get
and got something quite strange.
Example for GOOD address (the one
29.12.2015 14:58, Sowmini Varadhan пишет:
> On (12/29/15 13:54), Stas Sergeev wrote:
>>
>> ip route get 91.189.89.238
>> 91.189.89.238 via 192.168.0.1 dev eth0 src 192.168.10.202
>> cache
> :
>> Now, 192.168.0.1 is also a valid gateway, but
ethernet switches, the ones that support the in-band
status and the ones that not.
CC: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
CC: netdev@vger.kernel.org
CC: linux-ker...@vger.kernel.org
Signed-off-by: Stas Sergeev <s...@users.sourceforge.net>
---
drivers/net/ethe
This moves autoneg-related bit manipulations to the single place.
CC: Thomas Petazzoni <thomas.petazz...@free-electrons.com>
CC: netdev@vger.kernel.org
CC: linux-ker...@vger.kernel.org
Signed-off-by: Stas Sergeev <s...@users.sourceforge.net>
---
drivers/net/ethernet/marvell/m
These 2 patches add an ability to control the
autonegotiation via ethtool. For example:
ethtool -s eth0 autoneg off
ethtool -s eth0 autoneg on
This is needed if you want to connect the mvneta's MII
to different switches or PHYs: the ones the do support
the in-band status, and the ones that do
18.09.2015 20:30, Florian Fainelli пишет:
On 18/09/15 10:22, Russell King - ARM Linux wrote:
On Fri, Sep 18, 2015 at 07:04:09PM +0300, Stas Sergeev wrote:
18.09.2015 18:43, Russell King - ARM Linux пишет:
On Fri, Sep 18, 2015 at 05:45:27PM +0300, Stas Sergeev wrote:
AFAICS if it has
18.09.2015 02:14, Russell King - ARM Linux пишет:
> 3. Having DT specify a fixed-link with parameters along with in-band
>negotiation results in the fixed-link parameters being ignored.
>This means if a fixed-link DT declaration specifies a speed, that
>declaration will be ignored.
18.09.2015 15:13, Russell King - ARM Linux пишет:
> On Fri, Sep 18, 2015 at 02:29:34PM +0300, Stas Sergeev wrote:
>> 18.09.2015 02:14, Russell King - ARM Linux пишет:
>>> _But_ using the in-band status
>>>property fundamentally requires this for
18.09.2015 16:57, Russell King - ARM Linux пишет:
> On Fri, Sep 18, 2015 at 04:43:59PM +0300, Stas Sergeev wrote:
>> 18.09.2015 16:12, Russell King - ARM Linux пишет:
>>> On Fri, Sep 18, 2015 at 03:43:54PM +0300, Stas Sergeev wrote:
>>>> 18.09.2015 15:13,
18.09.2015 16:12, Russell King - ARM Linux пишет:
> On Fri, Sep 18, 2015 at 03:43:54PM +0300, Stas Sergeev wrote:
>> 18.09.2015 15:13, Russell King - ARM Linux пишет:
>>> On Fri, Sep 18, 2015 at 02:29:34PM +0300, Stas Sergeev wrote:
>>>> 18.09.2015 02:14,
18.09.2015 18:43, Russell King - ARM Linux пишет:
> On Fri, Sep 18, 2015 at 05:45:27PM +0300, Stas Sergeev wrote:
>> 18.09.2015 16:57, Russell King - ARM Linux пишет:
>>> On Fri, Sep 18, 2015 at 04:43:59PM +0300, Stas Sergeev wrote:
>>>> 18.09.2015 16:12,
14.09.2015 13:32, Russell King - ARM Linux пишет:
I've been bringing up the mainline kernel on a new board, which has
an Marvell SoC with a mvneta interface connected to a Marvell DSA
switch. The DSA switch is a 88E6176.
In the DT block for the interface, I specify:
ethernet@... {
31.08.2015 16:56, Andrew Lunn пишет:
> Changes since v1:
>
> Rewrite 9/9 so that it hopefully does not regression on
> 868a4215be9a6d80 ("net: phy: fixed_phy: handle link-down case")
>
> Stas, please could you test your use case.
This was actually not mine.
The change was fixing the regression
26.08.2015 17:58, Madalin Bucur пишет:
The fixed link values parsed from the device tree are stored in
the struct fixed_phy member status. The struct phy_device members
speed, duplex were not updated.
ACK, but IMHO it will make more sense if you include that
into your upcoming patch set rather
that,
Acked-by: Stas Sergeev s...@users.sourceforge.net
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
12.08.2015 16:26, Madalin-Cristian Bucur пишет:
I've tried to make the smallest changes that allow me to retrieve those
without modifying existing API.
Why is it important to hide the default values from the MAC driver?
My worry is that the fixed values are not really fixed, and
therefore are
12.08.2015 17:43, Madalin-Cristian Bucur пишет:
-Original Message-
From: Stas Sergeev [mailto:s...@list.ru]
12.08.2015 16:26, Madalin-Cristian Bucur пишет:
I've tried to make the smallest changes that allow me to retrieve those
without modifying existing API.
Why is it important
12.08.2015 18:27, Madalin-Cristian Bucur пишет:
Then I could call only of_* functions but the end result would be the same
and of_phy_register_fixed_phy() would not justify its existence that much...
You didn't say you wanted to obsolete the of_phy_register_fixed_phy().
Since it is there (and
08.08.2015 20:32, Florian Fainelli пишет:
CC'ing Stas,
Hi.
Le 08/05/15 07:42, Madalin Bucur a écrit :
The FMan MAC configuration code needs the speed and duplex information
for fixed-link interfaces that is parsed now by the of function
of_phy_register_fixed_link(). This parses the
11.08.2015 19:33, Madalin-Cristian Bucur пишет:
+ Joakim, Shaohui
-Original Message-
From: Stas Sergeev [mailto:s...@list.ru]
08.08.2015 20:32, Florian Fainelli пишет:
CC'ing Stas,
Hi.
Le 08/05/15 07:42, Madalin Bucur a écrit :
The FMan MAC configuration code needs the speed
21.07.2015 03:49, Florian Fainelli пишет:
Hi all,
Changes in v5:
- removed an invalid use of the link_update callback in the SF2 driver
was appeared after merging net: phy: fixed_phy: handle link-down case
Thanks for bringing this forward!
For the future, perhaps it will make sense to also
18.07.2015 05:29, Florian Fainelli пишет:
Le 07/17/15 16:53, Stas Sergeev a écrit :
18.07.2015 02:35, Florian Fainelli пишет:
On 17/07/15 16:24, Stas Sergeev wrote:
18.07.2015 01:01, Florian Fainelli пишет:
On 17/07/15 13:03, Stas Sergeev wrote:
17.07.2015 21:50, Florian Fainelli пишет
17.07.2015 02:25, Florian Fainelli пишет:
On 16/07/15 07:50, Stas Sergeev wrote:
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
It fixes the status registers when link is down, and also allows
to register the fixed
18.07.2015 01:01, Florian Fainelli пишет:
On 17/07/15 13:03, Stas Sergeev wrote:
17.07.2015 21:50, Florian Fainelli пишет:
On 17/07/15 04:26, Stas Sergeev wrote:
17.07.2015 02:25, Florian Fainelli пишет:
On 16/07/15 07:50, Stas Sergeev wrote:
Currently fixed_phy driver recognizes only
18.07.2015 02:35, Florian Fainelli пишет:
On 17/07/15 16:24, Stas Sergeev wrote:
18.07.2015 01:01, Florian Fainelli пишет:
On 17/07/15 13:03, Stas Sergeev wrote:
17.07.2015 21:50, Florian Fainelli пишет:
On 17/07/15 04:26, Stas Sergeev wrote:
17.07.2015 02:25, Florian Fainelli пишет:
On 16
17.07.2015 21:50, Florian Fainelli пишет:
On 17/07/15 04:26, Stas Sergeev wrote:
17.07.2015 02:25, Florian Fainelli пишет:
On 16/07/15 07:50, Stas Sergeev wrote:
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
It fixes
Hello.
Currently the link status auto-negotiation is enabled
for any SGMII link with fixed-link DT binding.
The regression was reported:
https://lkml.org/lkml/2015/7/8/865
Apparently not all HW that implements SGMII protocol, generates the
inband status for the auto-negotiation to work.
More
anything with such HW.
This patch enables the auto-negotiation only if explicitly requested with
the 'managed' DT property.
This patch fixes the following regression:
https://lkml.org/lkml/2015/7/8/865
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Thomas Petazzoni thomas.petazz
or nothing, depending on the presence
of the fixed-link node
in-band-status - use in-band status
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Rob Herring robh...@kernel.org
CC: Pawel Moll pawel.m...@arm.com
CC: Mark Rutland mark.rutl...@arm.com
CC: Ian Campbell ijc+devicet
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
It fixes the status registers when link is down, and also allows
to register the fixed-phy with link down without specifying the speed.
Signed-off-by: Stas Sergeev s
Hello.
Currently the link status auto-negotiation is enabled
for any SGMII link with fixed-link DT binding.
The regression was reported:
https://lkml.org/lkml/2015/7/8/865
Apparently not all HW that implements SGMII protocol, generates the
inband status for the auto-negotiation to work.
More
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
It fixes the status registers when link is down, and also allows
to register the fixed-phy with link down without specifying the speed.
Signed-off-by: Stas Sergeev s
anything with such HW.
This patch enables the auto-negotiation only if explicitly requested with
the 'managed' DT property.
This patch fixes the following regression:
https://lkml.org/lkml/2015/7/8/865
and is therefore CCed to stable.
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC
or nothing, depending on the presence
of the fixed-link node
mdio - use MDIO
in-band-status - use in-band status
none - use fixed-link description
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Rob Herring robh...@kernel.org
CC: Pawel Moll pawel.m...@arm.com
CC: Mark Rutland mark.rutl
14.07.2015 20:51, Florian Fainelli пишет:
On 14/07/15 10:13, Stas Sergeev wrote:
Currently the PHY management type is selected by the MAC driver arbitrary.
The decision is based on the presence of the fixed-link node and on a
will of the driver's authors.
This caused a regression recently, when
13.07.2015 12:54, Sebastien Rannou пишет:
Hi Stas,
On Fri, 10 Jul 2015, Stas Sergeev wrote:
Those who were affected by the change, please send your Tested-by,
Thanks!
I also confirm that this version of the patch solves the issue:
Tested-by: Sebastien Rannou m...@sbrk.org
Thanks
11.07.2015 03:22, Florian Fainelli пишет:
On 10/07/15 14:02, Stas Sergeev wrote:
10.07.2015 23:39, Florian Fainelli пишет:
- in-band status is an implementation delail, and it is
specific to a particular protocols. If you request the
in-band status for some protocol that doesn't support
10.07.2015 11:46, Sebastien Rannou пишет:
On Fri, 10 Jul 2015, Stas Sergeev wrote:
10.07.2015 00:15, Florian Fainelli пишет:
Then, if the in-band status indication is not reliable (which really
should be completely understood),
Agree!
But this is not something I can help with.
Sebastien
Hello.
Currently the link status auto-negotiation is enabled
for any SGMII link with fixed-link DT binding.
The regression was reported:
https://lkml.org/lkml/2015/7/8/865
Apparently not all HW that implements SGMII protocol, generates the
inband status for the auto-negotiation to work.
More
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
The actual change is 1-line, the rest is an indentation.
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Florian Fainelli f.faine...@gmail.com
CC: netdev
to request the auto-negotiation explicitly.
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Rob Herring robh...@kernel.org
CC: Pawel Moll pawel.m...@arm.com
CC: Mark Rutland mark.rutl...@arm.com
CC: Ian Campbell ijc+devicet...@hellion.org.uk
CC: Kumar Gala ga...@codeaurora.org
CC: Florian
/865
and is therefore CCed to stable.
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Thomas Petazzoni thomas.petazz...@free-electrons.com
CC: netdev@vger.kernel.org
CC: linux-ker...@vger.kernel.org
CC: sta...@vger.kernel.org
---
drivers/net/ethernet/marvell/mvneta.c | 7 +++
1 file
10.07.2015 21:37, Florian Fainelli пишет:
On 10/07/15 09:43, Stas Sergeev wrote:
Currently for fixed-link the MAC driver decides whether to use the
link status auto-negotiation or not.
Unfortunately the auto-negotiation may not work when expected by
the MAC driver. Sebastien Rannou explains
10.07.2015 23:39, Florian Fainelli пишет:
- in-band status is an implementation delail, and it is
specific to a particular protocols. If you request the
in-band status for some protocol that doesn't support
it, perhaps you should get -EINVAL, because such a
config makes no sense. With
10.07.2015 23:44, Florian Fainelli пишет:
On 10/07/15 09:41, Stas Sergeev wrote:
Currently fixed_phy driver recognizes only the link-up state.
This simple patch adds an implementation of link-down state.
The actual change is 1-line, the rest is an indentation.
It is not clear to me how
10.07.2015 23:31, Florian Fainelli пишет:
On 10/07/15 09:38, Stas Sergeev wrote:
Hello.
Currently the link status auto-negotiation is enabled
for any SGMII link with fixed-link DT binding.
The regression was reported:
https://lkml.org/lkml/2015/7/8/865
Apparently not all HW that implements
,
that is built into some MII protocols, namely SGMII.
The appropriate documentation is added and explicitly states that
auto is very specific (protocol, HW and driver-specific), and
is therefore should be used with care.
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Rob Herring robh
and is therefore CCed to stable.
Signed-off-by: Stas Sergeev s...@users.sourceforge.net
CC: Thomas Petazzoni thomas.petazz...@free-electrons.com
CC: netdev@vger.kernel.org
CC: linux-ker...@vger.kernel.org
CC: sta...@vger.kernel.org
---
drivers/net/ethernet/marvell/mvneta.c | 6 +++---
1 file
09.07.2015 12:19, Thomas Petazzoni пишет:
Sebastien, Stas,
On Thu, 9 Jul 2015 11:03:26 +0200 (CEST), Sebastien Rannou wrote:
On Wed, 8 Jul 2015, Stas Sergeev wrote:
What is there? A phy chip, or something else?
It's something else, there's a phy which aggregates 4xSGMIIs to
1xQSGMII, we
09.07.2015 21:18, Florian Fainelli пишет:
On 09/07/15 10:41, Stas Sergeev wrote:
The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link state
signaling) implemented the link parameters auto-negotiation unconditionally.
Unfortunately it appears that some HW that implements SGMII
10.07.2015 00:14, Florian Fainelli пишет:
On 09/07/15 13:26, Stas Sergeev wrote:
09.07.2015 21:18, Florian Fainelli пишет:
On 09/07/15 10:41, Stas Sergeev wrote:
The commit 898b2970e2c9 (mvneta: implement SGMII-based in-band link
state
signaling) implemented the link parameters auto
09.07.2015 21:24, Florian Fainelli пишет:
(there is no such thing as linux-...@vger.kernel.org, please remove it
from your future submissions).
On 09/07/15 10:38, Stas Sergeev wrote:
Currently for fixed-link the link state is always set to UP.
Not quite true, this is always a driver decision
10.07.2015 00:15, Florian Fainelli пишет:
On 09/07/15 13:43, Stas Sergeev wrote:
09.07.2015 21:24, Florian Fainelli пишет:
(there is no such thing as linux-...@vger.kernel.org, please remove it
from your future submissions).
On 09/07/15 10:38, Stas Sergeev wrote:
Currently for fixed-link
08.07.2015 20:36, Greg Kroah-Hartman пишет:
On Wed, Jul 08, 2015 at 08:10:46PM +0300, Stas Sergeev wrote:
08.07.2015 10:35, Greg Kroah-Hartman пишет:
4.1-stable review patch. If anyone has any objections, please let me know.
--
From: Stas Sergeev s...@list.ru
[ Upstream
08.07.2015 10:35, Greg Kroah-Hartman пишет:
4.1-stable review patch. If anyone has any objections, please let me know.
--
From: Stas Sergeev s...@list.ru
[ Upstream commit 538761b794c1542f1c6e31eadd9d7aae118889f7 ]
The commit 898b2970e2c9 (mvneta: implement SGMII-based
08.07.2015 19:30, Sebastien Rannou пишет:
Hi Stas,
On Fri, 27 Mar 2015, Stas Sergeev wrote:
When MDIO bus is unavailable (common setup for SGMII), the in-band
signaling must be used to correctly track link state.
This patch enables the in-band status delivery and interrupts for
links state
08.07.2015 22:36, Arnaud Ebalard пишет:
Hi,
Stas Sergeev s...@list.ru writes:
Another problem was reported:
https://lkml.org/lkml/2015/7/8/865
So, while the above patch is correct and fixes what
it should, the original patch has more problems to deal
with. Maybe for stable it would be better
-off-by: Stas Sergeev s...@users.sourceforge.net
---
drivers/net/ethernet/marvell/mvneta.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/marvell/mvneta.c
b/drivers/net/ethernet/marvell/mvneta.c
index ce5f7f9..74176ec 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
17.06.2015 02:05, Arnaud Ebalard пишет:
But it seems the patch can still change a couple of flags
for you, and maybe that makes a problem?
AFAICT, autoneg config register (MVNETA_GMAC_AUTONEG_CONFIG) is
modified.
Or, else, prevented from being modified at a couple of
bits that were wrongly
70 matches
Mail list logo
