Re: [PATCH net-next 0/7] net/ipv6: Fix route append and replace use cases

2018-05-29 Thread Thomas Winter
to make it clear the default ioctl behaviour has changed. From: David Ahern Sent: 23 May 2018 08:44 To: David Miller; dsah...@kernel.org Cc: netdev@vger.kernel.org; Thomas Winter; ido...@mellanox.com; sha...@cumulusnetworks.com; ro...@cumulusnetworks.com

Re: [PATCH net-next 1/4] ipv6: Calculate hash thresholds for IPv6 nexthops

2018-05-02 Thread Thomas Winter
> On Wed, May 02, 2018 at 12:58:56PM -0600, David Ahern wrote: > > On 5/2/18 12:53 PM, Ido Schimmel wrote: > > > > > > So this fixes the issue for me. To reproduce: > > > > > > # ip -6 address add 2001:db8::1/64 dev dummy0 > > > # ip -6 address add 2001:db8::1/64 dev dummy1 > > > > > > This

[PATCH] ipv6: Allow non-gateway ECMP for IPv6

2018-04-30 Thread Thomas Winter
It is valid to have static routes where the nexthop is an interface not an address such as tunnels. For IPv4 it was possible to use ECMP on these routes but not for IPv6. Signed-off-by: Thomas Winter <thomas.win...@alliedtelesis.co.nz> Cc: David Ahern <dsah...@gmail.com> Cc: "Dav

[PATCH] ip_tunnel: Do not use mark in skb by default

2018-02-25 Thread Thomas Winter
Signed-off-by: Thomas Winter <thomas.win...@alliedtelesis.co.nz> Cc: "David S. Miller" <da...@davemloft.net> Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Cc: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org> --- net/ipv4/ip_tunnel.c | 13 +++-- 1 file changed

Re: [PATCH] ip_tunnel: Use mark in skb by default

2018-02-14 Thread Thomas Winter
oop as the skb->mark is the mark of the encapsulated traffic and route selected by init_tunnel_flow is via tunnel itself. Regards, Thomas Winter From: David Miller <da...@davemloft.net> Sent: 25 January 2018 10:31 To: Thomas Winter Cc: netdev@vge

[PATCH] ip_tunnel: Use mark in skb by default

2018-01-22 Thread Thomas Winter
This allows marks set by connmark in iptables to be used for route lookups. Signed-off-by: Thomas Winter <thomas.win...@alliedtelesis.co.nz> Cc: "David S. Miller" <da...@davemloft.net> Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Cc: Hideaki YOSHIFUJI <yoshf..

Re: [PATCH net v3] net: ipmr: Fix some mroute forwarding issues in vrf's

2017-06-10 Thread Thomas Winter
I don't think we've seen this issue but patch looks good. From: David Ahern <dsah...@gmail.com> Sent: 11 June 2017 11:33 To: David Miller; sha...@cumulusnetworks.com Cc: netdev@vger.kernel.org; Thomas Winter; niko...@cumulusnetworks.com

[PATCH] ipmr: vrf: Find VIFs using the actual device

2017-05-15 Thread Thomas Winter
The skb->dev that is passed into ip_mr_input is the loX device for VRFs. When we lookup a vif for this dev, none is found as we do not create vifs for loopbacks. Instead lookup a vif for the actual device that the packet was received on, eg the vlan. Signed-off-by: Thomas Winter <thom

Patch to netfilter conntrack for secondary connection logging

2016-08-21 Thread Thomas Winter
such logging for any conntrack helper. Is this a good change? Or did I miss something really obvious? Regards, Thomas Winter example iptables rules: Chain FIREWALL_RULE_12 (1 references) target prot opt source destination LOGtcp -- anywhere