Re: [PATCH net-next] SUNRPC: drop pointless static qualifier in xdr_get_next_encode_buffer()

This really deserves to be a stable patch. Thank you, YueHaibing! Bruce, do you want to shepherd this one in? -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.mykleb...@hammerspace.com

Re: general protection fault in encode_rpcb_string

e of: > > map->r_addr = rpc_sockaddr2uaddr(sap, GFP_ATOMIC); > > ? Yes, and we can probably convert it, and the other GFP_ATOMIC allocations in the rpcbind client to use GFP_NOFS in order to improve reliability. Cheers Trond -- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@hammer.space

Re: sunrpc: infinite unkillable console spam in xs_tcp_setup_socket

es dropped ** [12875.022917] xs_tcp_setup_socket: > connect returned unhandled error -113 > Does the following fix the issue? 8<- From f48d3f01df45f50f0145060f5272ccf1aea855ac Mon Sep 17 00:00:00 2001 From: Trond Myklebust <trond.mykleb...@primar

Re: [PATCH 06/21] nfs client: exit_net cleanup check added

On Sun, 2017-11-05 at 19:48 +0300, Vasily Averin wrote: > On 2017-11-05 19:02, Trond Myklebust wrote: > > On Sun, 2017-11-05 at 13:00 +0300, Vasily Averin wrote: > > > Be sure that nfs_client_list and nfs_volume_list lists > > > initialized > > > in net_in

Re: [PATCH 06/21] nfs client: exit_net cleanup check added

volume_list is not empty\n", net); > } > Why do we need these? Is there a specific bug that you are trying to track down? -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.mykleb...@primarydata.com

Re: possible deadlock in flush_work (2)

gt; flush_work+0x57f/0x8a0 kernel/workqueue.c:2882 > > __cancel_work_timer+0x30a/0x7e0 kernel/workqueue.c:2954 > > cancel_work_sync+0x17/0x20 kernel/workqueue.c:2990 > > xprt_destroy+0xa1/0x130 net/sunrpc/xprt.c:1467 > > xprt_destroy_kref net/sunrpc/xprt.c:1477 [inline] > > kref_put include/linux/kref.h:70 [inline] > > xprt_put+0x38/0x40 net/sunrpc/xprt.c:1501 > > rpc_task_release_client+0x299/0x430 net/sunrpc/clnt.c:986 > > rpc_release_resources_task+0x7f/0xa0 net/sunrpc/sched.c:1020 > > rpc_release_task net/sunrpc/sched.c:1059 [inline] > > __rpc_execute+0x4d9/0xe70 net/sunrpc/sched.c:824 > > rpc_async_schedule+0x16/0x20 net/sunrpc/sched.c:848 > > process_one_work+0xbf0/0x1bc0 kernel/workqueue.c:2112 > > worker_thread+0x223/0x1990 kernel/workqueue.c:2246 > > kthread+0x38b/0x470 kernel/kthread.c:242 > > ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431 > > > +sunrpc maintainers A fix for this has already been merged. Please retest with an up to date kernel. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.mykleb...@primarydata.com

Re: [PATCH 01/23] net, sunrpc: convert rpc_cred.cr_count from atomic_t to refcount_t

On Fri, 2017-03-17 at 09:02 -0400, Jeff Layton wrote: > On Fri, 2017-03-17 at 12:50 +0000, Trond Myklebust wrote: > > On Fri, 2017-03-17 at 14:10 +0200, Elena Reshetova wrote: > > > refcount_t type and corresponding API should be > > > used instead of atomic_

Re: [PATCH 01/23] net, sunrpc: convert rpc_cred.cr_count from atomic_t to refcount_t

count_t: increment on 0; use-after-free.\n") like there's no tomorrow... Please stop with these automated conversions. They are going to cause a lot more bugs than they fix. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.mykleb...@primarydata.com

Re: [PATCHv1] sunrpc: fix write space race causing stalls

> On Sep 16, 2016, at 13:29, David Vrabel <david.vra...@citrix.com> wrote: > > On 16/09/16 18:06, Trond Myklebust wrote: >> >>> On Sep 16, 2016, at 12:41, David Vrabel <david.vra...@citrix.com> wrote: >>> >>> On 16/09/16 17:01, Trond

Re: [PATCHv1] sunrpc: fix write space race causing stalls

> On Sep 16, 2016, at 12:41, David Vrabel <david.vra...@citrix.com> wrote: > > On 16/09/16 17:01, Trond Myklebust wrote: >> >>> On Sep 16, 2016, at 08:28, David Vrabel <david.vra...@citrix.com> wrote: >>> >>> Write space beco

Re: [PATCHv1] sunrpc: fix write space race causing stalls

> On Sep 16, 2016, at 08:28, David Vrabel wrote: > > Write space becoming available may race with putting the task to sleep > in xprt_wait_for_buffer_space(). The existing mechanism to avoid the > race does not work. > > This (edited) partial trace illustrates the

Re: [PATCH 1/2] NFSv4.1: work around -Wmaybe-uninitialized warning

> On Aug 31, 2016, at 09:37, Arnd Bergmann <a...@arndb.de> wrote: > > On Wednesday, August 31, 2016 1:17:48 PM CEST Trond Myklebust wrote: >> What version of gcc are you using? I’m unable to reproduce with gcc 6.1.1.. > > This is also on 6.1.1 for ARM. Note that 6e8d

Re: [PATCH 1/2] NFSv4.1: work around -Wmaybe-uninitialized warning

> On Aug 31, 2016, at 08:39, Arnd Bergmann wrote: > > A bugfix introduced a harmless gcc warning in nfs4_slot_seqid_in_use: > > fs/nfs/nfs4session.c:203:54: error: 'cur_seq' may be used uninitialized in > this function [-Werror=maybe-uninitialized] > > gcc is not smart enough

Re: [PATCH 1/2] SUNRPC: accept() may return sockets that are still in SYN_RECV

Hi Eric, > On Jul 27, 2016, at 14:59, Eric Dumazet <eric.duma...@gmail.com> wrote: > > On Wed, 2016-07-27 at 14:48 -0400, Fields Bruce James wrote: >> On Tue, Jul 26, 2016 at 04:08:29PM +, Trond Myklebust wrote: >>> >>>> On Jul 26, 2016, at 11

Re: It's back! (Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() ))

> On Jun 30, 2016, at 08:59, Steven Rostedt wrote: > > [ resending as a new email, as I'm assuming people do not sort their > INBOX via last email on thread, thus my last email is sitting in the > bottom of everyone's INBOX ] > > I've hit this again. Not sure when it

Re: [PATCH 8/8] net: sunrpc: Replace CURRENT_TIME by current_fs_time()

<deepa.ker...@gmail.com> > Cc: "J. Bruce Fields" <bfie...@fieldses.org> > Cc: Jeff Layton <jlay...@poochiereds.net> > Cc: Trond Myklebust <trond.mykleb...@primarydata.com> > Cc: Anna Schumaker <anna.schuma...@netapp.com> > Cc: "

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

On Fri, Oct 9, 2015 at 5:18 PM, J. Bruce Fields wrote: > > On Fri, Oct 09, 2015 at 06:29:44AM +, Kosuke Tatsukawa wrote: > > Neil Brown wrote: > > > Kosuke Tatsukawa writes: > > > > > >> There are several places in net/sunrpc/svcsock.c which calls >

Re: Race with ip=dhcp bootparameter in ip_rcv_finish on am335x

Code: e59f0044 e59f1044 ebfb467a eac1 (e7f001f2) > > Additional missing information is that I am booting via nfsroot and > xprt_autoclose is something from sunrpc. > > Finally I figured out that commit > 4876cc779ff525b9c2376d8076edf47815e71f2c ("SUNRPC: E

Re: NFS/TCP/IPv6 acting strangely in 4.2

so the issue that clearing XPRT_CONNECTING in TCP_FIN_WAIT1, TCP_CLOSE_WAIT and TCP_CLOSING could interfere with another connection attempt by canceling the XPRT_CONNECTING state. How about the following? It is based on your patch, but adds a check to ensure that xs_tcp_state_change() doesn't c

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Thu, Sep 17, 2015 at 5:47 PM, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > On Thu, Sep 17, 2015 at 10:18:29AM -0400, Trond Myklebust wrote: >> Hi Russell, >> >> On Thu, 2015-09-17 at 14:57 +0100, Russell King - ARM Linux wrote: >> > On F

Re: NFS/TCP/IPv6 acting strangely in 4.2

On Thu, Sep 17, 2015 at 12:27 PM, Benjamin Coddington <bcodd...@redhat.com> wrote: > On Thu, 17 Sep 2015, Trond Myklebust wrote: > >> Hi Russell, >> >> On Thu, 2015-09-17 at 14:57 +0100, Russell King - ARM Linux wrote: >> > On Fri, Sep 11, 2015 at 05:

Re: [PATCH 14/39] SUNRPC: drop null test before destroy functions

On Mon, Sep 14, 2015 at 12:07 PM, J. Bruce Fields wrote: > ACK, but assuming Trond takes this one.--b. No problem. I'll pick it up... Cheers Trond > On Sun, Sep 13, 2015 at 02:15:07PM +0200, Julia Lawall wrote: >> Remove unneeded NULL test. >> >> The semantic patch that

Global protection fault in netfilter code

at by the netfilter folks? -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.mykleb...@primarydata.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

On Fri, 2015-06-19 at 15:52 -0400, Jeff Layton wrote: On Fri, 19 Jun 2015 13:39:08 -0400 Trond Myklebust trond.mykleb...@primarydata.com wrote: On Fri, Jun 19, 2015 at 1:17 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 19 Jun 2015 12:25:53 -0400 Steven Rostedt rost

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

On Fri, 2015-06-19 at 18:14 -0400, Steven Rostedt wrote: On Fri, 19 Jun 2015 16:30:18 -0400 Trond Myklebust trond.mykleb...@primarydata.com wrote: Steven, how about something like the following patch? OK, the box I'm running this on is using v4.0.5, can you make a patch based

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

On Fri, Jun 19, 2015 at 9:27 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 19 Jun 2015 19:25:59 -0400 Trond Myklebust trond.mykleb...@primarydata.com wrote: 8-- From 4876cc779ff525b9c2376d8076edf47815e71f2c Mon Sep 17 00:00

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

On Fri, Jun 19, 2015 at 1:17 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 19 Jun 2015 12:25:53 -0400 Steven Rostedt rost...@goodmis.org wrote: I don't see that 55201 anywhere. But then again, I didn't look for it before the port disappeared. I could reboot and look for it again. I

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

On Wed, Jun 17, 2015 at 11:08 PM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 12 Jun 2015 11:50:38 -0400 Steven Rostedt rost...@goodmis.org wrote: I reverted the following commits: c627d31ba0696cbd829437af2be2f2dee3546b1e 9e2b9f37760e129cee053cc7b6e7288acc2a7134

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

On Fri, Jun 12, 2015 at 10:40 AM, Eric Dumazet eric.duma...@gmail.com wrote: On Fri, 2015-06-12 at 10:10 -0400, Trond Myklebust wrote: On Thu, Jun 11, 2015 at 11:49 PM, Steven Rostedt rost...@goodmis.org wrote: I recently upgraded my main server to 4.0.4 from 3.19.5 and rkhunter started

Re: [REGRESSION] NFS is creating a hidden port (left over from xs_bind() )

On Thu, Jun 11, 2015 at 11:49 PM, Steven Rostedt rost...@goodmis.org wrote: I recently upgraded my main server to 4.0.4 from 3.19.5 and rkhunter started reporting a hidden port on my box. Running unhide-tcp I see this: # unhide-tcp Unhide-tcp 20121229 Copyright © 2012 Yago Jesus Patrick

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

On Wed, 2008-02-20 at 19:27 +0300, Pavel Emelyanov wrote: Patrick McHardy wrote: Joe Perches wrote: On Wed, 2008-02-20 at 07:29 -0800, Joe Perches wrote: fs/nfsd/nfsproc.c: char buf[RPC_MAX_ADDRBUFLEN]; Perhaps there should be a DECLARE_RPC_BUF(buf) macro? #define

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

On Wed, 2008-02-20 at 08:36 -0800, Joe Perches wrote: On Wed, 2008-02-20 at 16:35 +0100, Patrick McHardy wrote: Alternatively change the dprintk macro to behave similar like pr_debug() and mark things like svc_print_addr() __pure, which has the advantage that is still performs format

Re: [PATCH] SUNRPC: Mark buffer used for debug printks with __maybe_unused

On Wed, 2008-02-20 at 09:23 -0800, Joe Perches wrote: On Wed, 2008-02-20 at 12:02 -0500, Trond Myklebust wrote: #ifdef DEBUG #define some_print_wrapper(fmt, arg...) \ do { if (0) printk(KERN_DEBUG fmt, ##arg); } while (0) #else #define some_print_wrapper(fmt, arg

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

On Mon, 2007-11-12 at 12:22 +, David Howells wrote: Trond Myklebust [EMAIL PROTECTED] wrote: take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the Hmmm... Why SHUT_*? Why not SHUTDOWN_*? SHUT_RD/SHUT_WR/SHUT_RDWR are the traditional names for these constants (see 'man 3 shutdown

[PATCH][RESEND] NET: Add the helper kernel_sock_shutdown()

that kernel users of shutdown() don't get confused. Signed-off-by: Trond Myklebust [EMAIL PROTECTED] Cc: Paul Clements [EMAIL PROTECTED] Acked-by: Mark Fasheh [EMAIL PROTECTED] Cc: Steve French [EMAIL PROTECTED] Acked-by: David Howells [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

On Sun, 2007-11-11 at 10:03 -0800, Mark Fasheh wrote: On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote: From: Trond Myklebust [EMAIL PROTECTED] ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers. Looking at the sock-op-shutdown() handlers, it looks

[PATCH] NET: Add the helper kernel_sock_shutdown()

From: Trond Myklebust [EMAIL PROTECTED] ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers. Looking at the sock-op-shutdown() handlers, it looks as if all of them take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the RCV_SHUTDOWN/SEND_SHUTDOWN arguments. Add a helper

Re: NFS mount gives ENETDOWN in -git15

On Sat, 2007-07-21 at 15:31 +0200, Andi Kleen wrote: I tried to mount another nfs mount on a system running with nfsroot. But I get # mount basil:/home /basil/home/ mount: Network is down The network is not down of course, the system is happily running with nfs root from that server.

Re: networking busted in current -git ???

On Fri, 2007-06-08 at 19:06 -0700, David Miller wrote: From: Trond Myklebust [EMAIL PROTECTED] Date: Fri, 08 Jun 2007 17:43:27 -0400 It is not dhcp. I'm seeing the same bug with bog-standard ifup with a static address on an FC-6 machine. It appears to be something in the latest dump

Re: networking busted in current -git ???

On Fri, 2007-06-08 at 23:07 +0200, Arkadiusz Miskiewicz wrote: On Friday 08 of June 2007, you wrote: Hello, I am using the current git tree: 85f6038f2170e3335dda09c3dfb0f83110e87019 . Git tree from two days ago (with the same config) works fine. Attempting to acquire an IP address via

Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

On Sat, 2007-05-05 at 18:44 +0200, Adrian Bunk wrote: On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: ... Changes since 2.6.21-rc7-mm2: ... git-net.patch ... git trees ... match_table_t was made const and gcc doesn't like const __initdata: Then please revert the fix

Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

On Sat, 2007-05-05 at 13:20 -0400, Trond Myklebust wrote: On Sat, 2007-05-05 at 18:44 +0200, Adrian Bunk wrote: On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: ... Changes since 2.6.21-rc7-mm2: ... git-net.patch ... git trees ... match_table_t was made

Re: 2.6.19-rc1: known regressions (v2)

On Sat, 2006-10-07 at 23:46 +0200, Adrian Bunk wrote: Subject: NFSv4 fails to mount (timeout) References : http://bugzilla.kernel.org/show_bug.cgi?id=7274 Submitter : Torsten Kaiser [EMAIL PROTECTED] Guilty : Trond Myklebust [EMAIL PROTECTED] commit

Re: [PATCH 4/4] nfs: deadlock prevention for NFS

Grumble... If your patches are targetting NFS, could you please at the very least Cc [EMAIL PROTECTED] and/or myself. On Fri, 2006-08-25 at 17:40 +0200, Peter Zijlstra wrote: Provide a proper a_ops-swapfile() implementation for NFS. This will set the NFS socket to SOCK_VMIO and put the socket

Re: [Patch] Dead code in net/sunrpc/auth_gss/auth_gss.c

On Tue, 2006-04-18 at 18:07 +0200, Eric Sesterhenn wrote: Hi, the coverity checker spotted that cred is always NULL when we jump to out_err ( there is just one case, when we fail to allocate the memory for cred ) This is Coverity ID #79 Signed-off-by: Eric Sesterhenn [EMAIL PROTECTED]

[Fwd: [Bug 5644] New: NFS v3 TCP 3-way handshake incorrect, iptables blocks access]

Sorry to be cross-posting, but does this bug ring any bells? I'm having trouble seeing how the sunrpc server code could be at fault. Cheers, Trond ---BeginMessage--- http://bugzilla.kernel.org/show_bug.cgi?id=5644 Summary: NFS v3 TCP 3-way handshake incorrect, iptables blocks