Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Ben Greear <gree...@candelatech.com> writes: > On 02/07/2017 01:14 AM, Valo, Kalle wrote: >> Adrian Chadd <adr...@freebsd.org> writes: >> >>> Removing this method makes the diff to FreeBSD larger, as "vif" in >>> FreeBSD is a different

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv"

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

Joe Perches <j...@perches.com> writes: > On Tue, 2017-01-24 at 05:18 +0000, Valo, Kalle wrote: >> Joe Perches <j...@perches.com> writes: >> >> > On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: >> > > use dma_zalloc_coh

Re: [PATCH 2/3] ath10k: use dma_zalloc_coherent()

Joe Perches writes: > On Mon, 2017-01-23 at 15:04 +, Srinivas Kandagatla wrote: >> use dma_zalloc_coherent() instead of dma_alloc_coherent and memset(). > [] >> diff --git a/drivers/net/wireless/ath/ath10k/pci.c >> b/drivers/net/wireless/ath/ath10k/pci.c > [] >> @@ -896,7

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

Gabriel C <nix.or@gmail.com> writes: > On 18.12.2016 21:14, Paul E. McKenney wrote: >> On Sun, Dec 18, 2016 at 07:57:42PM +0000, Valo, Kalle wrote: >>> Tobias Klausmann <tobias.johannes.klausm...@mni.thm.de> writes: >>> >>>> A patch for

Re: regression: ath_tx_edma_tasklet() Illegal idle entry in RCU read-side critical section

Tobias Klausmann writes: > A patch for this is already floating on the ML for a while now latest: > (ath9k: do not return early to fix rcu unlocking) It's here: https://patchwork.kernel.org/patch/9472709/ > Hopefully Kalle will include it in one of his

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Hi Dave, Andy Gross <andy.gr...@linaro.org> writes: > On 1 December 2016 at 04:17, Valo, Kalle <kv...@qca.qualcomm.com> wrote: >> Kalle Valo <kv...@qca.qualcomm.com> writes: >> >>> It found the same problem. Interestingly I'm also building x86 with 32

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Kalle Valo <kv...@qca.qualcomm.com> writes: > Kalle Valo <kv...@qca.qualcomm.com> writes: > >> "Valo, Kalle" <kv...@qca.qualcomm.com> writes: >> >>> Bjorn Andersson <bjorn.anders...@linaro.org> writes: >>> >>&

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Kalle Valo <kv...@qca.qualcomm.com> writes: > "Valo, Kalle" <kv...@qca.qualcomm.com> writes: > >> Bjorn Andersson <bjorn.anders...@linaro.org> writes: >> >>> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: >>> >>>> Bj

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

"Valo, Kalle" <kv...@qca.qualcomm.com> writes: > Bjorn Andersson <bjorn.anders...@linaro.org> writes: > >> On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: >> >>> Bjorn Andersson <bjorn.anders...@linaro.org> wrote: >>> &g

Re: [v5,1/5] soc: qcom: smem_state: Fix include for ERR_PTR()

Bjorn Andersson writes: > On Wed 16 Nov 10:49 PST 2016, Kalle Valo wrote: > >> Bjorn Andersson wrote: >> > The correct include file for getting errno constants and ERR_PTR() is >> > linux/err.h, rather than linux/errno.h, so fix the

Re: [PATCH] ath10k: Spelling and miscellaneous neatening

Joe Perches writes: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches [...] > ---

Re: [PATCH] ath10k: fix memory leak on caldata on error exit path

Colin King writes: > From: Colin Ian King > > caldata is not being free'd on the error exit path, causing > a memory leak. kfree it to fix the leak. > > Signed-off-by: Colin Ian King > --- >

Re: [PATCH 1/2] ath10k: remove unused

Sergei Shtylyov writes: > On 6/21/2016 2:45 PM, Chaehyun Lim wrote: > >> is not used anymore, so just remove it. > >s/it/#include/? Fixed that in the pending branch. -- Kalle Valo

Re: [PATCH V2 2/2] ath6kl: replace semaphore with mutex

(Adding ath6k list) Chaehyun Lim writes: > It replaces struct semaphore sem with struct mutex mutex > > Reported-by: kbuild test robot > Signed-off-by: Chaehyun Lim > --- > V2: fix build failure reported by kbuild test robot I

Re: linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) Redundant condition

David Binderman writes: > Hello there, > > linux-4.7-rc2/drivers/net/wireless/ath/ath6kl/wmi.c:2547]: (style) > Redundant condition: If 'EXPR <= 7', the comparison 'EXPR < 8' is > always true. > > Source code is > > if (!((params->user_pri < 8) && >

Re: [PATCH] ath10k: fix erroneous return value

Anton Protopopov writes: > The ath10k_pci_hif_exchange_bmi_msg() function may return the positive > value EIO instead of -EIO in case of error. > > Signed-off-by: Anton Protopopov Applied, thanks. -- Kalle Valo

Re: [PATCH] ath10k: remove impossible code

Sudip Mukherjee writes: > From: Sudip Mukherjee > > len has been initialized with a value of 0 and buf_len with 4096. There > is no way that this condition (len > buf_len) can be true now. > > Signed-off-by: Sudip Mukherjee

Re: [PATCH] ath9k: reduce stack usage in ar9003_aic_cal_post_process

Arnd Bergmann writes: > In some configurations, this function uses more than the warning limit > of 1024 bytes: > > drivers/net/wireless/ath/ath9k/ar9003_aic.c: In function > 'ar9003_aic_cal_post_process': > drivers/net/wireless/ath/ath9k/ar9003_aic.c:434:1: error: the frame size