Re: [PATCH net-next RFC 7/7] bnxt_en: Add bnxt_en initial port params table and register it

On Thu, Dec 6, 2018 at 2:41 PM Jiri Pirko wrote: > > Thu, Dec 06, 2018 at 09:57:05AM CET, michael.c...@broadcom.com wrote: > >On Wed, Dec 5, 2018 at 11:11 PM Jakub Kicinski > > wrote: > >> > >> On Wed, 5 Dec 2018 22:41:43 -0800, Michael Chan wrote: > >> > > >> > It will be in the BIOS only for a

Re: [PATCH net-next RFC 1/7] devlink: Add devlink_param for port register and unregister

5, 2018 at 06:56:54AM CET, vasundhara-v.vo...@broadcom.com wrote: > >> >Add functions to register and unregister for the driver supported > >> >configuration parameters table per port. > >> > > >> >Cc: Jiri Pirko > >> >Signed-off-by: Vasundh

Re: [PATCH net-next RFC 1/7] devlink: Add devlink_param for port register and unregister

; > > >Cc: Jiri Pirko > >Signed-off-by: Vasundhara Volam > >--- > > include/net/devlink.h | 29 +++ > > net/core/devlink.c| 130 > > ++ > > 2 files changed, 151 insertions(+), 8 deletions(-)

[PATCH net-next RFC 7/7] bnxt_en: Add bnxt_en initial port params table and register it

pin upon reception of WoL packet. ACPI (Advanced Configuration and Power Interface) is an industry specification for the efficient handling of power consumption in desktop and mobile computers. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt.h

[PATCH net-next RFC 0/7] Add configuration parameters support for devlink_port

cmode permanent value false # devlink port param set pci/:3b:00.0/0 name wake-on-lan cmode permanent value true Vasundhara Volam (7): devlink: Add devlink_param for port register and unregister devlink: Add port param get command devlink: Add port param set command devlink: Add

[PATCH net-next RFC 6/7] devlink: Add a boolean generic port parameter

for the efficient handling of power consumption in desktop and mobile computers. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 17 + net/core/devlink.c| 8 +++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/include/net/devlink.h b/include

[PATCH net-next RFC 5/7] devlink: Add devlink notifications support for port params

Pirko Signed-off-by: Vasundhara Volam --- include/net/devlink.h| 9 include/uapi/linux/devlink.h | 2 + net/core/devlink.c | 97 3 files changed, 83 insertions(+), 25 deletions(-) diff --git a/include/net/devlink.h b/include

[PATCH net-next RFC 4/7] devlink: Add support for get/set driverinit value for devlink_port

ommon code to __devlink_param_driverinit_value_get/set() to be used by both device and port params. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 19 net/core/devlink.c| 118 +++--- 2 files changed, 112

[PATCH net-next RFC 3/7] devlink: Add port param set command

Add port param set command to set the value for a parameter. Value can be set to any of the supported configuration modes. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 1 + net/core/devlink.c | 41 ++--- 2

[PATCH net-next RFC 2/7] devlink: Add port param get command

Add port param get command which gets data per parameter. It also has option to dump the parameters data per port. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/uapi/linux/devlink.h | 2 + net/core/devlink.c | 102 --- 2 files

[PATCH net-next RFC 1/7] devlink: Add devlink_param for port register and unregister

Add functions to register and unregister for the driver supported configuration parameters table per port. Cc: Jiri Pirko Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 29 +++ net/core/devlink.c| 130 ++ 2 files changed

Re: [PATCH v4 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

On Tue, Oct 9, 2018 at 11:51 AM Saeed Mahameed wrote: > > On Thu, 2018-10-04 at 11:13 +0530, Vasundhara Volam wrote: > > This patch adds a new file to add information about some of the > > generic configuration parameters set via devlink. > > > > Cc: "David

[PATCH v4 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max

msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device which is applicable per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net

[PATCH v4 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

same number of partitions when platform does not support ARI capability. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 ++ drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers

[PATCH v4 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min

msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. This value is set in the device which limits MSIX vectors per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core

[PATCH v4 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED

Return proper error code when Firmware returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE commands. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH v4 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.

-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 50 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 5 +++ 2 files changed, 53 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet

[PATCH v4 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

This patch adds a new file to add information about some of the generic configuration parameters set via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networki

[PATCH v4 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

This patch adds a new file to add information about configuration parameters that are supported by bnxt_en driver via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/

[PATCH v4 net-next 1/9] devlink: Add generic parameter ignore_ari

ignore_ari - Device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same number of partitions when platform does not support ARI capability. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net

[PATCH v4 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter.

This patch adds following driver-specific permanent mode boolean parameter. gre_ver_check - Generic Routing Encapsulation(GRE) version check will be enabled in the device. If disabled, device skips version checking for GRE packets. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers

[PATCH v4 net-next 0/9] bnxt_en: devlink param updates

formation that are supported by bnxt_en driver. Vasundhara Volam (9): devlink: Add generic parameter ignore_ari devlink: Add generic parameter msix_vec_per_pf_max devlink: Add generic parameter msix_vec_per_pf_min bnxt_en: Use ignore_ari devlink parameter bnxt_en: return proper error when F

Re: [PATCH v3 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

> >> wrote: > >> >This patch adds a new file to add information about configuration > >> >parameters that are supported by bnxt_en driver via devlink. > >> > > >> >Cc: "David S. Miller" > >> >Cc: Jonathan Corbet >

Re: [PATCH v3 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

On Sun, Sep 30, 2018 at 2:53 AM Or Gerlitz wrote: > > On Fri, Sep 28, 2018 at 9:30 AM Vasundhara Volam > wrote: > > This patch adds support for ignore_ari generic permanent mode > > devlink parameter. This parameter is disabled by default. It can be > > enabled u

Re: [PATCH v3 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

> >Cc: "David S. Miller" > >Cc: Jonathan Corbet > >Cc: linux-...@vger.kernel.org > >Cc: Jiri Pirko > >Cc: Michael Chan > >Signed-off-by: Vasundhara Volam > >--- > > Documentation/networking/devlink-params-bnxt.txt | 22 ++

[PATCH v3 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.

-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 50 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 5 +++ 2 files changed, 53 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet

[PATCH v3 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

This patch adds a new file to add information about some of the generic configuration parameters set via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networki

[PATCH v3 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max

msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device which is applicable per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net

[PATCH v3 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

same number of partitions when platform does not support ARI capability. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 ++ drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v3 net-next 1/9] devlink: Add generic parameter ignore_ari

ignore_ari - Device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same number of partitions when platform does not support ARI capability. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net

[PATCH v3 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min

msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. This value is set in the device which limits MSIX vectors per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core

[PATCH v3 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

This patch adds a new file to add information about configuration parameters that are supported by bnxt_en driver via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/

[PATCH v3 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter.

This patch adds following driver-specific permanent mode boolean parameter. gre_ver_check - Generic Routing Encapsulation(GRE) version check will be enabled in the device. If disabled, device skips version checking for GRE packets. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers

[PATCH v3 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED

Return proper error code when Firmware returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE commands. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[PATCH v3 net-next 0/9] bnxt_en: devlink param updates

h some generic devlink parameters information. -Add a new Documentation/networking/devlink-params-bnxt.txt with devlink parameters information that are supported by bnxt_en driver. Vasundhara Volam (9): devlink: Add generic parameter ignore_ari devlink: Add generic parameter msix_vec_per_

Re: [PATCH v2 net-next 0/9] bnxt_en: devlink param updates

On Mon, Sep 24, 2018 at 10:11 PM Jakub Kicinski wrote: > > On Mon, 24 Sep 2018 10:46:12 +0530, Vasundhara Volam wrote: > > This patchset adds support for 3 generic and 1 driver-specific devlink > > parameters. Add documentation for these configuration parameters. > > >

Re: [PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

On Mon, Sep 24, 2018 at 9:54 PM Jakub Kicinski wrote: > > On Mon, 24 Sep 2018 10:46:21 +0530, Vasundhara Volam wrote: > > This patch adds a new file to add information about configuration > > parameters that are supported by bnxt_en driver via devlink. > > > >

[PATCH v2 net-next 7/9] bnxt_en: Add a driver specific gre_ver_check devlink parameter.

This patch adds following driver-specific permanent mode boolean parameter. gre_ver_check - Generic Routing Encapsulation(GRE) version check will be enabled in the device. If disabled, device skips version checking for GRE packets. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers

[PATCH v2 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

same number of partitions when platform does not support ARI capability. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 ++ drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 ++ 2 files changed, 8 insertions(+) diff --git

[PATCH v2 net-next 1/9] devlink: Add generic parameter ignore_ari

ignore_ari - Device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same number of partitions when platform does not support ARI capability. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net

[PATCH v2 net-next 3/9] devlink: Add generic parameter msix_vec_per_pf_min

msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. This value is set in the device which limits MSIX vectors per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core

[PATCH v2 net-next 2/9] devlink: Add generic parameter msix_vec_per_pf_max

msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device which is applicable per PF. Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net

[PATCH v2 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

This patch adds a new file to add information about configuration parameters that are supported by bnxt_en driver via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Doc

[PATCH v2 net-next 8/9] devlink: Add Documentation/networking/devlink-params.txt

This patch adds a new file to add information about some of the generic configuration parameters set via devlink. Cc: "David S. Miller" Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org Cc: Jiri Pirko Cc: Michael Chan Signed-off-by: Vasundhara Volam --- Documentation/networki

[PATCH v2 net-next 6/9] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.

-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 50 ++- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 5 +++ 2 files changed, 53 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet

[PATCH v2 net-next 0/9] bnxt_en: devlink param updates

ink-params-bnxt_en.txt with devlink parameters information that are supported by bnxt_en driver. Vasundhara Volam (9): devlink: Add generic parameter ignore_ari devlink: Add generic parameter msix_vec_per_pf_max devlink: Add generic parameter msix_vec_per_pf_min bnxt_en: Use ignore_ari devl

[PATCH v2 net-next 5/9] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED

Return proper error code when Firmware returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE commands. Cc: Michael Chan Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [PATCH net-next 0/8] bnxt_en: devlink param updates

On Wed, Sep 12, 2018 at 3:20 PM Jakub Kicinski wrote: > > On Wed, 12 Sep 2018 12:09:37 +0530, Vasundhara Volam wrote: > > On Tue, Sep 11, 2018 at 5:04 PM Jakub Kicinski wrote: > > > On Tue, 11 Sep 2018 14:14:57 +0530, Vasundhara Volam wrote: > > > > This patchset

Re: [PATCH net-next 0/8] bnxt_en: devlink param updates

On Tue, Sep 11, 2018 at 5:25 PM Jiri Pirko wrote: > > Tue, Sep 11, 2018 at 01:33:51PM CEST, jakub.kicin...@netronome.com wrote: > >On Tue, 11 Sep 2018 14:14:57 +0530, Vasundhara Volam wrote: > >> This patchset adds support for 4 generic and 1 driver-specific de

Re: [PATCH net-next 0/8] bnxt_en: devlink param updates

On Tue, Sep 11, 2018 at 5:04 PM Jakub Kicinski wrote: > > On Tue, 11 Sep 2018 14:14:57 +0530, Vasundhara Volam wrote: > > This patchset adds support for 4 generic and 1 driver-specific devlink > > parameters. > > > > Also, this patchset adds support to return proper

Re: [PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload

On Tue, Sep 11, 2018 at 3:25 PM Jiri Pirko wrote: > > Tue, Sep 11, 2018 at 10:44:58AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >hw_tc_offload - Enable/Disable TC flower offload in the device. > > > >Signed-off-by: Vasundhara Volam > >--- > > include

[PATCH net-next 8/8] bnxt_en: Add a driver specific devlink parameter.

This patch adds following driver-specific permanent mode boolean parameter. gre_ver_check - When this param is disabled, device skips GRE version check. Signed-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 24 ++- drivers/net/ethernet/broadcom

[PATCH net-next 7/8] bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink params.

which limits MSIX vectors per PF. msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. Value 0 indicates a default value is selected. This value is set in the device which limits MSIX vectors per PF. Signed-off-by: Vasundhara Volam

[PATCH net-next 6/8] bnxt_en: return proper error when FW returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED

Return proper error code when Firmware returns HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED for HWRM_NVM_GET/SET_VARIABLE commands. Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next 5/8] bnxt_en: Use hw_tc_offload and ignore_ari devlink parameters

when platforms has the support and creates same number of partitions when platform does not support ARI capability. Signed-off-by: Vasundhara Volam --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 12 drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 ++ 2 files changed

[PATCH net-next 0/8] bnxt_en: devlink param updates

This patchset adds support for 4 generic and 1 driver-specific devlink parameters. Also, this patchset adds support to return proper error code if HWRM_NVM_GET/SET_VARIABLE commands return error code HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. Vasundhara Volam (8): devlink: Add generic parameter

[PATCH net-next 1/8] devlink: Add generic parameter hw_tc_offload

hw_tc_offload - Enable/Disable TC flower offload in the device. Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core/devlink.c| 5 + 2 files changed, 9 insertions(+) diff --git a/include/net/devlink.h b/include/net/devlink.h index b9b89d6..a0e9ce9 100644

[PATCH net-next 4/8] devlink: Add generic parameter msix_vec_per_pf_min

msix_vec_per_pf_min - This param sets the number of minimal MSIX vectors required for the device initialization. This value is set in the device which limits MSIX vectors per PF. Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core/devlink.c| 5 + 2 files changed

[PATCH net-next 3/8] devlink: Add generic parameter msix_vec_per_pf_max

msix_vec_per_pf_max - This param sets the number of MSIX vectors that the device requests from the host on driver initialization. This value is set in the device which is applicable per PF. Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core/devlink.c| 5 + 2

[PATCH net-next 2/8] devlink: Add generic parameter ignore_ari

ignore_ari - Device ignores ARI(Alternate Routing ID) capability, even when platforms has the support and creates same number of partitions when platform does not support ARI capability. Signed-off-by: Vasundhara Volam --- include/net/devlink.h | 4 net/core/devlink.c| 5 + 2 files

Re: [PATCH net-next v2 09/10] bnxt_en: add support for software dynamic interrupt moderation

Hi Andy, If you are re-doing the patch, could you modify a minor comment below? On Sat, Jan 6, 2018 at 4:28 AM, Andy Gospodarek wrote: > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c > b/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c > new file mode 100644 >