Re: [PATCH net-next v1 1/4] etf: Cancel timer if there are no pending skbs

Hi, Vinicius Costa Gomes writes: > From: Jesus Sanchez-Palencia > > There is no point in firing the qdisc watchdog if there are no future > skbs pending in the queue and the watchdog had been set previously. > > Signed-off-by: Jesus Sanchez-Palencia It seems that I m

[next-queue PATCH v1 2/2] Documentation: igb: Add a section about CBS

Add some pointers to the definition of the CBS algorithm, and some notes about the limits of its implementation in the i210 family of controllers. Signed-off-by: Vinicius Costa Gomes --- Documentation/networking/igb.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git

[next-queue PATCH v1 1/2] igb: Change RXPBSIZE size when setting Qav mode

From: Jesus Sanchez-Palencia Section 4.5.9 of the datasheet says that the total size of all packet buffers combined (TxPB 0 + 1 + 2 + 3 + RxPB + BMC2OS + OS2BMC) must not exceed 60KB. Today we are configuring a total of 62KB, so reduce the RxPB from 32KB to 30KB in order to respect that. The

[PATCH net-next v1 3/4] etf: Split timersortedlist_erase()

From: Jesus Sanchez-Palencia This is just a refactor that will simplify the implementation of the next patch in this series which will drop all expired packets on the dequeue flow. Signed-off-by: Jesus Sanchez-Palencia --- net/sched/sch_etf.c | 44 +---

[PATCH net-next v1 1/4] etf: Cancel timer if there are no pending skbs

From: Jesus Sanchez-Palencia There is no point in firing the qdisc watchdog if there are no future skbs pending in the queue and the watchdog had been set previously. Signed-off-by: Jesus Sanchez-Palencia --- net/sched/sch_etf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH net-next v1 4/4] etf: Drop all expired packets

From: Jesus Sanchez-Palencia Currently on dequeue() ETF only drops the first expired packet, which causes a problem if the next packet is already expired. When this happens, the watchdog will be configured with a time in the past, fire straight way and the packet will finally be dropped once the

[PATCH net-next v1 2/4] etf: Use cached rb_root

From: Jesus Sanchez-Palencia ETF's peek() operation is heavily used so use an rb_root_cached instead and leverage rb_first_cached() which will run in O(1) instead of O(log n). Even if on 'timesortedlist_clear()' we could be using rb_erase(), we choose to use rb_erase_cached(), because if in the

Re: [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl

ght before reading the lowest bits of the PHC timestamp > - PHC time > - system time immediately after reading the lowest bits of the PHC > timestamp Cool stuff! Just one little thing below. Feel free to add my ack to the series. Acked-by: Vinicius Costa Gomes > > Cc: Richard Co

[PATCH iproute2 net-next v3 3/6] libnetlink: Add helper for getting a __s32 from netlink msgs

From: Jesus Sanchez-Palencia This function retrieves a signed 32-bit integer from a netlink message and returns it. Signed-off-by: Jesus Sanchez-Palencia --- include/libnetlink.h | 4 1 file changed, 4 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index

[PATCH iproute2 net-next v3 4/6] include: add definitions for taprio [DO NOT COMMIT]

DO NOT COMMIT This patch exists only to ease the testing, until this header is updated with the definitions from the kernel. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 52 -- 1 file changed, 49 insertions(+), 3 deletions(-) diff

[PATCH iproute2 net-next v3 0/6] Introduce the taprio scheduler

is the iproute2 side of the taprio v1 series. Please see the kernel side cover letter for more information about how to test this. Cheers, -- Vinicius Jesus Sanchez-Palencia (1): libnetlink: Add helper for getting a __s32 from netlink msgs Vinicius Costa Gomes (5): utils: Implement get_s64()

[PATCH iproute2 net-next v3 5/6] tc: Add support for configuring the taprio scheduler

- clockid: specifies the reference clock to be used; The parameters should be similar to what the IEEE 802.1Q family of specification defines. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_taprio.c | 400 +

[PATCH iproute2 net-next v3 1/6] utils: Implement get_s64()

Add this helper to read signed 64-bit integers from a string. Signed-off-by: Vinicius Costa Gomes --- include/utils.h | 1 + lib/utils.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/utils.h b/include/utils.h index 8cb4349e..58574a05 100644

[PATCH iproute2 net-next v3 2/6] include: Add helper to retrieve a __s64 from a netlink msg

This allows signed 64-bit integers to be retrieved from a netlink message. Signed-off-by: Vinicius Costa Gomes --- include/libnetlink.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index 9d9249e6..ffc49e56 100644 --- a/include

[PATCH iproute2 net-next v3 6/6] taprio: Add manpage for tc-taprio(8)

This documents the parameters and provides an example of usage. Signed-off-by: Vinicius Costa Gomes --- man/man8/tc-taprio.8 | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 man/man8/tc-taprio.8 diff --git a/man/man8/tc-taprio.8 b/man

Re: [PATCH iproute2 net-next v2 2/6] include: Add helper to retrieve a __s64 from a netlink msg

Hi Ilias, Ilias Apalodimas writes: > On Thu, Oct 04, 2018 at 04:17:07PM -0700, Vinicius Costa Gomes wrote: >> This allows signed 64-bit integers to be retrieved from a netlink >> message. >> --- >> include/libnetlink.h | 7 +++ >> 1 file changed, 7 insertio

[PATCH iproute2 net-next v2 6/6] taprio: Add manpage for tc-taprio(8)

This documents the parameters and provides an example of usage. Signed-off-by: Vinicius Costa Gomes --- man/man8/tc-taprio.8 | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 man/man8/tc-taprio.8 diff --git a/man/man8/tc-taprio.8 b/man

[PATCH iproute2 net-next v2 2/6] include: Add helper to retrieve a __s64 from a netlink msg

This allows signed 64-bit integers to be retrieved from a netlink message. --- include/libnetlink.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index 9d9249e6..88164975 100644 --- a/include/libnetlink.h +++ b/include/libnetlink.h @@

[PATCH iproute2 net-next v2 3/6] libnetlink: Add helper for getting a __s32 from netlink msgs

From: Jesus Sanchez-Palencia This function retrieves a signed 32-bit integer from a netlink message and returns it. Signed-off-by: Jesus Sanchez-Palencia --- include/libnetlink.h | 4 1 file changed, 4 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index

[PATCH iproute2 net-next v2 5/6] tc: Add support for configuring the taprio scheduler

- clockid: specifies the reference clock to be used; The parameters should be similar to what the IEEE 802.1Q family of specification defines. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_taprio.c | 400 +

[PATCH iproute2 net-next v2 1/6] utils: Implement get_s64()

Add this helper to read signed 64-bit integers from a string. Signed-off-by: Vinicius Costa Gomes --- include/utils.h | 1 + lib/utils.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/utils.h b/include/utils.h index 8cb4349e..58574a05 100644

[PATCH iproute2 net-next v2 4/6] include: add definitions for taprio [DO NOT COMMIT]

DO NOT COMMIT This patch exists only to ease the testing, until this header is updated with the definitions from the kernel. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 52 -- 1 file changed, 49 insertions(+), 3 deletions(-) diff

[PATCH iproute2 net-next v2 0/6] Introduce the taprio scheduler

, -- Vinicius Jesus Sanchez-Palencia (1): libnetlink: Add helper for getting a __s32 from netlink msgs Vinicius Costa Gomes (5): utils: Implement get_s64() include: Add helper to retrieve a __s64 from a netlink msg include: add definitions for taprio [DO NOT COMMIT] tc: Add support for co

Re: [PATCH iproute2 net-next v1 5/6] tc: Add support for configuring the taprio scheduler

Hi David, David Ahern writes: > On 9/28/18 7:10 PM, Vinicius Costa Gomes wrote: >> This traffic scheduler allows traffic classes states (transmission >> allowed/not allowed, in the simplest case) to be scheduled, according >> to a pre-generated time sequence. This is

Re: [PATCH net-next v1 0/1] net/sched: Introduce the taprio scheduler

Hi, Just a small correction, one link on the cover letter is wrong. Vinicius Costa Gomes writes: [...] > > > [1] https://patchwork.ozlabs.org/cover/938991/ > > [2] https://patchwork.ozlabs.org/cover/808504/ > > [3] github doesn't make it clear, but the gist can be clon

[PATCH iproute2 net-next v1 5/6] tc: Add support for configuring the taprio scheduler

- clockid: specifies the reference clock to be used; The parameters should be similar to what the IEEE 802.1Q family of specification defines. Signed-off-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_taprio.c | 410 +

[PATCH iproute2 net-next v1 1/6] utils: Implement get_s64()

Add this helper to read signed 64-bit integers from a string. Signed-off-by: Vinicius Costa Gomes --- include/utils.h | 1 + lib/utils.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/utils.h b/include/utils.h index 8cb4349e..58574a05 100644

[PATCH iproute2 net-next v1 2/6] include: Add helper to retrieve a __s64 from a netlink msg

This allows signed 64-bit integers to be retrieved from a netlink message. --- include/libnetlink.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index 9d9249e6..88164975 100644 --- a/include/libnetlink.h +++ b/include/libnetlink.h @@

[PATCH iproute2 net-next v1 0/6] introduce the taprio scheduler

-Palencia (1): libnetlink: Add helper for getting a __s32 from netlink msgs Vinicius Costa Gomes (5): utils: Implement get_s64() include: Add helper to retrieve a __s64 from a netlink msg include: add definitions for taprio [DO NOT COMMIT] tc: Add support for configuring the taprio

[PATCH iproute2 net-next v1 3/6] libnetlink: Add helper for getting a __s32 from netlink msgs

From: Jesus Sanchez-Palencia This function retrieves a signed 32-bit integer from a netlink message and returns it. Signed-off-by: Jesus Sanchez-Palencia --- include/libnetlink.h | 4 1 file changed, 4 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index

[PATCH iproute2 net-next v1 6/6] taprio: Add manpage for tc-taprio(8)

This documents the parameters and provides an example of usage. Signed-off-by: Vinicius Costa Gomes --- man/man8/tc-taprio.8 | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 man/man8/tc-taprio.8 diff --git a/man/man8/tc-taprio.8 b/man

[PATCH iproute2 net-next v1 4/6] include: add definitions for taprio [DO NOT COMMIT]

DO NOT COMMIT This patch exists only to ease the testing, until this header is updated with the definitions from the kernel. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 52 -- 1 file changed, 49 insertions(+), 3 deletions(-) diff

[PATCH net-next v1 1/1] tc: Add support for configuring the taprio scheduler

- clockid: specifies the reference clock to be used; The parameters should be similar to what the IEEE 802.1Q family of specification defines. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 46 ++ net/sched/Kconfig | 11 + net/sc

[PATCH net-next v1 0/1] net/sched: Introduce the taprio scheduler

s.org/cover/808504/ [3] github doesn't make it clear, but the gist can be cloned like this: $ git clone https://gist.github.com/jeez/bd3afeff081ba64a695008dd8215866f taprio-test [4] https://github.com/vcgomes/linux/tree/taprio-v1 [5] https://github.com/vcgomes/iproute2/tree/taprio-v1 Vinicius

Re: [RFC iproute2-next v1 5/5] tc: Add support for configuring the taprio scheduler

Hi, Vinicius Costa Gomes writes: > Hi, > > Stephen Hemminger writes: > [...] >> >> Why not just use batch mode? Introducing another input mode in tc that is >> only in one qdisc seems like a bad idea. > > Seems that I have missed batch mode. I am going to

[PATCH net-next] cbs: Add support for the graft function

This will allow to install a child qdisc under cbs. The main use case is to install ETF (Earliest TxTime First) qdisc under cbs, so there's another level of control for time-sensitive traffic. Signed-off-by: Vinicius Costa Gomes --- net/sched/sch_cbs.c | 134

Re: [RFC iproute2-next v1 5/5] tc: Add support for configuring the taprio scheduler

Hi, Stephen Hemminger writes: > On Fri, 13 Jul 2018 17:06:11 -0700 > Vinicius Costa Gomes wrote: > >> +while (fscanf(f, "%ms %x %" PRIu32 "\n", _str, , >> ) != EOF) { >> +struct rtattr *entry; >> + >> +er

Re: [RFC net-next v1 1/1] net/sched: Introduce the taprio scheduler

Hi Jiri, Jiri Pirko writes: [...] >> >>gates.sched > > Any particular reason this has to be in file and not on the cmdline? The idea here was to keep longer schedules more manageable. And during testing I found it more ergonomic to have a file. It also has the advantage that the file can be

[RFC iproute2-next v1 0/5] net/sched: Introduce the taprio scheduler

Hi, This is iproute2 side of the taprio RFC series. Please see the kernel side cover letter for more information about how to test this. Cheers, -- Vinicius Jesus Sanchez-Palencia (1): libnetlink: Add helper for getting a __s32 from netlink msgs Vinicius Costa Gomes (4): utils

[RFC net-next v1 1/1] net/sched: Introduce the taprio scheduler

rts; - clockid: specifies the reference clock to be used; Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 49 ++ net/sched/Kconfig | 11 + net/sched/Makefile | 1 + net/sched/sch_taprio.c | 952 + 4 f

[RFC iproute2-next v1 1/5] utils: Implement get_s64()

Add this helper to read signed 64-bit integers from a string. --- include/utils.h | 1 + lib/utils.c | 21 + 2 files changed, 22 insertions(+) diff --git a/include/utils.h b/include/utils.h index 8cb4349e..58574a05 100644 --- a/include/utils.h +++ b/include/utils.h @@

[RFC iproute2-next v1 3/5] libnetlink: Add helper for getting a __s32 from netlink msgs

From: Jesus Sanchez-Palencia This function retrieves a signed 32-bit integer from a netlink message and returns it. Signed-off-by: Jesus Sanchez-Palencia --- include/libnetlink.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index

[RFC iproute2-next v1 5/5] tc: Add support for configuring the taprio scheduler

-by: Vinicius Costa Gomes Signed-off-by: Jesus Sanchez-Palencia --- tc/Makefile | 1 + tc/q_taprio.c | 450 ++ 2 files changed, 451 insertions(+) create mode 100644 tc/q_taprio.c diff --git a/tc/Makefile b/tc/Makefile index dfd00267..6534d69b

[RFC iproute2-next v1 4/5] include: add definitions for taprio [DO NOT COMMIT]

DO NOT COMMIT This patch exists only to ease the testing, until this header is updated with the definitions from the kernel. Signed-off-by: Vinicius Costa Gomes --- include/uapi/linux/pkt_sched.h | 48 ++ 1 file changed, 48 insertions(+) diff --git a/include

[RFC iproute2-next v1 2/5] include: Add helper to retrieve a __s64 from a netlink msg

This allows signed 64-bit integers to be retrieved from a netlink message. --- include/libnetlink.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/libnetlink.h b/include/libnetlink.h index 9d9249e6..88164975 100644 --- a/include/libnetlink.h +++ b/include/libnetlink.h @@

[RFC net-next v1 0/1] net/sched: Introduce the taprio scheduler

test [4] https://github.com/vcgomes/linux/tree/taprio-RFC-v1 [5] https://github.com/vcgomes/iproute2/tree/taprio-RFC-v1 Vinicius Costa Gomes (1): net/sched: Introduce the taprio scheduler include/uapi/linux/pkt_sched.h | 49 ++ net/sched/Kconfig | 11 + net/sched/Makefile

Re: [PATCH iproute2-next 3/3] treewide: Use addattr_nest()/addattr_nest_end() to handle nested attributes

Hi, Serhey Popovych writes: [...] > diff --git a/tc/q_mqprio.c b/tc/q_mqprio.c > index 89b4600..207d644 100644 > --- a/tc/q_mqprio.c > +++ b/tc/q_mqprio.c > @@ -173,8 +173,7 @@ static int mqprio_parse_opt(struct qdisc_util *qu, int > argc, > argc--;

[next-queue PATCH v7 05/10] igb: Add support for enabling queue steering in filters

against i210), only support for the i210 model is enabled. These functions are exported and will be used in the next patch. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- .../net/ethernet/intel/igb/e1000_defines.h| 1 + drivers/net/ethernet/intel/igb/igb.h

[next-queue PATCH v7 04/10] igb: Add support for MAC address filters specifying source addresses

Makes it possible to direct packets to queues based on their source address. Documents the expected usage of the 'flags' parameter. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- .../net/ethernet/intel/igb/e1000_defines.h| 1 + drivers/net/ethernet/intel/igb

[next-queue PATCH v7 02/10] igb: Fix queue selection on MAC filters on i210

e previous behaviour was having no effect for i210 based controllers because the QSEL bit of the RAH register wasn't being set. This patch separates the condition in discrete cases, so the different handling is clearer. Fixes: 83c21335c876 ("igb: improve MAC filter handling") Signe

[next-queue PATCH v7 06/10] igb: Allow filters to be added for the local MAC address

ey are removed, only the steering configuration is reset. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 40 --- 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igb

[next-queue PATCH v7 00/10] igb: offloading of receive filters

ot;num_tc"? -- Vinicius Costa Gomes (10): igb: Fix not adding filter elements to the list igb: Fix queue selection on MAC filters on i210 igb: Enable the hardware traffic class feature bit for igb models igb: Add support for MAC address filters specifying source addresses igb: Add suppo

[next-queue PATCH v7 03/10] igb: Enable the hardware traffic class feature bit for igb models

This will allow functionality depending on the hardware being traffic class aware to work. In particular the tc-flower offloading checks verifies that this bit is set. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++

[next-queue PATCH v7 07/10] igb: Enable nfc filters to specify MAC addresses

. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb.h | 4 +++ drivers/net/ethernet/intel/igb/igb_ethtool.c | 28 2 files changed, 32 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drive

[next-queue PATCH v7 09/10] igb: Add the skeletons for tc-flower offloading

This adds basic functions needed to implement offloading for filters created by tc-flower. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/drive

[next-queue PATCH v7 10/10] igb: Add support for adding offloaded clsflower filters

the ethernet type (0x22f0) to steer traffic to queue 1) Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb.h | 2 + drivers/net/ethernet/intel/igb/igb_main.c | 188 +- 2 files changed, 188 insertions(+), 2 del

[next-queue PATCH v7 01/10] igb: Fix not adding filter elements to the list

on") Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index e77ba0d

[next-queue PATCH v7 08/10] igb: Add MAC address support for ethtool nftuple filters

"aa:aa:aa:aa:aa:aa" to the RX queue 0) $ ethtool -N eth0 flow-type ether src 44:44:44:44:44:44 \ proto 0x22f0 action 3 (this will direct packets with source address "44:44:44:44:44:44" and ethertype 0x22f0 to the RX queue 3) Signed-off-by:

RE: [Intel-wired-lan] [next-queue PATCH v6 10/10] igb: Add support for adding offloaded clsflower filters

Hi, "Brown, Aaron F" <aaron.f.br...@intel.com> writes: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >> Behalf Of Vinicius Costa Gomes >> Sent: Thursday, March 29, 2018 2:08 PM >> To: intel-wired-...@lists.osuosl.org >>

RE: [Intel-wired-lan] [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters

Hi, "Brown, Aaron F" writes: [...] > >> >> I added that note in the hope that someone else would have an stronger >> opinion about what to do. > > I don't have a strong opinion beyond my preference for an ideal world > where everything works :) If the part simply

RE: [Intel-wired-lan] [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters

Hi, "Brown, Aaron F" <aaron.f.br...@intel.com> writes: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >> Behalf Of Vinicius Costa Gomes >> Sent: Thursday, March 29, 2018 2:08 PM >> To: intel-wired-...@lists.osuosl.org >>

[next-queue PATCH] igb: Fix the transmission mode of queue 0 for Qav mode

2 2 2 2 2 2 2 2 2 2 queues 1@0 1@1 2@2 hw 0 $ tc qdisc replace dev enp2s0 parent 100:2 cbs locredit -1470 \ hicredit 30 sendslope -98 idleslope 20000 offload 1 Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 17 +

[next-queue PATCH v6 02/10] igb: Fix queue selection on MAC filters on i210

e previous behaviour was having no effect for i210 based controllers because the QSEL bit of the RAH register wasn't being set. This patch separates the condition in discrete cases, so the different handling is clearer. Fixes: 83c21335c876 ("igb: improve MAC filter handling") Signe

[next-queue PATCH v6 03/10] igb: Enable the hardware traffic class feature bit for igb models

This will allow functionality depending on the hardware being traffic class aware to work. In particular the tc-flower offloading checks verifies that this bit is set. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++

[next-queue PATCH v6 09/10] igb: Add the skeletons for tc-flower offloading

This adds basic functions needed to implement offloading for filters created by tc-flower. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/drive

[next-queue PATCH v6 04/10] igb: Add support for MAC address filters specifying source addresses

Makes it possible to direct packets to queues based on their source address. Documents the expected usage of the 'flags' parameter. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/e1000_defines.h | 1 + drivers/net/ethernet/intel/igb

[next-queue PATCH v6 06/10] igb: Allow filters to be added for the local MAC address

ey are removed, only the steering configuration is reset. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 40 +++ 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel

[next-queue PATCH v6 00/10] igb: offloading of receive filters

we need to increase this value, the only way I could find is to use mqprio (for example). Should igb be initialized with, say, the number of queues as its "num_tc"? Vinicius Costa Gomes (10): igb: Fix not adding filter elements to the list igb: Fix queue selection on MAC filters on i

[next-queue PATCH v6 10/10] igb: Add support for adding offloaded clsflower filters

. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb.h | 2 + drivers/net/ethernet/intel/igb/igb_main.c | 188 +- 2 files changed, 188 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/ig

[next-queue PATCH v6 05/10] igb: Add support for enabling queue steering in filters

against i210), only support for the i210 model is enabled. These functions are exported and will be used in the next patch. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/e1000_defines.h | 1 + drivers/net/ethernet/intel/igb

[next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters

(this will direct packets with destination address "aa:aa:aa:aa:aa:aa" to the RX queue 0) $ ethtool -N eth0 flow-type ether src 44:44:44:44:44:44 action 3 (this will direct packets with source address "44:44:44:44:44:44" to the RX queue 3) Signed-off-by: Vinicius Cost

[next-queue PATCH v6 07/10] igb: Enable nfc filters to specify MAC addresses

. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb.h | 4 drivers/net/ethernet/intel/igb/igb_ethtool.c | 28 2 files changed, 32 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb.h b/d

[next-queue PATCH v6 01/10] igb: Fix not adding filter elements to the list

on") Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index e77ba0d

RE: [Intel-wired-lan] [next-queue PATCH v5 7/9] igb: Add MAC address support for ethtool nftuple filters

Hi Aaron, "Brown, Aaron F" writes: [...] > And watching the rx_queue counters continues to be spread across the > different queues. This is with Jeff Kirsher's next queue, kernel > 4.16.0-rc4_next-queue_dev-queue_e31d20a, which has the series of 8 igb > patches

RE: [Intel-wired-lan] [next-queue PATCH v5 7/9] igb: Add MAC address support for ethtool nftuple filters

Hi Aaron, "Brown, Aaron F" writes: > > Maybe not "this" patch, but this is the one that enables the ethtool > commands, so replying here. > The filters do not seem to take effect with this version (v5) of the > series. The commands are accepted for i210 and rejected

[next-queue PATCH v5 1/9] igb: Fix not adding filter elements to the list

on") Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index 606e676

[next-queue PATCH v5 3/9] igb: Enable the hardware traffic class feature bit for igb models

This will allow functionality depending on the hardware being traffic class aware to work. In particular the tc-flower offloading checks verifies that this bit is set. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++

[next-queue PATCH v5 6/9] igb: Enable nfc filters to specify MAC addresses

. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb.h | 4 drivers/net/ethernet/intel/igb/igb_ethtool.c | 28 2 files changed, 32 insertions(+) diff --git a/drivers/net/ethernet/intel/igb/igb.h b/d

[next-queue PATCH v5 8/9] igb: Add the skeletons for tc-flower offloading

This adds basic functions needed to implement offloading for filters created by tc-flower. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb_main.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/drive

[next-queue PATCH v5 0/9] igb: offloading of receive filters

estion: - igb is initialized with the number of traffic classes as 1, if we want to use multiple traffic classes we need to increase this value, the only way I could find is to use mqprio (for example). Should igb be initialized with, say, the number of queues as its "num_tc"

[next-queue PATCH v5 4/9] igb: Add support for MAC address filters specifying source addresses

Makes it possible to direct packets to queues based on their source address. Documents the expected usage of the 'flags' parameter. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/e1000_defines.h | 1 + drivers/net/ethernet/intel/igb

[next-queue PATCH v5 7/9] igb: Add MAC address support for ethtool nftuple filters

(this will direct packets with destination address "aa:aa:aa:aa:aa:aa" to the RX queue 0) $ ethtool -N eth0 flow-type ether src 44:44:44:44:44:44 action 3 (this will direct packets with source address "44:44:44:44:44:44" to the RX queue 3) Signed-off-by: Vinicius Cost

[next-queue PATCH v5 2/9] igb: Fix queue selection on MAC filters on i210

e previous behaviour was having no effect for i210 based controllers because the QSEL bit of the RAH register wasn't being set. This patch separates the condition in discrete cases, so the different handling is clearer. Fixes: 83c21335c876 ("igb: improve MAC filter handling") Signe

[next-queue PATCH v5 5/9] igb: Add support for enabling queue steering in filters

against i210), only support for the i210 model is enabled. These functions are exported and will be used in the next patch. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/e1000_defines.h | 1 + drivers/net/ethernet/intel/igb

[next-queue PATCH v5 9/9] igb: Add support for adding offloaded clsflower filters

. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- drivers/net/ethernet/intel/igb/igb.h | 2 + drivers/net/ethernet/intel/igb/igb_main.c | 188 +- 2 files changed, 188 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/ig

Re: [Intel-wired-lan] [next-queue PATCH v4 6/8] igb: Add MAC address support for ethtool nftuple filters

Hi, Alexander Duyck <alexander.du...@gmail.com> writes: > On Tue, Mar 13, 2018 at 8:04 PM, Brown, Aaron F <aaron.f.br...@intel.com> > wrote: >>> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >>> Behalf Of Vinicius Costa Gomes >&g

[PATCH net-next v3 0/1] skbuff: Fix applications not being woken for errors

er it (my hypothesis is that only triggers when the error is reported from a different task context than the application). Am I missing something here? Cheers, Vinicius Costa Gomes (1): selftests/txtimestamp: Add more configurable parameters .../selftests/networking/timestamping/txtimestamp.c |

[PATCH net-next v3 1/1] selftests/txtimestamp: Add more configurable parameters

Add a way to configure if poll() should wait forever for an event, the number of packets that should be sent for each and if there should be any delay between packets. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- .../selftests/networking/timestamping/txtimestamp.

[PATCH net-next v2 2/2] skbuff: Fix not waking applications when errors are enqueued

x-2.6.12-rc2") Reported-by: Randy E. Witt <randy.e.w...@intel.com> Reviewed-by: Eric Dumazet <eduma...@google.com> Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/co

[PATCH net-next v2 1/2] selftests/txtimestamp: Add more configurable parameters

Add a way to configure if poll() should wait forever for an event, the number of packets that should be sent for each and if there should be any delay between packets. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- .../selftests/networking/timestamping/txtimestamp.

[PATCH net-next v2 0/2] skbuff: Fix applications not being woken for errors

t seems that this problem existed since a long time ago (pre git) and was uncommon for folks to reach the necessary conditions to trigger it (my hypothesis is that only triggers when the error is reported from a different task context than the application). Am I missing something here? Ch

[PATCH net] skbuff: Fix not waking applications when errors are enqueued

x-2.6.12-rc2") Reported-by: Randy E. Witt <randy.e.w...@intel.com> Reviewed-by: Eric Dumazet <eduma...@google.com> Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/co

RE: [Intel-wired-lan] [next-queue PATCH v4 6/8] igb: Add MAC address support for ethtool nftuple filters

Hi, "Brown, Aaron F" <aaron.f.br...@intel.com> writes: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >> Behalf Of Vinicius Costa Gomes >> Sent: Wednesday, March 7, 2018 4:37 PM >> To: intel-wired-...@lists.osuosl.org >>

Re: [PATCH net-next 0/2] skbuff: Fix applications not being woken for errors

Hi, Willem de Bruijn writes: >> Another interesting fact is that if the POLLIN event is added to the >> poll() .events, poll() no longer becomes stuck, > > The process has registered interest only in POLLIN, which the call to > sk_data_read (sock_def_readable)

RE: [Intel-wired-lan] [next-queue PATCH v4 2/8] igb: Fix queue selection on MAC filters on i210 and i211

Hi, "Brown, Aaron F" writes: >> --- a/drivers/net/ethernet/intel/igb/igb_main.c >> +++ b/drivers/net/ethernet/intel/igb/igb_main.c >> @@ -8747,12 +8747,19 @@ static void igb_rar_set_index(struct igb_adapter >> *adapter, u32 index) >> if

[PATCH net-next 1/2] selftests/txtimestamp: Add more configurable parameters

Add a way to configure if poll() should wait forever for an event, the number of packets that should be sent for each and if there should be any delay between packets. Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- .../selftests/networking/timestamping/txtimestamp.

[PATCH net-next 0/2] skbuff: Fix applications not being woken for errors

that only triggers when the error is reported from a different task context than the application). Am I missing something here? Cheers, -- Vinicius Costa Gomes (2): selftests/txtimestamp: Add more configurable parameters skbuff: Fix not waking applications when errors

[PATCH net-next 2/2] skbuff: Fix not waking applications when errors are enqueued

dy.e.w...@intel.com> Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- net/core/skbuff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 715c13495ba6..6def3534f509 100644 --- a/net/core/skbuff.c +++ b/ne

Re: [RFC PATCH v0 2/2] skbuff: Notify errors with sk_error_report()

Hi Eric Dumazet <eric.duma...@gmail.com> writes: > On 03/12/2018 04:10 PM, Vinicius Costa Gomes wrote: >> When errors are enqueued to the error queue via sock_queue_err_skb() >> function, it is possible that the correct application is not notified. > > Your patch

[RFC PATCH v0 2/2] skbuff: Notify errors with sk_error_report()

When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the correct application is not notified. Reported-by: Randy E. Witt <randy.e.w...@intel.com> Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com> --- net/core/skbuff.c |

  1   2   3   >