[PATCH V2 net-next 5/6] macvlan/macvtap: Add support for SCTP checksum offload.

2018-05-01 Thread Vladislav Yasevich
Since we now have support for software CRC32c offload, turn it on for macvlan and macvtap devices so that guests can take advantage of offload SCTP checksums to the host or host hardware. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 5 +++-- drive

[PATCH V2 net-next 3/6] sctp: Build sctp offload support into the base kernel

2018-05-01 Thread Vladislav Yasevich
kernel. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/net/sctp/sctp.h | 5 - net/Kconfig | 1 + net/sctp/Kconfig| 1 - net/sctp/Makefile | 3 ++- net/sctp/offload.c | 4 +++- net/sctp/protocol.c | 3 --- 6 files changed, 6 insertions(

[PATCH V2 net-next 1/6] virtio: Add support for SCTP checksum offloading

2018-05-01 Thread Vladislav Yasevich
eal with it. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 14 +- include/linux/virtio_net.h | 6 ++ include/uapi/linux/virtio_net.h | 5 + 3 files changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/net/virti

[PATCH V2 net-next 4/6] tun: Add support for SCTP checksum offload

2018-05-01 Thread Vladislav Yasevich
Adds a new tun offload flag to allow for SCTP checksum offload. The flag has to be set by the user and defaults to "no offload". Add SCTP checksum support to the supported tun features. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/tun.c | 7

[PATCH V2 net-next 0/6] virtio-net: Add SCTP checksum offload support

2018-05-01 Thread Vladislav Yasevich
to high bits - distinguish between GUEST and HOST features - Fixed offload control command to control sctp checksum offload - added ipvlan support Vladislav Yasevich (6): virtio: Add support for SCTP checksum offloading sctp: Handle sctp packets with CHECKSUM_PARTIAL sctp: Build

[PATCH V2 net-next 2/6] sctp: Handle sctp packets with CHECKSUM_PARTIAL

2018-05-01 Thread Vladislav Yasevich
an SCTP packet with CHECKSUM_PARTIAL will have checksum set to 0. Let SCTP treat this as a valid checksum if CHECKSUM_PARTIAL is set. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/sctp/input.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ne

[PATCH V2 net-next 6/6] ipvlan: Add support for SCTP checksum offload

2018-05-01 Thread Vladislav Yasevich
Since ipvlan is a software device, we can turn on SCTP checksum offload and let the checksum be computed at the lower layer. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/ipvlan/ipvlan_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/d

[PATCH net-next 1/5] virtio: Add support for SCTP checksum offloading

2018-04-02 Thread Vladislav Yasevich
will know to perform an alternate checksum calculation, which right now is only CRC32c. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 11 --- include/linux/virtio_net.h | 6 ++ include/uapi/linux/virtio_net.h | 2 ++ 3 files c

[PATCH net-next 5/5] macvlan/macvtap: Add support for SCTP checksum offload.

2018-04-02 Thread Vladislav Yasevich
Since we now have support for software CRC32c offload, turn it on for macvlan and macvtap devices so that guests can take advantage of offload SCTP checksums to the host or host hardware. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 5 +++-- d

[PATCH net-next 4/5] tun: Add support for SCTP checksum offload

2018-04-02 Thread Vladislav Yasevich
Adds a new tun offload flag to allow for SCTP checksum offload. The flag has to be set by the user and defaults to "no offload". Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/tun.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/tun

[PATCH net-next 2/5] sctp: Handle sctp packets with CHECKSUM_PARTIAL

2018-04-02 Thread Vladislav Yasevich
an SCTP packet with CHECKSUM_PARTIAL will have checksum set to 0. Let SCTP treat this as a valid checksum if CHECKSUM_PARTIAL is set. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/sctp/input.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/ne

[PATCH net-next 0/5] virtio-net: Add SCTP checksum offload support

2018-04-02 Thread Vladislav Yasevich
ort to virtio. To add true GSO, would require a lot of re-work inside of SCTP and would require extensions to the virtio net header to carry extra sctp data. Vladislav Yasevich (5): virtio: Add support for SCTP checksum offloading sctp: Handle sctp packets with CHECKSUM_PARTIAL sctp: Build

[PATCH net-next 3/5] sctp: Build sctp offload support into the base kernel

2018-04-02 Thread Vladislav Yasevich
We need to take the sctp offload out of the sctp module and add it to the base kernel to support guests that can support it. This is similar to how IPv6 offloads are done and works around kernels that exclude sctp protocol support. Signed-off-by: Vladislav Yasevich <vyase...@redhat.

[PATCH V2 net 3/4] macvlan: convert port passthru to flags.

2017-06-21 Thread Vladislav Yasevich
Convert the port passthru boolean into flags with accesor functions. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/net/macvlan.c b/drive

[PATCH V2 net 4/4] macvlan: Let passthru macvlan correctly restore lower mac address

2017-06-21 Thread Vladislav Yasevich
directly to the lower device mac address will be kept. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/mac

[PATCH V2 net 0/4] macvlan: Fix some issues with changing mac addresses

2017-06-21 Thread Vladislav Yasevich
and then removing it, the mac address of the physical device remains changed. This patch series attempts to resolve these issues. V2: Address a small issue in p4 where we save the address from the lowerdev (from girish.moodalb...@oracle.com) Thanks -vlad Vladislav Yasevich (4): macvlan: Do

[PATCH V2 net 1/4] macvlan: Do not return error when setting the same mac address

2017-06-21 Thread Vladislav Yasevich
The user currently gets an EBUSY error when attempting to set the mac address on a macvlan device to the same value. This should really be a no-op as nothing changes. Catch the condition and return early. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan

[PATCH V2 net 2/4] macvlan: Fix passthru macvlan mac address inheritance

2017-06-21 Thread Vladislav Yasevich
device in case of passthru macvlan device, since the 2 addresses are _supposed_ to be the same. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/mac

[PATCH net 2/4] macvlan: Fix passthru macvlan mac address inheritance

2017-06-16 Thread Vladislav Yasevich
device in case of passthru macvlan device, since the 2 addresses are _supposed_ to be the same. Fixes: e289fd281 (macvlan: fix the problem when mac address changes for passthru mode) Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 3 ++- 1 file chan

[PATCH net 4/4] macvlan: Let passthru macvlan correctly restore lower mac address

2017-06-16 Thread Vladislav Yasevich
directly to the lower device mac address will be kept. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/mac

[PATCH net 3/4] macvlan: convert port passthru to flags.

2017-06-16 Thread Vladislav Yasevich
Convert the port passthru boolean into flags with access functions. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/net/macvlan.c b/drive

[PATCH net 1/4] macvlan: Do not return error when setting the same mac address

2017-06-16 Thread Vladislav Yasevich
The user currently gets an EBUSY error when attempting to set the mac address on a macvlan device to the same value. This should really be a no-op as nothing changes. Catch the condition and return early. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan

[PATCH net 0/4] macvlan: Fix some issues with changing mac addresses

2017-06-16 Thread Vladislav Yasevich
and then removing it, the mac address of the physical device remains changed. This patch series attempts to resolve these issues. Thanks -vlad Vladislav Yasevich (4): macvlan: Do not return error when setting the same mac address macvlan: Fix passthru macvlan mac address inheritance macvlan

[PATCH V7 net-next iproute] ip: Add IFLA_EVENT output to ip monitor

2017-06-01 Thread Vladislav Yasevich
Add IFLA_EVENT output so that event types can be viewed with 'monitor' command. This gives a little more information for why a given message was received. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- v7: change the names to make it more generic then just netdev events. U

[PATCH net-next] rtnetlink: use the new rtnl_get_event() interface

2017-05-30 Thread Vladislav Yasevich
Small clean-up to rtmsg_ifinfo() to use the rtnl_get_event() interface instead of using 'internal' values directly. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/ne

[PATCH V6 net-next 1/2] rtnl: Add support for netdev event to link messages

2017-05-27 Thread Vladislav Yasevich
happend for these events. This patch adds a new extension to RTM_NEWLINK message called IFLA_EVENT that would have an encoding of event that triggered this message. This would allow the the message consumer to easily determine if it needs to perform certain actions. Signed-off-by: Vladislav Yasevich

[PATCH V6 net-next iproute] ip: Add support for netdev events to monitor

2017-05-27 Thread Vladislav Yasevich
Add IFLA_EVENT handling so that event types can be viewed with 'monitor' command. This gives a little more information for why a given message was receivied. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/linux/if_link.h | 11 +++ ip/ipaddress.c

[PATCH V6 net-next 2/2] bonding: Prevent duplicate userspace notification

2017-05-27 Thread Vladislav Yasevich
event and uses that function in the syfs and ioctl cases. This was discovered while auditing all the different envents and continues the effort of cleaning up duplicated netlink messages. CC: David Ahern <d...@cumulusnetworks.com> CC: Jiri Pirko <j...@resnulli.us> Signed-off-b

[PATCH V6 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-05-27 Thread Vladislav Yasevich
missed events (from David Ahern) Vladislav Yasevich (2): rtnl: Add support for netdev event to link messages bonding: Prevent duplicate userspace notification drivers/net/bonding/bond_main.c| 3 +- drivers/net/bonding/bond_options.c | 27 ++-- include/linux/rtnetlink.h

[PATCH v5 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-05-25 Thread Vladislav Yasevich
. V3: Rebased. Cleaned-up duplicate event. V2: Added missed events (from David Ahern) Vladislav Yasevich (2): rtnl: Add support for netdev event to link messages bonding: Prevent duplicate userspace notification drivers/net/bonding/bond_main.c| 3 +- drivers/net/bonding/bond_options.c

[PATCH V5 2/2] bonding: Prevent duplicate userspace notification

2017-05-25 Thread Vladislav Yasevich
event and uses that function in the syfs and ioctl cases. This was discovered while auditing all the different envents and continues the effort of cleaning up duplicated netlink messages. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/bonding/bond_main.c

[PATCH V5 iproute] ip: Add support for netdev events to monitor

2017-05-25 Thread Vladislav Yasevich
Add IFLA_EVENT handling so that event types can be viewed with 'monitor' command. This gives a little more information for why a given message was receivied. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/linux/if_link.h | 11 +++ ip/ipaddress.c

[PATCH V5 1/2] rtnl: Add support for netdev event to link messages

2017-05-25 Thread Vladislav Yasevich
happend for these events. This patch adds a new extension to RTM_NEWLINK message called IFLA_EVENT that would have an encoding of event that triggered this message. This would allow the the message consumer to easily determine if it needs to perform certain actions. Signed-off-by: Vladislav Yasevich

[PATCH V3 net 2/3] be2net: Fix offload features for Q-in-Q packets

2017-05-23 Thread Vladislav Yasevich
traffic. CC: Sathya Perla <sathya.pe...@broadcom.com> CC: Ajit Khaparde <ajit.khapa...@broadcom.com> CC: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> CC: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --

[PATCH V3 net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans

2017-05-23 Thread Vladislav Yasevich
com> Acked-by: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 665627c..ead7a58 100644 --- a/driver

[PATCH V3 net 0/3] Fix checksum issues with Q-in-Q vlans

2017-05-23 Thread Vladislav Yasevich
g. If any drivers are found to be broken, they would need be fixed individually. Vladislav Yasevich (3): vlan: Fix tcp checksum offloads in Q-in-Q vlans be2net: Fix offload features for Q-in-Q packets virtio-net: enable TSO/checksum offloads for Q-in-Q vlans drivers/net/ethernet/emulex/benet

[PATCH V3 net 1/3] vlan: Fix tcp checksum offloads in Q-in-Q vlans

2017-05-23 Thread Vladislav Yasevich
rbitrarily long headers can be checksummed. This patch disables IP|IPV6 checksums on the packet for multi-tagged packets. CC: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> CC: Michal Kubecek <mkube...@suse.cz> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> ---

[PATCH V2 net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans

2017-05-23 Thread Vladislav Yasevich
com> Acked-by: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 665627c..ead7a58 100644 --- a/driver

[PATCH V2 net 2/3] be2net: Fix offload features for Q-in-Q packets

2017-05-23 Thread Vladislav Yasevich
traffic. CC: Sathya Perla <sathya.pe...@broadcom.com> CC: Ajit Khaparde <ajit.khapa...@broadcom.com CC: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> CC: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> ---

[PATCH V2 net 0/3] Fix checksum issues with Q-in-Q vlans

2017-05-23 Thread Vladislav Yasevich
be broken, they would need be fixed individually. Vladislav Yasevich (3): vlan: Fix tcp checksum offloads in Q-in-Q vlans be2net: Fix offload features for Q-in-Q packets virtio-net: enable TSO/checksum offloads for Q-in-Q vlans drivers/net/ethernet/emulex/benet/be_main.c | 4 +++- d

[PATCH V2 net 1/3] vlan: Fix tcp checksum offloads in Q-in-Q vlans

2017-05-23 Thread Vladislav Yasevich
arily long headers can be checksummed. This patch disables IP|IPV6 checksums on the packet for multi-tagged packets. CC: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> CC: Michal Kubecek <mkube...@suse.cz> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> ---

[PATCH net 3/3] virtio-net: enable TSO/checksum offloads for Q-in-Q vlans

2017-05-18 Thread Vladislav Yasevich
..@redhat.com> CC: Jason Wang <jasow...@redhat.com> CC: virtualizat...@lists.linux-foundation.org Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_

[PATCH net 1/3] vlan: Fix tcp checksums offloads for Q-in-Q vlan.

2017-05-18 Thread Vladislav Yasevich
by default when sending Q-in-Q traffic. Devices that are proven to work can provided a corrected ndo_features_check implemetation. Fixes: 8cb65d000 ("net: Move check for multiple vlans to drivers") CC: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> Signed-off-by: Vladislav

[PATCH net 2/3] be2net: Fix offload features for Q-in-Q packets

2017-05-18 Thread Vladislav Yasevich
traffic. CC: Sathya Perla <sathya.pe...@broadcom.com> CC: Ajit Khaparde <ajit.khapa...@broadcom.com CC: Sriharsha Basavapatna <sriharsha.basavapa...@broadcom.com> CC: Somnath Kotur <somnath.ko...@broadcom.com> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> ---

[PATCH net 0/3] vlan: Offload fixes for Q-in-Q vlans

2017-05-18 Thread Vladislav Yasevich
ackets sent through Q-in-Q vlans. It is up to individual drivers to enable it properly through ndo_features_check if they have some support for Q-in-Q vlans. Vladislav Yasevich (3): vlan: Fix Q-in-Q vlan support. be2net: Fix offload features for Q-in-Q packets virtio-net: enable TSO/ch

[PATCH net] macvlan: Fix performance issues with vlan tagged packets

2017-05-11 Thread Vladislav Yasevich
overlow the macvtap queue. This patch adds the always on offloads to vlan_features. This makes sure that any vlan tagged traffic between 2 guest will not be segmented needlessly. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.c | 7 +-- 1 file chan

[PATCH v4 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-05-05 Thread Vladislav Yasevich
messages on bonding option changes. V3: Rebased. Cleaned-up duplicate event. V2: Added missed events (from David Ahern) Vladislav Yasevich (2): rtnl: Add support for netdev event to link messages bonding: Prevent duplicate userspace notification drivers/net/bonding/bond_main.c| 3

[PATCH V4 net-next 2/2] bonding: Prevent duplicate userspace notification

2017-05-05 Thread Vladislav Yasevich
event and uses that function in the syfs and ioctl cases. This was discovered while auditing all the different envents and continues the effort of cleaning up duplicated netlink messages. CC: David Ahern <d...@cumulusnetworks.com> CC: Jiri Pirko <j...@resnulli.us> Signed-off-b

[PATCH V3 net-next 1/2] rtnl: Add support for netdev event to link messages

2017-05-05 Thread Vladislav Yasevich
happend for these events. This patch adds a new extension to RTM_NEWLINK message called IFLA_EVENT that would have an encoding of event that triggered this message. This would allow the the message consumer to easily determine if it needs to perform certain actions. Signed-off-by: Vladislav Yasevich

[PATCH v2] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Vladislav Yasevich
on the vlan device while being disabled on the HW. However, the GSO code will correctly process the packets. This actually results in slightly better raw throughput. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- V2: posted the right patch. net/8021q/vlan_dev.c | 13 ++---

[PATCH] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

2017-05-05 Thread Vladislav Yasevich
on the vlan device while being disabled on the HW. However, the GSO code will correctly process the packets. This actually results in slightly better raw throughput. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/8021q/vlan_dev.c | 10 -- 1 file changed, 8 insertions

[PATCH net-next V3 2/2] rtnl: Add support for netdev event attribute to link messages

2017-04-21 Thread Vladislav Yasevich
happend for these events. This patch adds a new extension to RTM_NEWLINK message called IFLA_EVENT that would have an encoding of event that triggered this message. This would allow the the message consumer to easily determine if it needs to perform certain actions. Signed-off-by: Vladislav Yasevich

[PATCH v3 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-04-21 Thread Vladislav Yasevich
+++ 4 files changed, 123 insertions(+), 24 deletions(-) -- 2.7.4 Vladislav Yasevich (2): rtnetlink: Disable notification for NETDEV_NAMECHANGE event rtnl: Add support for netdev event to link messages include/linux/rtnetlink.h| 3 ++- include/uapi/linux/if_link.h | 11

Re: [PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-21 Thread Vladislav Yasevich
On Fri, Apr 21, 2017 at 1:33 AM, Michal Kubecek wrote: > On Thu, Apr 20, 2017 at 07:19:55PM -0400, Vlad Yasevich wrote: >> >> Having said that, the other alternative is to inherit hw_features from >> lower devices. BTW, bonding I think has a similar "issue" you are >>

[PATCH net-next 1/2] rtnetlink: Disable notification for NETDEV_NAMECHANGE event

2017-04-21 Thread Vladislav Yasevich
The data signaling name change is already provided at the end of do_setlink(). This event handler just generates a duplicate announcement. Disable it. CC: David Ahern <d...@cumulusnetworks.com> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/core/rtnetlink.c |

[PATCH V2 net] netdevice: Include NETIF_F_HW_CSUM when intersecting features

2017-04-20 Thread Vladislav Yasevich
Kubecek <mkube...@suse.cz> CC: Alexander Duyck <alexander.du...@gmail.com> CC: Tom Herbert <t...@herbertland.com> Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- V2: Addressed comments from Alex Duyck. I tested this with hacked virtio device that set IP|IPV6

[PATCH net] netdevice: Prefer NETIF_F_HW_CSUM when intersecting features

2017-04-19 Thread Vladislav Yasevich
offloading features on the software device. This patch resolves that by prefering the NETIF_F_HW_CSUM setting when computing a feature intersect. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/linux/netdevice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH RFC (resend) net-next 1/6] virtio-net: Remove the use the padded vnet_header structure

2017-04-15 Thread Vladislav Yasevich
We can replace the structure with a properly aligned size instead. The current structure attempts to align on a 16 byte boundary, so preserve it. Signed-off-by: Vlad Yaseivch --- drivers/net/virtio_net.c | 22 -- 1 file changed, 12 insertions(+), 10

[PATCH RFC (resend) net-next 4/6] virtio-net: Add support for IPv6 fragment id vnet header extension.

2017-04-15 Thread Vladislav Yasevich
to predict. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 27 +-- include/linux/virtio_net.h | 20 include/uapi/linux/virtio_net.h | 7 +++ 3 files changed, 52 insertions(+), 2 deletions(-)

[PATCH RFC (resend) net-next 3/6] virtio_net: Add basic skeleton for handling vnet header extensions.

2017-04-15 Thread Vladislav Yasevich
This is the basic sceleton which will be fleshed out by individiual extensions. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 21 + include/linux/virtio_net.h | 12 include/uapi/linux/virtio_net.

[PATCH RFC (resend) net-next 5/6] virtio-net: Add support for vlan acceleration vnet header extension.

2017-04-15 Thread Vladislav Yasevich
will enabled HW accelerated vlan features. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 17 - include/linux/virtio_net.h | 17 + include/uapi/linux/virtio_net.h | 7 +++ 3 files changed, 40 insertions

[PATCH RFC (resend) net-next 6/6] virtio: Add support for UDP tunnel offload and extension.

2017-04-15 Thread Vladislav Yasevich
This patch provides the ablility to negotiate UDP tunnel offload features in the virtio devices as well as the necesary extension to pass additional information to the host. This work is based on earlier work by Jarno Rajahalme

[PATCH RFC (resend) net-next 2/6] virtio-net: make header length handling uniform

2017-04-15 Thread Vladislav Yasevich
Consistently use hdr_len stored in virtnet_info structure instead of direclty using specific sizes. This will be required as the size of the virtio net header grows due to future extensions. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c | 8

[PATCH RFC (resend) net-next 0/6] virtio-net: Add support for virtio-net header extensions

2017-04-15 Thread Vladislav Yasevich
e checksum. This series only takes care of virtio net. I have addition patches for the host side (vhost and tap/macvtap as well as qemu), but wanted to get feedback on the general approach first. Vladislav Yasevich (6): virtio-net: Remove the use the padded vnet_header structure virtio-net: make hea

[PATCH v3 iproute] ip: Add support for netdev events to monitor

2017-04-04 Thread Vladislav Yasevich
Add IFLA_EVENT handling so that event types can be viewed with 'monitor' command. This gives a little more information for why a given message was receivied. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/linux/if_link.h | 21 + ip/ipadd

[PATCH v2 net-next 2/2] rtnl: Add support for netdev event to link messages

2017-04-04 Thread Vladislav Yasevich
if it is interested in a particular event or not. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- V2: Added support for 2 missed event types. include/linux/rtnetlink.h| 3 +- include/uapi/linux/if_link.h | 21 ++ net/core/dev.c | 2 +- net/core/rtnet

[PATCH net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-04-04 Thread Vladislav Yasevich
monitor'. I actually need the ability to trap NETDEV_NOTIFY_PEERS event (as well as possible NETDEV_RESEND_IGMP) to support hanlding of macvtap on top of bonding. I hope others will also find this info usefull. Vladislav Yasevich (2): rtnetlink: Convert rtnetlink_event to white list rtnl: Add

[PATCH v2 net-next 1/2] rtnetlink: Convert rtnetlink_event to white list

2017-04-04 Thread Vladislav Yasevich
would have to be specifically added to the list to be sent to userspace. This would force new event implementers to consider whether a given event is usefull to user space or if it's just a kernel event. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- V2: Added missed events (from

[PATCH v2 net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-04-04 Thread Vladislav Yasevich
monitor'. I actually need the ability to trap NETDEV_NOTIFY_PEERS event (as well as possible NETDEV_RESEND_IGMP) to support hanlding of macvtap on top of bonding. I hope others will also find this info usefull. V2: Added missed events (from David Ahern) Vladislav Yasevich (2): rtnetlink: Convert

[PATCH v2] ip: Add support for netdev events to monitor

2017-03-31 Thread Vladislav Yasevich
Add IFLA_EVENT handling so that event types can be viewed with 'moniotr' command. This gives a little more information for why a given message was recevied. V2: Adds all events recently proposed. This way all currently supported events can be viewed. Signed-off-by: Vladislav Yasevich <vy

[PATCH V2 net-next 2/2] rtnetlink: Add support for netdev event to link messages

2017-03-31 Thread Vladislav Yasevich
if it is interested in a particular event or not. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/linux/rtnetlink.h| 3 +- include/uapi/linux/if_link.h | 19 ++ net/core/dev.c | 2 +- net/core/rtnetlink.c

[PATCH net-next 0/2] rtnetlink: Updates to rtnetlink_event()

2017-03-31 Thread Vladislav Yasevich
monitor'. I actually need the ability to trap NETDEV_NOTIFY_PEERS event (as well as possible NETDEV_RESEND_IGMP) to support hanlding of macvtap on top of bonding. I hope others will also find this info usefull. Vladislav Yasevich (2): rtnetlink: Convert rtnetlink_event to white list rtnl: Add

[PATCH net-next 1/2] rtnetlink: Convert rtnetlink_event to white list

2017-03-31 Thread Vladislav Yasevich
would have to be specifically added to the list to be sent to userspace. This would force new event implementers to consider whether a given event is usefull to user space or if it's just a kernel event. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/core/rtnetlink.

Re: [PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-30 Thread Vladislav Yasevich
otification makes the > intent explicit. > > Looking at git commit logs for NETDEV_PRECHANGEMTU, it seems that it was > added for bonding and teaming to simplify kernel processing; userspace > does not need to be notified so no intention there. > So, something like the patch below would be

[PATCH net-next] ipv6: add support for NETDEV_RESEND_IGMP event

2017-03-28 Thread Vladislav Yasevich
This patch adds support for NETDEV_RESEND_IGMP event similar to how it works for IPv4. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/net/ndisc.h | 2 ++ net/ipv6/af_inet6.c | 8 +++- net/ipv6/mcast.c| 50 +- 3

[PATCH iproute] ip: Add support for netdev events to monitor

2017-03-28 Thread Vladislav Yasevich
Add MTU_CHANGED and NOTIFY_PEER events that can be viewed with 'moniotr' command. This gives a little more information for why a given notification was recevied. More events can be be added later. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/linux/if_link.

[PATCH net-next] rtnl: Add support for netdev event to link messages

2017-03-25 Thread Vladislav Yasevich
. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- include/linux/rtnetlink.h| 3 ++- include/uapi/linux/if_link.h | 7 ++ net/core/dev.c | 2 +- net/core/rtnetlink.c | 51 4 files changed, 52 insertions(

[RFC PATCH 0/6] virtio-net: Add support for virtio-net header extensions

2017-03-18 Thread Vladislav Yasevich
and possible other encapsulations. This series only takes care of virtio net. I have addition patches for the host side (vhost and tap/macvtap as well as qemu), but wanted to get feedback on the general approach first. Vladislav Yasevich (6): virtio-net: Remove the use the padded vnet_header

[RFC PATCH 4/6] virtio-net: Add support for IPv6 fragment id vnet header extension.

2017-03-18 Thread Vladislav Yasevich
to predict. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 27 +-- include/linux/virtio_net.h | 20 include/uapi/linux/virtio_net.h | 7 +++ 3 files changed, 52 insertions(+), 2 deletions(-)

[RFC PATCH 1/6] virtio-net: Remove the use the padded vnet_header structure

2017-03-18 Thread Vladislav Yasevich
We can replace the structure with a properly aligned size instead. The current structure attempts to align on a 16 byte boundary, so preserve it. Signed-off-by: Vlad Yaseivch --- drivers/net/virtio_net.c | 22 -- 1 file changed, 12 insertions(+), 10

[RFC PATCH 5/6] virtio-net: Add support for vlan acceleration vnet header extension.

2017-03-18 Thread Vladislav Yasevich
will enabled HW accelerated vlan features. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 17 - include/linux/virtio_net.h | 17 + include/uapi/linux/virtio_net.h | 7 +++ 3 files changed, 40 insertions

[RFC PATCH 3/6] virtio_net: Add basic skeleton for handling vnet header extensions.

2017-03-18 Thread Vladislav Yasevich
This is the basic sceleton which will be fleshed out by individiual extensions. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.c| 21 + include/linux/virtio_net.h | 12 include/uapi/linux/virtio_net.

[RFC PATCH 6/6] virtio: Add support for UDP tunnel offload and extension.

2017-03-18 Thread Vladislav Yasevich
This patch provides the ablility to negotiate UDP tunnel offload features in the virtio devices as well as the necesary extension to pass additional information to the host. This work is based on earlier work by Jarno Rajahalme

[RFC PATCH 2/6] virtio-net: make header length handling uniform

2017-03-18 Thread Vladislav Yasevich
Consistently use hdr_len stored in virtnet_info structure instead of direclty using specific sizes. This will be required as the size of the virtio net header grows due to future extensions. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/virtio_net.

[PATCH] net: Resend IGMP memberships upon peer notification.

2017-03-14 Thread Vladislav Yasevich
When we notify peers of potential changes, it's also good to update IGMP memberships. For example, during VM migration, updating IGMP memberships will redirect existing multicast streams to the VM at the new location. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/core

[PATCH net] ipv6: Paritially checksum full MTU frames

2017-01-29 Thread Vladislav Yasevich
IPv6 will mark data that is smaller that mtu - headersize as CHECKSUM_PARTIAL, but if the data will completely fill the mtu, the packet checksum will be computed in software instead. Extend the conditional to include the data that fills the mtu as well. Signed-off-by: Vladislav Yasevich <vy

Re: [PATCH net] sctp: sctp_addr_id2transport should verify the addr before looking up assoc

2017-01-25 Thread Vladislav Yasevich
On Wed, Jan 25, 2017 at 10:34 AM, Xin Long <lucien@gmail.com> wrote: > > On Wed, Jan 25, 2017 at 11:27 PM, Vladislav Yasevich > <vyasev...@gmail.com> wrote: > > On Tue, Jan 24, 2017 at 1:01 AM, Xin Long <lucien@gmail.com> wrote: > >> > >&g

[RFC PATCH net-next 0/3] Extend macvtap with multiple qdiscs

2016-02-07 Thread Vladislav Yasevich
side is left alone and will prefer skb hash if available. Macvlan through this all is left with lockless transmit path. Thanks -vlad Vladislav Yasevich (3): macvtap: mutiple qdiscs support macvlan: add queue selection functionality macvtap: Record the rx queue based on the user tap queue

[RFC PATCH net-next 1/3] macvtap: mutiple qdiscs support

2016-02-07 Thread Vladislav Yasevich
sequence will cause the queue index change and we account for this by updating real queues. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvtap.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c

[RFC PATCH net-next 2/3] macvlan: add queue selection functionality

2016-02-07 Thread Vladislav Yasevich
This patch adds a simple queue selection function to macvlan layer. In most cases, this will just use the standard fallback fuction, but when rx-queue has been recoreded we'll try to use that value. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drivers/net/macvlan.

[RFC PATCH net-next 3/3] macvtap: Record the rx queue based on the user tap queue

2016-02-07 Thread Vladislav Yasevich
Now that macvlan has a basic queue selection and macvtap has multiple qdiscs, we can record the the queue index into the skb based on the index of the macvtap user queue. This index will then be used to select the right qdisc. Signed-off-by: Vlad Yasevich ---

Re: [PATCH net] sctp: allow setting SCTP_SACK_IMMEDIATELY by the application

2016-01-24 Thread Vladislav Yasevich
On Fri, Jan 22, 2016 at 3:29 PM, Marcelo Ricardo Leitner wrote: > This patch extends commit b93d6471748d ("sctp: implement the sender side > for SACK-IMMEDIATELY extension") as it didn't white list > SCTP_SACK_IMMEDIATELY on sctp_msghdr_parse(), causing it to be >

[PATCH net] skbuff: Fix offset error in skb_reorder_vlan_header

2015-12-14 Thread Vladislav Yasevich
. Fixes: a6e18ff1117 (vlan: Fix untag operations of stacked vlans with REORDER_HEADER off) CC: Nicolas Dichtel <nicolas.dich...@6wind.com> CC: Patrick McHardy <ka...@trash.net> Signed-off-by: Vladislav Yasevich <vyasev...@gmail.com> --- net/core/skbuff.c | 2 +- 1 file changed,

[PATCH 1/2] vlan: Fix untag operations of stacked vlans with REORDER_HEADER off

2015-11-16 Thread Vladislav Yasevich
out as a ETH_HLEN. The value is also updated when the vlan header manupations occur so we know it will be correct. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- net/core/skbuff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/skbuff.c b/net/core/skbuf

[PATCH 0/2] Fix issues with vlans without REORDER_HEADER

2015-11-16 Thread Vladislav Yasevich
ike a broader restriction and _may_ break existing uses. Thanks -vlad Vladislav Yasevich (2): vlan: Fix untag operations of stacked vlans with REORDER_HEADER off vlan: Do not put vlan headers back on bridge and macvlan ports include/linux/netdevice.h | 5 + net/8021q/vlan_core.c

[PATCH 2/2] vlan: Do not put vlan headers back on bridge and macvlan ports

2015-11-16 Thread Vladislav Yasevich
and at the time of the forward, vlan headers end up being unexpectedly present. With the patch, we make sure that we do not put the vlan header back (when REORDER_HEADER is 0) if a bridge or macvlan has been configured on top of the vlan device. Signed-off-by: Vladislav Yasevich <vyase...@redhat.

[PATCH] Revert "bridge: Allow forward delay to be cfgd when STP enabled"

2015-11-10 Thread Vladislav Yasevich
This reverts commit 34c2d9fb0498c066afbe610b15e18995fd8be792. There are 2 reasons for this revert: 1) The commit in question doesn't do what it says it does. The description reads: "Allow bridge forward delay to be configured when Spanning Tree is enabled." This was already the case

[PATCH] macvtap: Resolve possible __might_sleep warning in macvtap_do_read()

2015-11-09 Thread Vladislav Yasevich
galen kernel: [] system_call_fastpath+0x12/0x76 Jun 23 16:25:26 galen kernel: ---[ end trace 22e33f67e70c0c2a ]--- Make sure thet we call finish_wait() if we have the skb to process before trying to actually process it. Signed-off-by: Vladislav Yasevich <vyase...@redhat.com> --- drive

[PATCH net] sctp: Do not try to search for the transport twice

2015-08-28 Thread Vladislav Yasevich
. Signed-off-by: Vladislav Yasevich vyasev...@gmail.com --- net/sctp/sm_sideeffect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c index fef2acd..1543cf8 100644 --- a/net/sctp/sm_sideeffect.c +++ b/net/sctp/sm_sideeffect.c