Re: [Xen-devel] [PATCH 4/6] xen-netfront: add range check for Tx response id

On Mon, Apr 30, 2018 at 11:01:48PM +0200, Marek Marczykowski-Górecki wrote: > Tx response ID is fetched from shared page, so make sure it is sane > before using it as an array index. > > CC: sta...@vger.kernel.org > Signed-off-by: Marek Marczykowski-Górecki > ---

Re: [Xen-devel] [PATCH] xen-netfront: fix xennet_start_xmit()'s return type

this driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Reviewed-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH] xen-netback: fix xenvif_start_xmit()'s return type

this driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH 2/3] xen netback: add fault injection facility

On Fri, Apr 20, 2018 at 10:47:31AM +, Stanislav Kinsburskii wrote: > > #include > #include > @@ -1649,6 +1650,7 @@ static int __init netback_init(void) > PTR_ERR(xen_netback_dbg_root)); > #endif /* CONFIG_DEBUG_FS */ > > + (void) xen_netbk_fi_init(); If you

[RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device

:0x3 ... -device vfio-pci,host=02:10.1,id=hostdev0,bus=pci.2,addr=0x3 Signed-off-by: Si-Wei Liu <si-wei@oracle.com> --- hw/net/virtio-net.c | 29 - include/hw/pci/pci.h| 3 ++ include/hw/virtio/virtio-net.h

[RFC PATCH 0/3] Userspace compatible driver model for virtio_bypass

it persistent across live migration. And so on.. The current patch series is based on Sridhar's v4 patch "Enable virtio to act as a backup for a passthru device", but I can resync anyway to his upcoming version once posted. Si-Wei Liu (1): qemu: virtio-bypass should expli

[RFC PATCH 3/3] virtio_net: make lower netdevs for virtio_bypass hidden

and : location. Changing BACKUP feature to take these configs into account, such that verifying target device for auto-enslavement no longer relies on the MAC address. Signed-off-by: Si-Wei Liu <si-wei@oracle.com> --- drivers/net/virtio_net.c

[RFC PATCH 2/3] netdev: kernel-only IFF_HIDDEN netdevice

be used as the namescope for the kernel-only IFF_HIDDEN netdevs. Signed-off-by: Si-Wei Liu <si-wei@oracle.com> --- include/linux/netdevice.h | 12 ++ include/net/net_namespace.h | 2 + net/core/dev.c | 281 ++-- net/core/net_names

Re: [PATCH 4/4] drivers/net: Use octal not symbolic permissions

> > Signed-off-by: Joe Perches <j...@perches.com> > --- > drivers/net/xen-netback/xenbus.c | 4 +- > drivers/net/xen-netfront.c | 6 +-- Reviewed-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static

/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Acked-by: Wei Liu <wei.l...@citrix.com> Thanks

Re: [PATCH] xen-netfront: remove warning when unloading module

CC netfront maintainers. On Mon, Nov 20, 2017 at 11:41:09AM +0100, Eduardo Otubo wrote: > When unloading module xen_netfront from guest, dmesg would output > warning messages like below: > > [ 105.236836] xen:grant_table: WARNING: g.e. 0x903 still in use! > [ 105.236839] deferring g.e.

Re: [PATCH 54/58] net/xen-netback: Convert timers to use timer_setup()

On Mon, Oct 16, 2017 at 05:29:38PM -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Wei Liu <wei.l..

Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

, the guest can no longer be pinged. > > xen_net{front|back} should not allow the user to set this value which causes > network problems. > > Reported-by: Chen Shi <che...@redhat.com> > Signed-off-by: Mohammed Gamal <mga...@redhat.com> Acked-by: Wei Liu <wei.l...@citrix.com> CC netfront maintainers

Re: [PATCH net-next] xen-netback: update ubuf_info initialization to anonymous union

to match their > nested position in the struct. After this, compilation succeeds again. > > Fixes: 4ab6c99d99bb ("sock: MSG_ZEROCOPY notification coalescing") > Reported-by: kbuild bot <l...@intel.com> > Signed-off-by: Willem de Bruijn <will...@google.com> Acked-by: Wei Liu <wei.l...@citrix.com>

[PATCH net] xen-netback: correctly schedule rate-limited queues

ed-off-by: Wei Liu <wei.l...@citrix.com> Tested-by: Jean-Louis Dupond <jean-lo...@dupond.be> --- drivers/net/xen-netback/common.h| 1 + drivers/net/xen-netback/interface.c | 6 +- drivers/net/xen-netback/netback.c | 6 +- 3 files changed, 11 insertions(+), 2 deletions(-) di

Re: [PATCH net 2/2] xen-netback: don't vfree() queues under spinlock

0x40/0x40 > [ 174.541898] ret_from_fork+0x21/0x2c > [ 174.548635] switch: port 2(vif3.0) entered disabled state > > This patch defers the vfree() until after the spinlock is released. > > Reported-by: Juergen Gross <jgr...@suse.com> > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net 1/2] xen-netback: keep a local pointer for vif in backend_disconnect()

On Thu, Mar 02, 2017 at 12:54:25PM +, Paul Durrant wrote: > This patch replaces use of 'be->vif' with 'vif' and hence generally > makes the function look tidier. No semantic change. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: BUG due to "xen-netback: protect resource cleaning on XenBus disconnect"

On Thu, Mar 02, 2017 at 12:56:20PM +0100, Juergen Gross wrote: > With commits f16f1df65 and 9a6cdf52b we get in our Xen testing: > > [ 174.512861] switch: port 2(vif3.0) entered disabled state > [ 174.522735] BUG: sleeping function called from invalid context at >

Re: [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash

On Thu, Mar 02, 2017 at 10:50:20AM +, Anoob Soman wrote: > Allocation of new_hash, inside xenvif_new_hash(), always happen > in softirq context, so use GFP_ATOMIC instead of GFP_KERNEL for new > hash allocation. > > Signed-off-by: Anoob Soman <anoob.so...@citrix.com> Ack

Re: [PATCH v2 2/2] xen-netback: protect resource cleaning on XenBus disconnect

On Tue, Jan 17, 2017 at 08:49:38PM +, Igor Druzhinin wrote: > vif->lock is used to protect statistics gathering agents from using the > queue structure during cleaning. > > Signed-off-by: Igor Druzhinin <igor.druzhi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH v2 1/2] xen-netback: fix memory leaks on XenBus disconnect

Igor Druzhinin <igor.druzhi...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH] xen-netback: fix memory leaks on XenBus disconnect

On Thu, Jan 12, 2017 at 05:51:56PM +, Igor Druzhinin wrote: > Eliminate memory leaks introduced several years ago by cleaning the queue > resources which are allocated on XenBus connection event. Namely, queue > structure array and pages used for IO rings. > vif->lock is used to protect

Re: [PATCH 0/2] xen/net: limit number of tx/rx queues

ximum on both sides to 8. Both > frontend and backend maximum can be individually tuned via module > parameters. > > Juergen Gross (2): > xen/netfront: set default upper limit of tx/rx queues to 8 > xen/netback: set default upper limit of tx/rx queues to 8 > Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH 2/3] xen: modify xenstore watch event interface

rad.w...@oracle.com > Cc: roger@citrix.com > Cc: wei.l...@citrix.com > Cc: paul.durr...@citrix.com > Cc: netdev@vger.kernel.org > > Signed-off-by: Juergen Gross <jgr...@suse.com> Reviewed-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH] vif queue counters from int to long

On Fri, Dec 23, 2016 at 04:09:23PM +0100, Mart van Santen wrote: > > Hello, > > This patch fixes an issue where counters in the queue have type int, > while the counters of the vif itself are specified as long. This can > cause incorrect reporting of tx/rx values of the vif interface. > More

Re: [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers

on.org > CC: "K. Y. Srinivasan" <k...@microsoft.com> > CC: Haiyang Zhang <haiya...@microsoft.com> > CC: "Michael S. Tsirkin" <m...@redhat.com> > CC: Shrikrishna Khare <skh...@vmware.com> > CC: "VMware, Inc." <pv-driv...@vm

Re: [PATCH net] xen-netback: (re-)create a debugfs node for hash information

hat creation of the debugfs node is predicated on 'ctrl_irq' being > non-zero rather then the now non-existent 'ctrl_task'. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> > Cc: David S. Miller <da...@davemloft.net> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net-next] MAINTAINERS: add myself as a maintainer of xen-netback

On Fri, Oct 07, 2016 at 11:33:37AM +0100, Paul Durrant wrote: > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> Thanks for stepping up! > --- > MAINTAINERS | 1 + > 1 file change

Re: [PATCH v2 net] xen-netback: make sure that hashes are not send to unaware frontends

such a segment, causing it to crash. > > This patch fixes the problem by clearing the hash in ndo_start_xmit() > instead, which is clearly guaranteed to be called irrespective of the > number of queues. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei

Re: [PATCH resend 2] xen-netback: switch to threaded irq for control ring

On Thu, Sep 22, 2016 at 11:06:25AM +0200, Juergen Gross wrote: > Instead of open coding it use the threaded irq mechanism in > xen-netback. > > Signed-off-by: Juergen Gross <jgr...@suse.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH v2] xen-netback: fix error handling on netback_probe()

new valid state transitions on > set_backend_state(), from XenbusStateInitialising to XenbusStateClosed, > and from XenbusStateInitialising to XenbusStateInitWait. > > Signed-off-by: Filipe Manco <filipe.ma...@neclab.eu> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [RFC PATCH] xen-netback: fix error handling on netback_probe()

On Thu, Sep 15, 2016 at 04:05:17PM +0200, Filipe Manco wrote: > On 14-09-2016 12:10, Wei Liu wrote: > >CC xen-devel as well. > > > >On Tue, Sep 13, 2016 at 02:11:27PM +0200, Filipe Manco wrote: > >>In case of error during netback_probe() (e.g. an entry missing on th

Re: [RFC PATCH] xen-netback: fix error handling on netback_probe()

CC xen-devel as well. On Tue, Sep 13, 2016 at 02:11:27PM +0200, Filipe Manco wrote: > In case of error during netback_probe() (e.g. an entry missing on the > xenstore) netback_remove() is called on the new device, which will set > the device backend state to XenbusStateClosed by calling >

Re: [PATCH net-next] xen-netback: create a debugfs node for hash information

On Wed, Aug 17, 2016 at 04:13:29PM +0100, Paul Durrant wrote: > It is useful to be able to see the hash configuration when running tests. > This patch adds a debugfs node for that purpose. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH 0805/1285] Replace numeric parameter like 0444 with macro

onding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng@intel.com> > Signed-off-by: Baole Ni <baolex...@intel.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH] xen-netback: prefer xenbus_write() over xenbus_printf() where possible

On Fri, Jul 08, 2016 at 05:13:49PM +0100, Wei Liu wrote: > On Thu, Jul 07, 2016 at 01:58:18AM -0600, Jan Beulich wrote: > > ... as being the simpler variant. > > > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [PATCH v2 4/4] xen-netback: prefer xenbus_scanf() over xenbus_gather()

> passed). > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH] xen-netback: prefer xenbus_write() over xenbus_printf() where possible

On Thu, Jul 07, 2016 at 01:58:18AM -0600, Jan Beulich wrote: > ... as being the simpler variant. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [PATCH] xen-netback: correct return value checks on xenbus_scanf()

On Thu, Jul 07, 2016 at 10:58:16AM +0100, David Vrabel wrote: > On 07/07/16 08:57, Jan Beulich wrote: > > Only a positive return value indicates success. > > This is not correct. > Do you mean the commit message is not correct or the code is not correct? If it is the formal, do you have any

Re: [PATCH net-next] xen-netback: only deinitialized hash if it was initialized

ient to ensure > it is only called if xenvif_init_hash() was called previously. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Reported-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > Tested-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > Cc: Wei Li

Re: [PATCH net-next] xen-netback: correct length checks on hash copy_ops

Reported-by: Dan Carpenter <dan.carpen...@oracle.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> > --- > drivers/net/xen-netback/hash.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/xen-netb

Re: [PATCH net-next v4 2/4] xen-netback: add control protocol implementation

ous patch added the necessary boilerplate for mapping the control > ring from the frontend, should it be created. This patch adds > implementations for each of the defined protocol messages. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()

ntered when processing packets containing extra info fragments. > This patch fixes the problem. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Reported-by: Jan Beulich <jbeul...@suse.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l.

Re: [PATCH net-next v3 1/4] xen-netback: add control ring boilerplate

necessary code to xen-netback to map this new shared > ring, should it be created by a frontend, but does not add implementations > for any of the defined protocol messages. These are added in a subsequent > patch for clarity. > > Signed-off-by: Paul Durrant <paul.durr...@citr

Re: [PATCH net-next v3 2/4] xen-netback: add control protocol implementation

ous patch added the necessary boilerplate for mapping the control > ring from the frontend, should it be created. This patch adds > implementations for each of the defined protocol messages. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net-next 4/4] xen-netback: use hash value from the frontend

in a hash extra > info fragment passed from the guest frontend in a transmit-side > (i.e. netback receive side) packet to set the skb hash accordingly. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net-next 3/4] xen-netback: pass hash value to the frontend

lues calculated for > guest receive-side packets (i.e. netback transmit side) to the frontend. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net-next 2/4] xen-netback: add control protocol implementation

ous patch added the necessary boilerplate for mapping the control > ring from the frontend, should it be created. This patch adds > implementations for each of the defined protocol messages. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net-next 1/4] xen-netback: add control ring boilerplate

On Thu, May 05, 2016 at 12:19:27PM +0100, Paul Durrant wrote: [...] > > +static int connect_ctrl_ring(struct backend_info *be) > +{ Please use goto style error handling in this function. Other than this the code looks good. Wei.

Re: [PATCH net-next 1/3] xen-netback: re-import canonical netif header

AB}/g > w > $ > w > EOF > > indent --line-length 80 --linux-style netif.h \ > -o include/xen/interface/io/netif.h > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Cc: Boris Ostrovsky <b

Re: [PATCH net-next 2/3] xen-netback: support multiple extra info fragments passed from frontend

ff-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [PATCH net-next 3/3] xen-netback: reduce log spam

: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> > --- > drivers/net/xen-netback/xenbus.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/xen-netback/xenbus.c > b/

Re: [PATCH] MAINTAINERS: Drop myself as xen netback maintainer

On Fri, Feb 19, 2016 at 11:44:51AM +, Ian Campbell wrote: > Wei has been picking this up for quite a while now. > > Signed-off-by: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> > --- >

Re: [PATCH net-next v1] xen-netback: implement dynamic multicast control

On Mon, Feb 01, 2016 at 02:40:53PM +, Paul Durrant wrote: [...] > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev, > + struct xenvif *vif) > +{ > + int err = 0; > + char *node; > + unsigned maxlen = strlen(dev->otherend) + >

Re: [PATCH net-next v2] xen-netback: implement dynamic multicast control

On Tue, Feb 02, 2016 at 11:31:08AM +, Paul Durrant wrote: [...] > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev, > + struct xenvif *vif) > +{ > + int err = 0; > + char *node; > + unsigned maxlen = strlen(dev->otherend) + >

Re: [PATCH net-next v3] xen-netback: implement dynamic multicast control

itrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com>

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On Fri, Jan 22, 2016 at 08:25:21PM +, One Thousand Gnomes wrote: > > The fact what include/linux/license.h:license_is_gpl_compatible includes > > "Dual MIT/GPL" as an option seems to suggest that it is enough of a thing > > to be validly used as the contents of a MODULE_LICENSE() thing. > >

[PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

The comment at the beginning of the file is the canonical source of licenses for this module. Currently it contains GPL and MIT license. Fix the code to reflect the reality. Signed-off-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 ins

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

On Fri, Jan 22, 2016 at 01:14:24PM +, David Vrabel wrote: > On 22/01/16 12:34, Wei Liu wrote: > > The comment at the beginning of the file is the canonical source of > > licenses for this module. Currently it contains GPL and MIT license. Fix > > the code to reflect the r

[PATCH v2 1/3] xen-netback: fix license ident used in MODULE_LICENSE

imply make the code to use "GPL" only. Signed-off-by: Wei Liu <wei.l...@citrix.com> --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 61b97c3..e9601d

Re: [PATCH 0/5] xen-netback: Fine-tuning for three function implementations

I think the original code is fine. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 1/2] xen-netback: limit xen vif max queues number to online cpus

On Fri, Oct 23, 2015 at 05:44:44PM +0800, Joe Jin wrote: > Should not allocate xen vif queues number more than online cpus. I think it's absolutely fine for administrators to override the value should they choose to. Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-next 6/8] xen-netback: pass an L4 or L3 skb hash value to the frontend

rant <paul.durr...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Reviewed-by: Wei Liu <wei.l...@citrix.com> > static int xenvif_rx_ring_slots_needed(struct xenvif *vif) > { > - if (vif->gso_mask) > -

Re: [PATCH net-next 8/8] xen-netback: add support for toeplitz hashing

lgorithm itself was based on pseudo-code provided by > Microsoft at: > > https://msdn.microsoft.com/en-us/library/windows/hardware/ff570725.aspx > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <we

Re: [PATCH net-next 1/8] xen-netback: re-import canonical netif header

_netif_rx/g > ,s/netif_extra_info/xen_netif_extra_info/g > w > EOF > > indent --linux-style netif.h -o include/xen/interface/io/netif.h > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Cc: Bori

Re: [PATCH net-next 2/8] xen-netback: remove GSO information from xenvif_rx_meta

ce in the array and > removes many lines of code. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Reviewed-by: Wei Liu <wei.l...@citrix.com> -- To unsubscribe from thi

Re: [PATCH net-next 3/8] xen-netback: support multiple extra info segments passed from frontend

modification, for better bisectability. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Reviewed-by: Wei Liu <wei.l...@citrix.com> -- To unsubscribe from this list

Re: [PATCH net-next 4/8] xen-netback: accept an L4 or L3 skb hash value from the frontend

; set a hash on the skb. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Reviewed-by: Wei Liu <wei.l...@citrix.com> [...] > > + /* We support hash v

Re: [PATCH net-next 7/8] xen-netback: add support for a multi-queue hash mapping table

On Wed, Oct 21, 2015 at 11:36:24AM +0100, Paul Durrant wrote: > Advertise the capability to handle a hash mapping specified by the > frontend (see netif.h for details). > > Add an ndo_select() entry point so that, of the frontend does specify a "if the frontend ..." > hash mapping, the skb hash

Re: [PATCH] xen-netback: correctly check failed allocation

On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > I changed patch with valid format. > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun wrote: > > > Since vzalloc can be failed in memory pressure, > > writes -ENOMEM to xenstore to indicate error. > > > > Signed-off-by:

Re: [PATCH] xen-netback: correctly check failed allocation

On Fri, Oct 16, 2015 at 10:05:21AM +0100, Wei Liu wrote: > On Thu, Oct 15, 2015 at 02:02:47PM -0400, Insu Yun wrote: > > I changed patch with valid format. > > > > On Thu, Oct 15, 2015 at 2:02 PM, Insu Yun <wuni...@gmail.com> wrote: > > > > > Sinc

Re: [PATCH 1/1] xen-netfront: update num_queues to real created

ned-off-by: Joe Jin <joe@oracle.com> > Cc: Wei Liu <wei.l...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: David S. Miller <da...@davemloft.net> > --- > drivers/net/xen-netfront.c |9 ++--- > 1 files changed, 6 insertions(+), 3

Re: [PATCH] xen-netback: corretly check failed allocation

On Thu, Oct 15, 2015 at 12:26:16PM -0400, Insu Yun wrote: > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. This function doesn't return ENOMEM, instead it writes to xenstore to indicate error. The commit log needs to be updated. > >

Re: [PATCH net v2 0/2] xen-net{front,back}: respect user provided max_queues

On Wed, Sep 09, 2015 at 10:05:53PM -0700, David Miller wrote: > From: David Miller <da...@davemloft.net> > Date: Wed, 09 Sep 2015 21:53:22 -0700 (PDT) > > > From: Wei Liu <wei.l...@citrix.com> > > Date: Wed, 9 Sep 2015 11:23:04 +0100 > > > >&g

[PATCH net v3 1/2] xen-netback: respect user provided max_queues

Originally that parameter was always reset to num_online_cpus during module initialisation, which renders it useless. The fix is to only set max_queues to num_online_cpus when user has not provided a value. Reported-by: Johnny Strom <johnny.st...@linuxsolutions.fi> Signed-off-by: Wei Liu

[PATCH net v3 0/2] xen-net{front,back}: respect user provided max_queues

Wei Liu (2): xen-netback: respect user provided max_queues xen-netfront: respect user provided max_queues drivers/net/xen-netback/netback.c | 7 +-- drivers/net/xen-netfront.c| 7 +-- 2 files changed, 10 insertions(+), 4 deletions(-) -- 2.1.4 -- To unsubscribe from

[PATCH net v3 2/2] xen-netfront: respect user provided max_queues

Originally that parameter was always reset to num_online_cpus during module initialisation, which renders it useless. The fix is to only set max_queues to num_online_cpus when user has not provided a value. Signed-off-by: Wei Liu <wei.l...@citrix.com> Cc: David Vrabel <david.vra...@c

Re: [PATCH net] xen-netback: respect user provided max_queues

On Wed, Sep 09, 2015 at 11:12:44AM +0100, David Vrabel wrote: > On 09/09/15 11:09, Wei Liu wrote: > > Originally that parameter was always reset to num_online_cpus during > > module initialisation, which renders it useless. > > > > The fix is to only set max_queues t

[PATCH net v2 2/2] xen-netfront: respect user provided max_queues

Originally that parameter was always reset to num_online_cpus during module initialisation, which renders it useless. The fix is to only set max_queues to num_online_cpus when user has not provided a value. Signed-off-by: Wei Liu <wei.l...@citrix.com> Cc: David Vrabel <david.vra...@c

[PATCH net v2 1/2] xen-netback: respect user provided max_queues

Originally that parameter was always reset to num_online_cpus during module initialisation, which renders it useless. The fix is to only set max_queues to num_online_cpus when user has not provided a value. Reported-by: Johnny Strom <johnny.st...@linuxsolutions.fi> Signed-off-by: Wei Liu

[PATCH net v2 0/2] xen-net{front,back}: respect user provided max_queues

Wei Liu (2): xen-netback: respect user provided max_queues xen-netfront: respect user provided max_queues drivers/net/xen-netback/netback.c | 7 +-- drivers/net/xen-netfront.c| 7 +-- 2 files changed, 10 insertions(+), 4 deletions(-) -- 2.1.4 -- To unsubscribe from

Re: [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

le Rx request. This is fine since we're predominately >concerned with detecting interfaces which are down and thus have >zero available Rx requests. > > Signed-off-by: David Vrabel <david.vra...@citrix.com> Reviewed-by: Wei Liu <wei.l...@citrix.com> -- To unsubscri

[PATCH net] xen-netback: respect user provided max_queues

Originally that parameter was always reset to num_online_cpus during module initialisation, which renders it useless. The fix is to only set max_queues to num_online_cpus when user has not provided a value. Reported-by: Johnny Strom <johnny.st...@linuxsolutions.fi> Signed-off-by: Wei Liu

Re: [PATCH v4 18/20] net/xen-netback: Make it running on 64KB page granularity

k backend on a non-modified Xen. > > It's only necessary to adapt the ring size and break skb data in small > chunk of 4KB. The rest of the code is relying on the grant table code. > > Signed-off-by: Julien Grall <julien.gr...@citrix.com> > Reviewed-by: Wei Liu <wei.l..

Re: [PATCH v2 net-next] xen-netback: add support for multicast control

_ADD > sent by the frontend will be failed with NETIF_RSP_ERROR. > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com> Acked-by: Wei Liu <wei.l...@citrix.com> -- To unsubs

Re: [PATCH net-next] xen-netback: add support for multicast control

On Wed, Sep 02, 2015 at 01:19:53PM +0100, Paul Durrant wrote: > Xen's PV network protocol includes messages to add/remove ethernet > multicast addresses to/from a filter list in the backend. This allows > the frontend to request the backend only forward multicast packets > which are off interest

Re: [PATCH v3 01/20] net/xen-netback: xenvif_gop_frag_copy: move GSO check out of the loop

On Fri, Aug 07, 2015 at 05:46:40PM +0100, Julien Grall wrote: The skb doesn't change within the function. Therefore it's only necessary to check if we need GSO once at the beginning. Signed-off-by: Julien Grall julien.gr...@citrix.com Acked-by: Wei Liu wei.l...@citrix.com -- To unsubscribe

Re: [PATCH v3 18/20] net/xen-netback: Make it running on 64KB page granularity

skb data in small chunk of 4KB. The rest of the code is relying on the grant table code. Signed-off-by: Julien Grall julien.gr...@citrix.com --- Cc: Ian Campbell ian.campb...@citrix.com Cc: Wei Liu wei.l...@citrix.com Cc: netdev@vger.kernel.org [...] +#define XEN_NETIF_TX_RING_SIZE

Re: [PATCH v2 4/8] xen: Use the correctly the Xen memory terminologies

-by: Wei Liu wei.l...@citrix.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] xen/netback: Wake dealloc thread after completing zerocopy work

forever with nothing to wake it. Instead, wake the thread only after decrementing inflight_packets. Signed-off-by: Ross Lagerwall ross.lagerw...@citrix.com Acked-by: Wei Liu wei.l...@citrix.com --- Changed in V2: Move wakeup into zerocopy_complete function. drivers/net/xen-netback

Re: [PATCH] xen/netback: Wake dealloc thread after completing zerocopy work

On Tue, Aug 04, 2015 at 01:50:58PM +0100, Ross Lagerwall wrote: Waking the dealloc thread before decrementing inflight_packets is racy because it means the thread may go to sleep before inflight_packets is decremented. If kthread_stop() has already been called, the dealloc thread may wait

Re: [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

-by: Wei Liu wei.l...@citrix.com One possible improvement is to change gmfn in copy_gop to gfn as well. But that's outside of netback code. Wei. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

On Wed, Jul 29, 2015 at 12:35:54PM +0100, Julien Grall wrote: Hi Wei, On 29/07/15 11:13, Wei Liu wrote: On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote: [...] diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7d50711..3b7b7c3

Re: [PATCH] xen-netback: remove duplicated function definition

On Sat, Jul 04, 2015 at 03:33:00AM +0800, Liang Li wrote: There are two duplicated xenvif_zerocopy_callback() definitions. Remove one of them. Signed-off-by: Liang Li liang.z...@intel.com Acked-by: Wei Liu wei.l...@citrix.com Please fix the time of your computer and resend. Wei

Re: [PATCH] xen-netback: fix a BUG() during initialization

existing packet-rate watches before trying to install those watches. This behaviour is in line with how connect() deals with the hotplug-status watch. Signed-off-by: Imre Palik im...@amazon.de Cc: Matt Wilson m...@amazon.com Acked-by: Wei Liu wei.l...@citrix.com --- drivers/net/xen-netback

Re: [PATCH] xen-netback:Make the function xenvif_schedulable have a return type of bool

...@gmail.com Acked-by: Wei Liu wei.l...@citrix.com --- drivers/net/xen-netback/common.h| 2 +- drivers/net/xen-netback/interface.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/xen-netback/common.h b/drivers/net/xen-netback/common.h index 8a495b3..c02cafb

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

On Wed, Jun 03, 2015 at 05:07:59PM +, Joao Martins wrote: [...] How much harder would it be to ref-count inflight grants? Would that simplify or perplex things? I'm just asking, not suggesting you should choose ref-counting over current scheme. In principle I favour simple code

[PATCH net-next] tcp: double default TSQ output bytes limit

-off-by: Wei Liu wei.l...@citrix.com Cc: David Miller da...@davemloft.net Cc: Eric Dumazet eric.duma...@gmail.com --- net/ipv4/tcp_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 190538a..eeb59be 100644 --- a/net

Re: [Xen-devel] tcp: refine TSO autosizing causes performance regression on Xen

Hi Eric Sorry for coming late to the discussion. On Thu, Apr 16, 2015 at 05:42:16AM -0700, Eric Dumazet wrote: On Thu, 2015-04-16 at 11:01 +0100, George Dunlap wrote: He suggested that after he'd been prodded by 4 more e-mails in which two of us guessed what he was trying to get at.

Re: [RFC PATCH 03/13] xen-netback: implement TX persistent grants

On Fri, May 22, 2015 at 10:24:39AM +, Joao Martins wrote: On 19 May 2015, at 17:23, Wei Liu wei.l...@citrix.com wrote: On Tue, May 12, 2015 at 07:18:27PM +0200, Joao Martins wrote: Introduces persistent grants for TX path which follows similar code path as the grant mapping

  1   2   >