Re: [PATCH] net: neigh: disallow state transition DELAY->STALE in neigh_update()

2016-07-24 Thread YOSHIFUJI Hideaki/
Hi, Chunhui He wrote: > Hi, > > On Fri, 22 Jul 2016 10:20:01 +0300 (EEST), Julian Anastasov > wrote: >> >> Hello, >> >> On Thu, 21 Jul 2016, Chunhui He wrote: >> >>> If neigh entry was CONNECTED and address is not changed, and if new state is >>> STALE, entry state will not change. Because

Re: [PATCHv3 net-next 08/12] ipv6: introduce neighbour discovery ops

2016-06-15 Thread YOSHIFUJI Hideaki/
Alexander Aring wrote: > This patch introduces neighbour discovery ops callback structure. The > idea is to separate the handling for 6LoWPAN into the 6lowpan module. > > These callback offers 6lowpan different handling, such as 802.15.4 short > address handling or RFC6775 (Neighbor Discovery Op

Re: [PATCH 1/4] kernel: time: Add current_nw_timestamp() for network timestamps

2016-02-25 Thread YOSHIFUJI Hideaki/
Hi, Deepa Dinamani wrote: >>> include/linux/ip.h | 2 ++ >>> include/linux/time64.h | 3 +++ >>> kernel/time/time.c | 26 ++ >>> 3 files changed, 31 insertions(+) >>> >> Since net/ipv4/* are the only users, it is enough to put >> it in under net/ipv4/. > > time.

Re: [RFCv3 bluetooth-next 3/4] ipv6: add ipv6_addr_prefix_copy

2015-12-01 Thread YOSHIFUJI Hideaki/
Hannes Frederic Sowa wrote: > > > On Sun, Nov 29, 2015, at 12:34, Alexander Aring wrote: >> This patch adds a static inline function ipv6_addr_prefix_copy which >> copies a ipv6 address prefix(argument pfx) into the ipv6 address prefix. >> The prefix len is given by plen as bits. This function ma

Re: [PATCH v4 1/2] geneve: implement support for IPv6-based tunnels

2015-10-20 Thread YOSHIFUJI Hideaki/
Hi, John W. Linville wrote: > Signed-off-by: John W. Linville > --- > v4: > - treat mode field of ip_tunnel_info as flags > - add a missing IS_ENABLED(CONFIG_IPV6) to geneve_rx > - remove unneeded flags field in geneve_dev > - NULL-check parameter for __geneve_sock_release > - check remote socket

Re: [PATCH net-next v2 1/2] ipv6: Re-arrange code in rt6_probe()

2015-07-27 Thread YOSHIFUJI Hideaki/
Martin KaFai Lau wrote: > It is a prep work for the next patch to remove write_lock > from rt6_probe(). > > 1. Reduce the number of if(neigh) check. From 4 to 1. > 2. Bring the write_(un)lock() closer to the operations that the >lock is protecting. > > Hopefully, the above make rt6_probe() m

Re: [PATCHv2] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-27 Thread YOSHIFUJI Hideaki/
Hi, Hangbin Liu wrote: > Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") > disabled accept hop limit from RA if it is higher than the current hop > limit for security stuff. But this behavior kind of break the RFC definition. > > RFC 4861, 6.3.4. Processing Received Router

Re: [RFC PATCH v3 net-next 2/3] tcp: add in_flight to tcp_skb_cb

2015-07-23 Thread YOSHIFUJI Hideaki/
Hi, Lawrence Brakmo wrote: > Based on comments by Neal Cardwell to tcp_nv patch: > > AFAICT this patch would not require an increase in the size of sk_buff > cb[] if it were to take advantage of the fact that the tcp_skb_cb > header.h4 and header.h6 fields are only used in the packet recept

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-14 Thread YOSHIFUJI Hideaki/
&score, &hiscore); > } else { > for_each_netdev_rcu(net, dev) { > idev = __in6_dev_get(dev); > if (!idev) > continue; > - __ipv6_dev_get_saddr(net, &dst,

[PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-13 Thread YOSHIFUJI Hideaki/
Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when finding source address on specific interface.") did not properly update best source address available. Plus, it introduced possible NULL pointer dereference. Bug was reported by Erik Kline . Based on patch proposed by Hajime Tazaki

[PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-10 Thread YOSHIFUJI Hideaki/
If outgoing interface is specified and the candidate address is restricted to the outgoing interface, it is enough to iterate over that given interface only. Signed-off-by: YOSHIFUJI Hideaki Acked-by: Erik Kline --- net/ipv6/addrconf.c | 197

[PATCH net-next] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-09 Thread YOSHIFUJI Hideaki/
If outgoing interface is specified and the candidate addresses are restricted to the outgoing interface, it is enough to iterate over that given interface only. Signed-off-by: YOSHIFUJI Hideaki --- net/ipv6/addrconf.c | 201 +--- 1 file changed, 11

Re: [PATCH] ipv6: Fixed source specific default route handling.

2015-06-22 Thread YOSHIFUJI Hideaki/
Matthias Schiffer wrote: > On 06/22/2015 07:58 AM, Steven Barth wrote: >> On 22.06.2015 00:35, Matthias Schiffer wrote: >>> Could you explain in detail what you mean with "If you want specific SA, >>> add same route with higher metric and/or (more) specific src match."? >>> Routes aren't bound to s

Re: [PATCH RFC net] neigh: do not modify unlinked entries

2015-06-19 Thread YOSHIFUJI Hideaki/
Hi, Julian Anastasov wrote: > The lockless lookups can return entry that is unlinked. > Sometimes they get reference before last neigh_cleanup_and_release, > sometimes they do not need reference. Later, any > modification attempts may result in the following problems: > > 1. entry is not destroye

Re: [PATCH] neighbour: Convert if statment in the function, neigh_add_timer to a WARN_ON

2015-06-01 Thread YOSHIFUJI Hideaki/
Nicholas Krause wrote: > This converts the if statement for dumping the stack into a > WARN_ON in order to make this function's debugging check > simpler and have a cleaner output when this condition > occurs inside this function for when bugs related to > adding a duplicate neighbour table timer a

[RFC PATCH] [XFRM]: Fix ordering issue in xfrm_dst_hash_transfer().

2008-02-14 Thread YOSHIFUJI Hideaki /
Keep ordering of policy entries with same selector in xfrm_dst_hash_transfer(). Issue should not appear in usual cases because multiple policy entries with same selector are basically not allowed so far. Bug was pointed out by Sebastien Decugis <[EMAIL PROTECTED]>. We could convert bydst from hli

Re: [PATCH][KEY] fix bug in spdadd

2008-02-14 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 14 Feb 2008 20:55:40 +0900), Kazunori MIYAZAWA <[EMAIL PROTECTED]> says: > This patch fix a BUG when adding spds which have > same selector. > > Signed-off-by: Kazunori MIYAZAWA <[EMAIL PROTECTED]> I think we need to fix xfrm_user side as well. --- [PATC

[PATCh TAKE 2] [IPROUTE2] Add addrlabel sub-command.

2008-02-13 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- diff --git a/ip/Makefile b/ip/Makefile index b427d58..d908817 100644 --- a/ip/Makefile +++ b/ip/Makefile @@ -1,4 +1,4 @@ -IPOBJ=ip.o ipaddress.o iproute.o iprule.o \ +IPOBJ=ip.o ipaddress.o ipaddrlabel.o iproute.o iprule.o \ rtm_map.o ip

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-12 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 07 Feb 2008 10:40:19 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > [NET] IPV4: lower stack usage in cookie_hash() function > > 400 bytes allocated on stack might be a litle bit too much. Using a > per_cpu var is more friendly. > > Signed-off-by: Eric

Re: [PATCH] Add IPv6 support to TCP SYN cookies

2008-02-11 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 7 Feb 2008 21:49:26 -0800), Glenn Griffin <[EMAIL PROTECTED]> says: > Updated to incorporate Eric's suggestion of using a per cpu buffer > rather than allocating on the stack. Just a two line change, but will > resend in it's entirety. > > Signed-off-by:

Re: [patch 14/14] replace __inline__ by inline in include/linux (net related)

2008-02-06 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 06 Feb 2008 10:14:19 +0100), Daniel Lezcano <[EMAIL PROTECTED]> says: > replace __inline__ by inline in include/linux (net related) > > Signed-off-by: Daniel Lezcano <[EMAIL PROTECTED]> > --- > include/linux/atm.h|4 ++-- > include/linux/atmsa

Re: [PATCH] Add addrlabel subsystem.

2008-01-31 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 01 Feb 2008 06:56:10 +1100 (EST)), YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > --- > include/linux/if_addrlabel.h | 32 + > ip/Makefile

[PATCH] IPROUTE2: Add addrlabel subsystem.

2008-01-31 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- include/linux/if_addrlabel.h | 32 + ip/Makefile |2 +- ip/ip.c |5 +- ip/ip_common.h |4 + ip/ipaddrlabel.c | 260 ++

[PATCH] Add addrlabel subsystem.

2008-01-31 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- include/linux/if_addrlabel.h | 32 + ip/Makefile |2 +- ip/ip.c |5 +- ip/ip_common.h |4 + ip/ipaddrlabel.c | 260 ++

Re: [PATCH 6/6][NETNS]: Udp sockets per-net lookup.

2008-01-31 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 31 Jan 2008 05:20:07 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > The networking devices are even per-namespace already, > so you can even say that each namespace is even > physically different. Ah, okay, we are splitting "weak" domains... --yos

Re: [PATCH 6/6][NETNS]: Udp sockets per-net lookup.

2008-01-31 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 31 Jan 2008 15:41:58 +0300), Pavel Emelyanov <[EMAIL PROTECTED]> says: > Add the net parameter to udp_get_port family of calls and > udp_lookup one and use it to filter sockets. I may miss something, but I'm afraid that I have to disagree. Port is identif

[PATCH net-2.6.25] [IPV6] ADDRLABEL: Fix double free on label deletion.

2008-01-28 Thread YOSHIFUJI Hideaki /
If an entry is being deleted because it has only one reference, we immediately delete it and blindly register the rcu handler for it, This results in oops by double freeing that object. This patch fixes it by consolidating the code paths for the deletion; let its rcu handler delete the object if

Re: [patch net-2.6.25][IPV6][SYSCTL] fix sysctl compilation error

2008-01-25 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 25 Jan 2008 14:32:23 +0100), Daniel Lezcano <[EMAIL PROTECTED]> says: > Move ipv6_icmp_sysctl_init and ipv6_route_sysctl_init into > the right ifdef section otherwise that does not compile when > CONFIG_SYSCTL=yes and CONFIG_PROC_FS=no > > Signed-off-by: D

Re: [PATCH 12/12 net-2.6.25] [NETNS]: Add namespace for ICMP replying code.

2008-01-23 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 23 Jan 2008 10:16:29 +0100), Mathieu Lacage <[EMAIL PROTECTED]> says: > I have been following the netns patches on this ML for a while but I > still have not figured out in which tree the patches fed to David Miller > are applied. I have attempted to grep t

[GIT PULL] [IPV6,IPV4]: Fix several sparse warnings.

2008-01-22 Thread YOSHIFUJI Hideaki /
Dave, please consider pulling following changes on top of net-2.6.25 tree: git://git.linux-ipv6.org/gitroot/yoshfuji/linux-2.6-dev.git net-2.6-dev-20080122 Thank you. HEADLINES - [IPV4] UDP,UDPLITE: Sparse: {__udp4_lib,udp,udplite}_err() are of void. [IPV6] UDP,UDPLITE:

Re: [PATCH 1/2] IPV6: ICMP6_MIB_OUTMSGS increment duplicated

2008-01-21 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 21 Jan 2008 17:46:32 +0800), Wang Chen <[EMAIL PROTECTED]> says: > [IPV6]: ICMP6_MIB_OUTMSGS increment duplicated > > icmpv6_send() calls ip6_push_pending_frames() indirectly. > Both ip6_push_pending_frames() and icmpv6_send() increment > counter ICMP6_MIB

Re: [PATCH 2/2] IPV6: RFC 2011 compatibility broken

2008-01-21 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 21 Jan 2008 17:46:44 +0800), Wang Chen <[EMAIL PROTECTED]> says: > The snmp6 entry name was changed, and it broke compatibility > to RFC 2011. > > Signed-off-by: Wang Chen <[EMAIL PROTECTED]> Acked-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --yoshfuji -- T

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-19 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 19 Jan 2008 14:44:13 +0100 (CET)), Jan Engelhardt <[EMAIL PROTECTED]> says: > From 84bccef295aa9754ee662191e32ba1d64edce2ba Mon Sep 17 00:00:00 2001 > From: Jan Engelhardt <[EMAIL PROTECTED]> > Date: Fri, 18 Jan 2008 02:10:44 +0100 > Subject: [PATCH] IPv4:

[PATCH] [IPV6] ROUTE: Make sending algorithm more friendly with RFC 4861.

2008-01-18 Thread YOSHIFUJI Hideaki /
We omit (or delay) sending NSes for known-to-unreachable routers (in NUD_FAILED state) according to RFC 4191 (Default Router Preferences and More-Specific Routes). But this is not fully compatible with RFC 4861 (Neighbor Discovery Protocol for IPv6), which does not remember unreachability of neighb

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-17 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 11:13:19 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > Assuming IN_BADCLASS() is still there, we should not reuse the name > of "ipv6_is_badclass" because the their meanings are different. Agai

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-17 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 02:52:08 +0100 (CET)), Jan Engelhardt <[EMAIL PROTECTED]> says: > > On Jan 18 2008 10:26, YOSHIFUJI Hideaki / 吉藤英明 wrote: > >> -#define IN_EXPERIMENTAL(a) long int) (a)) & 0xf000) == > >>

Re: [PATCH] IPv4: Enable use of 240/4 address space

2008-01-17 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 18 Jan 2008 02:13:52 +0100 (CET)), Jan Engelhardt <[EMAIL PROTECTED]> says: > diff --git a/include/linux/in.h b/include/linux/in.h > index 27d8a5a..b01bf75 100644 > --- a/include/linux/in.h > +++ b/include/linux/in.h > @@ -216,9 +216,6 @@ struct sockaddr_in

Re: Netconf at conf.au 2008?

2008-01-14 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 13 Jan 2008 19:17:51 +0100), martin f krafft <[EMAIL PROTECTED]> says: > also sprach Andy Johnson <[EMAIL PROTECTED]> [2008.01.12.0752 +0100]: > > I saw somewhere (maybe in this mailing list a while ago) that > > there might be a Linux Kernel Developers' N

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Mon, 7 Jan 2008 17:10:57 -0800), Vince Fuller <[EMAIL PROTECTED]> says: > #define IN_MULTICAST_NET 0xF000 > > +#define IN_CLASSE(a) long int) (a)) & 0xf000) == 0xf000) > +#define IN_CLASSE_NET 0xff00 > +#

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 11 Jan 2008 17:48:57 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> > Date: Fri, 11 Jan 2008 21:41:20 +0900 (JST) > > > There is no positive consesus on this dr

Re: [PATCH 001/001] ipv4: enable use of 240/4 address space

2008-01-11 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 11 Jan 2008 12:17:02 +0100), Andi Kleen <[EMAIL PROTECTED]> says: > Vince Fuller <[EMAIL PROTECTED]> writes: > > > from Vince Fuller <[EMAIL PROTECTED]> > > > > This set of diffs modify the 2.6.20 kernel to enable use of the 240/4 > > (aka "class-E") addre

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 09 Jan 2008 15:55:44 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > Because of the above, the existing behavior must still stay the > default. I hope this is your plan. > > By default Linux will not implement this SHOULD, it's a security > issue.

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 09 Jan 2008 15:32:12 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > I question any RFC mandate that shuts down IP communication on a node > because of packets received from remote systems. RFC4862 tell us that we SHOULD disable IP communication. (I

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 10 Jan 2008 01:38:57 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> says: > - we could have "dad_reaction" interface variable and > > 1: disable interface > = 1: disable IPv6 > < 0: ignore (

Re: Linux IPv6 DAD not full conform to RFC 4862 ?

2008-01-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 9 Jan 2008 16:36:56 +0100), Karsten Keil <[EMAIL PROTECTED]> says: > So I think we should disable the interface now, if DAD fails on a > hardware based LLA. I don't want to do this, at least, unconditionally. Options (not exclusive): - we could have "ena

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 23 Dec 2007 15:04:37 +0200), "David Shwatrz" <[EMAIL PROTECTED]> says: > Hello, > > > >You should iterate all of ifa_list (for IPv4) / addr_list (for IPv6). > > For IPv6, we also have anycast (maintained by ac_list) as well. > > I am not sure that we nee

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 23 Dec 2007 07:46:15 -0500), jamal <[EMAIL PROTECTED]> says: > On Sun, 2007-23-12 at 21:38 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > > In article <[EMAIL PROTECTED]> (at Sun, 23 Dec 2007 14:24:00 +0200), "David >

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 23 Dec 2007 14:24:00 +0200), "David Shwatrz" <[EMAIL PROTECTED]> says: > Regarding your answer; I accept it and I will soon send a revised > version of this patch (making changes to > arp_netdev_event() and ndisc_netdev_event().) > I had IPv4 in mind, th

Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change

2007-12-23 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sun, 23 Dec 2007 13:41:36 +0200), "David Shwatrz" <[EMAIL PROTECTED]> says: > I had written a small patch to neigh_changeaddr() in net/core/neighbour.c > against the 2.6 git net tree, which sends a gratuitous ARP to update > the list of > all the involved neighb

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-21 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 22:49:59 +0900), "Satoru SATOH" <[EMAIL PROTECTED]> says: > I agree. > > I mistakenly thought hz in that context must be larger than 1000.. > As it's uncertain, your's looks much simpler and better. > > (btw, the lines "else div = 1" is n

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-21 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 11:24:54 +0900), "Satoru SATOH" <[EMAIL PROTECTED]> says: > 2007/12/21, Jarek Poplawski <[EMAIL PROTECTED]>: > > Jarek Poplawski wrote, On 12/20/2007 09:24 PM: > > ... > > > > > but since it's your patch, I hope you do some additional checking >

[TCP]: Convert several length variable to unsigned.

2007-12-20 Thread YOSHIFUJI Hideaki /
Several length variables cannot be negative, so convert int to unsigned int. This also allows us to do sane shift operations on those variables. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> -- diff --git a/include/net/tcp.h b/include/net/tcp.h index cb5b033..f663a85 100644 --- a/include/

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 08:39:24 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > > Okay, anyway, I'll convert them to unsigned int, which is more > > appropriate. > > I didnt chose this path, because David was against changing some fields from > 'int' to 'unsigned'.

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler > to emit an integer divide, while we can help it to use a right shift, > less expensive. Are you really sure? A

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-20 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 20 Dec 2007 12:31:27 +0900), "Satoru SATOH" <[EMAIL PROTECTED]> says: > diff --git a/ip/iproute.c b/ip/iproute.c > index f4200ae..fa722c6 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -510,16 +510,16 @@ int print_route(const struct sockaddr_nl *who,

[GIT PULL] [NET]: Use {hton{s,l},cpu_to_be{16,32}}() where appropriate.

2007-12-13 Thread YOSHIFUJI Hideaki /
Hello. Please consider pulling the following changes from the branch net-2.6-dev-20071214 available at which is on top of your net-2.6-devel tree. Regards, --- HEADLINES - [BRIDGE]: Use cpu_to_be16() where appropriate. [DECNET]: Use htons() where appropriate.

Re: "ip neigh show" not showing arp cache entries?

2007-12-12 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 12 Dec 2007 15:57:08 -0600), "Chris Friesen" <[EMAIL PROTECTED]> says: > > You may try other versions of this command > > > > http://devresources.linux-foundation.org/dev/iproute2/download/ > > They appear to be numbered by kernel version, and the above v

Re: [PATCH] IPv6 support for NFS server

2007-12-11 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 11 Dec 2007 19:00:08 +0100), Aurélien Charbon <[EMAIL PROTECTED]> says: > --- linux-2.6.24-rc4/include/net/ipv6.h 2007-12-10 16:11:38.0 > +0100 > +++ linux-2.6.24-rc4-IPv6-cache-based/include/net/ipv6.h 2007-12-11 > 17:52:39.0 +

Re: [PATCH v2] XFRM: assorted IPsec fixups

2007-12-11 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 11 Dec 2007 11:30:19 -0500), Paul Moore <[EMAIL PROTECTED]> says: > diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c > index 5b860b6..e2a3dd1 100644 > --- a/net/xfrm/xfrm_state.c > +++ b/net/xfrm/xfrm_state.c : > @@ -1994,67 +1995,59 @@ void __ini

Re: [PATCH] NETLINK : kzalloc() conversion

2007-12-10 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 11 Dec 2007 06:40:18 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > nl_pid_hash_alloc() is renamed to nl_pid_hash_zalloc(). > It is now returning zeroed memory to its callers. I do think you do not need (and you should not) rename it because XXX_zalloc()

Re: [PATCH][NET]: Finish removing unused "mibalign" argument for snmp_mib_init().

2007-12-08 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Sat, 8 Dec 2007 15:55:34 -0200), Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> says: > Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> > > diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c > index 5ab8ba7..90d2f72 100644 > --- a/net/ipv6

[PATCH] [NET]: Remove unused "mibalign" argument for snmp_mib_init().

2007-12-08 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- diff --git a/include/net/ip.h b/include/net/ip.h index 840dd91..7f18819 100644 --- a/include/net/ip.h +++ b/include/net/ip.h @@ -169,7 +169,7 @@ DECLARE_SNMP_STAT(struct linux_mib, net_statistics); #define NET_ADD_STATS_USER(field, adnd)

Re: 'default' vs. 'all'

2007-12-08 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 08 Dec 2007 00:04:29 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > Herbert, Yoshifuji and I were just discussing the > sysfs device attribute issue. > > It's seems sane to me that if we had some kind of > 'dirty' bit per attribute we could propaga

[PATCH] [IPV6] XFRM: Fix auditing rt6i_flags; use RTF_xxx flags instead of RTCF_xxx.

2007-12-07 Thread YOSHIFUJI Hideaki /
RTCF_xxx flags, defined in include/linux/in_route.h) are available for IPv4 route (rtable) entries only. Use RTF_xxx flags instead, defined in include/linux/ipv6_route.h, for IPv6 route entries (rt6_info). Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> -- diff --git a/net/ipv6/xfrm6_policy

Re: [patch 0/3][IPV6]: remove ifdef in route6 init/fini functions

2007-12-07 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 07 Dec 2007 14:13:25 +0100), Daniel Lezcano <[EMAIL PROTECTED]> says: > The route6 init function is a little difficult to read because it contains > a lot of ifdef. The patchset redefines the usual static inline functions when > the code is to be disabled

Re: XFRM and IPv6 raw sockets and multicast

2007-12-04 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Tue, 4 Dec 2007 17:01:43 +0100), "Hugo Santos" <[EMAIL PROTECTED]> says: > > If we do really support it, if hdcincl is set, XFRM and other > > all extension header processes should be skipped, but they are > > not very clear at all so far. > > I under

Re: XFRM and IPv6 raw sockets and multicast

2007-12-04 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Tue, 4 Dec 2007 16:27:50 +0100), "Hugo Santos" <[EMAIL PROTECTED]> says: > The behavior is the same as in UDP, but ipv6_pinfo->saddr is not > usually set for these kind of sockets. I would say that if fl6_src is > any, it should be copied from the ipv6

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-29 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 29 Nov 2007 21:29:40 +1100), Herbert Xu <[EMAIL PROTECTED]> says: > On Mon, Nov 26, 2007 at 05:16:16PM +, Templin, Fred L wrote: > > From: Fred L. Templin <[EMAIL PROTECTED]> > > > > This patch includes support for the Intra-Site Automatic Tunnel > > A

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.5)

2007-11-26 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 26 Nov 2007 09:16:16 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > From: Fred L. Templin <[EMAIL PROTECTED]> > > This patch includes support for the Intra-Site Automatic Tunnel > Addressing Protocol (ISATAP) per RFC4214. It uses the SIT > module, a

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 22 Nov 2007 10:34:03 +0800), Herbert Xu <[EMAIL PROTECTED]> says: > On Wed, Nov 21, 2007 at 07:17:40PM -0500, Jeff Garzik wrote: > > > > For those interested, I am dealing with a UDP app that already does very > > strong checksumming and encryption, so add

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-21 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 21 Nov 2007 07:45:32 -0500), Jeff Garzik <[EMAIL PROTECTED]> says: > > SO_NO_CHECK support for IPv6 appeared to be missing. This is presented, > based on a reading of net/ipv4/udp.c. Disagree. UDP checksum is mandatory in IPv6. --yoshfuji - To unsubscrib

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.4)

2007-11-20 Thread YOSHIFUJI Hideaki /
Hello. I'll take care of this. Regards, --yoshfuji In article <[EMAIL PROTECTED]> (at Tue, 20 Nov 2007 09:36:26 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > From: Fred L. Templin <[EMAIL PROTECTED]> > > This patch includes support for the Intra-Site Automatic Tunnel > Addressing Pro

[PATCH 3/4] [IPV6] TCPMD5: Check return value of tcp_alloc_md5sig_pool().

2007-11-20 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/tcp_ipv6.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 3aad861..b1bfbdd 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -581,7 +581,10 @@

[PATCH 4/4] [IPV6] TCPMD5: Fix deleting key operation.

2007-11-20 Thread YOSHIFUJI Hideaki /
Due to the bug, refcnt for md5sig pool was leaked when an user try to delete a key if we have more than one key. In addition to the leakage, we returned incorrect return result value for userspace. This fix should close Bug #9418, reported by <[EMAIL PROTECTED]>. Signed-off-by: YOSHIFUJI Hideaki

PATCH 1/4] [IPV4] TCPMD5: Omit redundant NULL check for kfree() argument.

2007-11-20 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv4/tcp_ipv4.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index e566f3c..ff36096 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -900,8 +900,7 @@ in

[PATCH 2/4] [IPV4] TCPMD5: Use memmove() instead of memcpy() because we have overlaps.

2007-11-20 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv4/tcp_ipv4.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index ff36096..652c323 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -938,10 +938,1

Re: [PATCH 6/6 net-2.6.25][RAW] Consolidate proc interface

2007-11-16 Thread YOSHIFUJI Hideaki /
NAK. In article <[EMAIL PROTECTED]> (at Fri, 16 Nov 2007 17:19:27 +0300), Pavel Emelyanov <[EMAIL PROTECTED]> says: > @@ -858,7 +852,7 @@ static struct sock *raw_get_first(struct seq_file *seq) > ++state->bucket) { > struct hlist_node *node; > > -

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.2)

2007-11-15 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 15 Nov 2007 10:11:16 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > Yoshifuji, > > > -----Original Message----- > > From: YOSHIFUJI Hideaki / 吉藤英明 [mailto:[EMAIL PROTECTED] > > Sent: Thursday, Nov

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.2)

2007-11-15 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 14 Nov 2007 22:44:17 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > From: Fred L. Templin <[EMAIL PROTECTED]> > > This patch includes support for the Intra-Site Automatic Tunnel > Addressing Protocol (ISATAP) per RFC4214. It uses the SIT > module, a

Re: [PATCH 01/01] ipv6: RFC4214 Support (v2.2)

2007-11-15 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 14 Nov 2007 22:44:17 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > --- linux-2.6.24-rc2/net/ipv6/addrconf.c.orig 2007-11-08 11:59:35.0 > -0800 > +++ linux-2.6.24-rc2/net/ipv6/addrconf.c 2007-11-14 22:17:28.0 > -0800 > @@ -1424

[GIT PULL] RFC3484 Configurable Policy Table.

2007-11-13 Thread YOSHIFUJI Hideaki /
David, Please consider pulling from inet6-2.6.25 branch at which contains the following commits on top of your net-2.6.25 tree. Regards, -- HEADLINES - [IPV6] ADDRCONF: Rename ipv6_saddr_label() to ipv6_addr_label(). [IPV6] ADDRCONF: Allow address selection pol

Re: [PATCH 05/25] NFS: eliminate NIPQUAD(clp->cl_addr.sin_addr)

2007-11-13 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 13 Nov 2007 13:31:27 -0500), Chuck Lever <[EMAIL PROTECTED]> says: > clp->rpc_ops->version, > -NIPQUAD(clp->cl_addr.sin_addr), > -ntohs(clp->cl_addr.sin_port), > +rpc_peeraddr2str(clp->cl_rpcc

Re: [patch 1/1][NETNS][IPV6] protect addrconf from loopback registration

2007-11-12 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 12 Nov 2007 12:50:53 -0700), [EMAIL PROTECTED] (Eric W. Biederman) says: > My opinion is that both your analysis is slightly off (as to the cause > of your problems) and that your approach to fix your problem is wrong > because you don't untangle the knot y

Re: UDP-Lite and /proc/net/snmp

2007-11-10 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 10 Nov 2007 22:33:25 +0800), Herbert Xu <[EMAIL PROTECTED]> says: > On Sat, Nov 10, 2007 at 10:32:43PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > > > > Hmm? netstat 1.42 (net-tools 1.60) seems fine. > > Which netstat are yo

Re: UDP-Lite and /proc/net/snmp

2007-11-10 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Sat, 10 Nov 2007 21:14:29 +0800), Herbert Xu <[EMAIL PROTECTED]> says: > It looks like the addition of UDP-Lite has upset netstat: > > $ netstat -s > Ip: : > Udp: > 30 packets received > 0 packets to unknown port received. > 0 packet receive errors

Re: [PATCH 05/05] ipv6: RFC4214 Support (3)

2007-11-09 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Fri, 09 Nov 2007 16:35:59 -0800), osprey67 <[EMAIL PROTECTED]> says: > --- linux-2.6.24-rc2/include/linux/if_tunnel.h.orig 2007-11-09 > 09:06:16.0 -0800 > +++ linux-2.6.24-rc2/include/linux/if_tunnel.h2007-11-09 > 15:49:54.0 -0800 > @

Re: [PATCH 02/05] ipv6: RFC4214 Support (2)

2007-11-08 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 08 Nov 2007 12:41:39 -0800), osprey67 <[EMAIL PROTECTED]> says: > From: Fred L. Templin <[EMAIL PROTECTED]> > > This is experimental support for the Intra-Site Automatic > Tunnel Addressing Protocol (ISATAP) per RFC4214. It uses > the SIT module, and is co

Re: [PATCH 04/05] ipv6: RFC4214 Support

2007-11-08 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 7 Nov 2007 11:12:47 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > > > The goal was to avoid requiring changes to applications such as > > > 'iproute2', i.e., the intention was for a standalone code > > insertion point > > > within the kernel itself

Re: [PATCH 02/05] ipv6: RFC4214 Support

2007-11-07 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 7 Nov 2007 10:52:47 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > > > > > > + if (((ipv4 >= 0x0100) && (ipv4 < 0x0a00)) || > > > > > > + ((ipv4 >= 0x0b00) && (ipv4 < 0x7f00)) || > > > > > > + ((ipv4 >= 0x8000) && (i

Re: [PATCH 02/05] ipv6: RFC4214 Support

2007-11-07 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Wed, 7 Nov 2007 10:24:50 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > > > > -----Original Message----- > > From: YOSHIFUJI Hideaki / 吉藤英明 [mailto:[EMAIL PROTECTED] > > Sent: Wednesday, November 07,

Re: [PATCH 04/05] ipv6: RFC4214 Support

2007-11-07 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Tue, 6 Nov 2007 17:16:11 -0800), "Templin, Fred L" <[EMAIL PROTECTED]> says: > @@ -154,6 +155,14 @@ static struct ip_tunnel * ipip6_tunnel_l > struct net_device *dev; > char name[IFNAMSIZ]; > > +#if defined(CONFIG_IPV6_ISATAP) > + /* IS

Re: [PATCH 02/05] ipv6: RFC4214 Support

2007-11-07 Thread YOSHIFUJI Hideaki /
Hello. In article <[EMAIL PROTECTED]> (at Wed, 7 Nov 2007 16:58:59 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > > + eui[0] = 0; > > + > > + /* Check for RFC3330 global address ranges */ > > + if (((ipv4 >= 0x0100) && (ipv4 < 0x0a00)) || > > + ((ipv4 >= 0x0b00) && (ipv4

Re: [PATCH 00/05] ipv6: RFC4214 Support

2007-11-06 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Tue, 06 Nov 2007 21:37:50 -0800 (PST)), David Miller <[EMAIL PROTECTED]> says: > From: David Stevens <[EMAIL PROTECTED]> > Date: Tue, 6 Nov 2007 21:26:15 -0800 > > > Last I heard, there are Intellectual Property claims with ISATAP, > > which is why the RFC is n

Re: [BUG] in inet6_create

2007-11-05 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 01 Nov 2007 21:07:52 +0100), Roel Kluin <[EMAIL PROTECTED]> says: > I got this bug recently, I am not sure whether this is related to any > previously > reported ones. It was a recently pulled git kernel. Also I have been hacking > my > kernel a bit late

[RFC 2/2] [IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.

2007-10-29 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- include/linux/if_addrlabel.h | 55 include/linux/rtnetlink.h|7 + include/net/addrconf.h |8 + net/ipv6/Makefile|1 + net/ipv6/addrconf.c | 40 +--- net/ipv6/addrlabel.c | 566

[RFC 1/2] [IPV6] ADDRCONF: Preparation for configurable address selection policy with ifindex.

2007-10-29 Thread YOSHIFUJI Hideaki /
Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 348bd8d..8b408b7 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -877,7

[RFC 0/2] [IPV6] ADDRCONF: IPv6 configurable Default Address Selection support (TAKE 2)

2007-10-29 Thread YOSHIFUJI Hideaki /
This is the 2nd RFC for supporting configurable IPv6 Default Address Selection policy (RFC3484) based on 2.6.24-rc1. This is intended for 2.6.25. Major changes: - Use rtnetlink instead of ioctl/procfs. - Use RCU. Git tree is available at the branch named 2.6.24-rc1-addrlabel-20071

Re: [UDP6]: Restore sk_filter optimisation

2007-10-28 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Mon, 29 Oct 2007 15:33:20 +0900), Mitsuru Chinen <[EMAIL PROTECTED]> says: > Hello Herbert, > > Let me ask a question about this patch. > After this patch was applied, 2 of the protocol stack behaviors were > changed when it receives a UDP datagram with broken

[PATCH 2.6.24-rc] [IPV6] NDISC: Fix setting base_reachable_time_ms variable.

2007-10-28 Thread YOSHIFUJI Hideaki /
This bug was introduced by the commit d12af679bcf8995a237560bdf7a4d734f8df5dbb. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 20cfc90..36f7dbf 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -1670,7 +1670,7 @@ int ndisc_if

Re: [Bugme-new] [Bug 9224] New: Settings to /proc/sys/net/ipv[46]/conf/all are not propagated

2007-10-25 Thread YOSHIFUJI Hideaki /
In article <[EMAIL PROTECTED]> (at Thu, 25 Oct 2007 09:16:52 -0700), Andrew Morton <[EMAIL PROTECTED]> says: > > Most recent kernel where this bug did not occur: 2.6.22 (not sure) > Apparently a regression. I would say it is a bug, but it is not a regression. I mean, I believe this "bug" lives

  1   2   3   4   5   >