Hi Sergei,
On Fri, 20 Nov 2015 02:53:39 +0900,
Sergei Shtylyov wrote:
>
>Shoji-san, can I push this patch to net.git? I doubt that it has
> ill effects in itself -- the reason of the slowdown you're seeing
> should be somewhere else...
Sure. I've tested and the null access problem is gone
Control: 10c53c7d Table: 4248c059 DAC: 0015
> Process klogd (pid: 2046, stack limit = 0x84eb02e8)
> [...]
>
> This is because netdev_alloc_skb() fails and 'mdp->rx_skbuff[entry]' is left
> NULL but sh_eth_rx() later uses it without checking. Add such check...
>
Hi Sergei,
Thank your for your reply.
On Wed, 21 Oct 2015 05:48:01 +0900,
Sergei Shtylyov wrote:
>
> On 10/19/2015 06:01 PM, Yasushi SHOJI wrote:
>
> > I'm not that familiar with this code base so I'm note including any
> > patch yet. I appreciate if someone with insi
Hi,
In a low memory situation with netdev_alloc_skb() failure,
mdp->rx_skbuff[entry] can be left NULL, however, sh_eth_rx() seems to
access it without checking NULL or not in the following code:
skb = mdp->rx_skbuff[entry];
mdp->rx_skbuff[entry] =
