gt; Signed-off-by: Aditya Pakki
> ---
> net/rds/message.c | 1 +
> net/rds/send.c| 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Looks fine by me. Thanks.
Acked-by: Santosh Shilimkar
> On Apr 5, 2021, at 7:08 AM, Leon Romanovsky wrote:
>
> On Mon, Apr 05, 2021 at 03:41:15PM +0200, Christoph Hellwig wrote:
>> On Mon, Apr 05, 2021 at 08:23:54AM +0300, Leon Romanovsky wrote:
>>> From: Leon Romanovsky
>>>
From Avihai,
>>>
>>> Relaxed Ordering is a PCIe mechanism that rel
y: Parav Pandit
> Signed-off-by: Leon Romanovsky
> ---
> net/rds/ib.c | 20 +———
Looks fine by me.
Acked-by: Santosh Shilimkar
[...]
Thanks Haakon. Patchset looks fine by me.
Acked-by: Santosh Shilimkar
vbuf untouched.
>
> Signed-off-by: William Kucharski
> —
Looks good. Thanks !!
Acked-by: Santosh Shilimkar
include/linux/slab.h:621 [inline]
> rds_rdma_extra_size+0xb2/0x3b0 net/rds/rdma.c:568
> rds_rm_size net/rds/send.c:928 [inline]
>
> Reported-by: syzbot+1bd2b07f93745fa38...@syzkaller.appspotmail.com
> Signed-off-by: Sabyrzhan Tasbolatov
> —
Looks fine by me.
Acked-by: Santosh Shilimkar
&conn_param);
if (ret)
- rds_ib_conn_error(conn, "rdma_connect failed (%d)\n", ret);
+ rds_ib_conn_error(conn, "rdma_connect_locked failed (%d)\n",
+ ret);
out:
/* Beware - returning non-zero tells the rdma_cm to destroy
For RDS part,
Acked-by: Santosh Shilimkar
ng as well as
review.
Acked-by: Santosh Shilimkar
On 9/16/20 2:15 PM, Manjunath Patil wrote:
Hi Santosh,
inline.
On 9/16/2020 12:27 PM, santosh.shilim...@oracle.com wrote:
On 9/16/20 12:08 PM, Manjunath Patil wrote:
RDS/IB tries to refill the recv buffer in softirq context using
GFP_NOWAIT flag. However alloc failure is handled by queueing a
On 9/16/20 12:08 PM, Manjunath Patil wrote:
RDS/IB tries to refill the recv buffer in softirq context using
GFP_NOWAIT flag. However alloc failure is handled by queueing a work to
refill the recv buffer with GFP_KERNEL flag. This means failure to
allocate with GFP_NOWAIT isn't fatal. Do not print
On 5/29/20 12:12 PM, Jason Gunthorpe wrote:
On Thu, May 28, 2020 at 01:21:33PM -0700, santosh.shilim...@oracle.com wrote:
On 5/28/20 12:45 PM, Jason Gunthorpe wrote:
From: Max Gurtovoy
Use FRWR method for memory registration by default and remove the ancient
and unsafe FMR method.
Signed-off
On 6/15/20 12:40 AM, Ka-Cheong Poon wrote:
The parent field of a struct device may be NULL. The macro
ibdev_to_node() should check for that.
Signed-off-by: Ka-Cheong Poon
---
Looks good.
Acked-by: Santosh Shilimkar
On 5/28/20 12:45 PM, Jason Gunthorpe wrote:
From: Max Gurtovoy
Use FRWR method for memory registration by default and remove the ancient
and unsafe FMR method.
Signed-off-by: Max Gurtovoy
Signed-off-by: Jason Gunthorpe
---
net/rds/Makefile | 2 +-
net/rds/ib.c | 20 ++--
net/
nvert get_user_pages() --> pin_user_pages()")
Cc: David S. Miller
Cc: Jakub Kicinski
Cc: netdev@vger.kernel.org
Cc: linux-r...@vger.kernel.org
Cc: rds-de...@oss.oracle.com
Signed-off-by: John Hubbard
---
Thanks John !!
Acked-by: Santosh Shilimkar
Carvalho Chehab
---
Acked-by: Santosh Shilimkar
messages as well. Thanks !!
Acked-by: Santosh Shilimkar
() in failure path. This
can potentially crash the system. The code has been updated to
initialize these variables very early in the function.
Signed-off-by: Dotan Barak
Signed-off-by: Sudhakar Dindukurti
---
Thanks Sudhakar !!
Acked-by: Santosh Shilimkar
and can be costly at
times when memory is fragmented. Instead, RDS should use the DMA
memory pool interface to handle this.
Suggested-by: Håkon Bugge
Signed-off-by: Ka-Cheong Poon
---
Thanks for getting this out on the list Ka-Cheong.
Acked-by: Santosh Shilimkar
-Cheong for getting this out quickly on list.
Acked-by: Santosh Shilimkar
quot;RDS: IB: ack more receive completions to improve
performance")
Signed-off-by: Gerd Rausch
---
Thanks Gerd !!
Acked-by: Santosh Shilimkar
or the fixup patch. Should be applied to stable
as well.
Acked-by: Santosh Shilimkar
Regards,
Santosh
On 8/23/19 7:03 AM, Dag Moxnes wrote:
Add the RDMA cookie and RX timestamp to the usercopy whitelist.
After the introduction of hardened usercopy whitelisting
(https://lwn.net/Articles/727322/), a warning is displayed when the
RDMA cookie or RX timestamp is copied to userspace:
kernel: WARNING:
service(tos) infrastructure")
Fixes: b7ff8b1036f0 ("rds: Extend RDS API for IPv6 support")
Reported-by: 黄ID蝴蝶
Signed-off-by: Dan Carpenter
Signed-off-by: Ka-Cheong Poon
---
Thanks for getting this out of the list.
Acked-by: Santosh Shilimkar
-Cheong for getting this one out on list.
Acked-by: Santosh Shilimkar
ned-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
cket recv memory usage")
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
On 8/15/19 7:42 AM, Gerd Rausch wrote:
From: Chris Mason
Date: Fri, 3 Feb 2012 11:08:51 -0500
Signed-off-by: Chris Mason
Signed-off-by: Bang Nguyen
Signed-off-by: Gerd Rausch
Signed-off-by: Somasundaram Krishnasamy
---
Acked-by: Santosh Shilimkar
e" if "rds_ib_recv_refill_one" fails.
Signed-off-by: Gerd Rausch
---
Thought I acked V1 series.
Acked-by: Santosh Shilimkar
On 8/14/19 11:21 AM, David Miller wrote:
From: santosh.shilim...@oracle.com
Date: Wed, 14 Aug 2019 11:01:36 -0700
Some of the application software was released before 2009 and ended up
using these proc entries from downstream kernel. The newer lib/app
using RDS don't use these. Unfortunately lo
On 8/14/19 8:56 AM, Doug Ledford wrote:
On Tue, 2019-08-13 at 11:20 -0700, Gerd Rausch wrote:
From: Andy Grover
Date: Tue, 24 Nov 2009 15:35:51 -0800
Although RDS has an official PF_RDS value now, existing software
expects to look for rds sysctls to determine it. We need to maintain
these f
e" if "rds_ib_recv_refill_one" fails.
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
eed Andy's SOB as well.
Signed-off-by: Gerd Rausch
Other than that,
Acked-by: Santosh Shilimkar
done in the name of compatibility
with the Oracle internal code-base.
s_recv_bytes_added_to_socket -> "recv_bytes_added_to_sock"
s_recv_bytes_removed_from_socket -> "recv_bytes_freed_fromsock"
Fixes: 192a798f5299 ("RDS: add stat for socket recv memory usage&q
On 8/13/19 11:21 AM, Gerd Rausch wrote:
From: Chris Mason
Date: Fri, 3 Feb 2012 11:08:51 -0500
Signed-off-by: Chris Mason
Signed-off-by: Bang Nguyen
Signed-off-by: Gerd Rausch
Signed-off-by: Somasundaram Krishnasamy
---Acked-by: Santosh Shilimkar
Grover
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
alled "i_fastreg_inuse_count" that keeps track of how
many FRWR memory segments are out there marked "FRMR_IS_INUSE"
(and also wake_up rds_ib_ring_empty_wait, as they go away).
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
shutdown" will spin forever,
waiting for it to go back to "RDS_IB_DEFAULT_FR_WR",
which of course will never happen as there are no
outstanding work requests.
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
On 7/16/19 3:29 PM, Gerd Rausch wrote:
Fix a bug where fr_state first goes to FRMR_IS_STALE, because of a failure
of operation IB_WR_LOCAL_INV, but then gets set back to "FRMR_IS_FREE"
uncoditionally, even though the operation failed.
Signed-off-by: Gerd Rausch
---
Acked-b
an invalid access error in a race from a pending
"IB_WR_LOCAL_INV" operation with a teardown ("dma_unmap_sg", "put_page")
and de-registration ("ib_dereg_mr") of the corresponding
memory region.
Signed-off-by: Gerd Rausch
---
Thanks for updated version.
Acked-by: Santosh Shilimkar
On 7/16/19 3:29 PM, Gerd Rausch wrote:
Make function "rds_ib_try_reuse_ibmr" return NULL in case
memory region could not be allocated, since callers
simply check if the return value is not NULL.
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
Cases where locking is needed:
* If we have multiple consumers with llist_del_first used in one consumer,
* and llist_del_first or llist_del_all used in other consumers,
* then a lock is needed.
Also, while at it, drop the unused "pool" parameter
from "list_to_llist_nodes".
Signed-off-by: Gerd Rausch
---
Acked-by: Santosh Shilimkar
and "drop_list" before they even have a chance to be properly invalidated.
Signed-off-by: Gerd Rausch
---
Thanks for the update.
Acked-by: Santosh Shilimkar
onnection:
if (rds_conn_state(conn) == RDS_CONN_CONNECTING) {
/* Wait and see - our connect may still be succeeding */
rds_ib_stats_inc(s_ib_connect_raced);
}
goto out;
#6 Host-A
receives an "RDMA_CM_EVENT_REJECTED" event (from
From: Gerd Rausch
The proper "tos" value needs to be returned
to user-space (sockopt RDS_INFO_CONNECTIONS).
Fixes: 3eb450367d08 ("rds: add type of service(tos) infrastructure")
Signed-off-by: Gerd Rausch
Reviewed-by: Zhu Yanjun
Signed-off-by: Santosh Shilimkar
---
net/
iated connection with say
tos 8 while usual connection racing can get downgraded to tos 0
which is not desirable.
Patch fixes above issue introduced by commit
commit d021fabf525f ("rds: rdma: add consumer reject")
Reported-by: Yanjun Zhu
Tested-by: Yanjun Zhu
Signed-off-by: Sa
e send completes fix was done by Venkat
Venkatsubra in downstream kernel.
Reviewed-and-tested-by: Zhu Yanjun
Reviewed-by: Gerd Rausch
Signed-off-by: Santosh Shilimkar
---
net/rds/ib_send.c | 29 +
net/rds/rdma.c| 10 --
net/rds/rds.h | 1 -
net/rds/se
nd invalidation path"
rds: Accept peer connection reject messages due to incompatible version
rds: Return proper "tos" value to user-space
Santosh Shilimkar (2):
rds: fix reordering with composite message notification
rds: avoid version downgrade to legitimat
inal commit was done in the name of performance:
to remove the performance bottleneck
No performance benefit could be observed with a fixed-up version
of the original commit measured between two Oracle X7 servers,
both equipped with Mellanox Connect-X5 HCAs.
The prudent course of action is to
On 7/2/19 3:12 PM, Gerd Rausch wrote:
On 02/07/2019 14.18, santosh.shilim...@oracle.com wrote:
On 7/2/19 2:05 PM, Gerd Rausch wrote:
What do you call "RDS_GET_MR" semantics?
Its a blocking socket call. Meaning after this call return to the
user, the key must be valid. With async registration
On 7/2/19 2:05 PM, Gerd Rausch wrote:
On 02/07/2019 09.49, santosh.shilim...@oracle.com wrote:
On 7/1/19 10:11 PM, Gerd Rausch wrote:
For the registration work-requests there is a benefit to wait a short
amount of time only (the trade-off described in patch #1 of this series).
Actually we sho
On 7/1/19 10:11 PM, Gerd Rausch wrote:
Hi Santosh,
On 01/07/2019 19.28, santosh.shilim...@oracle.com wrote:
Below. All command timeouts are 60 seconds.
enum {
MLX4_CMD_TIME_CLASS_A = 6,
MLX4_CMD_TIME_CLASS_B = 6,
MLX4_CMD_TIME_CLASS_C = 6,
};
T
On 7/1/19 2:06 PM, Gerd Rausch wrote:
Hi Santosh,
On 01/07/2019 14.00, santosh.shilim...@oracle.com wrote:
Look for command timeout in CX3 sources. 60 second is upper bound in
CX3. Its not standard in specs(at least not that I know) though
and may vary from vendor to vendor.
I am not se
On 7/1/19 1:55 PM, Gerd Rausch wrote:
Hi Santosh,
On 01/07/2019 13.41, santosh.shilim...@oracle.com wrote:
@@ -144,7 +146,29 @@ static int rds_ib_post_reg_frmr(struct rds_ib_mr *ibmr)
if (printk_ratelimit())
pr_warn("RDS/IB: %s returned error(%d)\n",
On 7/1/19 1:50 PM, Gerd Rausch wrote:
Hi David,
On 01/07/2019 11.27, David Miller wrote:
From: Gerd Rausch
Date: Mon, 1 Jul 2019 09:39:44 -0700
+ /* Memory regions make it onto the "clean_list" via
+* "rds_ib_flush_mr_pool", after the memory regi
On 7/1/19 9:39 AM, Gerd Rausch wrote:
In order to:
1) avoid a silly bouncing between "clean_list" and "drop_list"
triggered by function "rds_ib_reg_frmr" as it is releases frmr
regions whose state is not "FRMR_IS_FREE" right away.
2) prevent an invalid access error in a race from a pendi
On 7/1/19 9:39 AM, Gerd Rausch wrote:
Waiting for activity on the "clean_list" to quiesce is no substitute
for proper locking.
We can have multiple threads competing for "llist_del_first"
via "rds_ib_reuse_mr", and a single thread competing
for "llist_del_all" and "llist_del_first" via "rds_ib_f
On 7/1/19 9:39 AM, Gerd Rausch wrote:
Make function "rds_ib_try_reuse_ibmr" return NULL in case
memory region could not be allocated, since callers
simply check if the return value is not NULL.
Signed-off-by: Gerd Rausch
---
Looks good to me. Will add this to other fixes.
On 7/1/19 9:40 AM, Gerd Rausch wrote:
Otherwise, if an IB connection is torn down before "rds_ib_setup_qp"
is called, the value of "ic->i_fastreg_wrs" is still at zero
(as it wasn't initialized by "rds_ib_setup_qp").
Consequently "rds_ib_conn_path_shutdown" will spin forever,
waiting for it to go
On 7/1/19 9:40 AM, Gerd Rausch wrote:
Since "rds_ib_free_frmr" and "rds_ib_free_frmr_list" simply put
the FRMR memory segments on the "drop_list" or "free_list",
and it is the job of "rds_ib_flush_mr_pool" to reap those entries
by ultimately issuing a "IB_WR_LOCAL_INV" work-request,
we need to tr
On 7/1/19 9:40 AM, Gerd Rausch wrote:
Fix a bug where fr_state first goes to FRMR_IS_STALE, because of a failure
of operation IB_WR_LOCAL_INV, but then gets set back to "FRMR_IS_FREE"
uncoditionally, even though the operation failed.
Signed-off-by: Gerd Rausch
---
net/rds/ib_frmr.c | 3 ++-
On 7/1/19 9:39 AM, Gerd Rausch wrote:
A number of net/rds fixes necessary to make "rds_rdma.ko"
pass some basic Oracle internal tests.
Gerd Rausch (7):
net/rds: Give fr_state a chance to transition to FRMR_IS_FREE
net/rds: Get rid of "wait_clean_list_grace" and add locking
net/rds: Wait
ean_list.
So clean_nodes is discarded. It can not be used again.
The workqueue is executed periodically. So more and more clean_nodes are
discarded. Finally the clean_list is NULL.
Then this problem will occur.
Fixes: 1bc144b62524 ("net, rds, Replace xlist in net/rds/xlist.h with llist")
Signed-off-by: Zhu Yanjun
---
Thanks.
Acked-by: Santosh Shilimkar
e rds.h in rds-tools is not related with the kernel rds.h, the change
in kernel rds.h does not affect rds-tools.
rds-info in rds-tools 2.0.5 and 2.0.6 is tested with this commit. It works
well.
Signed-off-by: Zhu Yanjun
---
V1->V2: RDS CI is removed.
Thanks for testing compatibility.
troy_cq(ic->i_send_cq);
+ ic->i_send_cq = NULL;
This was done to ensure, you still don't get ISR delivering
the CQEs while we are in shutdown path. Your patch
is fine though since you don't change that behavior.
Acked-by: Santosh Shilimkar
On 5/10/2019 12:47 PM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 12:38:31PM -0700, Santosh Shilimkar wrote:
On 5/10/2019 12:20 PM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 11:58:42AM -0700, santosh.shilim...@oracle.com wrote:
On 5/10/19 11:07 AM, Jason Gunthorpe wrote:
On Fri, May
On 5/10/2019 12:20 PM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 11:58:42AM -0700, santosh.shilim...@oracle.com wrote:
On 5/10/19 11:07 AM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 11:02:35AM -0700, santosh.shilim...@oracle.com wrote:
[...]
Why would you need to detect FS DAX mem
On 5/10/2019 6:02 AM, Jason Gunthorpe wrote:
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supp
On 5/10/2019 5:54 AM, Jason Gunthorpe wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform
On 5/4/2019 11:28 PM, Leon Romanovsky wrote:
On Thu, May 02, 2019 at 10:52:23AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 11:21 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:00AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019
5/4/2019 11:22 PM, Leon Romanovsky wrote:
On Thu, May 02, 2019 at 10:59:58AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 11:18 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:50AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at
On 5/1/2019 11:18 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:50AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that requi
On 5/1/2019 11:21 PM, Leon Romanovsky wrote:
On Wed, May 01, 2019 at 10:54:00AM -0700, Santosh Shilimkar wrote:
On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on m
On 5/1/2019 12:45 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:20PM -0700, Santosh Shilimkar wrote:
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supp
On 5/1/2019 12:44 AM, Leon Romanovsky wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. User applications can try to use
RDS to perform
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supported.
Reviewed-by: Håkon Bugge
Reviewed-tested-by: Zhu Yanjun
Signed-off-by: Hans Westgaard Ry
Signed-off-by: Sa
orted rdma request to fs dax memory
Santosh Shilimkar (1):
rds: add sysctl for rds support of On-Demand-Paging
net/rds/ib.h| 1 +
net/rds/ib_sysctl.c | 8
net/rds/rdma.c | 5 +++--
3 files changed, 12 insertions(+), 2 deletions(-)
--
1.9.1
Signed-off-by: Santosh Shilimkar
---
net/rds/rdma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 182ab84..e0a6b72 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -158,8 +158,9 @@ static int rds_pin_pages(unsigned long user_addr
RDS doesn't support RDMA on memory apertures that require On Demand
Paging (ODP), such as FS DAX memory. A sysctl is added to indicate
whether RDMA requiring ODP is supported.
Reviewed-by: Håkon Bugge
Reviewed-tested-by: Zhu Yanjun
Signed-off-by: Hans Westgaard Ry
Signed-off-by: Sa
orted rdma request to fs dax memory
Santosh Shilimkar (1):
rds: add sysctl for rds support of On-Demand-Paging
net/rds/ib.h| 1 +
net/rds/ib_sysctl.c | 8
net/rds/rdma.c | 5 +++--
3 files changed, 12 insertions(+), 2 deletions(-)
--
1.9.1
Signed-off-by: Santosh Shilimkar
---
net/rds/rdma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index 182ab84..5010100 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -158,8 +158,9 @@ static int rds_pin_pages(unsigned long user_addr
00 0.00 0.00 0.000.00 0.00 -1.00
100 0.00 0.00 0.000.00 0.00 -1.00
...
"
So this exchange between 8K and 1M pool is added back.
Fixes: commit 490ea5967b0d ("RDS: IB: move FMR code to its own file")
Signed-off-by: Zhu Yanjun
---
Acked-by: Santosh Shilimkar
for validation.
[1]
https://syzkaller.appspot.com/bug?id=f4e61c010416c1e6f0fa3ffe247561b60a50ad71
[2]
https://syzkaller.appspot.com/bug?id=a4bf9e41b7e055c3823fdcd83e8c58ca7270e38f
Reported-by: syzbot
Reported-by: syzbot
Signed-off-by: Tetsuo Handa
---
Acked-by: Santosh Shilimkar
On 3/8/2019 2:37 PM, Gerd Rausch wrote:
On 07/03/2019 17.37, santosh.shilim...@oracle.com wrote:
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -736,6 +736,7 @@ static int rds_conn_info_visitor(struct rds_conn_path *cp,
void *buffer)
cinfo->next_rx_seq = cp->cp_next_rx_seq;
bf525ff ("rds: rdma: add consumer reject")
Signed-off-by: Gerd Rausch
---
net/rds/rdma_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Changes in submitted patch v2:
* Dropped the "Orabug:" line from the commit-log message (as requested)
* Added a "Fixes:" line to the commit-log-message
Thanks Gerd for posting an update. The fix looks correct as already
mentioned in earlier post.
FWIW,
Acked-by: Santosh Shilimkar
Hi Yanjun,
Please provide your tested-by since you mentioned offlist that
so far you are unable to reproduce the issue on net-next. Thanks.
Regards,
Santosh
nn->c_faddr);
conn->c_proposed_version = RDS_PROTOCOL_COMPAT_VERSION;
@@ -122,7 +122,6 @@ static int rds_rdma_cm_event_handler_cmn(struct rdma_cm_id
*cm_id,
rdsdebug("Connection rejected: %s\n",
rdma_reject_msg(cm_id, event->st
On 3/5/2019 8:48 AM, Gerd Rausch wrote:
Hi Santosh,
On 05/03/2019 08.41, Santosh Shilimkar wrote:
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
If there's a mechanism that ensures compatibility with older (pre-4.1) versions
of RDS I am not seeing it.
Thats handled as part of the connection r
On 3/5/2019 8:33 AM, Gerd Rausch wrote:
Hi,
This patchset breaks compatibility...
On 04/02/2019 16.04, Santosh Shilimkar wrote:
--- a/net/rds/ib_cm.c
+++ b/net/rds/ib_cm.c
@@ -868,7 +870,7 @@ int rds_ib_cm_initiate_connect(struct rdma_cm_id *cm_id,
bool isv6)
/* If the peer doesn'
263024b3a6f9:
rds: rdma: update rdma transport for tos (2019-02-04 14:59:13 -0800)
--------
Santosh Shilimkar (5):
rds: make v3.1 as compat version
rds: rdma: add consumer reject
rds: add type of service(tos) infrastructure
rds: a
RDMA transport maps user tos to underline virtual lanes(VL)
for IB or DSCP values. RDMA CM transport abstract thats for
RDS. TCP transport makes use of default priority 0 and maps
all user tos values to it.
Reviewed-by: Sowmini Varadhan
Signed-off-by: Santosh Shilimkar
[yanjun@oracle.com
e versions, properly
encoded reject reason should to be used.
Reviewed-by: Sowmini Varadhan
Signed-off-by: Santosh Shilimkar
[yanjun@oracle.com: Adapted original patch with ipv6 changes]
Signed-off-by: Zhu Yanjun
---
net/rds/ib_cm.c | 6 --
net/rds/rdma_transport.c | 12 +++
metadata also carries the tos
information to set up SL on end to end context. The original
code was developed by Bang Nguyen in downstream kernel back in
2.6.32 kernel days and it has evolved over period of time.
Reviewed-by: Sowmini Varadhan
Signed-off-by: Santosh Shilimkar
[yanjun@oracle.com
: Santosh Shilimkar
[yanjun@oracle.com: Adapted original patch with ipv6 changes]
Signed-off-by: Zhu Yanjun
---
include/uapi/linux/rds.h | 11 +++
net/rds/af_rds.c | 35 ++-
net/rds/connection.c | 20 +++-
net/rds/ib.c
Mark RDSv3.1 as compat version and add v4.1 version macro's.
Subsequent patches enable TOS(Type of Service) feature which is
tied with v4.1 for RDMA transport.
Reviewed-by: Sowmini Varadhan
Signed-off-by: Santosh Shilimkar
[yanjun@oracle.com: Adapted original patch with ipv6 changes]
S
related problems")
Signed-off-by: Eric Dumazet
Reported-by: syzbot
Cc: Sowmini Varadhan
Cc: Santosh Shilimkar
Cc: rds-de...@oss.oracle.com
Cc: Cong Wang
---
Looks good.
Acked-by: Santosh Shilimkar
On 12/19/2018 10:22 AM, David Miller wrote:
From: Santosh Shilimkar
Date: Wed, 19 Dec 2018 10:00:20 -0800
On 12/19/2018 2:54 AM, Shamir Rabinovitch wrote:
[...]
Great. On patchwork I see the patches marked under review by Dave so
lets wait for his instruction(s).
Since they apply
On 12/19/2018 2:54 AM, Shamir Rabinovitch wrote:
On Tue, Dec 18, 2018 at 03:02:24PM -0800, Santosh Shilimkar wrote:
[...]
Shamir, please check if these apply cleanly to Dave's 'net' tree.
Santosh,
The patches apply cleanly on the master branch of
git://git.kernel.or
On 12/18/2018 2:57 PM, David Miller wrote:
From: Shamir Rabinovitch
Date: Sun, 16 Dec 2018 09:01:07 +0200
From: shamir rabinovitch
This patch set fix google syzbot rds bug found in linux-next.
The first patch solve the syzbot issue.
The second patch fix issue mentioned by Leon Romanovsky tha
.
Signed-off-by: Ka-Cheong Poon
---
Thanks for getting this out on the list.
Acked-by: Santosh Shilimkar
-off-by: Zhu Yanjun
---
Looks good. Thanks !!
Acked-by: Santosh Shilimkar
(),
so we need to extend RCU read lock protection in rds_find_bound()
to close this race condition.
Reported-and-tested-by: syzbot+8967084bcac563795...@syzkaller.appspotmail.com
Reported-by: syzbot+93a5839deb3555374...@syzkaller.appspotmail.com
Cc: Sowmini Varadhan
Cc: Santosh Shilimkar
Cc: rds-de
1 - 100 of 487 matches
Mail list logo
