[PATCH net-next] net: qualcomm: rmnet: Remove set but not used variable 'cmd'

2018-11-28 Thread YueHaibing
rmnet_map_control_command *cmd; 'cmd' not used anymore now, should also be removed. Signed-off-by: YueHaibing --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet

[PATCH net-next] e100: Fix passing zero to 'PTR_ERR' warning in e100_load_ucode_wait

2018-11-19 Thread YueHaibing
Fix a static code checker warning: drivers/net/ethernet/intel/e100.c:1349 e100_load_ucode_wait() warn: passing zero to 'PTR_ERR' Signed-off-by: YueHaibing --- drivers/net/ethernet/intel/e100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel

[PATCH net-next] SUNRPC: drop pointless static qualifier in xdr_get_next_encode_buffer()

2018-11-07 Thread YueHaibing
There is no need to have the '__be32 *p' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- net/sunrpc/xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index 2bbb8d3..d80b156 100644

Re: [PATCH net-next] octeontx2-af: Remove set but not used variable 'block'

2018-10-21 Thread YueHaibing
On 2018/10/19 21:36, Sunil Kovvuri wrote: > On Fri, Oct 19, 2018 at 6:11 PM YueHaibing wrote: >> >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c: In function >> 'rvu_npa_init': >> drivers/net/ethe

[PATCH net-next] octeontx2-af: Remove set but not used variable 'block'

2018-10-19 Thread YueHaibing
in commit 7a37245ef23f ("octeontx2-af: NPA block admin queue init") Signed-off-by: YueHaibing --- drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npa.c b/drivers/net/ethernet/marvell/oc

[PATCH net-next] igc: Remove set but not used variable 'pci_using_dac'

2018-10-19 Thread YueHaibing
d89f88419f99 ("igc: Add skeletal frame for Intel(R) 2.5G Ethernet Controller support") Signed-off-by: YueHaibing --- drivers/net/ethernet/intel/igc/igc_main.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethe

[PATCH net-next] igc: Remove set but not used variables 'ctrl_ext, link_mode'

2018-10-19 Thread YueHaibing
code") Signed-off-by: YueHaibing --- I'm not sure that reading IGC_CTRL_EXT is necessary. --- drivers/net/ethernet/intel/igc/igc_base.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_base.c b/drivers/net/ethernet/intel/igc/igc_base.c index 832da60

[PATCH net-next] rocker: Drop pointless static qualifier

2018-10-19 Thread YueHaibing
There is no need to have the 'struct rocker_desc_info *desc_info' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/net/ethernet/rocker/rocker_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH net-next] octeontx2-af: Remove set but not used variable 'dev'

2018-10-11 Thread YueHaibing
in commit 1463f382f58d ("octeontx2-af: Add support for CGX link management") Signed-off-by: YueHaibing --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethern

[PATCH v3] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets

2018-10-09 Thread YueHaibing
Emit BUSY packets when supposed to rather than ABORTs") Signed-off-by: YueHaibing --- v3: remove 'commit' from Fixes info. v2: use 'ioc' rather than remove it. --- net/rxrpc/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/output.c b/net/rxrpc/outp

Re: [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets

2018-10-09 Thread YueHaibing
On 2018/10/9 23:34, Sergei Shtylyov wrote: > On 10/09/2018 05:15 PM, YueHaibing wrote: > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> net/rxrpc/output.c: In function 'rxrpc_reject_packets': >> net/rxrpc/output.c:527:11: warning: >> variable 'ioc

[PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets

2018-10-09 Thread YueHaibing
rxrpc: Emit BUSY packets when supposed to rather than ABORTs") Signed-off-by: YueHaibing --- net/rxrpc/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c index e8fb892..a141ee3 100644 --- a/net/rxrpc/output.c +++ b/net/rxrp

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

2018-10-09 Thread YueHaibing
On 2018/10/9 18:13, David Howells wrote: > YueHaibing wrote: > >> net/rxrpc/output.c: In function 'rxrpc_reject_packets': >> net/rxrpc/output.c:527:11: warning: >> variable 'ioc' set but not used [-Wunused-but-set-variable] >> >> It never used since introduct

[PATCH net-next] rxrpc: Remove set but not used variable 'ioc'

2018-10-08 Thread YueHaibing
posed to rather than ABORTs") Signed-off-by: YueHaibing --- net/rxrpc/output.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/rxrpc/output.c b/net/rxrpc/output.c index e8fb892..f3ed16a 100644 --- a/net/rxrpc/output.c +++ b/net/rxrpc/output.c @@ -524,7 +524

[PATCH net-next] net: mscc: ocelot: remove set but not used variable 'phy_mode'

2018-10-08 Thread YueHaibing
introduction in commit 71e32a20cfbf ("net: mscc: ocelot: make use of SerDes PHYs for handling their configuration") Signed-off-by: YueHaibing --- drivers/net/ethernet/mscc/ocelot_board.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mscc/ocelot_board.c b/d

Re: [PATCH can-next] can: ucan: remove set but not used variable 'udev'

2018-09-27 Thread YueHaibing
ping. On 2018/8/29 9:46, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/can/usb/ucan.c: In function 'ucan_disconnect': > drivers/net/can/usb/ucan.c:1578:21: warning: > variable 'udev' set but not used [-Wunused-but-set-variable] > struc

Re: [PATCH can-next] can: ucan: remove duplicated include from ucan.c

2018-09-27 Thread YueHaibing
ping. On 2018/8/29 9:25, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing > --- > drivers/net/can/usb/ucan.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c > in

[PATCH net-next] qed: Remove set but not used variable 'p_archipelago'

2018-09-27 Thread YueHaibing
Signed-off-by: YueHaibing --- drivers/net/ethernet/qlogic/qed/qed_ooo.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_ooo.c b/drivers/net/ethernet/qlogic/qed/qed_ooo.c index 63931df..ffac4ac 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_ooo.c +++ b/drivers/ne

Re: [PATCH net-next] net/smc: cast sizeof to int for comparison

2018-09-16 Thread YueHaibing
On 2018/9/15 19:35, Andreas Schwab wrote: > On Sep 15 2018, YueHaibing wrote: > >> Comparing an int to a size, which is unsigned, causes the int to become >> unsigned, giving the wrong result. kernel_sendmsg can return a negative >> error code. >> >> Signed-of

[PATCH net-next] qlcnic: Remove set but not used variables 'fw_mbx' and 'hdr_size'

2018-09-11 Thread YueHaibing
From: Yue Haibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c: In function 'qlcnic_sriov_pull_bc_msg': drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:907:6: warning: variable 'fw_mbx' set but not used

[PATCH net-next] liquidio CN23XX: Remove set but not used variable 'ring_flag'

2018-09-06 Thread YueHaibing
-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c b/drivers/net/ethernet/cavium/liquidio/cn23xx_vf_device.c index 962bb62..fda4940 100644

[PATCH net-next] bnxt_en: remove set but not used variable 'addr_type'

2018-09-05 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c: In function 'bnxt_tc_parse_flow': drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:186:6: warning: variable 'addr_type' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers

[PATCH v2 net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-09-03 Thread YueHaibing
: cfc80d9a1163 ("net: Introduce net_failover driver") Signed-off-by: YueHaibing --- v2: use WARN_ON_ONCE as Liran Alon suggested --- drivers/net/net_failover.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index 7ae1856..5a74

[PATCH net-next] failover: Add missing check to validate 'slave_dev' in net_failover_slave_unregister

2018-08-31 Thread YueHaibing
: cfc80d9a1163 ("net: Introduce net_failover driver") Suggested-by: Samudrala, Sridhar Signed-off-by: YueHaibing --- drivers/net/net_failover.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index 7ae1856..af1ece8 100644 --- a/d

Re: [PATCH net-next] failover: remove set but not used variable 'primary_dev'

2018-08-31 Thread YueHaibing
On 2018/9/1 0:39, Samudrala, Sridhar wrote: > On 8/30/2018 8:46 PM, YueHaibing wrote: >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> drivers/net/net_failover.c: In function 'net_failover_slave_unregister': >> drivers/net/net_failover.c:598:35: warning: >

[PATCH v2 net-next] liquidio: remove set but not used variable 'irh'

2018-08-31 Thread YueHaibing
-by: YueHaibing --- v2: fix patch description,remove 'cHECK-' --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c index

Re: [PATCH net-next] liquidio: cHECK-remove set but not used variable 'irh'

2018-08-31 Thread YueHaibing
sorry, patch description is messy, will fix it in V2. On 2018/8/31 19:53, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/cavium/liquidio/request_manager.c: In function > 'lio_process_iq_request_list': > drivers/net/ethernet/

[PATCH net-next] liquidio: cHECK-remove set but not used variable 'irh'

2018-08-31 Thread YueHaibing
-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/request_manager.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c index bd0153e..c6f4cbd 100644 --- a/drivers/net/ethernet

[PATCH net-next] bnxt_en: remove set but not used variable 'rx_stats'

2018-08-30 Thread YueHaibing
; Signed-off-by: YueHaibing --- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c index e31f5d8..b574fe8 100644 --- a/drivers/net/ethernet/broadcom/bnxt

[PATCH net-next] failover: remove set but not used variable 'primary_dev'

2018-08-30 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/net_failover.c: In function 'net_failover_slave_unregister': drivers/net/net_failover.c:598:35: warning: variable 'primary_dev' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers/net/net_failover.c | 3

[PATCH net-next] net: remove duplicated include from net_failover.c

2018-08-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/net_failover.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index 7ae1856..192ae1c 100644 --- a/drivers/net/net_failover.c +++ b/drivers/net/net_failover.c @@ -19,7

[PATCH net-next] net/ncsi: remove duplicated include from ncsi-netlink.c

2018-08-29 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- net/ncsi/ncsi-netlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ncsi/ncsi-netlink.c b/net/ncsi/ncsi-netlink.c index 45f33d6..32cb775 100644 --- a/net/ncsi/ncsi-netlink.c +++ b/net/ncsi/ncsi-netlink.c @@ -12,7 +12,6

[PATCH can-next] can: ucan: remove set but not used variable 'udev'

2018-08-28 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/can/usb/ucan.c: In function 'ucan_disconnect': drivers/net/can/usb/ucan.c:1578:21: warning: variable 'udev' set but not used [-Wunused-but-set-variable] struct usb_device *udev; Signed-off-by: YueHaibing --- drivers/net/can/usb

[PATCH can-next] can: ucan: remove duplicated include from ucan.c

2018-08-28 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/can/usb/ucan.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/can/usb/ucan.c b/drivers/net/can/usb/ucan.c index 0678a38..c6f4b41 100644 --- a/drivers/net/can/usb/ucan.c +++ b/drivers/net/can/usb/ucan.c

[PATCH bpf-next] bpf: remove duplicated include from syscall.c

2018-08-28 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- kernel/bpf/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c index 8339d81..3c9636f 100644 --- a/kernel/bpf/syscall.c +++ b/kernel/bpf/syscall.c @@ -30,7 +30,6 @@ #include #include

[PATCH net-next] bnxt_en: combine 'else if' and 'else' into single branche

2018-07-25 Thread YueHaibing
The else-if branch and else branch set mac_ok to true similarly, so combine the two into single else branch. Aslo add comments to explain the two conditions, which from Michael Chan and Vasundhara Volam. Signed-off-by: YueHaibing --- drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 8

Re: [PATCH net-next] bnxt_en: Fix logic of forward the VF MAC address to PF in bnxt_vf_validate_set_mac

2018-07-25 Thread YueHaibing
On 2018/7/25 5:48, Michael Chan wrote: > On Tue, Jul 24, 2018 at 9:01 AM, Vasundhara Volam > wrote: >> On Tue, Jul 24, 2018 at 1:01 PM, Michael Chan >> wrote: >>> >>> On Mon, Jul 23, 2018 at 10:24 PM, YueHaibing wrote: >>>> Based on the co

[PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media

2018-07-25 Thread YueHaibing
when tipc_own_id failed to obtain node identity,dev_put should be call before return -EINVAL. Fixes: 682cd3cf946b ("tipc: confgiure and apply UDP bearer MTU on running links") Signed-off-by: YueHaibing --- net/tipc/bearer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/tip

[PATCH ipsec-next] xfrm: fix 'passing zero to ERR_PTR()' warning

2018-07-25 Thread YueHaibing
plate resolving always returns xfrms") Signed-off-by: YueHaibing --- net/xfrm/xfrm_policy.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 5f48251..4adbeb2 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c

[PATCH net] net: qcom/emac: Add missing of_node_put()

2018-06-11 Thread YueHaibing
Add missing of_node_put() call for device node returned by of_parse_phandle(). Signed-off-by: YueHaibing --- drivers/net/ethernet/qualcomm/emac/emac-sgmii.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qualcomm/emac/emac-sgmii.c b/drivers/net/ethernet/qualcomm/emac

[PATCH bpf-next] bpf: hide the unused 'off' variable

2018-05-28 Thread YueHaibing
read sock fields") Signed-off-by: YueHaibing --- net/core/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/filter.c b/net/core/filter.c index 24e6ce8..0ce93ed 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -6486,7 +6486,9 @@ static u32 sk_msg_convert_ctx_a

[PATCH net-next] net: remove unnecessary genlmsg_cancel() calls

2018-05-26 Thread YueHaibing
the message be freed immediately, no need to trim it back to the previous size. Inspired by commit 7a9b3ec1e19f ("nl80211: remove unnecessary genlmsg_cancel() calls") Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/team/team.c | 2 -- driv

Re: [PATCH net-next] bpfilter: fix a build err

2018-05-25 Thread YueHaibing
On 2018/5/26 0:19, Alexei Starovoitov wrote: > On Fri, May 25, 2018 at 06:17:57PM +0800, YueHaibing wrote: >> gcc-7.3.0 report following err: >> >> HOSTCC net/bpfilter/main.o >> In file included from net/bpfilter/main.c:9:0: >> ./include/uapi/linux/bpf.h:12:10

[PATCH net-next] bpfilter: fix a build err

2018-05-25 Thread YueHaibing
leton of bpfilter kernel module") Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- net/bpfilter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bpfilter/Makefile b/net/bpfilter/Makefile index 2af752c..3f3cb87 100644 --- a/net/bpfilter/Makefile +++ b/net/b

Re: [PATCH net-next] cxgb4: Check for kvzalloc allocation failure

2018-05-24 Thread YueHaibing
On 2018/5/24 23:07, David Miller wrote: > From: YueHaibing <yuehaib...@huawei.com> > Date: Tue, 22 May 2018 15:07:18 +0800 > >> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c >> index 130d1ee..01

[PATCH net-next] net: fec: remove stale comment

2018-05-24 Thread YueHaibing
This comment is outdated as fec_ptp_ioctl has been replaced by fec_ptp_set/fec_ptp_get since commit 1d5244d0e43b ("fec: Implement the SIOCGHWTSTAMP ioctl") Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/ethernet/freescale/fec_ptp.c | 6 -- 1 file chan

[PATCH net-next] ixgbe: introduce a helper to simplify code

2018-05-23 Thread YueHaibing
ixgbe_dbg_reg_ops_read and ixgbe_dbg_netdev_ops_read copy-pasting the same code except for ixgbe_dbg_netdev_ops_buf/ixgbe_dbg_reg_ops_buf, so introduce a helper ixgbe_dbg_common_ops_read to remove redundant code. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/ethernet

[PATCH] atmel: Add missing call to pci_disable_device()

2018-05-23 Thread YueHaibing
add pci_disable_device in error handling while init_atmel_card failed. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/wireless/atmel/atmel_pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/atmel/atmel_pci.c b/drive

[PATCH] netfilter: uapi: includes linux/types.h

2018-05-23 Thread YueHaibing
gcc-7.3.0 report following warning: ./usr/include/linux/netfilter/nf_osf.h:27: found __[us]{8,16,32,64} type without #include includes linux/types.h to fix it. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- include/uapi/linux/netfilter/nf_osf.h | 2 ++ 1 file changed, 2 inse

[PATCH net-next] cxgb4: Check for kvzalloc allocation failure

2018-05-22 Thread YueHaibing
t4_prep_fw doesn't check for card_fw pointer before store the read data, which could lead to a NULL pointer dereference if kvzalloc failed. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH] bpf: check NULL for sk_to_full_sk()

2018-05-21 Thread YueHaibing
On 2018/5/21 23:17, Eric Dumazet wrote: > > > On 05/21/2018 12:55 AM, YueHaibing wrote: >> like commit df39a9f106d5 ("bpf: check NULL for sk_to_full_sk() return >> value"), >> we should check sk_to_full_sk return value against NULL. >> >>

[PATCH] bpf: check NULL for sk_to_full_sk()

2018-05-21 Thread YueHaibing
like commit df39a9f106d5 ("bpf: check NULL for sk_to_full_sk() return value"), we should check sk_to_full_sk return value against NULL. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- include/linux/bpf-cgroup.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH net-next] vmxnet3: Replace msleep(1) with usleep_range()

2018-05-16 Thread YueHaibing
As documented in Documentation/timers/timers-howto.txt, replace msleep(1) with usleep_range(). Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/vmxnet3/vmxnet3_drv.c | 6 +++--- drivers/net/vmxnet3/vmxnet3_ethtool.c | 2 +- 2 files changed, 4 insertions(+), 4 del

Re: [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare

2018-05-16 Thread YueHaibing
On 2018/5/16 19:42, Kalle Valo wrote: > YueHaibing <yuehaib...@huawei.com> writes: > >> clk_disable_unprepare() already checks that the clock pointer is valid. >> No need to test it before calling it. >> >> Signed-off-by: YueHaibing <yuehaib...@huawei.co

[PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare

2018-05-16 Thread YueHaibing
clk_disable_unprepare() already checks that the clock pointer is valid. No need to test it before calling it. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/ethernet/ethoc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/e

[PATCH net-next] net: stmmac: Remove useless test before clk_disable_unprepare

2018-05-16 Thread YueHaibing
clk_disable_unprepare() already checks that the clock pointer is valid. No need to test it before calling it. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-)

[PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare

2018-05-16 Thread YueHaibing
clk_disable_unprepare() already checks that the clock pointer is valid. No need to test it before calling it. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/wireless/ath/ath10k/ahb.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drive

[PATCH bpf] tools: bpf: fix NULL return handling in bpf__prepare_load

2018-05-11 Thread YueHaibing
bpf_object__open()/bpf_object__open_buffer can return error pointer or NULL, check the return values with IS_ERR_OR_NULL() in bpf__prepare_load and bpf__prepare_load_buffer Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- tools/perf/util/bpf-loader.c | 6 +++--- 1 file changed, 3 inse

[PATCH net-next] can: dev: use skb_put_zero to simplfy code

2018-04-28 Thread YueHaibing
use helper skb_put_zero to replace the pattern of skb_put() && memset() Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/can/dev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index b1

[PATCH net-next] libcxgb,cxgb4: use __skb_put_zero to simplfy code

2018-04-27 Thread YueHaibing
use helper __skb_put_zero to replace the pattern of __skb_put() && memset() Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 3 +-- drivers/net/ethernet/chelsio/cxgb4/srq.c | 3 +-- drivers/net/ethernet/c

[PATCH] ptp_pch: use helpers function for converting between ns and timespec

2018-04-27 Thread YueHaibing
use ns_to_timespec64() and timespec64_to_ns() instead of open coding Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/ptp/ptp_pch.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/ptp/ptp_pch.c b/drivers/ptp/ptp_pch.c index b328517..78ccf93

Re: [PATCH] mac80211_hwsim: fix a possible memory leak in hwsim_new_radio_nl()

2018-04-27 Thread YueHaibing
cc Ben Hutchings <ben.hutchi...@codethink.co.uk> On 2018/4/24 11:08, YueHaibing wrote: > 'hwname' should be freed before leaving from the error handling cases, > otherwise it will cause mem leak > > Fixes: cb1a5bae5684 ("mac80211_hwsim: add permanent mac address o

[PATCH net-next] bridge: use hlist_entry_safe

2018-04-25 Thread YueHaibing
Use hlist_entry_safe() instead of open-coding it. Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- net/bridge/br_forward.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c index b4eed11..7a7fd67 100644 --- a/net/

[PATCH] mac80211_hwsim: fix a possible memory leak in hwsim_new_radio_nl()

2018-04-23 Thread YueHaibing
'hwname' should be freed before leaving from the error handling cases, otherwise it will cause mem leak Fixes: cb1a5bae5684 ("mac80211_hwsim: add permanent mac address option for new radios") Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/wireless/mac80211_

[PATCH net] tg3: don't clear stats while tg3_close

2017-05-03 Thread YueHaibing
: 92feeabf3f67 ("tg3: Save stats across chip resets") Signed-off-by: YueHaibing <yuehaib...@huawei.com> --- drivers/net/ethernet/broadcom/tg3.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index 30d1eb9

Re: [PATCH RFC net-next 2/7] net: add dst_pending_confirm flag to skbuff

2017-01-19 Thread YueHaibing
On 2016/12/20 4:37, Julian Anastasov wrote: > > Hello, > > On Mon, 19 Dec 2016, Eric Dumazet wrote: > >> I am still digesting this awesome patch series ;) > > Thanks. I don't feel quite comfortable with some > of the changes (mostly XFRM, dst_confirm usage in CXGB) and > I hope

Re: net/arp: ARP cache aging failed.

2016-12-14 Thread YueHaibing
On 2016/12/15 4:15, Julian Anastasov wrote: > > Hello, > > On Wed, 14 Dec 2016, YueHaibing wrote: > >> On 2016/11/26 4:40, Julian Anastasov wrote: >>> >>> So, the idea is to move TCP and other similar >>> users to the new dst_confi

Re: net/arp: ARP cache aging failed.

2016-12-14 Thread YueHaibing
On 2016/11/26 4:40, Julian Anastasov wrote: > > Hello, > > On Fri, 25 Nov 2016, Hannes Frederic Sowa wrote: > >> On 25.11.2016 09:18, Julian Anastasov wrote: >>> >>> Another option would be to add similar bit to >>> struct sock (sk_dst_pending_confirm), may be ip_finish_output2 >>>

Re: net/arp: ARP cache aging failed.

2016-11-24 Thread YueHaibing
On 2016/11/24 15:51, Julian Anastasov wrote: > > Hello, > > On Wed, 23 Nov 2016, Eric Dumazet wrote: > >> On Wed, 2016-11-23 at 15:37 +0100, Hannes Frederic Sowa wrote: >> >>> Irregardless about the question if bonding should keep the MAC address >>> alive, a MAC address can certainly

net/arp: ARP cache aging failed.

2016-11-22 Thread yuehaibing
Hi, I've encountered a arp cache aging failed bug in 4.9 kernel.The topo is as follow: HOST1 - IP1 | Switch |IP2-| HOST2 | |

Hello

2016-10-14 Thread yuehaibing
subscribe linux-kernel