Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-23 Thread David Miller
From: Arnd Bergmann Date: Thu, 22 Feb 2018 17:56:12 +0100 > I expect to do the same for gcc-8. Most of the fixes are trivial > anyway, and some of them fix actual bugs that would otherwise get > missed. It does make the code easier to understand and you can more directly see what

Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 5:40 PM, Eric Dumazet wrote: > On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote: > > ... >> >> This code is old, so Cc stable to make sure that we don't get the warning >> for older kernels built with new gcc. >> >> Cc: sta...@vger.kernel.org

Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Eric Dumazet
On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote: ... > > This code is old, so Cc stable to make sure that we don't get the warning > for older kernels built with new gcc. > > Cc: sta...@vger.kernel.org This part makes little sense to me for two reasons. 1) David Miller handles stable

[PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Arnd Bergmann
gcc-8 has a new warning that detects overlapping input and output arguments in memcpy(). It triggers for sit_init_net() calling ipip6_tunnel_clone_6rd(), which is actually correct: net/ipv6/sit.c: In function 'sit_init_net': net/ipv6/sit.c:192:3: error: 'memcpy' source argument is the same as