Re: [PATCH 0/5] skb data accessors cleanup

[David Miller]

From: Joe Perches 
Date: Fri, 16 Jun 2017 12:43:23 -0700

> On Fri, 2017-06-16 at 11:50 -0400, David Miller wrote:
>> From: Johannes Berg 
>> Date: Fri, 16 Jun 2017 09:07:42 +0200
>> 
>> > Over night, Fengguang's bot told me that it compiled all of its many
>> > various configurations successfully, and I had done allyesconfig on
>> > x86_64 myself yesterday to iron out the things I missed.
>> > 
>> > So now I think I'm happy with it.
> 
> Nice work Johannes. thanks.
> 
> Next up: skb_push?
>  
>> Series applied, thanks!
> 
> David, it seems you applied the V2 version of
> this patchset.  When you
> apply revised patches,
> can you please reply to the V2 submission?
> 
> It's a bit confusing otherwise.

Sorry, that happens from time to time :-(

Re: [PATCH 0/5] skb data accessors cleanup

[Joe Perches]

On Fri, 2017-06-16 at 11:50 -0400, David Miller wrote:
> From: Johannes Berg 
> Date: Fri, 16 Jun 2017 09:07:42 +0200
> 
> > Over night, Fengguang's bot told me that it compiled all of its many
> > various configurations successfully, and I had done allyesconfig on
> > x86_64 myself yesterday to iron out the things I missed.
> > 
> > So now I think I'm happy with it.

Nice work Johannes. thanks.

Next up: skb_push?
 
> Series applied, thanks!

David, it seems you applied the V2 version of
this patchset.  When you
apply revised patches,
can you please reply to the V2 submission?

It's a bit confusing otherwise.

> I tell ya, spatch appears to be the crack cocaine of Linus kernel
> development.  Once someone gets into some spatch scripting work,
> they can't stop!

True.

Sometimes I use cocci, sometimes I use regexes.
cocci is cool but it can still be pretty slow.

Re: [PATCH 0/5] skb data accessors cleanup

[David Miller]

From: Johannes Berg 
Date: Fri, 16 Jun 2017 09:07:42 +0200

> Over night, Fengguang's bot told me that it compiled all of its many
> various configurations successfully, and I had done allyesconfig on
> x86_64 myself yesterday to iron out the things I missed.
> 
> So now I think I'm happy with it.
> 
> My tree was based on your
> 
> commit 3715c47bcda8bb56f7e2be27276282a2d0d48c09
> Merge: 18b6e7955d8f d8fbd27469fc
> Author: David S. Miller 
> Date:   Thu Jun 15 14:31:56 2017 -0400
> 
> Merge branch 'r8152-support-new-chips'
> 
> when the compilation tests happened, but I've reviewed the changes
> coming into net-next in the meantime and didn't see any new usages
> of skb data accessors having come in.

Series applied, thanks!

I tell ya, spatch appears to be the crack cocaine of Linus kernel
development.  Once someone gets into some spatch scripting work,
they can't stop!

[PATCH 0/5] skb data accessors cleanup

[Johannes Berg]

Hi,

Over night, Fengguang's bot told me that it compiled all of its many
various configurations successfully, and I had done allyesconfig on
x86_64 myself yesterday to iron out the things I missed.

So now I think I'm happy with it.

My tree was based on your

commit 3715c47bcda8bb56f7e2be27276282a2d0d48c09
Merge: 18b6e7955d8f d8fbd27469fc
Author: David S. Miller 
Date:   Thu Jun 15 14:31:56 2017 -0400

Merge branch 'r8152-support-new-chips'

when the compilation tests happened, but I've reviewed the changes
coming into net-next in the meantime and didn't see any new usages
of skb data accessors having come in.

johannes