Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

Hi Finn, On Wed, Apr 18, 2018 at 1:23 PM, Finn Thain wrote: > On Wed, 18 Apr 2018, Michael Schmitz wrote: > >> I think this is a false positive - we're encouraged to provide the >> full parameter list for functions, so the sreuct sk_buff* can't be >> avoided. >> > > I

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

Hi Andrew, ax88796 includes it via linux/netdevice.h. mac-anubis.c doesn't. Michael Karcher's patches have added forward derclarations for struct netdevice and struct platform_data already - I'll add struct sk_buff as suggested by Finn. Cheers, Michael On Wed, Apr 18, 2018 at 1:19 PM,

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

On Wed, 18 Apr 2018, Michael Schmitz wrote: > I think this is a false positive - we're encouraged to provide the > full parameter list for functions, so the sreuct sk_buff* can't be > avoided. > I don't think it's a false positive. I think ax88796.h would need to #include . You may be able to

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

On Wed, Apr 18, 2018 at 12:53:21PM +1200, Michael Schmitz wrote: > I think this is a false positive - we're encouraged to provide the > full parameter list for functions, so the sreuct sk_buff* can't be > avoided. Hi Michael How is being included? You probably want to build using the .config

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

I think this is a false positive - we're encouraged to provide the full parameter list for functions, so the sreuct sk_buff* can't be avoided. Cheers, Michael On Wed, Apr 18, 2018 at 6:46 AM, kbuild test robot wrote: > Hi Michael, > > I love your patch! Perhaps something to

Re: [PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

Hi Michael, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16] [cannot apply to net-next/master net/master v4.17-rc1 next-20180417] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz