Re: [PATCH 2/2] hns: Clean up string operations

[kbuild test robot]

Hi Ben,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v4.16-rc4]
[also build test WARNING on next-20180314]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Ben-Hutchings/hns-Fix-string-set-validation-in-ethtool-string-operations/20180315-082407
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:73:20: sparse: symbol 
'hns_ae_get_handle' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:332:6: sparse: symbol 
'hns_ae_stop' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:360:6: sparse: symbol 
'hns_ae_toggle_ring_irq' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:580:6: sparse: symbol 
'hns_ae_update_stats' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:663:6: sparse: symbol 
'hns_ae_get_stats' was not declared. Should it be static?
>> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:695:6: sparse: symbol 
>> 'hns_ae_get_stats_strings' was not declared. Should it be static?
>> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:727:5: sparse: symbol 
>> 'hns_ae_get_stats_count' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:773:6: sparse: symbol 
'hns_ae_update_led_status' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:785:5: sparse: symbol 
'hns_ae_cpld_set_led_id' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:797:6: sparse: symbol 
'hns_ae_get_regs' was not declared. Should it be static?
   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:822:5: sparse: symbol 
'hns_ae_get_regs_len' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation

[PATCH 2/2] hns: Clean up string operations

[Ben Hutchings]

The driver-internal string operations are only ever used for
statistics, so remove the stringset parameters and rename them
accordingly.

Signed-off-by: Ben Hutchings 
---
 drivers/net/ethernet/hisilicon/hns/hnae.h  | 13 
 drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c  | 37 +++---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 16 +++---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c  |  9 +++---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h  | 10 +++---
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 28 ++--
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h |  6 ++--
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c  | 11 +++
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.h  |  4 +--
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.c  | 20 
 drivers/net/ethernet/hisilicon/hns/hns_dsaf_rcb.h  |  4 +--
 .../net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c| 24 +-
 drivers/net/ethernet/hisilicon/hns/hns_ethtool.c   |  9 +++---
 13 files changed, 78 insertions(+), 113 deletions(-)

diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h 
b/drivers/net/ethernet/hisilicon/hns/hnae.h
index 3e62692af011..480fa2b49be7 100644
--- a/drivers/net/ethernet/hisilicon/hns/hnae.h
+++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
@@ -457,10 +457,10 @@ enum hnae_media_type {
  *   update Old network device statistics
  * get_ethtool_stats()
  *   get ethtool network device statistics
- * get_strings()
- *   get a set of strings that describe the requested objects
- * get_sset_count()
- *   get number of strings that @get_strings will write
+ * get_stats_strings()
+ *   get a set of strings that describe the statistics
+ * get_stats_count()
+ *   get number of strings that @get_stats_strings will write
  * update_led_status()
  *   update the led status
  * set_led_id()
@@ -522,9 +522,8 @@ struct hnae_ae_ops {
void (*update_stats)(struct hnae_handle *handle,
 struct net_device_stats *net_stats);
void (*get_stats)(struct hnae_handle *handle, u64 *data);
-   void (*get_strings)(struct hnae_handle *handle,
-   u32 stringset, u8 *data);
-   int (*get_sset_count)(struct hnae_handle *handle, int stringset);
+   void (*get_stats_strings)(struct hnae_handle *handle, u8 *data);
+   int (*get_stats_count)(struct hnae_handle *handle);
void (*update_led_status)(struct hnae_handle *handle);
int (*set_led_id)(struct hnae_handle *handle,
  enum hnae_led_state status);
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c 
b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c
index bd68379d2bea..638476aa6311 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c
+++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c
@@ -679,21 +679,20 @@ void hns_ae_get_stats(struct hnae_handle *handle, u64 
*data)
 
for (idx = 0; idx < handle->q_num; idx++) {
hns_rcb_get_stats(handle->qs[idx], p);
-   p += hns_rcb_get_ring_sset_count((int)ETH_SS_STATS);
+   p += hns_rcb_get_ring_stats_count();
}
 
hns_ppe_get_stats(ppe_cb, p);
-   p += hns_ppe_get_sset_count((int)ETH_SS_STATS);
+   p += hns_ppe_get_stats_count();
 
hns_mac_get_stats(mac_cb, p);
-   p += hns_mac_get_sset_count(mac_cb, (int)ETH_SS_STATS);
+   p += hns_mac_get_stats_count(mac_cb);
 
if (mac_cb->mac_type == HNAE_PORT_SERVICE)
hns_dsaf_get_stats(vf_cb->dsaf_dev, p, vf_cb->port_index);
 }
 
-void hns_ae_get_strings(struct hnae_handle *handle,
-   u32 stringset, u8 *data)
+void hns_ae_get_stats_strings(struct hnae_handle *handle, u8 *data)
 {
int port;
int idx;
@@ -711,21 +710,21 @@ void hns_ae_get_strings(struct hnae_handle *handle,
ppe_cb = hns_get_ppe_cb(handle);
 
for (idx = 0; idx < handle->q_num; idx++) {
-   hns_rcb_get_strings(stringset, p, idx);
-   p += ETH_GSTRING_LEN * hns_rcb_get_ring_sset_count(stringset);
+   hns_rcb_get_stats_strings(p, idx);
+   p += ETH_GSTRING_LEN * hns_rcb_get_ring_stats_count();
}
 
-   hns_ppe_get_strings(ppe_cb, stringset, p);
-   p += ETH_GSTRING_LEN * hns_ppe_get_sset_count(stringset);
+   hns_ppe_get_stats_strings(ppe_cb, p);
+   p += ETH_GSTRING_LEN * hns_ppe_get_stats_count();
 
-   hns_mac_get_strings(mac_cb, stringset, p);
-   p += ETH_GSTRING_LEN * hns_mac_get_sset_count(mac_cb, stringset);
+   hns_mac_get_stats_strings(mac_cb, p);
+   p += ETH_GSTRING_LEN * hns_mac_get_stats_count(mac_cb);
 
if (mac_cb->mac_type == HNAE_PORT_SERVICE)
-   hns_dsaf_get_strings(stringset, p, port, dsaf_dev);
+   hns_dsaf_get_stats_strings(p, port, dsaf_dev);
 }
 
-int hns_ae_get_sset_count(struct hnae_handle *handle, int