Re: [PATCH 2/2] net: rds: drop VLA in rds_walk_conn_path_info()

[David Miller]

From: Salvatore Mesoraca 
Date: Sun, 11 Mar 2018 22:07:50 +0100

> Avoid VLA[1] by using an already allocated buffer passed
> by the caller.
> 
> [1] https://lkml.org/lkml/2018/3/7/621
> 
> Signed-off-by: Salvatore Mesoraca 

Also applied, thanks.

Re: [PATCH 2/2] net: rds: drop VLA in rds_walk_conn_path_info()

[santosh.shilim...@oracle.com]

On 3/11/18 2:07 PM, Salvatore Mesoraca wrote:

Avoid VLA[1] by using an already allocated buffer passed
by the caller.

[1] https://lkml.org/lkml/2018/3/7/621

Signed-off-by: Salvatore Mesoraca 
---

Acked-by: Santosh Shilimkar 

[PATCH 2/2] net: rds: drop VLA in rds_walk_conn_path_info()

[Salvatore Mesoraca]

Avoid VLA[1] by using an already allocated buffer passed
by the caller.

[1] https://lkml.org/lkml/2018/3/7/621

Signed-off-by: Salvatore Mesoraca 
---
 net/rds/connection.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/rds/connection.c b/net/rds/connection.c
index f80792c..abef75d 100644
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -578,9 +578,9 @@ static void rds_walk_conn_path_info(struct socket *sock, 
unsigned int len,
struct rds_info_iterator *iter,
struct rds_info_lengths *lens,
int (*visitor)(struct rds_conn_path *, void 
*),
+   u64 *buffer,
size_t item_len)
 {
-   u64  buffer[(item_len + 7) / 8];
struct hlist_head *head;
struct rds_connection *conn;
size_t i;
@@ -649,8 +649,11 @@ static void rds_conn_info(struct socket *sock, unsigned 
int len,
  struct rds_info_iterator *iter,
  struct rds_info_lengths *lens)
 {
+   u64 buffer[(sizeof(struct rds_info_connection) + 7) / 8];
+
rds_walk_conn_path_info(sock, len, iter, lens,
rds_conn_info_visitor,
+   buffer,
sizeof(struct rds_info_connection));
 }
 
-- 
1.9.1