[PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] --- include/net/fib_rules.h | 16 +++- 1 files changed, 7 insertions(+), 9 deletions(-) diff --git a/include/net/fib_rules.h b/include/net/fib_rules.h index 2364db1..d20db25 100644 --- a/include/net/fib_rules.h +++ b/include/net/fib_rules.h @@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr *frh, struct nlattr **nla) return frh-table; } -extern int fib_rules_register(struct fib_rules_ops *); -extern int fib_rules_unregister(struct fib_rules_ops *); -extern void fib_rules_cleanup_ops(struct fib_rules_ops *); +extern int fib_rules_register(struct fib_rules_ops *); +extern int fib_rules_unregister(struct fib_rules_ops *); +extern void fib_rules_cleanup_ops(struct fib_rules_ops *); -extern int fib_rules_lookup(struct fib_rules_ops *, -struct flowi *, int flags, -struct fib_lookup_arg *); -extern int fib_default_rule_add(struct fib_rules_ops *, -u32 pref, u32 table, -u32 flags); +extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags, + struct fib_lookup_arg *); +extern int fib_default_rule_add(struct fib_rules_ops *, u32 pref, u32 table, + u32 flags); #endif -- 1.5.3.rc5 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
David Miller wrote: From: Denis V. Lunev [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 17:18:42 +0300 There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] This is just noise and serves nothing other than to invite potential patch conflicts which makes development harder. If you happened to be changing these for other reasons, I'd say OK, but not like this. I will add parameter to these calls. The line will be too long after that. I'd like to separate sense changes from, you perfectly correct, useless changes :( Could you still apply it, or I will need to send fully functional set to you including this? -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
From: Denis V. Lunev [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 18:01:32 +0300 Could you still apply it, or I will need to send fully functional set to you including this? Please combine the changes so that when you change the args you fixup the whitespace as well. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
From: Denis V. Lunev [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 17:18:42 +0300 There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines. Signed-off-by: Denis V. Lunev [EMAIL PROTECTED] This is just noise and serves nothing other than to invite potential patch conflicts which makes development harder. If you happened to be changing these for other reasons, I'd say OK, but not like this. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 17:47:07 +0300 On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote: There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines. If this patch is going in, it would be nice to get rid of extern as well. The convention in the networking headers is to use extern, and this is pretty consistently done across the board. If we are going to do this, which I personally see no reason for, we should do it across the whole networking. Consistency is much more important than whatever reason you could come up with to get rid of the 'extern'. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote: There are to many spaces between type and function name in the declaration of fib rules manipulation routines. Eat them and save a couple of lines. If this patch is going in, it would be nice to get rid of extern as well. Alexey, who once removed all externs from prototypes and got 4 seconds compilation speedup. --- a/include/net/fib_rules.h +++ b/include/net/fib_rules.h @@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr *frh, struct nlattr **nla) return frh-table; } -extern int fib_rules_register(struct fib_rules_ops *); -extern int fib_rules_unregister(struct fib_rules_ops *); -extern void fib_rules_cleanup_ops(struct fib_rules_ops *); +extern int fib_rules_register(struct fib_rules_ops *); +extern int fib_rules_unregister(struct fib_rules_ops *); +extern void fib_rules_cleanup_ops(struct fib_rules_ops *); -extern int fib_rules_lookup(struct fib_rules_ops *, - struct flowi *, int flags, - struct fib_lookup_arg *); -extern int fib_default_rule_add(struct fib_rules_ops *, - u32 pref, u32 table, - u32 flags); +extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags, + struct fib_lookup_arg *); +extern int fib_default_rule_add(struct fib_rules_ops *, u32 pref, u32 table, + u32 flags); #endif -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
