Re: [PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type

2017-08-09 Thread David Howells
Arnd Bergmann wrote: > Ah, I'm slowly starting to understand how this fits together. So you can add > a key either through key_add() from local user space, or through an rxrpc > socket. No, you can't add keys through an rxrpc socket. There are three 'classes' of key: (1)

Re: [PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type

2017-08-09 Thread Arnd Bergmann
On Wed, Aug 9, 2017 at 3:26 PM, David Howells wrote: > Arnd Bergmann wrote: > >> Do you know which format is used in practice? Are both kad and k5 common >> among rxrpc users? > > The aklog program I'm using uses the non-XDR interface to push a Kerberos 5 >

Re: [PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type

2017-08-09 Thread David Howells
Arnd Bergmann wrote: > Do you know which format is used in practice? Are both kad and k5 common > among rxrpc users? The aklog program I'm using uses the non-XDR interface to push a Kerberos 5 ticket to the kernel, so it doesn't actually invoke rxrpc_preparse_xdr() from

Re: [PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type

2017-08-09 Thread Arnd Bergmann
On Wed, Aug 9, 2017 at 11:33 AM, David Howells wrote: > Arnd Bergmann wrote: > >> > @@ -533,8 +536,9 @@ static int rxrpc_preparse_xdr_rxk5(struct >> > key_preparsed_payload *prep, >> > pptoken = &(*pptoken)->next) >> > continue;

Re: [PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type

2017-08-09 Thread David Howells
Arnd Bergmann wrote: > > @@ -533,8 +536,9 @@ static int rxrpc_preparse_xdr_rxk5(struct > > key_preparsed_payload *prep, > > pptoken = &(*pptoken)->next) > > continue; > > *pptoken = token; > > - if (token->kad->expiry < prep->expiry) > >

Re: [PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type

2017-08-09 Thread Arnd Bergmann
On Wed, Aug 9, 2017 at 4:51 AM, Baolin Wang wrote: > diff --git a/include/keys/rxrpc-type.h b/include/keys/rxrpc-type.h > index 5de0673..76421e2 100644 > --- a/include/keys/rxrpc-type.h > +++ b/include/keys/rxrpc-type.h > @@ -127,4 +127,25 @@ struct rxrpc_key_data_v1 { >

[PATCH 3/3] net: rxrpc: Replace time_t type with time64_t type

2017-08-08 Thread Baolin Wang
Since the 'expiry' variable of 'struct key_preparsed_payload' has been changed to 'time64_t' type, which is year 2038 safe on 32bits system. In net/rxrpc subsystem, we need convert 'u32' type to 'time64_t' type when copying ticket expires time to 'prep->expiry', then this patch introduces two