Re: [PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-14 Thread Björn Töpel
Den fre 10 aug. 2018 kl 18:26 skrev Jakub Kicinski : > > On Fri, 10 Aug 2018 17:16:45 +0200, Björn Töpel wrote: > > Den fre 10 aug. 2018 kl 16:10 skrev Daniel Borkmann : > > > > > > On 08/10/2018 11:28 AM, Björn Töpel wrote: > > > > From: Björn Töpel > > > > > > > > This reverts commit

Re: [PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-10 Thread Jakub Kicinski
On Fri, 10 Aug 2018 17:16:45 +0200, Björn Töpel wrote: > Den fre 10 aug. 2018 kl 16:10 skrev Daniel Borkmann : > > > > On 08/10/2018 11:28 AM, Björn Töpel wrote: > > > From: Björn Töpel > > > > > > This reverts commit 36e0f12bbfd3016f495904b35e41c5711707509f. > > > > > > The reverted commit

Re: [PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-10 Thread Jakub Kicinski
On Fri, 10 Aug 2018 17:15:07 +0200, Björn Töpel wrote: > Den fre 10 aug. 2018 kl 12:18 skrev Jesper Dangaard Brouer > : > > > > On Fri, 10 Aug 2018 11:28:02 +0200 > > Björn Töpel wrote: > > > > > From: Björn Töpel > > > > > > This reverts commit 36e0f12bbfd3016f495904b35e41c5711707509f. > > >

Re: [PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-10 Thread Björn Töpel
Den fre 10 aug. 2018 kl 16:10 skrev Daniel Borkmann : > > On 08/10/2018 11:28 AM, Björn Töpel wrote: > > From: Björn Töpel > > > > This reverts commit 36e0f12bbfd3016f495904b35e41c5711707509f. > > > > The reverted commit adds a WARN to check against NULL entries in the > > mem_id_ht rhashtable.

Re: [PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-10 Thread Björn Töpel
Den fre 10 aug. 2018 kl 12:18 skrev Jesper Dangaard Brouer : > > On Fri, 10 Aug 2018 11:28:02 +0200 > Björn Töpel wrote: > > > From: Björn Töpel > > > > This reverts commit 36e0f12bbfd3016f495904b35e41c5711707509f. > > > > The reverted commit adds a WARN to check against NULL entries in the > >

Re: [PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-10 Thread Daniel Borkmann
On 08/10/2018 11:28 AM, Björn Töpel wrote: > From: Björn Töpel > > This reverts commit 36e0f12bbfd3016f495904b35e41c5711707509f. > > The reverted commit adds a WARN to check against NULL entries in the > mem_id_ht rhashtable. Any kernel path implementing the XDP (generic or > driver) fast path

Re: [PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-10 Thread Jesper Dangaard Brouer
On Fri, 10 Aug 2018 11:28:02 +0200 Björn Töpel wrote: > From: Björn Töpel > > This reverts commit 36e0f12bbfd3016f495904b35e41c5711707509f. > > The reverted commit adds a WARN to check against NULL entries in the > mem_id_ht rhashtable. Any kernel path implementing the XDP (generic or >

[PATCH bpf] Revert "xdp: add NULL pointer check in __xdp_return()"

2018-08-10 Thread Björn Töpel
From: Björn Töpel This reverts commit 36e0f12bbfd3016f495904b35e41c5711707509f. The reverted commit adds a WARN to check against NULL entries in the mem_id_ht rhashtable. Any kernel path implementing the XDP (generic or driver) fast path is required to make a paired