Re: [PATCH bpf] tools: bpftool: close prog FD before exit on showing a single program

2019-08-15 Thread Alexei Starovoitov
On Thu, Aug 15, 2019 at 7:22 AM Quentin Monnet wrote: > > When showing metadata about a single program by invoking > "bpftool prog show PROG", the file descriptor referring to the program > is not closed before returning from the function. Let's close it. > > Fixes: 71bb428fe2c1 ("tools: bpf: add

Re: [PATCH bpf] tools: bpftool: close prog FD before exit on showing a single program

2019-08-15 Thread Andrii Nakryiko
On Thu, Aug 15, 2019 at 11:09 AM Jakub Kicinski wrote: > > On Thu, 15 Aug 2019 11:05:16 -0700, Andrii Nakryiko wrote: > > > > Would it be better to make show_prog(fd) close provided fd instead or > > > > is it used in some other context where FD should live longer (I > > > > haven't checked, sorry

Re: [PATCH bpf] tools: bpftool: close prog FD before exit on showing a single program

2019-08-15 Thread Jakub Kicinski
On Thu, 15 Aug 2019 11:05:16 -0700, Andrii Nakryiko wrote: > > > Would it be better to make show_prog(fd) close provided fd instead or > > > is it used in some other context where FD should live longer (I > > > haven't checked, sorry)? > > > > I think it used to close that's how the bug crept in.

Re: [PATCH bpf] tools: bpftool: close prog FD before exit on showing a single program

2019-08-15 Thread Andrii Nakryiko
On Thu, Aug 15, 2019 at 10:30 AM Jakub Kicinski wrote: > > On Thu, 15 Aug 2019 10:09:38 -0700, Andrii Nakryiko wrote: > > On Thu, Aug 15, 2019 at 7:24 AM Quentin Monnet wrote: > > > When showing metadata about a single program by invoking > > > "bpftool prog show PROG", the file descriptor referri

Re: [PATCH bpf] tools: bpftool: close prog FD before exit on showing a single program

2019-08-15 Thread Jakub Kicinski
On Thu, 15 Aug 2019 10:09:38 -0700, Andrii Nakryiko wrote: > On Thu, Aug 15, 2019 at 7:24 AM Quentin Monnet wrote: > > When showing metadata about a single program by invoking > > "bpftool prog show PROG", the file descriptor referring to the program > > is not closed before returning from the func

Re: [PATCH bpf] tools: bpftool: close prog FD before exit on showing a single program

2019-08-15 Thread Andrii Nakryiko
On Thu, Aug 15, 2019 at 7:24 AM Quentin Monnet wrote: > > When showing metadata about a single program by invoking > "bpftool prog show PROG", the file descriptor referring to the program > is not closed before returning from the function. Let's close it. > > Fixes: 71bb428fe2c1 ("tools: bpf: add

[PATCH bpf] tools: bpftool: close prog FD before exit on showing a single program

2019-08-15 Thread Quentin Monnet
When showing metadata about a single program by invoking "bpftool prog show PROG", the file descriptor referring to the program is not closed before returning from the function. Let's close it. Fixes: 71bb428fe2c1 ("tools: bpf: add bpftool") Signed-off-by: Quentin Monnet Reviewed-by: Jakub Kicins