Re: [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare

[YueHaibing]

On 2018/5/16 19:42, Kalle Valo wrote:
> YueHaibing  writes:
> 
>> clk_disable_unprepare() already checks that the clock pointer is valid.
>> No need to test it before calling it.
>>
>> Signed-off-by: YueHaibing 
> 
> Just a note that ath10k patches are applied to my ath.git tree, not to
> net-next. So adding net-next to the subject is wrong, but no need to
> resend just because of that.
> 

OK, got it, thank you

Re: [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare

[Kalle Valo]

YueHaibing  writes:

> clk_disable_unprepare() already checks that the clock pointer is valid.
> No need to test it before calling it.
>
> Signed-off-by: YueHaibing 

Just a note that ath10k patches are applied to my ath.git tree, not to
net-next. So adding net-next to the subject is wrong, but no need to
resend just because of that.

-- 
Kalle Valo

[PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare

[YueHaibing]

clk_disable_unprepare() already checks that the clock pointer is valid.
No need to test it before calling it.

Signed-off-by: YueHaibing 
---
 drivers/net/wireless/ath/ath10k/ahb.c | 9 +++--
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/ahb.c 
b/drivers/net/wireless/ath/ath10k/ahb.c
index 35d1049..fa39fff 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -180,14 +180,11 @@ static void ath10k_ahb_clock_disable(struct ath10k *ar)
 {
struct ath10k_ahb *ar_ahb = ath10k_ahb_priv(ar);
 
-   if (!IS_ERR_OR_NULL(ar_ahb->cmd_clk))
-   clk_disable_unprepare(ar_ahb->cmd_clk);
+   clk_disable_unprepare(ar_ahb->cmd_clk);
 
-   if (!IS_ERR_OR_NULL(ar_ahb->ref_clk))
-   clk_disable_unprepare(ar_ahb->ref_clk);
+   clk_disable_unprepare(ar_ahb->ref_clk);
 
-   if (!IS_ERR_OR_NULL(ar_ahb->rtc_clk))
-   clk_disable_unprepare(ar_ahb->rtc_clk);
+   clk_disable_unprepare(ar_ahb->rtc_clk);
 }
 
 static int ath10k_ahb_rst_ctrl_init(struct ath10k *ar)
-- 
2.7.0