Mon, Oct 12, 2015 at 02:41:06PM IDT, ra...@blackwall.org wrote:
>From: Nikolay Aleksandrov
>
Hi Nik,
Small nitpick:
>@@ -825,17 +848,19 @@ unlock:
>
> int br_vlan_init(struct net_bridge *br)
> {
>+ struct net_bridge_vlan_group *vg;
> int ret = -ENOMEM;
>
>- br->vlgrp = kzallo
From: Nikolay Aleksandrov
The bridge and port's vlgrp member is already used in RCU way, currently
we rely on the fact that it cannot disappear while the port exists but
that is error-prone and we might miss places with improper locking
(either RCU or RTNL must be held to walk the vlan_list). So