Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

[David Miller]

From: marcelo.leit...@gmail.com
Date: Mon, 31 Oct 2016 18:13:02 -0200

> On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote:
>> From: Xin Long 
>> Date: Mon, 31 Oct 2016 00:42:35 +0800
>> 
>> > Prior to this patch, it used a local variable to save the transport that is
>> > looked up by __sctp_lookup_association(), and didn't return it back. But in
>> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
>> > even if it found the transport, it was still initializing chunk->transport
>> > with null instead.
>> > 
>> > This patch is to return the transport back through transport pointer
>> > that is from __sctp_rcv_lookup_harder().
>> > 
>> > Signed-off-by: Xin Long 
>> 
>> So do I apply this to 'net'?  If so I'd like to see explicit ACKs.
>> 
>> Thanks.
> 
> No. Xin reposted the patchset with this patch updated instead, so please
> ignore this one. Thanks.
> 
> Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport

I got this now, thanks.

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

[marcelo . leitner]

On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote:
> From: Xin Long 
> Date: Mon, 31 Oct 2016 00:42:35 +0800
> 
> > Prior to this patch, it used a local variable to save the transport that is
> > looked up by __sctp_lookup_association(), and didn't return it back. But in
> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> > even if it found the transport, it was still initializing chunk->transport
> > with null instead.
> > 
> > This patch is to return the transport back through transport pointer
> > that is from __sctp_rcv_lookup_harder().
> > 
> > Signed-off-by: Xin Long 
> 
> So do I apply this to 'net'?  If so I'd like to see explicit ACKs.
> 
> Thanks.

No. Xin reposted the patchset with this patch updated instead, so please
ignore this one. Thanks.

Patchset named: [PATCHv2 net 0/3] sctp: a bunch of fixes by holding transport

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

[David Miller]

From: Xin Long 
Date: Mon, 31 Oct 2016 00:42:35 +0800

> Prior to this patch, it used a local variable to save the transport that is
> looked up by __sctp_lookup_association(), and didn't return it back. But in
> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> even if it found the transport, it was still initializing chunk->transport
> with null instead.
> 
> This patch is to return the transport back through transport pointer
> that is from __sctp_rcv_lookup_harder().
> 
> Signed-off-by: Xin Long 

So do I apply this to 'net'?  If so I'd like to see explicit ACKs.

Thanks.

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

[Xin Long]

On Mon, Oct 31, 2016 at 6:51 PM, Marcelo Ricardo Leitner
 wrote:
> On Mon, Oct 31, 2016 at 12:42:35AM +0800, Xin Long wrote:
>> Prior to this patch, it used a local variable to save the transport that is
>> looked up by __sctp_lookup_association(), and didn't return it back. But in
>> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
>> even if it found the transport, it was still initializing chunk->transport
>> with null instead.
>>
>> This patch is to return the transport back through transport pointer
>> that is from __sctp_rcv_lookup_harder().
>>
>> Signed-off-by: Xin Long 
>> ---
>
> Patch looks good now but you have to either repost the entire series
> altogether, or repost the series to remove this patch from it.
Ah, sorry, will repost the entire series altogether.

>
>   Marcelo
>

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

[Marcelo Ricardo Leitner]

On Mon, Oct 31, 2016 at 12:42:35AM +0800, Xin Long wrote:
> Prior to this patch, it used a local variable to save the transport that is
> looked up by __sctp_lookup_association(), and didn't return it back. But in
> sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
> even if it found the transport, it was still initializing chunk->transport
> with null instead.
> 
> This patch is to return the transport back through transport pointer
> that is from __sctp_rcv_lookup_harder().
> 
> Signed-off-by: Xin Long 
> ---

Patch looks good now but you have to either repost the entire series
altogether, or repost the series to remove this patch from it.

  Marcelo

[PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

[Xin Long]

Prior to this patch, it used a local variable to save the transport that is
looked up by __sctp_lookup_association(), and didn't return it back. But in
sctp_rcv, it is used to initialize chunk->transport. So when hitting this,
even if it found the transport, it was still initializing chunk->transport
with null instead.

This patch is to return the transport back through transport pointer
that is from __sctp_rcv_lookup_harder().

Signed-off-by: Xin Long 
---
 net/sctp/input.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/sctp/input.c b/net/sctp/input.c
index a2ea1d1..8e0bc58 100644
--- a/net/sctp/input.c
+++ b/net/sctp/input.c
@@ -1021,7 +1021,6 @@ static struct sctp_association 
*__sctp_rcv_init_lookup(struct net *net,
struct sctphdr *sh = sctp_hdr(skb);
union sctp_params params;
sctp_init_chunk_t *init;
-   struct sctp_transport *transport;
struct sctp_af *af;
 
/*
@@ -1052,7 +1051,7 @@ static struct sctp_association 
*__sctp_rcv_init_lookup(struct net *net,
 
af->from_addr_param(paddr, params.addr, sh->source, 0);
 
-   asoc = __sctp_lookup_association(net, laddr, paddr, );
+   asoc = __sctp_lookup_association(net, laddr, paddr, transportp);
if (asoc)
return asoc;
}
-- 
2.1.0