Re: [bpf-next PATCH] samples/bpf: fix xdp_monitor user output for tracepoint exception

[Daniel Borkmann]

On 04/17/2018 04:08 PM, Jesper Dangaard Brouer wrote:
> The variable rec_i contains an XDP action code not an error.
> Thus, using err2str() was wrong, it should have been action2str().
> 
> Signed-off-by: Jesper Dangaard Brouer 

Applied to bpf-next, thanks Jesper!

[bpf-next PATCH] samples/bpf: fix xdp_monitor user output for tracepoint exception

[Jesper Dangaard Brouer]

The variable rec_i contains an XDP action code not an error.
Thus, using err2str() was wrong, it should have been action2str().

Signed-off-by: Jesper Dangaard Brouer 
---
 samples/bpf/xdp_monitor_user.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/samples/bpf/xdp_monitor_user.c b/samples/bpf/xdp_monitor_user.c
index eec14520d513..894bc64c2cac 100644
--- a/samples/bpf/xdp_monitor_user.c
+++ b/samples/bpf/xdp_monitor_user.c
@@ -330,7 +330,7 @@ static void stats_print(struct stats_record *stats_rec,
pps = calc_pps_u64(r, p, t);
if (pps > 0)
printf(fmt1, "Exception", i,
-  0.0, pps, err2str(rec_i));
+  0.0, pps, action2str(rec_i));
}
pps = calc_pps_u64(>total, >total, t);
if (pps > 0)