RE: [PATCH 03/12] netfilter: x_tables: align per cpu xt_counter

2015-06-22 Thread David Laight
From: Pablo Neira Ayuso
 Sent: 19 June 2015 18:18
 From: Eric Dumazet eduma...@google.com
 
 Let's force a 16 bytes alignment on xt_counter percpu allocations,
 so that bytes and packets sit in same cache line.
 
 xt_counter being exported to user space, we cannot add __align(16) on
 the structure itself.

You could allocate a wrapper structure that contains xt_counter
and is itself marked __align(16).

David

--
To unsubscribe from this list: send the line unsubscribe netdev in


Re: [PATCH 03/12] netfilter: x_tables: align per cpu xt_counter

2015-06-22 Thread Eric Dumazet
On Mon, 2015-06-22 at 11:49 +, David Laight wrote:
 From: Pablo Neira Ayuso
  Sent: 19 June 2015 18:18
  From: Eric Dumazet eduma...@google.com
  
  Let's force a 16 bytes alignment on xt_counter percpu allocations,
  so that bytes and packets sit in same cache line.
  
  xt_counter being exported to user space, we cannot add __align(16) on
  the structure itself.
 
 You could allocate a wrapper structure that contains xt_counter
 and is itself marked __align(16).

Sure. I took one solution, out of multiple ones.


--
To unsubscribe from this list: send the line unsubscribe netdev in