Re: [PATCH/RFC net-next 0/3] introduce Geneve options support in TC tunnel key

2018-03-06 Thread Simon Horman
On Tue, Mar 06, 2018 at 07:11:12PM +0200, Or Gerlitz wrote:
> On Tue, Mar 6, 2018 at 7:08 PM, Simon Horman  
> wrote:
> > Hi all,
> >
> > This set adds Geneve options support to the TC tunnel key action.
> > Options TLVs are exposed to userspace using a list of netlink attributes
> > with each option described using attributes for class, type and data.
> 
> can you comment re what are the change vs your earlier post (will
> appreciate an arch link to the thread..)

The main change is that the netlink interface exposes netlink attribute for
the class, type and data of each option, rather than a single attribute
that describes all options as a byte-string.

I believe the previous discussion is here:
https://www.spinics.net/lists/netdev/msg457058.html


Re: [PATCH/RFC net-next 0/3] introduce Geneve options support in TC tunnel key

2018-03-06 Thread Or Gerlitz
On Tue, Mar 6, 2018 at 7:08 PM, Simon Horman  wrote:
> Hi all,
>
> This set adds Geneve options support to the TC tunnel key action.
> Options TLVs are exposed to userspace using a list of netlink attributes
> with each option described using attributes for class, type and data.

can you comment re what are the change vs your earlier post (will
appreciate an arch link to the thread..)

>
> The series also enhances the tunnel key action to use extended ack.
>
> Simon Horman (3):
>   net/sched: act_tunnel_key: disambiguate metadata dst error cases
>   net/sched: act_tunnel_key: add extended ack support
>   net/sched: add tunnel option support to act_tunnel_key
>
>  include/uapi/linux/tc_act/tc_tunnel_key.h |  26 
>  net/sched/act_tunnel_key.c| 212 
> --
>  2 files changed, 230 insertions(+), 8 deletions(-)
>
> --
> 2.11.0
>