Re: [PATCH iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Shmulik Ladkani 
On Thu, 22 Sep 2016 09:05:04 -0700 Stephen Hemminger 
 wrote:
> On Thu, 22 Sep 2016 12:31:10 +0300
> Shmulik Ladkani  wrote:
> 
> > +
> > +static const char *action_name(int action)
> > +{
> > +   static const char * const names[] = {
> > +   [TCA_VLAN_ACT_POP] = "pop",
> > +   [TCA_VLAN_ACT_PUSH] = "push",
> > +   [TCA_VLAN_ACT_MODIFY] = "modify",
> > +   };
> > +   return names[action];
> > +}
> > +  
> 
> Why are you wrapping a simple array lookup in a function?

No reason in particular, was probably code evolution, will amend, thanks.

Re: [PATCH iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Stephen Hemminger 
On Thu, 22 Sep 2016 12:31:10 +0300
Shmulik Ladkani  wrote:

> +
> +static const char *action_name(int action)
> +{
> + static const char * const names[] = {
> + [TCA_VLAN_ACT_POP] = "pop",
> + [TCA_VLAN_ACT_PUSH] = "push",
> + [TCA_VLAN_ACT_MODIFY] = "modify",
> + };
> + return names[action];
> +}
> +

Why are you wrapping a simple array lookup in a function?