Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Wed, Jan 18, 2017 at 1:16 PM, Eric Dumazet wrote: > > On Wed, Jan 18, 2017 at 10:13 AM, Yuchung Cheng wrote: > > On Wed, Jan 18, 2017 at 9:35 AM, Eric Dumazet wrote: > >> > >> On Wed, Jan 18, 2017 at 9:32 AM, Alexey Kodanev > >>

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Wed, Jan 18, 2017 at 1:27 PM, Yuchung Cheng wrote: > Hi Eric: yeah I think the test was just due to the TSO chunking > difference between prod and upstream, which I was able to avoid with > this patch re-suited by Neal in b/34128974. In fact, this patch > enables me to run

Re: resend: tcp: performance issue with fastopen connections (mss > window)

Googler-only Hi Eric: yeah I think the test was just due to the TSO chunking difference between prod and upstream, which I was able to avoid with this patch re-suited by Neal in b/34128974. In fact, this patch enables me to run all recovery tests on upstream kernels for my RACK patch set. Neal:

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Wed, Jan 18, 2017 at 10:13 AM, Yuchung Cheng wrote: > On Wed, Jan 18, 2017 at 9:35 AM, Eric Dumazet wrote: >> >> On Wed, Jan 18, 2017 at 9:32 AM, Alexey Kodanev >> wrote: >> > Hi Eric, >> > >> > On 01/13/2017 08:07 PM, Alexey

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Wed, Jan 18, 2017 at 9:35 AM, Eric Dumazet wrote: > > On Wed, Jan 18, 2017 at 9:32 AM, Alexey Kodanev > wrote: > > Hi Eric, > > > > On 01/13/2017 08:07 PM, Alexey Kodanev wrote: > > > > > Looks like max_window not correctly initialized for tfo

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Wed, Jan 18, 2017 at 9:32 AM, Alexey Kodanev wrote: > Hi Eric, > > On 01/13/2017 08:07 PM, Alexey Kodanev wrote: > > Looks like max_window not correctly initialized for tfo sockets. > On my test machine it has set to '5592320' in tcp_fastopen_create_child(). > >

Re: resend: tcp: performance issue with fastopen connections (mss > window)

Hi Eric, On 01/13/2017 08:07 PM, Alexey Kodanev wrote: Hi Eric, On 13.01.2017 18:35, Eric Dumazet wrote: I would suggest to clamp MSS to half the initial window, but I guess this is impractical since window in SYN/SYNACK are not scaled. Looks like max_window not correctly initialized for

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Fri, 2017-01-13 at 12:32 -0500, Neal Cardwell wrote: > On Fri, Jan 13, 2017 at 12:14 PM, Eric Dumazet wrote: > > > > On Fri, Jan 13, 2017 at 9:07 AM, Alexey Kodanev > > wrote: > > > Hi Eric, > > > On 13.01.2017 18:35, Eric Dumazet wrote: > > > >

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Fri, Jan 13, 2017 at 12:14 PM, Eric Dumazet wrote: > > On Fri, Jan 13, 2017 at 9:07 AM, Alexey Kodanev > wrote: > > Hi Eric, > > On 13.01.2017 18:35, Eric Dumazet wrote: > > >> Care to send a packetdrill test so that we have a clear picture of

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Fri, Jan 13, 2017 at 9:07 AM, Alexey Kodanev wrote: > Hi Eric, > On 13.01.2017 18:35, Eric Dumazet wrote: >> Care to send a packetdrill test so that we have a clear picture of what >> is going on ? > > Is it capable of making two connections in the single test, one

Re: resend: tcp: performance issue with fastopen connections (mss > window)

Hi Eric, On 13.01.2017 18:35, Eric Dumazet wrote: > On Fri, 2017-01-13 at 18:01 +0300, Alexey Kodanev wrote: >> Hi, >> >> Got the issue when running LTP/netstress test on localhost with mss >> greater than the send window advertised by client (right after 3WHS). >> Here is the testscenario that

Re: resend: tcp: performance issue with fastopen connections (mss > window)

On Fri, 2017-01-13 at 18:01 +0300, Alexey Kodanev wrote: > Hi, > > Got the issue when running LTP/netstress test on localhost with mss > greater than the send window advertised by client (right after 3WHS). > Here is the testscenario that can reproduce this: Hi Alexey So this is a combination

resend: tcp: performance issue with fastopen connections (mss > window)

Hi, Got the issue when running LTP/netstress test on localhost with mss greater than the send window advertised by client (right after 3WHS). Here is the testscenario that can reproduce this: TCP client is sending 32 bytes request, TCP server replies with 65KB answer. net.ipv4.tcp_fastopen set