Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
drivers/net/ehea/ehea_ethtool.c | 294
1 file changed, 294 insertions(+)
--- linux-2.6.18-rc6-orig/drivers/net/ehea/ehea_ethtool.c 1970-01-01
01:00:00.0 +0100
+++
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
drivers/net/ehea/ehea_ethtool.c | 244
1 file changed, 244 insertions(+)
--- linux-2.6.18-rc4-git1-orig/drivers/net/ehea/ehea_ethtool.c 1969-12-31
16:00:00.0 -0800
+++
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
drivers/net/ehea/ehea_ethtool.c | 244
1 file changed, 244 insertions(+)
--- linux-2.6.18-rc4-git1-orig/drivers/net/ehea/ehea_ethtool.c 1969-12-31
16:00:00.0 -0800
+++
Stephen Hemminger wrote:
On Fri, 18 Aug 2006 17:41:26 +0200
Thomas Klein [EMAIL PROTECTED] wrote:
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;
Useless assignment here and everywhere.
Initializing returncodes to
Alexey Dobriyan wrote:
On Fri, Aug 18, 2006 at 01:33:22PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c
+++ kernel/drivers/net/ehea/ehea_ethtool.c
+{
+strncpy(info-driver, DRV_NAME, sizeof(info-driver) - 1);
+strncpy(info-version,
On Fri, 2006-08-18 at 17:41 +0200, Thomas Klein wrote:
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;
Useless assignment here and everywhere.
Initializing returncodes to errorstate is a cheap way to prevent
On Sat, 2006-08-19 at 16:18 +1000, Michael Ellerman wrote:
If you try to return an uninitialized value the compiler will warn you,
you'll then look at the code and realise you missed a case, you might
save yourself a bug.
You *should* look at the code :)
So should we be reporting these as
On Sat, 2006-08-19 at 02:48 -0400, Andy Gay wrote:
On Sat, 2006-08-19 at 16:18 +1000, Michael Ellerman wrote:
If you try to return an uninitialized value the compiler will warn you,
you'll then look at the code and realise you missed a case, you might
save yourself a bug.
You
On Saturday 19 August 2006 10:41, Michael Ellerman wrote:
A lot of these have started appearing recently, which I think is due to
GCC becoming more vocal. Unfortunately many of them are false positives
caused by GCC not seeming to grok that this is ok:
void foo(int *x) { *x = 1; }
...
int
Andy Gay wrote:
fs/bio.c:169: warning: 'idx' may be used uninitialized in this function
fs/eventpoll.c:500: warning: 'fd' may be used uninitialized in this function
fs/isofs/namei.c:162: warning: 'offset' may be used uninitialized in this
function
fs/isofs/namei.c:162: warning: 'block' may be
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
drivers/net/ehea/ehea_ethtool.c | 264
1 file changed, 264 insertions(+)
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c 1969-12-31
16:00:00.0 -0800
+++
On Fri, Aug 18, 2006 at 01:33:22PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c
+++ kernel/drivers/net/ehea/ehea_ethtool.c
+static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd
*cmd)
+{
+ u64 hret = H_HARDWARE;
useless
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;
Useless assignment here and everywhere.
Initializing returncodes to errorstate is a cheap way to prevent
accidentally returning (uninitalized) success returncodes which
On Fri, 18 Aug 2006 17:41:26 +0200
Thomas Klein [EMAIL PROTECTED] wrote:
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;
Useless assignment here and everywhere.
Initializing returncodes to errorstate is a cheap
14 matches
Mail list logo
