On 13-12-2007 03:49, Herbert Xu wrote:
On Thu, Dec 13, 2007 at 09:58:56AM +0800, Herbert Xu wrote:
[IPSEC]: Fix reversed ICMP6 policy check
While that won't crash anymore, it's still logically wrong.
Here's a more complete fix.
...even more than this!
Since more than a year each time I
On Wed, Dec 12, 2007 at 05:39:51PM -0800, Andrew Morton wrote:
Here's the screen-shot (actually more like a reen-hot):
http://userweb.kernel.org/~akpm/pc121694.jpg
I'm awaiting a reoccurrence with the screen in 50-row mode.
Sorry, I didn't test IPv6.
[IPSEC]: Fix reversed ICMP6 policy
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 09:58:56 +0800
[IPSEC]: Fix reversed ICMP6 policy check
The policy check I added for ICMP on IPv6 is reversed. This
patch fixes that.
It also adds an skb-sp check so that unprotected packets that
fail the policy check do
On Thu, Dec 13, 2007 at 09:58:56AM +0800, Herbert Xu wrote:
[IPSEC]: Fix reversed ICMP6 policy check
While that won't crash anymore, it's still logically wrong.
Here's a more complete fix.
[IPSEC]: Fix reversed ICMP6 policy check
The policy check I added for ICMP on IPv6 is reversed. We
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 10:49:18 +0800
On Thu, Dec 13, 2007 at 09:58:56AM +0800, Herbert Xu wrote:
[IPSEC]: Fix reversed ICMP6 policy check
While that won't crash anymore, it's still logically wrong.
Here's a more complete fix.
I already applied
On Wed, Dec 12, 2007 at 06:48:30PM -0800, David Miller wrote:
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 09:58:56 +0800
[IPSEC]: Fix reversed ICMP6 policy check
Applied, thanks Herbert.
You're too quick :) Before you ask for an incremental patch, here's
a preemptive strike
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 10:51:56 +0800
You're too quick :) Before you ask for an incremental patch, here's
a preemptive strike :)
Hehe :)
[IPSEC]: Do not let packets pass when ICMP flag is off
This fixes a logical error in ICMP policy checks which lets
