Re: [PATCH][FIX 4.1] bgmac: fix requests for extra polling calls from NAPI

2015-04-24 Thread David Miller 
From: Felix Fietkau n...@openwrt.org
Date: Thu, 23 Apr 2015 21:00:04 +0200

 On 2015-04-23 20:56, Rafał Miłecki wrote:
 After d75b1ade567f (net: less interrupt masking in NAPI) polling
 function has to return whole budget when it wants NAPI to call it again.
 
 Signed-off-by: Rafał Miłecki zaj...@gmail.com
 Cc: Felix Fietkau n...@openwrt.org
 Fixes: eb64e2923a886 (bgmac: leave interrupts disabled as long as there is 
 work to do)
 Acked-by: Felix Fietkau n...@openwrt.org

Applied, thanks everyone.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][FIX 4.1] bgmac: fix requests for extra polling calls from NAPI

2015-04-23 Thread Eric Dumazet 
On Thu, 2015-04-23 at 20:56 +0200, Rafał Miłecki wrote:
 After d75b1ade567f (net: less interrupt masking in NAPI) polling
 function has to return whole budget when it wants NAPI to call it again.
 
 Signed-off-by: Rafał Miłecki zaj...@gmail.com
 Cc: Felix Fietkau n...@openwrt.org
 Fixes: eb64e2923a886 (bgmac: leave interrupts disabled as long as there is 
 work to do)
 ---
  drivers/net/ethernet/broadcom/bgmac.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Signed-off-by: Eric Dumazet eduma...@google.com

Thanks !


--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH][FIX 4.1] bgmac: fix requests for extra polling calls from NAPI

2015-04-23 Thread Rafał Miłecki 
After d75b1ade567f (net: less interrupt masking in NAPI) polling
function has to return whole budget when it wants NAPI to call it again.

Signed-off-by: Rafał Miłecki zaj...@gmail.com
Cc: Felix Fietkau n...@openwrt.org
Fixes: eb64e2923a886 (bgmac: leave interrupts disabled as long as there is 
work to do)
---
 drivers/net/ethernet/broadcom/bgmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c 
b/drivers/net/ethernet/broadcom/bgmac.c
index de77d3a..21e3c38 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -1260,7 +1260,7 @@ static int bgmac_poll(struct napi_struct *napi, int 
weight)
 
/* Poll again if more events arrived in the meantime */
if (bgmac_read(bgmac, BGMAC_INT_STATUS)  (BGMAC_IS_TX0 | BGMAC_IS_RX))
-   return handled;
+   return weight;
 
if (handled  weight) {
napi_complete(napi);
-- 
1.8.4.5

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][FIX 4.1] bgmac: fix requests for extra polling calls from NAPI

2015-04-23 Thread Felix Fietkau 
On 2015-04-23 20:56, Rafał Miłecki wrote:
 After d75b1ade567f (net: less interrupt masking in NAPI) polling
 function has to return whole budget when it wants NAPI to call it again.
 
 Signed-off-by: Rafał Miłecki zaj...@gmail.com
 Cc: Felix Fietkau n...@openwrt.org
 Fixes: eb64e2923a886 (bgmac: leave interrupts disabled as long as there is 
 work to do)
Acked-by: Felix Fietkau n...@openwrt.org

- Felix
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html