Re: [PATCH] [XFRM]: Add module alias for transformation type.

2007-06-27 Thread David Miller
From: [EMAIL PROTECTED]
Date: Fri, 25 May 2007 13:23:23 +0900

 Hi Ingo and all,
 
 This is the third one of MIPv6 module patch. It can be applied
 after two patches which are already sent to the list.
 Could you review it?
 
 
 It is clean-up for XFRM type modules and adds aliases with its
 protocol:
  ESP, AH, IPCOMP, IPIP and IPv6 for IPsec
  ROUTING and DSTOPTS for MIPv6
 
 It is almost the same thing as XFRM mode alias, but it is added
 new defines XFRM_PROTO_XXX for preprocessing since some protocols
 are defined as enum.
 
 Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]

I have also applied this patch, thank you!
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] [XFRM]: Add module alias for transformation type. (Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.)

2007-05-31 Thread Ingo Oeser
Dear Nakamura-san,

[EMAIL PROTECTED] schrieb:
 This is the third one of MIPv6 module patch. It can be applied
 after two patches which are already sent to the list.
 Could you review it?

They look good. Thanks for taking the time to clean this up!

Acked-by: Ingo Oeser [EMAIL PROTECTED]


Best Regards

Ingo Oeser
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] [XFRM]: Add module alias for transformation type. (Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.)

2007-05-24 Thread nakam
Hi Ingo and all,

This is the third one of MIPv6 module patch. It can be applied
after two patches which are already sent to the list.
Could you review it?


It is clean-up for XFRM type modules and adds aliases with its
protocol:
 ESP, AH, IPCOMP, IPIP and IPv6 for IPsec
 ROUTING and DSTOPTS for MIPv6

It is almost the same thing as XFRM mode alias, but it is added
new defines XFRM_PROTO_XXX for preprocessing since some protocols
are defined as enum.

Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
---
 include/net/xfrm.h  |   10 ++
 net/ipv4/ah4.c  |1 +
 net/ipv4/esp4.c |1 +
 net/ipv4/ipcomp.c   |1 +
 net/ipv4/xfrm4_tunnel.c |1 +
 net/ipv6/ah6.c  |1 +
 net/ipv6/esp6.c |1 +
 net/ipv6/ipcomp6.c  |2 +-
 net/ipv6/mip6.c |2 ++
 net/ipv6/xfrm6_tunnel.c |1 +
 10 files changed, 20 insertions(+), 1 deletions(-)

diff --git a/include/net/xfrm.h b/include/net/xfrm.h
index 1e53520..c9f895f 100644
--- a/include/net/xfrm.h
+++ b/include/net/xfrm.h
@@ -19,9 +19,19 @@
 #include net/ipv6.h
 #include net/ip6_fib.h
 
+#define XFRM_PROTO_ESP 50
+#define XFRM_PROTO_AH  51
+#define XFRM_PROTO_COMP108
+#define XFRM_PROTO_IPIP4
+#define XFRM_PROTO_IPV641
+#define XFRM_PROTO_ROUTING IPPROTO_ROUTING
+#define XFRM_PROTO_DSTOPTS IPPROTO_DSTOPTS
+
 #define XFRM_ALIGN8(len)   (((len) + 7)  ~7)
 #define MODULE_ALIAS_XFRM_MODE(family, encap) \
MODULE_ALIAS(xfrm-mode- __stringify(family) - __stringify(encap))
+#define MODULE_ALIAS_XFRM_TYPE(family, proto) \
+   MODULE_ALIAS(xfrm-type- __stringify(family) - __stringify(proto))
 
 extern struct sock *xfrm_nl;
 extern u32 sysctl_xfrm_aevent_etime;
diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c
index 6da8ff5..7a23e59 100644
--- a/net/ipv4/ah4.c
+++ b/net/ipv4/ah4.c
@@ -339,3 +339,4 @@ static void __exit ah4_fini(void)
 module_init(ah4_init);
 module_exit(ah4_fini);
 MODULE_LICENSE(GPL);
+MODULE_ALIAS_XFRM_TYPE(AF_INET, XFRM_PROTO_AH);
diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c
index 47c95e8..98767a4 100644
--- a/net/ipv4/esp4.c
+++ b/net/ipv4/esp4.c
@@ -481,3 +481,4 @@ static void __exit esp4_fini(void)
 module_init(esp4_init);
 module_exit(esp4_fini);
 MODULE_LICENSE(GPL);
+MODULE_ALIAS_XFRM_TYPE(AF_INET, XFRM_PROTO_ESP);
diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
index ab86137..e787044 100644
--- a/net/ipv4/ipcomp.c
+++ b/net/ipv4/ipcomp.c
@@ -485,3 +485,4 @@ MODULE_LICENSE(GPL);
 MODULE_DESCRIPTION(IP Payload Compression Protocol (IPComp) - RFC3173);
 MODULE_AUTHOR(James Morris [EMAIL PROTECTED]);
 
+MODULE_ALIAS_XFRM_TYPE(AF_INET, XFRM_PROTO_COMP);
diff --git a/net/ipv4/xfrm4_tunnel.c b/net/ipv4/xfrm4_tunnel.c
index 5685103..9275c79 100644
--- a/net/ipv4/xfrm4_tunnel.c
+++ b/net/ipv4/xfrm4_tunnel.c
@@ -109,3 +109,4 @@ static void __exit ipip_fini(void)
 module_init(ipip_init);
 module_exit(ipip_fini);
 MODULE_LICENSE(GPL);
+MODULE_ALIAS_XFRM_TYPE(AF_INET, XFRM_PROTO_IPIP);
diff --git a/net/ipv6/ah6.c b/net/ipv6/ah6.c
index 7f764f9..5669430 100644
--- a/net/ipv6/ah6.c
+++ b/net/ipv6/ah6.c
@@ -554,3 +554,4 @@ module_init(ah6_init);
 module_exit(ah6_fini);
 
 MODULE_LICENSE(GPL);
+MODULE_ALIAS_XFRM_TYPE(AF_INET6, XFRM_PROTO_AH);
diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
index 7107bb7..2db31ce 100644
--- a/net/ipv6/esp6.c
+++ b/net/ipv6/esp6.c
@@ -421,3 +421,4 @@ module_init(esp6_init);
 module_exit(esp6_fini);
 
 MODULE_LICENSE(GPL);
+MODULE_ALIAS_XFRM_TYPE(AF_INET6, XFRM_PROTO_ESP);
diff --git a/net/ipv6/ipcomp6.c b/net/ipv6/ipcomp6.c
index 1ee50b5..473f165 100644
--- a/net/ipv6/ipcomp6.c
+++ b/net/ipv6/ipcomp6.c
@@ -500,4 +500,4 @@ MODULE_LICENSE(GPL);
 MODULE_DESCRIPTION(IP Payload Compression Protocol (IPComp) for IPv6 - 
RFC3173);
 MODULE_AUTHOR(Mitsuru KANDA [EMAIL PROTECTED]);
 
-
+MODULE_ALIAS_XFRM_TYPE(AF_INET6, XFRM_PROTO_COMP);
diff --git a/net/ipv6/mip6.c b/net/ipv6/mip6.c
index 20c78ec..8a1399c 100644
--- a/net/ipv6/mip6.c
+++ b/net/ipv6/mip6.c
@@ -514,3 +514,5 @@ module_init(mip6_init);
 module_exit(mip6_fini);
 
 MODULE_LICENSE(GPL);
+MODULE_ALIAS_XFRM_TYPE(AF_INET6, XFRM_PROTO_DSTOPTS);
+MODULE_ALIAS_XFRM_TYPE(AF_INET6, XFRM_PROTO_ROUTING);
diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c
index 5502cc9..6f87dd5 100644
--- a/net/ipv6/xfrm6_tunnel.c
+++ b/net/ipv6/xfrm6_tunnel.c
@@ -379,3 +379,4 @@ static void __exit xfrm6_tunnel_fini(void)
 module_init(xfrm6_tunnel_init);
 module_exit(xfrm6_tunnel_fini);
 MODULE_LICENSE(GPL);
+MODULE_ALIAS_XFRM_TYPE(AF_INET6, XFRM_PROTO_IPV6);
-- 
1.4.4.2

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] [XFRM]: Add module alias for transformation type. (Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.)

2007-05-24 Thread Herbert Xu
On Fri, May 25, 2007 at 01:23:23PM +0900, [EMAIL PROTECTED] wrote:
 
 diff --git a/include/net/xfrm.h b/include/net/xfrm.h
 index 1e53520..c9f895f 100644
 --- a/include/net/xfrm.h
 +++ b/include/net/xfrm.h
 @@ -19,9 +19,19 @@
  #include net/ipv6.h
  #include net/ip6_fib.h
  
 +#define XFRM_PROTO_ESP   50
 +#define XFRM_PROTO_AH51
 +#define XFRM_PROTO_COMP  108
 +#define XFRM_PROTO_IPIP  4
 +#define XFRM_PROTO_IPV6  41
 +#define XFRM_PROTO_ROUTING   IPPROTO_ROUTING
 +#define XFRM_PROTO_DSTOPTS   IPPROTO_DSTOPTS

Could we use the existing IPPROTO_* values for all of these?

Otherwise this looks pretty good.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] [XFRM]: Add module alias for transformation type.

2007-05-24 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Fri, 25 May 2007 15:32:20 +1000), Herbert Xu 
[EMAIL PROTECTED] says:

 On Fri, May 25, 2007 at 01:23:23PM +0900, [EMAIL PROTECTED] wrote:
  
  diff --git a/include/net/xfrm.h b/include/net/xfrm.h
  index 1e53520..c9f895f 100644
  --- a/include/net/xfrm.h
  +++ b/include/net/xfrm.h
  @@ -19,9 +19,19 @@
   #include net/ipv6.h
   #include net/ip6_fib.h
   
  +#define XFRM_PROTO_ESP 50
  +#define XFRM_PROTO_AH  51
  +#define XFRM_PROTO_COMP108
  +#define XFRM_PROTO_IPIP4
  +#define XFRM_PROTO_IPV641
  +#define XFRM_PROTO_ROUTING IPPROTO_ROUTING
  +#define XFRM_PROTO_DSTOPTS IPPROTO_DSTOPTS
 
 Could we use the existing IPPROTO_* values for all of these?

No, because they are of enums.

--yoshfuji
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] [XFRM]: Add module alias for transformation type.

2007-05-24 Thread Herbert Xu
On Fri, May 25, 2007 at 02:34:34PM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
  Could we use the existing IPPROTO_* values for all of these?
 
 No, because they are of enums.

Good point.  I've forgotten about these module alias hacks :)

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html