RUC_Soft_Sec <zy900...@163.com> writes:
> Current code assigns 0 to variable 'retval', which makes ezusb_probe() to
> return success even if alloc_orinocodev() fails.
>
> The related code snippets in mantis_dma_init() is as following.
>
> 1573 static int ezusb_probe(struct usb_interface *interface,
> 1574 const struct usb_device_id *id)
> 1575 {
>
> ....
>
> 1583 int retval = 0;
> 1584 int i;
> 1585
> 1586 priv = alloc_orinocodev(sizeof(*upriv), &udev->dev,
> 1587 ezusb_hard_reset, NULL);
> 1588 if (!priv) {
> 1589 err("Couldn't allocate orinocodev");
> 1590 goto exit;
> 1591 }
> ...
>
> 1729 exit:
> 1730 if (fw_entry) {
> 1731 firmware.code = NULL;
> 1732 firmware.size = 0;
> 1733 release_firmware(fw_entry);
> 1734 }
> 1735 usb_set_intfdata(interface, upriv);
> 1736 return retval;
> 1737 }
>
> Fix it by checking the return value from alloc_orinocodev() and assigns
> '-ENOMEM' to variable 'retval' in the case of error.
>
> Signed-off-by: Zhang Yan <zy900...@163.com>---
> orinoco_usb.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/orinoco_usb.c b/orinoco_usb.c
The patch looks corrupted. And the from header doesn't contain a proper
name.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
