Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Yoann P.
Le lundi 29 octobre 2018, 23:03:07 CET Stefano Brivio a écrit : > On Mon, 29 Oct 2018 21:06:35 +0100 > > "Yoann P." wrote: > > > By the way, why do you use column(1), when ss already prints output in > > > columns? Any other issue you are working around? > > > > column can hide columns with "-H

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Stefano Brivio
On Mon, 29 Oct 2018 21:07:47 +0100 "Yoann P." wrote: > > - printed = printf("%s", current_field->ldelim); > > + printed = printf("%s", f->ldelim); > > else > > printed = 0; > > I can't reproduce the issue with

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Stefano Brivio
On Mon, 29 Oct 2018 21:06:35 +0100 "Yoann P." wrote: > > By the way, why do you use column(1), when ss already prints output in > > columns? Any other issue you are working around? > > column can hide columns with "-H -" and is a bit faster than awk to output a > single column according to

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Yoann P.
> On Mon, 29 Oct 2018 19:20:36 +0100 > > Stefano Brivio wrote: > > The actual issue seems to be that in some cases the left delimiter for > > the State column is not printed > > Much worse, we always print the left delimiter of the last buffered > column, which is usually empty. My bad. >

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Yoann P.
> Hi Yohann, > > On Fri, 26 Oct 2018 22:53:32 +0200 > > "Yoann P." wrote: > > When using ss -Hutn4 or -utn3, Netid and State columns are sometime > > merged, it can be confusing when trying to pipe into awk or column. > > Thanks for fixing this. A few comments though: > > @@ -144,9 +144,9 @@

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Stefano Brivio
On Mon, 29 Oct 2018 19:20:36 +0100 Stefano Brivio wrote: > The actual issue seems to be that in some cases the left delimiter for > the State column is not printed Much worse, we always print the left delimiter of the last buffered column, which is usually empty. My bad. The issue is not so

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Stefano Brivio
Hi Yohann, On Fri, 26 Oct 2018 22:53:32 +0200 "Yoann P." wrote: > When using ss -Hutn4 or -utn3, Netid and State columns are sometime merged, > it > can be confusing when trying to pipe into awk or column. Thanks for fixing this. A few comments though: > @@ -144,9 +144,9 @@ static struct

Re: [PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-29 Thread Stephen Hemminger
On Fri, 26 Oct 2018 22:53:32 +0200 "Yoann P." wrote: > When using ss -Hutn4 or -utn3, Netid and State columns are sometime merged, > it > can be confusing when trying to pipe into awk or column. > Details (before and after output) are available on this github issue: https:// >

[PATCH] Fix ss Netid column and Local/Peer_Address

2018-10-26 Thread Yoann P.
When using ss -Hutn4 or -utn3, Netid and State columns are sometime merged, it can be confusing when trying to pipe into awk or column. Details (before and after output) are available on this github issue: https:// github.com/shemminger/iproute2/issues/20 Signed-off-by: YoyPa --- misc/ss.c | 6